Actually there are 2 questions.
Firstly , on Windows 7 vm i can install spice-webdavd-x64-2.2.msi and no error
, but the service spice-webdavd in TASK MANAGER allways stop although rebooting
vm.
Then, on Linux vm , I can install spice-webdavd and also can find Spice client
folder icon on files n
I added in those involved in Oct 25, 2017'ish discussion regarding
horizontal mouse wheel support, from here:
https://patchwork.freedesktop.org/series/32626/
I'm not sure if that patchset was officially rejected.
Regarding comments in that patcheset, because a native qemu (no spice
involved) wind
>
> From: Victor Toso
>
> Found by coverity:
> | warning: Access to field 'next' results in a dereference of a
> | null pointer (loaded from variable 'prev_sel')
>
> Signed-off-by: Victor Toso
> ---
> src/vdagent/x11.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --gi
On Tue, Dec 18, 2018 at 12:15:09PM -0500, Frediano Ziglio wrote:
> >
> > The udev rule already adds SYSTEMD_WANTS=spice-vdagentd.socket
> > to the relevant virtio devices, which automatically adds Wants=${device}
> > to spice-vdagentd.socket (see 'systemctl show spice-vdagentd.socket').
> > Adding
>
> From: Victor Toso
>
> And use well defined macros for standard file descriptors.
>
> Signed-off-by: Victor Toso
> ---
> src/vdagent/vdagent.c | 8 ++--
> src/vdagentd/vdagentd.c | 8 ++--
> 2 files changed, 12 insertions(+), 4 deletions(-)
>
> diff --git a/src/vdagent/vdagent.c
>
> From: Victor Toso
>
> In the current code, output should never be negative but the check
> exists after we use the variable as index. Make the check earlier.
>
> Found by coverity:
> | check_after_sink: You might be using variable "output" before
> | verifying that it is >= 0.
>
> Sign
> On Thu, Dec 13, 2018 at 02:20:24PM +, Frediano Ziglio wrote:
> > A full copy can keep both the key and the value instead of
> > allocating twice the memory.
> > Also this remove a warning produced by Coverity that is assuming
> > that allocating strlen(string_variable) is wrong.
>
> We are p
> On Thu, Dec 13, 2018 at 02:20:25PM +, Frediano Ziglio wrote:
> > Signed-off-by: Frediano Ziglio
> > ---
> > common/ssl_verify.c | 5 +-
> > common/ssl_verify.h | 4 ++
> > tests/Makefile.am | 20 ++
> > tests/test-ssl-verify.c | 141 +++
>
> The udev rule already adds SYSTEMD_WANTS=spice-vdagentd.socket
> to the relevant virtio devices, which automatically adds Wants=${device}
> to spice-vdagentd.socket (see 'systemctl show spice-vdagentd.socket').
> Adding a Requisite/After for these ports is at best redundant, and most
> likely
On Thu, Dec 13, 2018 at 02:20:25PM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> common/ssl_verify.c | 5 +-
> common/ssl_verify.h | 4 ++
> tests/Makefile.am | 20 ++
> tests/test-ssl-verify.c | 141
> 4 fil
On Thu, Dec 13, 2018 at 02:20:24PM +, Frediano Ziglio wrote:
> A full copy can keep both the key and the value instead of
> allocating twice the memory.
> Also this remove a warning produced by Coverity that is assuming
> that allocating strlen(string_variable) is wrong.
We are parsing key1=va
>
> From: Victor Toso
>
> Found by coverity:
>
> | uninit_use_in_call: Using uninitialized value "message_header". Field
> | "message_header.data" is uninitialized when calling "memcpy".
>
> Signed-off-by: Victor Toso
This structure is defined as:
typedef struct SPICE_ATTR_PACKED VDAgent
Hi,
sorry about piecemealing this.
On Thu, 2018-12-13 at 16:46 -0600, Jonathon Jongsma wrote:
> Add a function to look up an xrandr output for a given device display
> id. This uses sysfs and the drm subsystem to lookup information about a
> graphics device output. It then compares the drm output
From: Victor Toso
Found by coverity:
| warning: Access to field 'next' results in a dereference of a
| null pointer (loaded from variable 'prev_sel')
Signed-off-by: Victor Toso
---
src/vdagent/x11.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/vdagent/x11.c b/src
From: Victor Toso
Found by coverity:
| uninit_use_in_call: Using uninitialized value "message_header". Field
| "message_header.data" is uninitialized when calling "memcpy".
Signed-off-by: Victor Toso
---
src/vdagentd/virtio-port.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
From: Victor Toso
And use well defined macros for standard file descriptors.
Signed-off-by: Victor Toso
---
src/vdagent/vdagent.c | 8 ++--
src/vdagentd/vdagentd.c | 8 ++--
2 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/src/vdagent/vdagent.c b/src/vdagent/vdagent.c
From: Victor Toso
Similar to previous patch, found by coverity:
| var_deref_op: Dereferencing null pointer "prev_conv".
Signed-off-by: Victor Toso
---
src/vdagent/x11.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/vdagent/x11.c b/src/vdagent/x11.c
index 69eed4a..50
From: Victor Toso
In the current code, output should never be negative but the check
exists after we use the variable as index. Make the check earlier.
Found by coverity:
| check_after_sink: You might be using variable "output" before
| verifying that it is >= 0.
Signed-off-by: Victor Toso
The udev rule already adds SYSTEMD_WANTS=spice-vdagentd.socket
to the relevant virtio devices, which automatically adds Wants=${device}
to spice-vdagentd.socket (see 'systemctl show spice-vdagentd.socket').
Adding a Requisite/After for these ports is at best redundant, and most
likely wrong as this
The udev rule already adds SYSTEMD_WANTS=spice-vdagentd.socket
to the relevant virtio devices, which automatically adds Wants=${device}
to spice-vdagentd.socket (see 'systemctl show spice-vdagentd.socket').
Adding a Requisite for these ports is at best redundant, and most likely
wrong as this is ca
20 matches
Mail list logo
