[Spice-devel] [PATCH spice-server] tests/pki: Use CA/certificate valid until 2048 and with 2048 bits

2018-12-04 Thread Frediano Ziglio
This changes tests/pki/server-cert.pem and tests/pki/ca-cert.pem to have 2048 bits. These certificates were generated using the instructions on https://www.spice-space.org/spice-user-manual.html The -subj args were omitted, and the defaults suggested by openssl used. The -days parameter was changed

[Spice-devel] [PATCH spice-streaming-agent 2/3] Move the syslog() helper for errors to a new utils module

2018-12-04 Thread Lukáš Hrázký
The syslog() helper for logging an error is not necessary, leave it out of the API and move it to a new private utils module. Signed-off-by: Lukáš Hrázký --- include/spice-streaming-agent/error.hpp | 8 src/Makefile.am | 1 + src/cursor-updater.cpp

[Spice-devel] [PATCH spice-streaming-agent 3/3] Export symbols in the binary to use by the plugins

2018-12-04 Thread Lukáš Hrázký
This commits adds the -export-dynamic linker flag to export dynamic symbols to be used by the streaming agent's plugins. It also adds the -fvisibility=hidden compiler flag to hide all symbols by default (along with -fvisibility-inline-hidden for C++ inline functions). Then it adds the visibility("

[Spice-devel] [PATCH spice-streaming-agent 1/3] Make error.hpp and the Error class a public API

2018-12-04 Thread Lukáš Hrázký
Moves IOError and its descendants to stream-port.hpp, as those are I/O errors related to that. Makes the Error class a public base class for exceptions thrown across the API boundary. Note exception ABI conpatibility is not guaranteed between different compilers, but it is compatible between gcc a

[Spice-devel] [PATCH spice-streaming-agent 0/3] Add an Error to the API

2018-12-04 Thread Lukáš Hrázký
Hello, this series adds an Error class to the plugin API, to be thrown across the API boundary. It also makes sure the symbols are properly exported and the class has RTTI (or more precisely the information used to identify the exceptions equivalent to RTTI) so that the exception can be properly c

Re: [Spice-devel] [PATCH spice-server] tests: Use g_assert_(non)null instead of g_assert

2018-12-04 Thread Victor Toso
Hi, On Tue, Dec 04, 2018 at 03:58:07AM -0500, Frediano Ziglio wrote: > > > > Hi, > > > > On Mon, Dec 03, 2018 at 05:09:55PM +, Frediano Ziglio wrote: > > > Just a style change, on more recent GLib would print a more > > > friendly error report. > > > > > > Signed-off-by: Frediano Ziglio >

[Spice-devel] CI failing as out of resources

2018-12-04 Thread Frediano Ziglio
Hi, it seems FreeDesktop resources ran out for CI jobs. Last attempts to check spice-server were unsuccessful as there are no more runners available to run the jobs :-( Had a quick search and found they have some issues about but not a real confirmation. Is anybody aware of this issue? Will be f

Re: [Spice-devel] [PATCH spice-server] tests: Use g_assert_(non)null instead of g_assert

2018-12-04 Thread Frediano Ziglio
> > Hi, > > On Mon, Dec 03, 2018 at 05:09:55PM +, Frediano Ziglio wrote: > > Just a style change, on more recent GLib would print a more > > friendly error report. > > > > Signed-off-by: Frediano Ziglio > > --- > > server/tests/test-display-base.c | 2 +- > > server/tests/test-listen.c

Re: [Spice-devel] [PATCH spice-server] tests: Use g_assert_(non)null instead of g_assert

2018-12-04 Thread Victor Toso
Hi, On Mon, Dec 03, 2018 at 05:09:55PM +, Frediano Ziglio wrote: > Just a style change, on more recent GLib would print a more > friendly error report. > > Signed-off-by: Frediano Ziglio > --- > server/tests/test-display-base.c | 2 +- > server/tests/test-listen.c | 6 -- > 2 file