Re: [Spice-devel] [PATCH] drm/qxl: add spice-devel list to MAINTAINERS

2018-11-21 Thread Gerd Hoffmann
On Wed, Nov 21, 2018 at 05:40:19PM +0100, Christophe Fergeau wrote: > On Wed, Nov 21, 2018 at 10:01:29AM +0100, Gerd Hoffmann wrote: > > So qxl kernel patches are sent to the spice-devel list for review. > > > > Signed-off-by: Gerd Hoffmann > > --- > > MAINTAINERS | 1 + > > 1 file changed, 1 in

Re: [Spice-devel] Feature suggestion: Port tunneling between VM & client over spice-channel

2018-11-21 Thread Michal Suchánek
On Wed, 14 Nov 2018 16:16:27 +0100 Javier Celaya wrote: > Hi > FYI, in flexVDI we have already implemented this feature. We just had > not the time to split it into meaningful patches and share it with the > list. If you are really interested, we can try to dedicate some time to > it. > Our impl

Re: [Spice-devel] Feature suggestion: Port tunneling between VM & client over spice-channel

2018-11-21 Thread David Jaša
Hi Boris, On Wed, 2018-11-14 at 11:38 +0900, Boris Morozov wrote: > Hello, dear friends. I would like a share idea with you about new feature. > Please forgive me if i wrong. > > Current approach to publish ports from virtual machine is connecting it to > network by network adapter. > > In thi

Re: [Spice-devel] [PATCH spice-common] Integrate recorder library

2018-11-21 Thread Christophe Fergeau
Hey, On Mon, Nov 19, 2018 at 08:46:04PM +, Frediano Ziglio wrote: > From: Christophe de Dinechin > > Allow to use recorder library. See https://github.com/c3d/recorder for > details. > The main usage will be to collect statistics while the programs will run. > By default the recorder will be

Re: [Spice-devel] [PATCH spice-gtk] spice-channel: Adjust endianness in a single place for link message

2018-11-21 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Tue, Nov 20, 2018 at 05:36:15PM +, Frediano Ziglio wrote: > Make sure all fields have right endian. "error" field was not adjusted. > > Signed-off-by: Frediano Ziglio > --- > src/spice-channel.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deleti

Re: [Spice-devel] [PATCH] drm/qxl: add spice-devel list to MAINTAINERS

2018-11-21 Thread Christophe Fergeau
On Wed, Nov 21, 2018 at 10:01:29AM +0100, Gerd Hoffmann wrote: > So qxl kernel patches are sent to the spice-devel list for review. > > Signed-off-by: Gerd Hoffmann > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 4caac2f6b0..d9945d5

Re: [Spice-devel] spice-vdagent.service not starting

2018-11-21 Thread Frediano Ziglio
> Hi, > I am trying to setup a VDI on a physical machine & cloud environment in > parallel. > I got the virtual machines running along with dashboards, websocxify etc.. > However, I am stuck at where I have to use spice-vdagentd service. > The service keep failing due to dependency error. Below

Re: [Spice-devel] [spice-gtk] build: Remove need for static linking for tests

2018-11-21 Thread Frediano Ziglio
> > Hey, > > On Wed, Nov 21, 2018 at 06:21:40AM -0500, Frediano Ziglio wrote: > > > > > > Currently, spice-gtk tests are disabled if build of static libraries is > > > disabled. This commit introduces an intermediate > > > spice-client-glib-impl.la convenience library which does not have its > >

Re: [Spice-devel] [PATCH] drm/qxl: add spice-devel list to MAINTAINERS

2018-11-21 Thread Daniel Vetter
On Wed, Nov 21, 2018 at 10:01:29AM +0100, Gerd Hoffmann wrote: > So qxl kernel patches are sent to the spice-devel list for review. > > Signed-off-by: Gerd Hoffmann Makes sense. Acked-by: Daniel Vetter > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/

Re: [Spice-devel] [spice-gtk] build: Remove need for static linking for tests

2018-11-21 Thread Christophe Fergeau
Hey, On Wed, Nov 21, 2018 at 06:21:40AM -0500, Frediano Ziglio wrote: > > > > Currently, spice-gtk tests are disabled if build of static libraries is > > disabled. This commit introduces an intermediate > > spice-client-glib-impl.la convenience library which does not have its > > internal symbols

Re: [Spice-devel] [PATCH spice-server 1/2] ci: Merge new glib.supp file

2018-11-21 Thread Frediano Ziglio
> > Hi > > On Fri, Nov 9, 2018 at 2:07 PM Frediano Ziglio wrote: > > > > Merge from GLib master repository. > > > > Signed-off-by: Frediano Ziglio > > Wouldn't it be more robust to refer to the installed version instead? > (/usr/share/glib-2.0/valgrind/glib.supp on my machine) > I just reali

Re: [Spice-devel] [PATCH vd_agent_linux v2] vdagent: Stop trying to connect to the daemon after a while

2018-11-21 Thread Frediano Ziglio
> On Mon, 2018-11-19 at 11:42 -0500, Frediano Ziglio wrote: > > > > > > On Mon, 2018-11-19 at 10:23 +, Frediano Ziglio wrote: > > > > Do not try indefinitely to connect to the daemon, should not > > > > take long to activate. > > > > > > > > Signed-off-by: Frediano Ziglio > > > > --- > > >

Re: [Spice-devel] [PATCH spice-server 1/2] ci: Merge new glib.supp file

2018-11-21 Thread Marc-André Lureau
Hi On Fri, Nov 9, 2018 at 2:07 PM Frediano Ziglio wrote: > > Merge from GLib master repository. > > Signed-off-by: Frediano Ziglio Wouldn't it be more robust to refer to the installed version instead? (/usr/share/glib-2.0/valgrind/glib.supp on my machine) > --- > server/tests/valgrind/glib.su

[Spice-devel] [PATCH spice-gtk] spice-channel: Add some comment to spice_channel_read

2018-11-21 Thread Frediano Ziglio
Document return value. Signed-off-by: Frediano Ziglio --- src/spice-channel.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/spice-channel.c b/src/spice-channel.c index 1486137e..602869e1 100644 --- a/src/spice-channel.c +++ b/src/spice-channel.c @@ -1124,6 +1124,8 @@ static int spice

Re: [Spice-devel] [spice-gtk] build: Remove need for static linking for tests

2018-11-21 Thread Frediano Ziglio
> > Currently, spice-gtk tests are disabled if build of static libraries is > disabled. This commit introduces an intermediate > spice-client-glib-impl.la convenience library which does not have its > internal symbols hidden, and can thus be used instead of static linking > when building the tests

[Spice-devel] [spice-gtk] build: Remove need for static linking for tests

2018-11-21 Thread Christophe Fergeau
Currently, spice-gtk tests are disabled if build of static libraries is disabled. This commit introduces an intermediate spice-client-glib-impl.la convenience library which does not have its internal symbols hidden, and can thus be used instead of static linking when building the tests. The install

Re: [Spice-devel] [PATCH spice-common 2/2] docs: Document to_ptr protocol attribute

2018-11-21 Thread Snir Sheriber
Hi On 11/21/2018 11:14 AM, Frediano Ziglio wrote: Signed-off-by: Frediano Ziglio --- docs/spice_protocol.txt | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/docs/spice_protocol.txt b/docs/spice_protocol.txt index 5e13c93..0ef2800 100644 --- a/do

Re: [Spice-devel] [PATCH spice-common 1/2] docs: Fix typos and grammar

2018-11-21 Thread Snir Sheriber
Hi, On 11/21/2018 11:14 AM, Frediano Ziglio wrote: Signed-off-by: Frediano Ziglio --- docs/spice_protocol.txt | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/spice_protocol.txt b/docs/spice_protocol.txt index b205743..5e13c93 100644 --- a/docs/spice

[Spice-devel] [PATCH spice-common 2/2] docs: Document to_ptr protocol attribute

2018-11-21 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- docs/spice_protocol.txt | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/docs/spice_protocol.txt b/docs/spice_protocol.txt index 5e13c93..0ef2800 100644 --- a/docs/spice_protocol.txt +++ b/docs/spice_protocol.txt @@ -

[Spice-devel] [PATCH spice-common 1/2] docs: Fix typos and grammar

2018-11-21 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- docs/spice_protocol.txt | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/docs/spice_protocol.txt b/docs/spice_protocol.txt index b205743..5e13c93 100644 --- a/docs/spice_protocol.txt +++ b/docs/spice_protocol.txt @@ -65,7 +65,

[Spice-devel] [PATCH] drm/qxl: add spice-devel list to MAINTAINERS

2018-11-21 Thread Gerd Hoffmann
So qxl kernel patches are sent to the spice-devel list for review. Signed-off-by: Gerd Hoffmann --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 4caac2f6b0..d9945d57eb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4728,6 +4728,7 @@ DRM DRIVER F

Re: [Spice-devel] spice can't transfer files from gust OS to client

2018-11-21 Thread Jakub Janku
Hi, You can use a shared folder for this purpose, consult the Spice User Manual for more details: https://www.spice-space.org/spice-user-manual.html Drag& dropping files from guest to client is currently not supported. Regards, Jakub On Nov 21, 2018 7:53 AM, "wangjiedong" wrote: I installed

Re: [Spice-devel] spice can't transfer files from gust OS to client

2018-11-21 Thread Frediano Ziglio
> I installed spice-vdagent in guest OS Ubuntu 1804 , then i connect guest with > virt-viewer . > I can drag files to guest Ubuntu from client , but i can't drag files out > from guest Ubuntu. > Then i try it with guest OS windows installed windows-spice-tools , it can't > transfer files from guest