Re: [Spice-devel] [RFC linux vdagent] Add POC for getting xrandr output from monitor ID

2018-11-12 Thread Jonathon Jongsma
On Thu, 2018-11-08 at 14:21 +0100, Lukáš Hrázký wrote: > Hello, > > On Mon, 2018-11-05 at 17:09 -0600, Jonathon Jongsma wrote: > > This is just a proof of concept utility that takes a PCI device > > address > > and a monitor ID and finds the xrandr output associated with that > > monitor id. > > -

Re: [Spice-devel] [PATCH 1/2] Make output name numbering 0-based

2018-11-12 Thread Frediano Ziglio
Title should be "Make output name numbering 1-based" > > The QXL driver names its outputs starting at 0 (e.g. Virtual-0, > Virtual-1, etc). This code was presumably copy/pasted from a different > driver, and is not necessary for the QXL driver. Other drivers simply > use the kernel connector_type_

Re: [Spice-devel] [RFC PATCH spice-protocol 1/3] Add a graphics device info message

2018-11-12 Thread Jonathon Jongsma
On Mon, 2018-11-12 at 11:01 +0100, Lukáš Hrázký wrote: > On Thu, 2018-11-08 at 11:36 -0600, Jonathon Jongsma wrote: > > On Wed, 2018-11-07 at 18:23 +0100, Lukáš Hrázký wrote: > > > The message serves for passing the device address and device > > > display > > > ID > > > > "serves for passing..." i

[Spice-devel] [PATCH 1/2] Make output name numbering 0-based

2018-11-12 Thread Jonathon Jongsma
The QXL driver names its outputs starting at 0 (e.g. Virtual-0, Virtual-1, etc). This code was presumably copy/pasted from a different driver, and is not necessary for the QXL driver. Other drivers simply use the kernel connector_type_id which starts at 1. For example, the modesetting driver change

[Spice-devel] [QXL PATCH 0/2] Minor QXL patches

2018-11-12 Thread Jonathon Jongsma
These QXL patches were both reviewed and ACKed by Frediano, but apparently neither of us has commit rights to the xf86-video-qxl repository. I'm not sure if this is since the move to gitlab or if we never had commit rights to this repository. In any case, it looks like we'll need an Xorg developer

[Spice-devel] [PATCH 2/2] Make output names match modesetting driver

2018-11-12 Thread Jonathon Jongsma
The xrandr output name used by the QXL driver is based on the drm connector type, but the names do not match the kernel names (see /drivers/gpu/drm/drm_connector.c) or the modesetting driver names (see hw/xfree86/drivers/modesetting/drmmode_display.c). Making these more consistent will require less

Re: [Spice-devel] [RFC PATCH spice-protocol 1/3] Add a graphics device info message

2018-11-12 Thread Lukáš Hrázký
On Thu, 2018-11-08 at 11:36 -0600, Jonathon Jongsma wrote: > On Wed, 2018-11-07 at 18:23 +0100, Lukáš Hrázký wrote: > > The message serves for passing the device address and device display > > ID > > "serves for passing..." is a little strange to my ear. "serves to > pass..." sounds OK. Or "is use