Signed-off-by: Frediano Ziglio
---
src/spice-session-priv.h | 2 --
src/spice-session.c | 9 +
2 files changed, 5 insertions(+), 6 deletions(-)
diff --git a/src/spice-session-priv.h b/src/spice-session-priv.h
index d2a557b..0190c1f 100644
--- a/src/spice-session-priv.h
+++ b/src/spi
Signed-off-by: Frediano Ziglio
---
src/spice-session-priv.h | 1 -
src/spice-session.c | 10 --
2 files changed, 11 deletions(-)
diff --git a/src/spice-session-priv.h b/src/spice-session-priv.h
index 03005aa..d2a557b 100644
--- a/src/spice-session-priv.h
+++ b/src/spice-session-pri
Hi
On Wed, Sep 26, 2018 at 3:49 PM Frediano Ziglio wrote:
>
> Not much sense to reimplement a list using Ring type.
> This patch maintains the stability of the iterators and
> the order of the items in the container.
>
> Signed-off-by: Frediano Ziglio
ack
> ---
> src/spice-session.c | 135
Hi,
On Wed, Sep 26, 2018 at 7:45 PM Yuri Benditovich
wrote:
>
> Hi,
>
> Is it possible also make the QMP helper optional depending on presence of
> relevant packages?
> After initial commit of QMP on some platforms in is hard to build the
> spice-gtk, as json-glib-devel package for Linux or min
>
> From: Victor Toso
>
> Introduced in the last iteration (v4) by mistake, commit
> bd195d3f76f115
>
> usb-device-manager.c: In function ‘channel_event’:
> usb-device-manager.c:900:19: error: format ‘%d’ expects argument of
> type ‘int’, but argument 4 has type ‘unsigned int’ [-Wer
From: Victor Toso
Introduced in the last iteration (v4) by mistake, commit
bd195d3f76f115
usb-device-manager.c: In function ‘channel_event’:
usb-device-manager.c:900:19: error: format ‘%d’ expects argument of
type ‘int’, but argument 4 has type ‘unsigned int’ [-Werror=format=]
g
Capnproto is about encapsulation of messages, looks like these patches
are more about writing/reading. But maybe I'm wrong.
>
> So, off list we had discussed potentially investigating whether we
> wanted to use something like Cap'n Proto for the StreamDevice
> communication protocol. With that in
So, off list we had discussed potentially investigating whether we
wanted to use something like Cap'n Proto for the StreamDevice
communication protocol. With that in mind, is it worth reviewing this
series, or should we wait?
On Tue, 2018-07-10 at 16:51 +0200, Lukáš Hrázký wrote:
> Hi all,
>
> t
Hi,
Is it possible also make the QMP helper optional depending on presence of
relevant packages?
After initial commit of QMP on some platforms in is hard to build the
spice-gtk, as json-glib-devel package for Linux or mingw-json-glib package
not available.
Thanks,
Yuri
On Wed, Sep 26, 2018 at 5
From: Marc-André Lureau
g_hash_table_remove() will call the free handler and dispose the
pending tasks.
Signed-off-by: Marc-André Lureau
---
src/qmp-port.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/src/qmp-port.c b/src/qmp-port.c
index 89b27aa..c91f967 100644
--- a/src
From: Marc-André Lureau
There is no size argument for SpicePortChannel::port-event signal.
Signed-off-by: Marc-André Lureau
---
src/channel-port.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/channel-port.c b/src/channel-port.c
index d9c5a6c..2b6fb75 100644
--- a/src/channel-port.c
+
From: Marc-André Lureau
Hi,
Here are a few follow-up patches for the QMP helper.
Thanks
Marc-André Lureau (4):
channel-port: fix invalid arg comment
qmp: use SPICE_DEBUG for consistency
qmp: release channel on dispose
qmp: clear all pending tasks on close event
src/channel-port.c |
From: Marc-André Lureau
Do not leak the strong channel ref.
Signed-off-by: Marc-André Lureau
---
src/qmp-port.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/qmp-port.c b/src/qmp-port.c
index bdc0c7e..89b27aa 100644
--- a/src/qmp-port.c
+++ b/src/qmp-port.c
@@ -203,6 +203,8 @@ stat
From: Marc-André Lureau
Signed-off-by: Marc-André Lureau
---
src/qmp-port.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/qmp-port.c b/src/qmp-port.c
index c32bdc4..bdc0c7e 100644
--- a/src/qmp-port.c
+++ b/src/qmp-port.c
@@ -101,7 +101,7 @@ spice_qmp_dispatch_
On 9/26/18 6:48 AM, Christophe Fergeau wrote:
> On Wed, Sep 26, 2018 at 10:50:26AM +0200, Victor Toso wrote:
>> Hi,
>>
>> On Wed, Sep 26, 2018 at 10:25:56AM +0200, Christophe Fergeau wrote:
>>> NB: The newer meson we require, the harder it will be to say "ok, from
>>> now on, we'll be switching to
Not much sense to reimplement a list using Ring type.
This patch maintains the stability of the iterators and
the order of the items in the container.
Signed-off-by: Frediano Ziglio
---
src/spice-session.c | 135 +++-
1 file changed, 46 insertions(+), 89 d
>
> Hi,
>
> On Wed, Sep 26, 2018 at 06:17:34AM -0400, Frediano Ziglio wrote:
> > >
> > > From: Victor Toso
> > >
> > > This should not change code behavior, only add some comments.
> > >
> > > This is a preparatory patch for bug below, introduced with:
> > >
> > > commit 9fbf679453d8dbfe
>
> From: Victor Toso
>
> This should not change code behavior, only add some comments.
>
> This is a preparatory patch for bug below, introduced with:
>
> commit 9fbf679453d8dbfe797a738cb536136599d7adab
> Author: Kirill Moizik
> Date: Tue Mar 8 16:05:57 2016 +0200
>
>
>
> From: Victor Toso
>
> As we are not able to redirect anything in case that usbredir channel
> is not connected.
>
> Related: https://bugzilla.redhat.com/show_bug.cgi?id=1625550
> Signed-off-by: Victor Toso
> ---
> src/usb-device-manager.c | 32
> 1 file ch
From: Victor Toso
This should not change code behavior, only add some comments.
This is a preparatory patch for bug below, introduced with:
commit 9fbf679453d8dbfe797a738cb536136599d7adab
Author: Kirill Moizik
Date: Tue Mar 8 16:05:57 2016 +0200
usbredir: Disconnect USB
From: Victor Toso
As we are not able to redirect anything in case that usbredir channel
is not connected.
Related: https://bugzilla.redhat.com/show_bug.cgi?id=1625550
Signed-off-by: Victor Toso
---
src/usb-device-manager.c | 32
1 file changed, 32 insertions(+)
Hi,
On Wed, Sep 26, 2018 at 06:17:34AM -0400, Frediano Ziglio wrote:
> >
> > From: Victor Toso
> >
> > This should not change code behavior, only add some comments.
> >
> > This is a preparatory patch for bug below, introduced with:
> >
> > commit 9fbf679453d8dbfe797a738cb536136599d7adab
Hi,
Thanks for the quick review!
On Wed, Sep 26, 2018 at 06:15:48AM -0400, Frediano Ziglio wrote:
> >
> > From: Victor Toso
> >
> > As we are not able to redirect anything in case that usbredir channel
> > is not connected.
> >
> > Related: https://bugzilla.redhat.com/show_bug.cgi?id=1625550
>
> From: Victor Toso
>
> Otherwise spice-channel is left with a broken state.
>
> This code moves parent's call to channel_reset() into
> _channel_reset_finish() - Note that spice-channel's channel_reset()
> can be called from GMainContext.
>
> Resolves: https://bugzilla.redhat.com/show_bug.c
>
> From: Victor Toso
>
> This should not change code behavior, only add some comments.
>
> This is a preparatory patch for bug below, introduced with:
>
> commit 9fbf679453d8dbfe797a738cb536136599d7adab
> Author: Kirill Moizik
> Date: Tue Mar 8 16:05:57 2016 +0200
>
>
>
> From: Victor Toso
>
> As we are not able to redirect anything in case that usbredir channel
> is not connected.
>
> Related: https://bugzilla.redhat.com/show_bug.cgi?id=1625550
> Signed-off-by: Victor Toso
> ---
> src/usb-device-manager.c | 31 +++
> 1 file cha
>
> From: Victor Toso
>
> The channel_connect() function could fail leading to a spice-channel
> existing as zombie (its coroutine return soon after).
>
> Check if channel_connect() fails and give a proper error signal to
> user when that happens.
>
> Related: https://bugzilla.redhat.com/show_
>
> Hi,
>
> On Tue, Sep 18, 2018 at 03:53:19AM -0400, Frediano Ziglio wrote:
> > >
> > > From: Victor Toso
> > >
> > > The channel_connect() function could fail leading to a spice-channel
> > > existing as zombie (its coroutine return soon after).
> > >
> > > Check if channel_connect() fails
From: Victor Toso
Otherwise spice-channel is left with a broken state.
This code moves parent's call to channel_reset() into
_channel_reset_finish() - Note that spice-channel's channel_reset()
can be called from GMainContext.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1625550
Signed-
From: Victor Toso
The channel_connect() function could fail leading to a spice-channel
existing as zombie (its coroutine return soon after).
Check if channel_connect() fails and give a proper error signal to
user when that happens.
Related: https://bugzilla.redhat.com/show_bug.cgi?id=1625550
Si
From: Victor Toso
As we are not able to redirect anything in case that usbredir channel
is not connected.
Related: https://bugzilla.redhat.com/show_bug.cgi?id=1625550
Signed-off-by: Victor Toso
---
src/usb-device-manager.c | 31 +++
1 file changed, 31 insertions(+)
From: Victor Toso
This should not change code behavior, only add some comments.
This is a preparatory patch for bug below, introduced with:
commit 9fbf679453d8dbfe797a738cb536136599d7adab
Author: Kirill Moizik
Date: Tue Mar 8 16:05:57 2016 +0200
usbredir: Disconnect USB
On Wed, Sep 26, 2018 at 10:50:26AM +0200, Victor Toso wrote:
> Hi,
>
> On Wed, Sep 26, 2018 at 10:25:56AM +0200, Christophe Fergeau wrote:
> > NB: The newer meson we require, the harder it will be to say "ok, from
> > now on, we'll be switching to building with meson by default".
>
> What would m
Hi,
On Tue, Sep 18, 2018 at 03:53:19AM -0400, Frediano Ziglio wrote:
> >
> > From: Victor Toso
> >
> > The channel_connect() function could fail leading to a spice-channel
> > existing as zombie (its coroutine return soon after).
> >
> > Check if channel_connect() fails and give a proper error
On Wed, Sep 26, 2018 at 05:05:43AM -0400, Frediano Ziglio wrote:
> >
> > Hi,
> >
> > On Wed, Sep 26, 2018 at 10:25:56AM +0200, Christophe Fergeau wrote:
> > > NB: The newer meson we require, the harder it will be to say "ok, from
> > > now on, we'll be switching to building with meson by default"
>
> Hi,
>
> On Wed, Sep 26, 2018 at 10:25:56AM +0200, Christophe Fergeau wrote:
> > NB: The newer meson we require, the harder it will be to say "ok, from
> > now on, we'll be switching to building with meson by default".
>
> What would mean switching to it by default? Removing autotools?
>
> I
On Wed, Sep 26, 2018 at 04:10:31AM -0400, Frediano Ziglio wrote:
> >
> > Signed-off-by: Eduardo Lima (Etrunko)
> > ---
> > meson.build | 1 -
> > src/meson.build | 1 -
> > 2 files changed, 2 deletions(-)
> >
> > diff --git a/meson.build b/meson.build
> > index 85f6e78..eba2c38 100644
> > -
On Tue, Sep 25, 2018 at 02:37:55PM -0300, Eduardo Lima (Etrunko) wrote:
> This new version ships the fix for the issue where 'check' keyword could
> not be used in project definition, so we had to run that command again
> only to check if it succeeded.
>
> https://github.com/mesonbuild/meson/issue
Hi,
On Tue, Sep 25, 2018 at 02:37:59PM -0300, Eduardo Lima (Etrunko) wrote:
> Fixes the cases where either the dependency is not installed or
> the version installed does not satisfy the requirement.
>
> Signed-off-by: Eduardo Lima (Etrunko)
Nack, for now. Same argument from teuf:
https:/
Hi,
On Wed, Sep 26, 2018 at 10:25:56AM +0200, Christophe Fergeau wrote:
> NB: The newer meson we require, the harder it will be to say "ok, from
> now on, we'll be switching to building with meson by default".
What would mean switching to it by default? Removing autotools?
I agree that we should
Hi,
On Tue, Sep 25, 2018 at 10:59:10AM -0300, Eduardo Lima (Etrunko) wrote:
> This is required in the case another project uses this one as a
> subproject
>
> Signed-off-by: Eduardo Lima (Etrunko)
Just for reference,
http://mesonbuild.com/Reference-manual.html#declare_dependencyo
Acked-by
On Wed, Sep 26, 2018 at 10:27:00AM +0200, Christophe Fergeau wrote:
> On Tue, Sep 25, 2018 at 04:38:26PM -0400, Frediano Ziglio wrote:
> > >
> > > Fixes the cases where either the dependency is not installed or the
> > > version installed does not satisfy the requirement.
> > >
> > > Signed-off-b
On Tue, Sep 25, 2018 at 04:38:26PM -0400, Frediano Ziglio wrote:
> >
> > Fixes the cases where either the dependency is not installed or the
> > version installed does not satisfy the requirement.
> >
> > Signed-off-by: Eduardo Lima (Etrunko)
>
> Why this is not true for autoconf?
>
> As spice
>
> Signed-off-by: Eduardo Lima (Etrunko)
> ---
> meson.build | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index 629f109..ebd42e1 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -88,10 +88,9 @@ foreach dep, version : deps
>spi
NB: The newer meson we require, the harder it will be to say "ok, from
now on, we'll be switching to building with meson by default".
Christophe
On Tue, Sep 25, 2018 at 02:40:00PM -0300, Eduardo Lima (Etrunko) wrote:
> This new version ships the fix for the issue where 'check' keyword could
> not
Hi,
On Tue, Sep 25, 2018 at 02:12:14PM -0300, Eduardo Lima (Etrunko) wrote:
> On 9/6/18 11:13 AM, Victor Toso wrote:
> > From: Victor Toso
> >
> > Otherwise spice-channel is left with a broken state.
> >
> > This code moves parent's call to channel_reset() into
> > _channel_reset_finish() - Not
>
> Signed-off-by: Eduardo Lima (Etrunko)
> ---
> meson.build | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index eba2c38..629f109 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -30,7 +30,6 @@ spice_gtk_global_cflags = ['-DHAVE_
>
> Signed-off-by: Eduardo Lima (Etrunko)
> ---
> meson.build | 1 -
> src/meson.build | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index 85f6e78..eba2c38 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -32,7 +32,6 @@ compiler = meson.get_compile
48 matches
Mail list logo
