Re: [Spice-devel] [PATCH v4 spice-streaming-agent 1/1] Adding gstreamer based plugin

2018-09-05 Thread Snir Sheriber
Hi, On 08/16/2018 08:59 PM, Eduardo Lima (Etrunko) wrote: On 16/08/18 11:59, Snir Sheriber wrote: Gstreamer based plugin utilizing gstreamer elements to capture screen from X, convert and encode into h264/h265/vp8/vp9/mjpeg stream Configure with --enable-gstreamer, will be built as a separate

Re: [Spice-devel] [PATCH v4 spice-streaming-agent 1/1] Adding gstreamer based plugin

2018-09-05 Thread Snir Sheriber
Hi, Thanks for reviewing this, so most things i fixed in v5. just one comment. On 08/17/2018 05:44 PM, Lukáš Hrázký wrote: Hi Snir, mostly nitpicks and style comments below... On Thu, 2018-08-16 at 17:59 +0300, Snir Sheriber wrote: Gstreamer based plugin utilizing gstreamer elements to capt

Re: [Spice-devel] [PATCH spice-gtk] build: Make usb-acl-helper test work under Meson

2018-09-05 Thread Eduardo Lima (Etrunko)
On 09/04/2018 12:50 PM, Frediano Ziglio wrote: >> >> On 09/03/2018 01:34 PM, Frediano Ziglio wrote: >>> Meson waits for pipes (stdout and stderr) to be not readable but >>> our mocking helper does not close these handles causing Meson >>> to give some problems. >>> >> >> Can you elaborate on the "s