Hi,
On Mon, Sep 03, 2018 at 06:38:58PM +0200, Jakub Janku wrote:
> Hi Victor,
>
> On Tue, Aug 28, 2018 at 9:38 AM Victor Toso wrote:
> >
> > Hi,
> >
> > On Tue, Aug 14, 2018 at 08:53:37PM +0200, Jakub Janků wrote:
> > > This is purely a preparatory patch as it renders
> > > the vdagentd non-func
Hi,
On Mon, Sep 03, 2018 at 09:03:38PM +0200, Jakub Janku wrote:
> I do agree that turning VDAgentConnection into a GObject is
> probably a good idea, however, I do not see how it could help
> us in this situation. Am I missing something? I'll try to
> explain the problem again:
>
> Let's consid
Hi,
On Mon, Sep 03, 2018 at 06:20:44PM +0200, Jakub Janku wrote:
> Hi,
>
> On Tue, Aug 28, 2018 at 7:52 AM Victor Toso wrote:
> >
> > Hi,
> >
> > Took me a while to get the rationale behind this so some more
> > info in the commit log might help.
>
> OK, will do, sorry.
No worries
> >
> > On
Hi,
On Mon, Sep 03, 2018 at 06:06:01PM +0200, Jakub Janku wrote:
> Hi,
>
> > I think that after "vdagentd: use GMainLoop" patch, we should
> > also include glib's command line options.
>
> Not sure what you are referring to here.
> GLib uses environment variables instead of command line
> option
On Tue, Aug 28, 2018 at 9:33 AM Victor Toso wrote:
>
> Hi,
>
> First of all, thanks for your work on this :)
>
> I'm still looking into the glib-integration related patches so I
> might still reply once more afterwards. To keep things easy to
> review, I take we could split this series in three di
Signed-off-by: Eduardo Lima (Etrunko)
---
doc/reference/meson.build | 1 -
meson.build | 1 -
src/meson.build | 11 +++
3 files changed, 3 insertions(+), 10 deletions(-)
diff --git a/doc/reference/meson.build b/doc/reference/meson.build
index 7ac703f..2ec333b 10
No need to use it when we can actually specify the parameters in the
actual gnome.generate_gir() function calls. We still keep it in the case
of gnome.gtkdoc(), as there is no way to specify the libraries to link
with.
Signed-off-by: Eduardo Lima (Etrunko)
---
doc/reference/meson.build | 4 ++--
Hey,
On Tue, Aug 28, 2018 at 10:04 AM Victor Toso wrote:
>
> Hi,
>
> On Tue, Aug 14, 2018 at 08:53:39PM +0200, Jakub Janků wrote:
> > Add a set of helper functions built around GIO that can be used to
> > easily write messages to and read from the given FD.
> >
> > Since VDAgentConnection uses GI
Hi Victor,
On Tue, Aug 28, 2018 at 9:38 AM Victor Toso wrote:
>
> Hi,
>
> On Tue, Aug 14, 2018 at 08:53:37PM +0200, Jakub Janků wrote:
> > This is purely a preparatory patch as it renders
> > the vdagentd non-functional.
>
> I would rather not break it unless it really helps a lot. It was
> possi
Meson waits for pipes (stdout and stderr) to be not readable but
our mocking helper does not close these handles causing Meson
to give some problems.
Signed-off-by: Frediano Ziglio
---
tests/usb-acl-helper.c | 8
1 file changed, 8 insertions(+)
diff --git a/tests/usb-acl-helper.c b/tes
Hi,
On Tue, Aug 28, 2018 at 7:52 AM Victor Toso wrote:
>
> Hi,
>
> Took me a while to get the rationale behind this so some more
> info in the commit log might help.
OK, will do, sorry.
>
> On Tue, Aug 14, 2018 at 08:53:36PM +0200, Jakub Janků wrote:
> > If the virtio port is destroyed explicitl
Hi,
On Tue, Aug 28, 2018 at 7:16 AM Victor Toso wrote:
>
> Hi,
>
> Just for reference, the output of spice-vdagentd -h before was:
>
> | $ spice-vdagentd -h
> | Usage: spice-vdagentd [OPTIONS]
> |
> | Spice guest agent daemon, version 0.17.0.
> |
> | Options:
> | -h print thi
>
> This function does accept a list of arguments, so there is no need to
> iterate over it.
>
> Signed-off-by: Eduardo Lima (Etrunko)
Acked-by: Frediano Ziglio
But I'd like to see CI fixes merged before this one.
I cannot understand why "meson test" fails, Meson fails with
a weird Python sta
On 09/03/2018 09:46 AM, Frediano Ziglio wrote:
> If gir files are not installed generate_vapi is not able to
> find generated gir files, so look also in src generated files.
>
> Signed-off-by: Frediano Ziglio
> ---
> vapi/meson.build | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/vapi
On 09/03/2018 09:46 AM, Frediano Ziglio wrote:
> File generated should be depends on currently files built, not from
> installed files, so use target objects for spice-gtk dependency
> on spice-lib.
>
> Signed-off-by: Frediano Ziglio
> ---
> src/meson.build | 2 +-
> 1 file changed, 1 insertion(
On 09/03/2018 10:30 AM, Eduardo Lima (Etrunko) wrote:
> On 09/03/2018 09:46 AM, Frediano Ziglio wrote:
>> If gir files are not installed generate_vapi is not able to
>> find generated gir files, so look also in src generated files.
>>
>> Signed-off-by: Frediano Ziglio
>> ---
>> vapi/meson.build |
On 09/03/2018 09:46 AM, Frediano Ziglio wrote:
> If gir files are not installed generate_vapi is not able to
> find generated gir files, so look also in src generated files.
>
> Signed-off-by: Frediano Ziglio
> ---
> vapi/meson.build | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/vapi
File generated should be depends on currently files built, not from
installed files, so use target objects for spice-gtk dependency
on spice-lib.
Signed-off-by: Frediano Ziglio
---
src/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/meson.build b/src/meson.bui
If gir files are not installed generate_vapi is not able to
find generated gir files, so look also in src generated files.
Signed-off-by: Frediano Ziglio
---
vapi/meson.build | 1 +
1 file changed, 1 insertion(+)
diff --git a/vapi/meson.build b/vapi/meson.build
index 4737715..de9adb9 100644
---
>
> This avoids adding an extra build flag which may not be supported by the
> compiler.
>
> Signed-off-by: Eduardo Lima (Etrunko)
Acked-by: Frediano Ziglio
Frediano
> ---
> meson.build | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/meson.build b/meson.build
>
> This function does accept a list of arguments, so there is no need to
> iterate over it.
>
> Signed-off-by: Eduardo Lima (Etrunko)
Acked-by: Frediano Ziglio ---
> meson.build | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/meson.build b/meson.build
> index 2
21 matches
Mail list logo
