Re: [Spice-devel] [RFC PATCH v2 00/20] Monitor ID rework

2018-08-23 Thread Gerd Hoffmann
Hi, > Note that if all we want to support with the associated QXL device is > text console, we may perhaps just drop the QXL device and use > console/VT directly using spice ports, like I proposed in virt-viewer > "[PATCH 00/22] Add QEMU-like UI: VT console & basic VM state" series. Not going t

Re: [Spice-devel] [RFC PATCH v2 00/20] Monitor ID rework

2018-08-23 Thread Gerd Hoffmann
Hi, > 1. The logic used to switch something for something and when - You need > to define somehow you have this QXL device that is showing the boot in > client display 1 and then you start X and want to replace client > display 1 with X monitor 1. Then the user switches VTs and you need to > swi

Re: [Spice-devel] [RFC PATCH v2 00/20] Monitor ID rework

2018-08-23 Thread Gerd Hoffmann
Hi, > There's not a new channel type, but there is a new channel, because > there are two devices. Both the QXL device and the vGPU have their own > Display channels. > * channel #0 is the QXL device and only displays stuff at boot time >(or when switching to a VT) > * channel #1 is the n

Re: [Spice-devel] [RFC PATCH v2 00/20] Monitor ID rework

2018-08-23 Thread Gerd Hoffmann
Hi, > "we only support" seems to just state the use cases before adding > vGPU but we are trying to support vGPU cases. > If even we decide that for vGPU cards we always have monitor_id == 0 Yes, we want this for sure. One channel per display. > (that is multiple DisplayChannels for each vGPU

Re: [Spice-devel] [RFC PATCH spice-common v2 02/20] A version 2 of the MousePosition message

2018-08-23 Thread Gerd Hoffmann
Hi, > Note also that under Linux currently all these protocol limitations allows > to support only a single device with multiple output, which is a problem for > vGPU. Under Windows we support multiple devices but all devices are limited > to one monitor. Extending Linux using the same limitatio

Re: [Spice-devel] [RFC PATCH spice-protocol v2 04/20] Create a version 2 of the VDAgentMonitorsConfig message

2018-08-23 Thread Jonathon Jongsma
On Thu, 2018-08-23 at 11:27 +0200, Lukáš Hrázký wrote: > On Wed, 2018-08-22 at 11:53 -0500, Jonathon Jongsma wrote: > > On Wed, 2018-08-22 at 10:41 +0200, Lukáš Hrázký wrote: > > > On Tue, 2018-08-21 at 15:41 -0500, Jonathon Jongsma wrote: > > > > I'm wondering if this new message is strictly neces

Re: [Spice-devel] [RFC PATCH spice-common v2 02/20] A version 2 of the MousePosition message

2018-08-23 Thread Marc-André Lureau
Hi On Thu, Aug 23, 2018 at 2:15 PM Lukáš Hrázký wrote: > > On Thu, 2018-08-23 at 03:51 -0400, Frediano Ziglio wrote: > > > > > > Hi > > > > > > On Wed, Aug 22, 2018 at 11:11 PM Jonathon Jongsma > > > wrote: > > > > > > > > On Thu, 2018-08-16 at 18:26 +0200, Lukáš Hrázký wrote: > > > > > The vers

Re: [Spice-devel] [RFC PATCH spice-common v2 02/20] A version 2 of the MousePosition message

2018-08-23 Thread Lukáš Hrázký
On Thu, 2018-08-23 at 03:51 -0400, Frediano Ziglio wrote: > > > > Hi > > > > On Wed, Aug 22, 2018 at 11:11 PM Jonathon Jongsma > > wrote: > > > > > > On Thu, 2018-08-16 at 18:26 +0200, Lukáš Hrázký wrote: > > > > The version 2 is using a (channel_id, monitor_id) pair to uniquely > > > > identif

Re: [Spice-devel] [RFC PATCH spice-common v2 02/20] A version 2 of the MousePosition message

2018-08-23 Thread Lukáš Hrázký
On Wed, 2018-08-22 at 16:11 -0500, Jonathon Jongsma wrote: > On Thu, 2018-08-16 at 18:26 +0200, Lukáš Hrázký wrote: > > The version 2 is using a (channel_id, monitor_id) pair to uniquely > > identify the display on which the event occured, instead of the > > ambiguous display_id. > > > > Signed-of

Re: [Spice-devel] [RFC PATCH spice-common v2 02/20] A version 2 of the MousePosition message

2018-08-23 Thread Marc-André Lureau
Hi On Thu, Aug 23, 2018 at 11:53 AM Frediano Ziglio wrote: > > > > > Hi > > On Thu, Aug 23, 2018 at 9:51 AM Frediano Ziglio wrote: > > > > > > > > > > > Hi > > > > > > > > On Wed, Aug 22, 2018 at 11:11 PM Jonathon Jongsma > > > > wrote: > > > > > > > > > > On Thu, 2018-08-16 at 18:26 +0200, Luká

Re: [Spice-devel] [RFC PATCH spice-common v2 02/20] A version 2 of the MousePosition message

2018-08-23 Thread Frediano Ziglio
> > Hi > On Thu, Aug 23, 2018 at 9:51 AM Frediano Ziglio wrote: > > > > > > > > Hi > > > > > > On Wed, Aug 22, 2018 at 11:11 PM Jonathon Jongsma > > > wrote: > > > > > > > > On Thu, 2018-08-16 at 18:26 +0200, Lukáš Hrázký wrote: > > > > > The version 2 is using a (channel_id, monitor_id) pair to

Re: [Spice-devel] [RFC PATCH spice-protocol v2 04/20] Create a version 2 of the VDAgentMonitorsConfig message

2018-08-23 Thread Lukáš Hrázký
On Wed, 2018-08-22 at 11:53 -0500, Jonathon Jongsma wrote: > On Wed, 2018-08-22 at 10:41 +0200, Lukáš Hrázký wrote: > > On Tue, 2018-08-21 at 15:41 -0500, Jonathon Jongsma wrote: > > > I'm wondering if this new message is strictly necessary. We *could* > > > still support the vgpu scenario with the

Re: [Spice-devel] [RFC PATCH spice-common v2 01/20] Add a monitors config message from the client to the server

2018-08-23 Thread Lukáš Hrázký
On Wed, 2018-08-22 at 11:00 -0500, Jonathon Jongsma wrote: > On Wed, 2018-08-22 at 13:35 +0200, Lukáš Hrázký wrote: > > On Tue, 2018-08-21 at 16:35 -0500, Jonathon Jongsma wrote: > > > So I sent my comments on patch 04/20 before this one, but this is > > > obviously very closely related. This spice

Re: [Spice-devel] [RFC PATCH spice-common v2 02/20] A version 2 of the MousePosition message

2018-08-23 Thread Marc-André Lureau
Hi On Thu, Aug 23, 2018 at 9:51 AM Frediano Ziglio wrote: > > > > > Hi > > > > On Wed, Aug 22, 2018 at 11:11 PM Jonathon Jongsma > > wrote: > > > > > > On Thu, 2018-08-16 at 18:26 +0200, Lukáš Hrázký wrote: > > > > The version 2 is using a (channel_id, monitor_id) pair to uniquely > > > > identif

Re: [Spice-devel] [RFC PATCH spice-common v2 02/20] A version 2 of the MousePosition message

2018-08-23 Thread Frediano Ziglio
> > Hi > > On Wed, Aug 22, 2018 at 11:11 PM Jonathon Jongsma > wrote: > > > > On Thu, 2018-08-16 at 18:26 +0200, Lukáš Hrázký wrote: > > > The version 2 is using a (channel_id, monitor_id) pair to uniquely > > > identify the display on which the event occured, instead of the > > > ambiguous disp