Re: [Spice-devel] [cacard 2/2] tests: Fix 'simpletlv' on i686 arches

2018-08-13 Thread Marc-André Lureau
On Mon, Aug 13, 2018 at 6:11 PM, Christophe Fergeau wrote: > The simpletlv_* functions return lengths as an int, but the test is > casting it to a size_t before comparing it against -1. This is not > giving the expected result on i686, causing the test to fail. > Why not change the variable to be

Re: [Spice-devel] [cacard 1/2] tests: Add cert.cfg to EXTRA_DIST

2018-08-13 Thread Marc-André Lureau
On Mon, Aug 13, 2018 at 6:11 PM, Christophe Fergeau wrote: > Without it, make check from tarballs will fail. Actually make distcheck passes, but the tests are skipped, right? > > Signed-off-by: Christophe Fergeau > --- > Makefile.am | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Make

Re: [Spice-devel] [PATCH spice-server] Support h265 in stream-channel

2018-08-13 Thread Frediano Ziglio
> > On Mon, Aug 13, 2018 at 11:41:31AM -0400, Frediano Ziglio wrote: > > > > > > Hey, > > > > > > At this point, I don't think we have anything which is going to give us > > > an h265 encoded stream, and latest spice-protocol release is fairly > > > recent but does not have the SPICE_DISPLAY_CAP

Re: [Spice-devel] [PATCH spice-server] Support h265 in stream-channel

2018-08-13 Thread Christophe Fergeau
On Mon, Aug 13, 2018 at 11:41:31AM -0400, Frediano Ziglio wrote: > > > > Hey, > > > > At this point, I don't think we have anything which is going to give us > > an h265 encoded stream, and latest spice-protocol release is fairly > > recent but does not have the SPICE_DISPLAY_CAP_CODEC_H265. I'd

[Spice-devel] [cacard 2/2] tests: Fix 'simpletlv' on i686 arches

2018-08-13 Thread Christophe Fergeau
The simpletlv_* functions return lengths as an int, but the test is casting it to a size_t before comparing it against -1. This is not giving the expected result on i686, causing the test to fail. Signed-off-by: Christophe Fergeau --- tests/simpletlv.c | 12 ++-- 1 file changed, 6 insert

[Spice-devel] [cacard 1/2] tests: Add cert.cfg to EXTRA_DIST

2018-08-13 Thread Christophe Fergeau
Without it, make check from tarballs will fail. Signed-off-by: Christophe Fergeau --- Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile.am b/Makefile.am index 16ec30c..f4e8009 100644 --- a/Makefile.am +++ b/Makefile.am @@ -141,6 +141,7 @@ EXTRA_DIST +=

Re: [Spice-devel] [PATCH spice-gtk] glib: add SpiceQmpPort helper

2018-08-13 Thread Marc-André Lureau
Hi On Fri, Aug 10, 2018 at 11:26 PM, Victor Toso wrote: > Hi, > > On Fri, Aug 10, 2018 at 03:44:19PM +0200, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau >> >> Add a few helper functions to deal with a QMP port channel, in order >> to ease json handling, and wrapping a few comman

Re: [Spice-devel] [PATCH spice-server] Support h265 in stream-channel

2018-08-13 Thread Frediano Ziglio
> > Hey, > > At this point, I don't think we have anything which is going to give us > an h265 encoded stream, and latest spice-protocol release is fairly > recent but does not have the SPICE_DISPLAY_CAP_CODEC_H265. I'd like to > temporarily revert this commit for spice-server 0.14.1 so that it d

Re: [Spice-devel] [PATCH spice-server] Support h265 in stream-channel

2018-08-13 Thread Christophe Fergeau
Hey, At this point, I don't think we have anything which is going to give us an h265 encoded stream, and latest spice-protocol release is fairly recent but does not have the SPICE_DISPLAY_CAP_CODEC_H265. I'd like to temporarily revert this commit for spice-server 0.14.1 so that it does not depend

Re: [Spice-devel] [PATCH] win-usb-dev: Set UsbDk backend on libusb 1.0.22

2018-08-13 Thread Christophe Fergeau
Hey, On Mon, Aug 13, 2018 at 03:45:06PM +0200, Jorge Olmos wrote: > This patch configures libusb in the context used in win-usb-dev, with > the same backend as the context initialized in usb-device-manager. > > Otherwise spice_usb_device_manager_libdev_match returns false for all > devices, and n

Re: [Spice-devel] [cacard] simpletlv: Use GArray to make simpletlv_parse simpler

2018-08-13 Thread Christophe Fergeau
Hey, On Mon, Aug 13, 2018 at 02:56:43PM +0200, Jakub Jelen wrote: > On Mon, 2018-08-13 at 11:08 +0200, Christophe Fergeau wrote: > > This allows to get rid of manual reallocations. > > Thank you. This looks more elegant way. Assuming it still works and > passes the CI, it looks good to me. Yup,

[Spice-devel] [PATCH] win-usb-dev: Set UsbDk backend on libusb 1.0.22

2018-08-13 Thread Jorge Olmos
This patch configures libusb in the context used in win-usb-dev, with the same backend as the context initialized in usb-device-manager. Otherwise spice_usb_device_manager_libdev_match returns false for all devices, and no usb device is offered to end user for redirection. --- src/win-usb-dev.c |

[Spice-devel] [PATCH vd_agent 2/2] Improve/add some logging messages

2018-08-13 Thread Lukáš Hrázký
Signed-off-by: Lukáš Hrázký --- src/vdagent/vdagent.c | 2 ++ src/vdagent/x11-randr.c | 23 +++ src/vdagentd/uinput.c | 8 3 files changed, 21 insertions(+), 12 deletions(-) diff --git a/src/vdagent/vdagent.c b/src/vdagent/vdagent.c index 3f8ef31..c5e5952 10064

[Spice-devel] [PATCH vd_agent 1/2] vdagent/x11-randr: rename error_handler to ignore_error_handler

2018-08-13 Thread Lukáš Hrázký
The handler is meant to ignore the X11 error, name it properly. Signed-off-by: Lukáš Hrázký --- src/vdagent/x11-randr.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/vdagent/x11-randr.c b/src/vdagent/x11-randr.c index 803cf73..15fb2b2 100644 --- a/src/vdagent

[Spice-devel] [PATCH spice-gtk] fixup! Add support for building with meson/ninja

2018-08-13 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- meson.build | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/meson.build b/meson.build index 2a72e79..52339b8 100644 --- a/meson.build +++ b/meson.build @@ -29,7 +29,8 @@ spice_gtk_global_cflags = ['-DHAVE_CONFIG_H',

Re: [Spice-devel] [cacard] simpletlv: Use GArray to make simpletlv_parse simpler

2018-08-13 Thread Jakub Jelen
On Mon, 2018-08-13 at 11:08 +0200, Christophe Fergeau wrote: > This allows to get rid of manual reallocations. Thank you. This looks more elegant way. Assuming it still works and passes the CI, it looks good to me. Acked-by: Jakub Jelen > Signed-off-by: Christophe Fergeau > --- > src/simpletl

Re: [Spice-devel] [PATCH spice-gtk v4 0/3] Add support for building with meson/ninja

2018-08-13 Thread Eduardo Lima (Etrunko)
On 10/08/18 17:26, Victor Toso wrote: > Hi, > > On Fri, Aug 10, 2018 at 04:23:45PM -0300, Eduardo Lima (Etrunko) wrote: >> in v4: >> - New patch renaming vncdisplaykeymap_*.c to .h >> - Fix parallel builds by adding generated keymap files as dependency >>of spice_client_gtk library. > > Yep

Re: [Spice-devel] [PATCH spice-gtk v4 1/3] Rename generated vncdisplaykeymap_*.c files to .h

2018-08-13 Thread Eduardo Lima (Etrunko)
On 13/08/18 07:23, Frediano Ziglio wrote: >> >> Ninja parallel build fails in certain environments, so it is required >> specify those files as a dependency so that vncdisplaykeymap.c will only >> be built after all files it depends on are generated. >> >> The problem is that, when using meson decl

Re: [Spice-devel] [spice-server v2 2/2] build: Prepare for 0.14.1 release

2018-08-13 Thread Christophe Fergeau
On Mon, Aug 13, 2018 at 06:34:19AM -0400, Frediano Ziglio wrote: > > > > Signed-off-by: Christophe Fergeau > > --- > > NEWS | 33 + > > configure.ac | 2 +- > > 2 files changed, 34 insertions(+), 1 deletion(-) > > > > diff --git a/NEWS b/NEWS > > index 5

Re: [Spice-devel] [spice-gtk] Fix using NULL main channel reference

2018-08-13 Thread Javier Celaya
Hi, sorry for the late response, I was on holidays El mar, 24-07-2018 a las 17:58 +0200, Marc-André Lureau escribió: > On Mon, Jul 16, 2018 at 6:45 PM, Javier Celaya com> wrote:The main channel reference d->main of SpiceWidget is > initialized onconstruction. However, it is used a couple of times >

Re: [Spice-devel] [spice-server v2 2/2] build: Prepare for 0.14.1 release

2018-08-13 Thread Frediano Ziglio
> > Signed-off-by: Christophe Fergeau > --- > NEWS | 33 + > configure.ac | 2 +- > 2 files changed, 34 insertions(+), 1 deletion(-) > > diff --git a/NEWS b/NEWS > index 51bb4a2e6..1577b013f 100644 > --- a/NEWS > +++ b/NEWS > @@ -1,3 +1,36 @@ > +Major Ch

Re: [Spice-devel] [PATCH spice-gtk v4 1/3] Rename generated vncdisplaykeymap_*.c files to .h

2018-08-13 Thread Frediano Ziglio
> > Ninja parallel build fails in certain environments, so it is required > specify those files as a dependency so that vncdisplaykeymap.c will only > be built after all files it depends on are generated. > > The problem is that, when using meson declare_dependency() function, > only header files

[Spice-devel] [spice-server v2 2/2] build: Prepare for 0.14.1 release

2018-08-13 Thread Christophe Fergeau
Signed-off-by: Christophe Fergeau --- NEWS | 33 + configure.ac | 2 +- 2 files changed, 34 insertions(+), 1 deletion(-) diff --git a/NEWS b/NEWS index 51bb4a2e6..1577b013f 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,36 @@ +Major Changes in 0.14.1: +=

[Spice-devel] [spice-server v2 1/2] docs: Add documentation for the streaming device

2018-08-13 Thread Christophe Fergeau
Signed-off-by: Christophe Fergeau --- docs/manual/manual.txt | 51 ++ 1 file changed, 51 insertions(+) diff --git a/docs/manual/manual.txt b/docs/manual/manual.txt index 40d080d9f..99f6a5c84 100644 --- a/docs/manual/manual.txt +++ b/docs/manual/manual.txt

Re: [Spice-devel] [RFC spice-vdagent 4/8] build: make GTK+ mandatory

2018-08-13 Thread Christophe Fergeau
On Thu, Aug 09, 2018 at 03:35:52PM +0200, Victor Toso wrote: > Hi, > > On Thu, May 31, 2018 at 10:52:21PM +0200, Jakub Janků wrote: > > Use GTK+ instead of Xlib where possible, > > remove Xlib code that handles clipboard. > > @teuf, double checking here if you think requiring gtk and > dropping x

[Spice-devel] [cacard] simpletlv: Use GArray to make simpletlv_parse simpler

2018-08-13 Thread Christophe Fergeau
This allows to get rid of manual reallocations. Signed-off-by: Christophe Fergeau --- src/simpletlv.c | 37 +++-- 1 file changed, 11 insertions(+), 26 deletions(-) diff --git a/src/simpletlv.c b/src/simpletlv.c index 6759ea7..0adba5a 100644 --- a/src/simpletlv.c

[Spice-devel] [cacard v2] simpletlv: Use g_malloc instead of malloc

2018-08-13 Thread Christophe Fergeau
This is more consistent with the rest of the codebase. Signed-off-by: Christophe Fergeau --- src/simpletlv.c | 35 --- 1 file changed, 12 insertions(+), 23 deletions(-) diff --git a/src/simpletlv.c b/src/simpletlv.c index 42ff572..6759ea7 100644 --- a/src/simplet

Re: [Spice-devel] [cacard 1/7] Fix 'Reqested' typo

2018-08-13 Thread Jakub Jelen
Thank you for reviewing the changes, fixing typos and cleaning things. All your changes from this patch set look good to me. Acked-by: Jakub Jelen On Fri, 2018-08-10 at 10:04 +0200, Christophe Fergeau wrote: > Signed-off-by: Christophe Fergeau > --- > src/cac.c | 4 ++-- > 1 file changed, 2 in