Re: [Spice-devel] [PATCH spice-common] meson: Fix checking for python

2018-07-24 Thread Frediano Ziglio
> > When running with -Dpython-checks=false, the build fails. To fix this, > we move the python variable declaration outside of the get_option() > block as it will be used for calling the generators. Also removes the > unnecessary check for python3-devel. > > Signed-off-by: Eduardo Lima (Etrunko)

[Spice-devel] [PATCH spice-common] meson: Fix checking for python

2018-07-24 Thread Eduardo Lima (Etrunko)
When running with -Dpython-checks=false, the build fails. To fix this, we move the python variable declaration outside of the get_option() block as it will be used for calling the generators. Also removes the unnecessary check for python3-devel. Signed-off-by: Eduardo Lima (Etrunko) --- .gitlab-

Re: [Spice-devel] [spice-gtk] Fix using NULL main channel reference

2018-07-24 Thread Marc-André Lureau
On Mon, Jul 16, 2018 at 6:45 PM, Javier Celaya wrote: > The main channel reference d->main of SpiceWidget is initialized on > construction. However, it is used a couple of times before that moment > while setting the default values of some properties, like resize-guest. > This results in some anno

Re: [Spice-devel] [RFC spice-gtk 1/1] Gstreamer: Use GstVideoOverlay if possible

2018-07-24 Thread Marc-André Lureau
Hi On Sun, Mar 11, 2018 at 10:44 AM, Snir Sheriber wrote: > Currently when gstreamer is used to decode a full-screen > stream sent from the server, the decoding frames are being > forced to RBGA format and pushed using appsink to be scaled > and rendered to screen. > > Today most of the gstreamer

Re: [Spice-devel] [PATCH spice-server v3 2/2] Update gitlab-ci to use meson

2018-07-24 Thread Eduardo Lima (Etrunko)
On 24/07/18 11:00, Eduardo Lima (Etrunko) wrote: > Signed-off-by: Eduardo Lima (Etrunko) > --- > .gitlab-ci.yml | 31 ++- > 1 file changed, 30 insertions(+), 1 deletion(-) > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > index 50fb7a15..44dc26d3 100644 > --- a/.gitl

Re: [Spice-devel] [PATCH spice-server v3 2/2] Update gitlab-ci to use meson

2018-07-24 Thread Eduardo Lima (Etrunko)
On 24/07/18 10:21, Uri Lublin wrote: > On 07/24/2018 03:15 PM, Eduardo Lima (Etrunko) wrote: >> Signed-off-by: Eduardo Lima (Etrunko) >> --- >>   .gitlab-ci.yml | 31 ++- >>   1 file changed, 30 insertions(+), 1 deletion(-) >> >> diff --git a/.gitlab-ci.yml b/.gitlab-ci.

[Spice-devel] [PATCH spice-server v3 2/2] Update gitlab-ci to use meson

2018-07-24 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- .gitlab-ci.yml | 31 ++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 50fb7a15..44dc26d3 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -4,7 +4,7 @@ before_script:

[Spice-devel] [PATCH spice-server v3 1/2] Add support for building with meson/ninja

2018-07-24 Thread Eduardo Lima (Etrunko)
In a comparison with current autotools build system, meson/ninja provides a huge improvement in build speed, while keeping the same functionalities currently available and being considered more user friendly. The new system coexists within the same repository with the current one, so we can do mor

[Spice-devel] [PATCH spice-server v3 0/2] Add support for building with meson/ninja

2018-07-24 Thread Eduardo Lima (Etrunko)
In v3: - Check for LZ4_compress_fast_continue function. - Only update spice-common submodule if running under git environment. - Fix spice-server-enums.[ch] generation - Added spice_server_so_version as a global variable Eduardo Lima (Etrunko) (2): Add support for building with meson/nin

[Spice-devel] [spice-gtk v2 3/4] gtk-deprecated: silence warn on gtk_widget_set_double_buffered()

2018-07-24 Thread Victor Toso
From: Victor Toso To quote documentation: | gtk_widget_set_double_buffered has been deprecated since version | 3.14 and should not be used in newly-written code. | This function does not work under non-X11 backends or with | non-native windows. It should not be used in newly written code. So

Re: [Spice-devel] [PATCH spice-server 2/3] Add support for building with meson

2018-07-24 Thread Eduardo Lima (Etrunko)
On 24/07/18 06:14, Frediano Ziglio wrote: > ... > > + > +# lz4 > +spice_server_has_lz4 = false > +if get_option('lz4') > + lz4_dep = dependency('liblz4', required : false, version : '>= 129') > + if not lz4_dep.found() > +lz4_dep = dependency('liblz4', version : '

Re: [Spice-devel] [PATCH spice-server 2/3] Add support for building with meson

2018-07-24 Thread Eduardo Lima (Etrunko)
On 24/07/18 03:56, Frediano Ziglio wrote: >> >> On 22/07/18 11:31, Frediano Ziglio wrote: Signed-off-by: Eduardo Lima (Etrunko) --- Makefile.am | 2 + build-aux/meson/check_spice-common.sh | 2 + docs/Makefile.am |

Re: [Spice-devel] [spice-gtk 3/4] gtk-deprecated: silence warn on gtk_widget_set_double_buffered()

2018-07-24 Thread Victor Toso
Hi, On Tue, Jul 24, 2018 at 09:35:01AM -0400, Frediano Ziglio wrote: > > Ugly indeed, I didn't care much at first sight but you are right. > > > > I don't mind wrapping this in an utility function/macro but don't > > exactly agree to use it in glib-compat as that's usually referred > > to glib fu

Re: [Spice-devel] [PATCH spice-server v3 2/2] Update gitlab-ci to use meson

2018-07-24 Thread Frediano Ziglio
> > On 07/24/2018 03:15 PM, Eduardo Lima (Etrunko) wrote: > > Signed-off-by: Eduardo Lima (Etrunko) > > --- > > .gitlab-ci.yml | 31 ++- > > 1 file changed, 30 insertions(+), 1 deletion(-) > > > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > > index 50fb7a15..44d

Re: [Spice-devel] [spice-gtk 3/4] gtk-deprecated: silence warn on gtk_widget_set_double_buffered()

2018-07-24 Thread Frediano Ziglio
> > Hi, > > On Tue, Jul 24, 2018 at 08:56:53AM -0400, Frediano Ziglio wrote: > > > > > > From: Victor Toso > > > > > > To quote documentation: > > > | gtk_widget_set_double_buffered has been deprecated since version > > > | 3.14 and should not be used in newly-written code. > > > | This fun

Re: [Spice-devel] [PATCH spice-server v3 2/2] Update gitlab-ci to use meson

2018-07-24 Thread Uri Lublin
On 07/24/2018 03:15 PM, Eduardo Lima (Etrunko) wrote: Signed-off-by: Eduardo Lima (Etrunko) --- .gitlab-ci.yml | 31 ++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 50fb7a15..44dc26d3 100644 --- a/.gitlab-ci.y

Re: [Spice-devel] [spice-gtk 3/4] gtk-deprecated: silence warn on gtk_widget_set_double_buffered()

2018-07-24 Thread Victor Toso
Hi, On Tue, Jul 24, 2018 at 08:56:53AM -0400, Frediano Ziglio wrote: > > > > From: Victor Toso > > > > To quote documentation: > > | gtk_widget_set_double_buffered has been deprecated since version > > | 3.14 and should not be used in newly-written code. > > | This function does not work und

Re: [Spice-devel] [spice-gtk 3/4] gtk-deprecated: silence warn on gtk_widget_set_double_buffered()

2018-07-24 Thread Frediano Ziglio
> > From: Victor Toso > > To quote documentation: > | gtk_widget_set_double_buffered has been deprecated since version > | 3.14 and should not be used in newly-written code. > | This function does not work under non-X11 backends or with > | non-native windows. It should not be used in newly

Re: [Spice-devel] [spice-gtk v2 4/4] gtk-deprecated: Avoid gdk_screen_get_width/height()

2018-07-24 Thread Frediano Ziglio
> > From: Victor Toso > > As those were deprecated in favor of fetching for information directly > with GdkMonitor. > > Warnings fixed: > | spice-widget.c: In function ‘mouse_wrap’: > | spice-widget.c:1136:5: warning: ‘gdk_screen_get_width’ is deprecated > | > | xr = gdk_screen_get_widt

Re: [Spice-devel] [spice-gtk 2/4] gtk-deprecated: Use gdk_keymap_get_for_display()

2018-07-24 Thread Frediano Ziglio
> > From: Victor Toso > > As gdk_keymap_get_default() was deprecated in 3.22 > > Warnings fixed: > | vncdisplaykeymap.c: In function ‘vnc_display_keyval_set_entries’: > | vncdisplaykeymap.c:263:4: warning: ‘gdk_keymap_get_default’ is > | deprecated: Use 'gdk_keymap_get_for_display' instead >

Re: [Spice-devel] [PATCH spice-server v3 1/2] Add support for building with meson/ninja

2018-07-24 Thread Eduardo Lima (Etrunko)
I've sent the patch from the wrong branch, please ignore this one. On 24/07/18 09:15, Eduardo Lima (Etrunko) wrote: > In a comparison with current autotools build system, meson/ninja > provides a huge improvement in build speed, while keeping the same > functionalities currently available and bei

[Spice-devel] [PATCH spice-server v3 2/2] Update gitlab-ci to use meson

2018-07-24 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- .gitlab-ci.yml | 31 ++- 1 file changed, 30 insertions(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 50fb7a15..44dc26d3 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -4,7 +4,7 @@ before_script:

[Spice-devel] [PATCH spice-server v3 1/2] Add support for building with meson/ninja

2018-07-24 Thread Eduardo Lima (Etrunko)
In a comparison with current autotools build system, meson/ninja provides a huge improvement in build speed, while keeping the same functionalities currently available and being considered more user friendly. The new system coexists within the same repository with the current one, so we can do mor

Re: [Spice-devel] [spice-server PATCH] RFC: stream-device: do not reallocate dev->msg for each frame

2018-07-24 Thread Frediano Ziglio
> > In the past dev->msg was only allocated for cursor images, and > after use dev->msg size was reduced. > > Now, since commit dcc3f995d9f55, dev->msg is used for every frame. > There is little point of calling reallocate with a large dev->msg size > and then reallocate with a small size, for ev

Re: [Spice-devel] [spice-server PATCH] Remove unused structs QXLDrawArea and QXLDevInfo

2018-07-24 Thread Frediano Ziglio
> > Signed-off-by: Uri Lublin Nice catch. I would add some comments as this is changing also a public header. The structure usage was removed from commit 2ba69f9f8819daaa3d166c4c1c7e03b121b88a95 ("libspice: add surface 0 support"). Was never used by Qemu. > --- > server/spice-qxl.h | 20

[Spice-devel] [spice-server PATCH] Remove unused structs QXLDrawArea and QXLDevInfo

2018-07-24 Thread Uri Lublin
Signed-off-by: Uri Lublin --- server/spice-qxl.h | 20 1 file changed, 20 deletions(-) diff --git a/server/spice-qxl.h b/server/spice-qxl.h index 04c657c58..0c4e75fc2 100644 --- a/server/spice-qxl.h +++ b/server/spice-qxl.h @@ -115,26 +115,6 @@ void spice_qxl_gl_draw_async(Q

Re: [Spice-devel] [PATCH spice-server 2/3] Add support for building with meson

2018-07-24 Thread Frediano Ziglio
... > > >> + > > >> +# lz4 > > >> +spice_server_has_lz4 = false > > >> +if get_option('lz4') > > >> + lz4_dep = dependency('liblz4', required : false, version : '>= 129') > > >> + if not lz4_dep.found() > > >> +lz4_dep = dependency('liblz4', version : '>= 1.7.3') > > >> + endif > > >> + > >