Re: [Spice-devel] [PATCH spice-server 2/3] Add support for building with meson

2018-07-23 Thread Frediano Ziglio
> > On 22/07/18 11:31, Frediano Ziglio wrote: > >> > >> Signed-off-by: Eduardo Lima (Etrunko) > >> --- > >> Makefile.am | 2 + > >> build-aux/meson/check_spice-common.sh | 2 + > >> docs/Makefile.am | 1 + > >> docs/manual/Makefile.am

Re: [Spice-devel] [PATCH spice-server 2/3] Add support for building with meson

2018-07-23 Thread Eduardo Lima (Etrunko)
On 22/07/18 11:31, Frediano Ziglio wrote: >> >> Signed-off-by: Eduardo Lima (Etrunko) >> --- >> Makefile.am | 2 + >> build-aux/meson/check_spice-common.sh | 2 + >> docs/Makefile.am | 1 + >> docs/manual/Makefile.am | 1 + >> d

Re: [Spice-devel] [PATCH] meson: Make options accessible through parent project

2018-07-23 Thread Frediano Ziglio
> > When building either spice-server or spice-gtk, spice-common should > inherit the command line options from the parent project. This is done > by adding the 'yield' keyword for the opus and celt051 options. > > It is also required to add a smartcard option so that we can bypass the > checks i

Re: [Spice-devel] [PATCH spice-server v2] build: Move spice-common to subprojects/ directory

2018-07-23 Thread Frediano Ziglio
> > The reason for this commit is that Meson expects all submodules to be > placed in this subdirectory, and since autotools build is more flexible > in this case, we make some small adjustments to configure.ac and > Makefile.am files to accommodate for this change. > > Signed-off-by: Eduardo Lim

Re: [Spice-devel] [PATCH spice-server 2/3] Add support for building with meson

2018-07-23 Thread Eduardo Lima (Etrunko)
On 22/07/18 11:32, Frediano Ziglio wrote: >> >>> >>> Signed-off-by: Eduardo Lima (Etrunko) >>> --- >>> Makefile.am | 2 + >>> build-aux/meson/check_spice-common.sh | 2 + >>> docs/Makefile.am | 1 + >>> docs/manual/Makefile.am |

[Spice-devel] [PATCH spice-server v2] build: Move spice-common to subprojects/ directory

2018-07-23 Thread Eduardo Lima (Etrunko)
The reason for this commit is that Meson expects all submodules to be placed in this subdirectory, and since autotools build is more flexible in this case, we make some small adjustments to configure.ac and Makefile.am files to accommodate for this change. Signed-off-by: Eduardo Lima (Etrunko) --

Re: [Spice-devel] [PATCH spice-server 1/3] build: Move spice-common to subprojects/ directory

2018-07-23 Thread Eduardo Lima (Etrunko)
On 22/07/18 11:15, Frediano Ziglio wrote: >> >> On 20/07/18 18:23, Eduardo Lima (Etrunko) wrote: >>> The reason for this commit is that Meson expects all submodules to be >>> placed in this subdirectory, and since autotools build is more flexible >>> in this case, we make some small adjustments to

Re: [Spice-devel] [PATCH spice-gtk] build-sys: disable celt051 by default when configure from autogen

2018-07-23 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Mon, Jul 23, 2018 at 01:23:46PM +0200, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Avoid the new error message for explicit celt051 option. > > Signed-off-by: Marc-André Lureau > --- > autogen.sh | 2 +- > 1 file changed, 1 insertion(+),

Re: [Spice-devel] [spice-gtk] cache: Fix OOM due bad refcount of image

2018-07-23 Thread Marc-André Lureau
Hi On Fri, Jul 20, 2018 at 11:56 AM, Victor Toso wrote: > From: 乐义华 > > The image in cache was not being freed properly leading the client to > crash with OOM after sometime. > > When image flag is SPICE_IMAGE_FLAGS_CACHE_REPLACE_ME, and if found it > in hash table, we will increase the refcount

[Spice-devel] [PATCH spice-gtk] build-sys: disable celt051 by default when configure from autogen

2018-07-23 Thread marcandre . lureau
From: Marc-André Lureau Avoid the new error message for explicit celt051 option. Signed-off-by: Marc-André Lureau --- autogen.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/autogen.sh b/autogen.sh index 363720f..92067e5 100755 --- a/autogen.sh +++ b/autogen.sh @@ -12,7

Re: [Spice-devel] [PATCH spice-vdagent] dummy-session-info: remove session_is_locked()

2018-07-23 Thread Frediano Ziglio
> > 364b6bba068bd694d7c4355b6275f88482d9f3f8 introduced > session_info_session_is_locked() in session-info.h, however > dummy-session-info.c implemented session_is_locked() instead, > causing builds with --with-session-info=none to fail. > > This was fixed by d66fbb9d12ae2e5dbaf13d23b9abb4b6bf187

[Spice-devel] [PATCH spice-vdagent] dummy-session-info: remove session_is_locked()

2018-07-23 Thread Jakub Janků
364b6bba068bd694d7c4355b6275f88482d9f3f8 introduced session_info_session_is_locked() in session-info.h, however dummy-session-info.c implemented session_is_locked() instead, causing builds with --with-session-info=none to fail. This was fixed by d66fbb9d12ae2e5dbaf13d23b9abb4b6bf187d7f, but it did