On 20/07/18 18:23, Eduardo Lima (Etrunko) wrote:
> Signed-off-by: Eduardo Lima (Etrunko)
> ---
> Makefile.am | 2 +
> build-aux/meson/check_spice-common.sh | 2 +
> docs/Makefile.am | 1 +
> docs/manual/Makefile.am | 1 +
> docs
On 20/07/18 18:23, Eduardo Lima (Etrunko) wrote:
> The reason for this commit is that Meson expects all submodules to be
> placed in this subdirectory, and since autotools build is more flexible
> in this case, we make some small adjustments to configure.ac and
> Makefile.am files to accommodate fo
Many things have changed since the last version of this series. More
importantly, we already have the meson build merged in spice-common and
decided to not reuse the checks that are done in the subproject here,
but replicate those blocks here as meson does not support any other way
of reusing the s
Signed-off-by: Eduardo Lima (Etrunko)
---
.gitlab-ci.yml | 31 ++-
1 file changed, 30 insertions(+), 1 deletion(-)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 50fb7a15..44dc26d3 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -4,7 +4,7 @@ before_script:
The reason for this commit is that Meson expects all submodules to be
placed in this subdirectory, and since autotools build is more flexible
in this case, we make some small adjustments to configure.ac and
Makefile.am files to accommodate for this change.
Signed-off-by: Eduardo Lima (Etrunko)
--
Signed-off-by: Eduardo Lima (Etrunko)
---
Makefile.am | 2 +
build-aux/meson/check_spice-common.sh | 2 +
docs/Makefile.am | 1 +
docs/manual/Makefile.am | 1 +
docs/manual/meson.build | 18
docs/meson.build
From: Victor Toso
Fedora 28: 3.22.30
Fedora 27: 3.22.26
Fedora 26: 3.22.21
RHEL 7.6: 3.22.30
RHEL 7.5: 3.22.26
RHEL 7.4: 3.22.10
Debian 10: 3.22.30
Debian 9: 3.22.11
Ubuntu 18.04: 3.22.30
Ubuntu 17.10: 3.22.24
Besides cleanup the code, gtk is under heavy development to better
work under Wayland
Hi,
On Fri, Jul 20, 2018 at 06:17:10PM +0100, Frediano Ziglio wrote:
> Remove G_GNUC_BEGIN_IGNORE_DEPRECATIONS/G_GNUC_END_IGNORE_DEPRECATIONS
> for too new APIs that are available on 3.22
Looks fine, applied in top of my series. I don't agree with it
being a fixup but an extra patch as it has a w
Hi,
On Fri, Jul 20, 2018 at 06:17:09PM +0100, Frediano Ziglio wrote:
> Remove check for gdk_event_get_scancode presence, included in 3.22
Agree with fixup, I'll ammend your patch and send a v2 of the
bump patch, many thanks!
Cheers,
> ---
> configure.ac | 12
> src/spice-wi
Hi,
On Fri, Jul 20, 2018 at 01:26:24PM -0400, Frediano Ziglio wrote:
> >
> > From: Victor Toso
> >
> > As those were deprecated in favor of fetching for information directly
> > with GdkMonitor.
> >
> > Warnings fixed:
> > | spice-widget.c: In function ‘mouse_wrap’:
> > | spice-widget.c:1136
From: Victor Toso
As those were deprecated in favor of fetching for information directly
with GdkMonitor.
Warnings fixed:
| spice-widget.c: In function ‘mouse_wrap’:
| spice-widget.c:1136:5: warning: ‘gdk_screen_get_width’ is deprecated
|
| xr = gdk_screen_get_width(screen) / 2;
| ^
On 20/07/18 16:58, Frediano Ziglio wrote:
>>
>> On 13/07/18 16:33, Frediano Ziglio wrote:
>>> Check that data sent to device are collapsed in a single message.
>>> The StreamChannel object is mocked in the test.
>>> This checks that commit dcc3f995d9f5575e319adcfe530c477a7c294ff3
>>> ("stream-devic
>
> On 13/07/18 16:33, Frediano Ziglio wrote:
> > Check that data sent to device are collapsed in a single message.
> > The StreamChannel object is mocked in the test.
> > This checks that commit dcc3f995d9f5575e319adcfe530c477a7c294ff3
> > ("stream-device: handle_data: send whole message") is doi
On 13/07/18 16:33, Frediano Ziglio wrote:
> Check that data sent to device are collapsed in a single message.
> The StreamChannel object is mocked in the test.
> This checks that commit dcc3f995d9f5575e319adcfe530c477a7c294ff3
> ("stream-device: handle_data: send whole message") is doing the
> righ
When building either spice-server or spice-gtk, spice-common should
inherit the command line options from the parent project. This is done
by adding the 'yield' keyword for the opus and celt051 options.
It is also required to add a smartcard option so that we can bypass the
checks if the user want
>
> From: Victor Toso
>
> As those were deprecated in favor of fetching for information directly
> with GdkMonitor.
>
> Warnings fixed:
> | spice-widget.c: In function ‘mouse_wrap’:
> | spice-widget.c:1136:5: warning: ‘gdk_screen_get_width’ is deprecated
> |
> | xr = gdk_screen_get_widt
Remove G_GNUC_BEGIN_IGNORE_DEPRECATIONS/G_GNUC_END_IGNORE_DEPRECATIONS
for too new APIs that are available on 3.22
---
src/channel-webdav.c | 6 --
src/giopipe.c | 2 --
src/spice-widget-egl.c | 3 ---
src/spice-widget.c | 17 -
4 files changed, 28 deletions(-
Add needed G_GNUC_BEGIN_IGNORE_DEPRECATIONS/G_GNUC_END_IGNORE_DEPRECATIONS
for gtk_widget_set_double_buffered, looking at documentation
maybe gtk_widget_set_double_buffered calls should be removed
---
src/spice-widget.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/spice-widget.c
Add needed G_GNUC_BEGIN_IGNORE_DEPRECATIONS/G_GNUC_END_IGNORE_DEPRECATIONS
for 3.22
---
src/spice-gtk-session.c | 3 +++
src/spice-widget.c | 4
2 files changed, 7 insertions(+)
diff --git a/src/spice-gtk-session.c b/src/spice-gtk-session.c
index 3d8973e1..6bca923b 100644
--- a/src/spi
Remove check for gdk_event_get_scancode presence, included in 3.22
---
configure.ac | 12
src/spice-widget.c | 10 +-
2 files changed, 1 insertion(+), 21 deletions(-)
diff --git a/configure.ac b/configure.ac
index 2d90b7bc..6ddfa4b8 100644
--- a/configure.ac
+++ b/confi
From: Victor Toso
Fedora 28: 3.22.30
Fedora 27: 3.22.26
Fedora 26: 3.22.21
RHEL 7.6: 3.22.30
RHEL 7.5: 3.22.26
RHEL 7.4: 3.22.10
Debian 10: 3.22.30
Debian 9: 3.22.11
Ubuntu 18.04: 3.22.30
Ubuntu 17.10: 3.22.24
Besides cleanup the code, gtk is under heavy development to better
work under Wayland
From: Victor Toso
To quote documentation:
| gtk_widget_set_double_buffered has been deprecated since version
| 3.14 and should not be used in newly-written code.
| This function does not work under non-X11 backends or with
| non-native windows. It should not be used in newly written code.
So
From: Victor Toso
As gdk_keymap_get_default() was deprecated in 3.22
Warnings fixed:
| vncdisplaykeymap.c: In function ‘vnc_display_keyval_set_entries’:
| vncdisplaykeymap.c:263:4: warning: ‘gdk_keymap_get_default’ is
| deprecated: Use 'gdk_keymap_get_for_display' instead
|
| gdk_keymap
From: Victor Toso
As those were deprecated in favor of fetching for information directly
with GdkMonitor.
Warnings fixed:
| spice-widget.c: In function ‘mouse_wrap’:
| spice-widget.c:1136:5: warning: ‘gdk_screen_get_width’ is deprecated
|
| xr = gdk_screen_get_width(screen) / 2;
| ^
From: Victor Toso
The only deprecation warning that I see is on usb-device-widget.c
around GtkAligment that had all API's deprecated in 3.14. I'll fix that
at a later time.
Included Ubuntu LTS version in the first patch and included my comment
in the commit too, see thread [0]
[0] https://lists
Hi,
On Fri, Jul 20, 2018 at 09:20:59AM -0400, Frediano Ziglio wrote:
> >
> > From: Victor Toso
> >
> > Fedora 28: 3.22.30
> > Fedora 27: 3.22.26
> > Fedora 26: 3.22.21
> > RHEL 7.6: 3.22.30
> > RHEL 7.5: 3.22.26
> > RHEL 7.4: 3.22.10
> > Debian 10: 3.22.30
> > Debian 9: 3.22.11
> >
> > Signed
>
> From: Victor Toso
>
> Fedora 28: 3.22.30
> Fedora 27: 3.22.26
> Fedora 26: 3.22.21
> RHEL 7.6: 3.22.30
> RHEL 7.5: 3.22.26
> RHEL 7.4: 3.22.10
> Debian 10: 3.22.30
> Debian 9: 3.22.11
>
> Signed-off-by: Victor Toso
Last Ubuntu LTS (18.04) is happy too (3.22.30)
Any other reason you want
From: Victor Toso
Fedora 28: 3.22.30
Fedora 27: 3.22.26
Fedora 26: 3.22.21
RHEL 7.6: 3.22.30
RHEL 7.5: 3.22.26
RHEL 7.4: 3.22.10
Debian 10: 3.22.30
Debian 9: 3.22.11
Signed-off-by: Victor Toso
---
configure.ac| 4 +--
src/spice-gtk-session.c | 38 -
src/sp
On Fri, Jul 20, 2018 at 06:03:03AM -0400, Frediano Ziglio wrote:
> >
> > Rather than using
> > #ifdef COMPRESS_DEBUG
> >spice_info(...);
> > #endif
> >
> > we can #define COMPRESS_DEBUG to spice_debug() or to do nothing for a
> > slight readability improvement. This opportunity is used to r
>
> There was a small regression introduced in get_compression_for_bitmap()
> by f401eb07f dcc: Rewrite dcc_image_compress.
> If SPICE_IMAGE_COMPRESSION_AUTO_GLZ is specified, and the bitmap has a
> stride which is bigger than its width (ie it has padding), then
> get_compression_for_bitmap() will
>
> Rather than using
> #ifdef COMPRESS_DEBUG
>spice_info(...);
> #endif
>
> we can #define COMPRESS_DEBUG to spice_debug() or to do nothing for a
> slight readability improvement. This opportunity is used to replace
> these spice_info() calls with g_debug(). The "do nothing" macro is a bit
Rather than using
#ifdef COMPRESS_DEBUG
spice_info(...);
#endif
we can #define COMPRESS_DEBUG to spice_debug() or to do nothing for a
slight readability improvement. This opportunity is used to replace
these spice_info() calls with g_debug(). The "do nothing" macro is a bit
convoluted to ensu
From: 乐义华
The image in cache was not being freed properly leading the client to
crash with OOM after sometime.
When image flag is SPICE_IMAGE_FLAGS_CACHE_REPLACE_ME, and if found it
in hash table, we will increase the refcount but this image will only
be destroyed, so the cache will usage more a
On Fri, Jul 20, 2018 at 11:46:38AM +0200, Christophe Fergeau wrote:
> Slight screwup on my side, this is a single patch, not a series of 3
> patches as the email subject says.
Ah and actually this is not even the patch I meant to send /o\
Sorry for the noise
Christophe
signature.asc
Description
Slight screwup on my side, this is a single patch, not a series of 3
patches as the email subject says.
Christophe
On Fri, Jul 20, 2018 at 11:44:51AM +0200, Christophe Fergeau wrote:
> There was a small regression introduced in get_compression_for_bitmap()
> by f401eb07f dcc: Rewrite dcc_image_co
There was a small regression introduced in get_compression_for_bitmap()
by f401eb07f dcc: Rewrite dcc_image_compress.
If SPICE_IMAGE_COMPRESSION_AUTO_GLZ is specified, and the bitmap has a
stride which is bigger than its width (ie it has padding), then
get_compression_for_bitmap() will return SPICE
36 matches
Mail list logo
