On Wed, 2018-07-11 at 13:21 -0400, Frediano Ziglio wrote:
> >
> > On Tue, 2018-07-10 at 14:35 +0100, Frediano Ziglio wrote:
> > > Check we have enough data before reading.
> >
> > Check *that* we have...
> >
>
> updated, thanks
>
> > > This could lead to read buffer overflows being undetected.
On 11/07/18 06:39, Frediano Ziglio wrote:
> test-overflow was doing a specific test on demarshalling code.
> Joining the 2 tests also allows to remove the dependency from the main
> protocol allowing to run the test independently from generation setting.
> Using Meson when building either SPICE ser
>
> On Tue, 2018-07-10 at 14:35 +0100, Frediano Ziglio wrote:
> > Check we have enough data before reading.
>
> Check *that* we have...
>
updated, thanks
> > This could lead to read buffer overflows being undetected.
> > This is not a security issue, read happens only in the client not
> > cau
Acked-by: Jonathon Jongsma
On Tue, 2018-07-10 at 14:35 +0100, Frediano Ziglio wrote:
> The 2 APIs are equivalent.
> Some minor coherence changes:
> - remove line terminator, already added;
> - start message with lower case;
> - LZ4, not Lz4.
>
> Signed-off-by: Frediano Ziglio
> ---
> common/ca
On Tue, 2018-07-10 at 14:35 +0100, Frediano Ziglio wrote:
> Check we have enough data before reading.
Check *that* we have...
> This could lead to read buffer overflows being undetected.
> This is not a security issue, read happens only in the client not
> causing
> any information leakage, maxim
Leak detectors did not manage to find leaks, possibly as double list
have all elements likely with a pointer to them.
The reference from the agent is necessary for inserting it into
the list.
Signed-off-by: Frediano Ziglio
---
server/reds.c | 14 ++
1 file changed, 14 insertions(+)
dispose and finalize methods have to call parent relative
cleanup method to avoid leaking resources.
Signed-off-by: Frediano Ziglio
---
server/red-stream-device.c | 4
1 file changed, 4 insertions(+)
diff --git a/server/red-stream-device.c b/server/red-stream-device.c
index 77d0acd06..d293
Signed-off-by: Frediano Ziglio
---
server/tests/test-stream-device.c | 41 ++-
1 file changed, 40 insertions(+), 1 deletion(-)
diff --git a/server/tests/test-stream-device.c
b/server/tests/test-stream-device.c
index ae9a78da5..781b45af9 100644
--- a/server/tests/test
If guest sent an empty data message this was not parsed correctly.
Signed-off-by: Frediano Ziglio
---
server/red-stream-device.c| 2 +-
server/tests/test-stream-device.c | 18 +++---
2 files changed, 16 insertions(+), 4 deletions(-)
diff --git a/server/red-stream-device.c b
On Wed, Jul 11, 2018 at 12:21:07PM +0200, Victor Toso wrote:
> Hi,
>
> On Wed, Jul 11, 2018 at 11:00:26AM +0200, Christophe Fergeau wrote:
> > On Tue, Jul 10, 2018 at 06:00:29PM +0200, Victor Toso wrote:
> > > Hi,
> > >
> > > Similarly to closing github spice mirror [0], I'd like to propose
> > >
Hi,
> > > 2.1) Clone repositories to freedesktop.org
> > > 2.2) Move bugs reported in gitlab.com to freedesktop.org
> > > 2.3) Close reporting new issues, merge-request, etc.
> > > 2.4) Keep the project for a few weeks a mirror from
> > >freedesktop.org
>
> After 2.4, or instead o
Hi,
On Wed, Jul 11, 2018 at 11:00:26AM +0200, Christophe Fergeau wrote:
> On Tue, Jul 10, 2018 at 06:00:29PM +0200, Victor Toso wrote:
> > Hi,
> >
> > Similarly to closing github spice mirror [0], I'd like to propose
> > closing the gitlab.com/spice one now that we have a gitlab
> > instance in g
test-overflow was doing a specific test on demarshalling code.
Joining the 2 tests also allows to remove the dependency from the main
protocol allowing to run the test independently from generation setting.
Using Meson when building either SPICE server or spice-gtk, we only
generate the specific ma
On Wed, Jul 11, 2018 at 09:06:08AM +0100, Frediano Ziglio wrote:
> CentOS 7 compiler generate this warning:
>
> glz-encoder-dict.c: In function 'glz_dictionary_pre_encode':
> glz-encoder-dict.c:516:30: error: 'prev_seg_id' may be used uninitialized in
> this function [-Werror=maybe-uninitialized]
Acked-by: Christophe Fergeau
On Wed, Jul 11, 2018 at 09:06:07AM +0100, Frediano Ziglio wrote:
> Make sure we can compile and run base tests using latest Centos.
>
> Signed-off-by: Frediano Ziglio
> ---
> .gitlab-ci.yml | 19 +++
> 1 file changed, 19 insertions(+)
>
> diff --g
Acked-by: Christophe Fergeau
On Tue, Jul 10, 2018 at 01:18:42PM +0100, Frediano Ziglio wrote:
> This avoids compilers detect misaligned access which can lead to
> warnings.
> In QEMU the structure is allocated at the beginning of a 4Kb page,
> in Xspice is allocated with a calloc, so the structu
On Tue, Jul 10, 2018 at 10:41:16AM -0300, Eduardo Lima (Etrunko) wrote:
> On 10/07/18 07:31, Frediano Ziglio wrote:
> >>
> >> On Tue, Jul 10, 2018 at 04:51:35AM -0400, Frediano Ziglio wrote:
>
> On Tue, Jul 10, 2018 at 07:21:50AM +0100, Frediano Ziglio wrote:
> > test-overflow was doi
On Tue, Jul 10, 2018 at 06:00:29PM +0200, Victor Toso wrote:
> Hi,
>
> Similarly to closing github spice mirror [0], I'd like to propose
> closing the gitlab.com/spice one now that we have a gitlab
> instance in gitlab.freedesktop.org
>
> [0] https://lists.freedesktop.org/archives/spice-devel/201
On 05/07/2018 17:04, Mitja Mihelič wrote:
On 05/07/2018 16:56, Mitja Mihelič wrote:
On 19/06/2018 10:09, Victor Toso wrote:
Hi,
On Mon, Jun 18, 2018 at 04:23:32PM +0200, Mitja Mihelič wrote:
Does it work fine with remote-viewer?
Question ^
You could try different image compression too,
>
> Make sure we can compile and run base tests using latest Centos.
>
> Signed-off-by: Frediano Ziglio
Results at
https://gitlab.freedesktop.org/freddy77/spice/-/jobs/8821
> ---
> .gitlab-ci.yml | 19 +++
> 1 file changed, 19 insertions(+)
>
> diff --git a/.gitlab-ci.yml b/
> On Tue, Jul 10, 2018 at 9:55 PM, Jonathon Jongsma < jjong...@redhat.com >
> wrote:
> > On Tue, 2018-07-10 at 18:00 +0200, Victor Toso wrote:
>
> > > Hi,
>
> > >
>
> > > Similarly to closing github spice mirror [0], I'd like to propose
>
> > > closing the gitlab.com/spice one now that we have
Make sure we can compile and run base tests using latest Centos.
Signed-off-by: Frediano Ziglio
---
.gitlab-ci.yml | 19 +++
1 file changed, 19 insertions(+)
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index becdb28b0..50fb7a15d 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
CentOS 7 compiler generate this warning:
glz-encoder-dict.c: In function 'glz_dictionary_pre_encode':
glz-encoder-dict.c:516:30: error: 'prev_seg_id' may be used uninitialized in
this function [-Werror=maybe-uninitialized]
dict->window.segs[prev_seg_id].next = seg_id;
Hi,
On Tue, Jul 10, 2018 at 10:35:55AM -0500, Carlos González wrote:
> Still not working as of today.
> Any news about it by any chance?
Could you please file a bug to freedesktop admins at [0] and
point out that this is happening?
[0] https://gitlab.freedesktop.org/freedesktop/freedesktop
Than
Hi,
On 07/10/2018 03:25 PM, molo wrote:
hi,
?0?2 ?0?2I am sorry to trouble you??
?0?2 ?0?2We encountered the problem of video picture jam in the process of
using the spice protocol, and the audio and video out of sync problem
also appeared in the drag and drop player window. When trying to so
25 matches
Mail list logo
