[Spice-devel] Offload pixel encoding via Virgil

2018-06-14 Thread Benjamin Kingston
Hello, Is it possible to increase guest density by offloading the pixel codec in the guests to a common onboard GPU? In other words, does the Spice Agent, particularly in Windows 10, leverage OpenGL or other Virgil features to reduce CPU load when full screen refreshing is taking place? Thanks,

Re: [Spice-devel] [RFC/POC PATCH 00/16] add output_id to monitors_config

2018-06-14 Thread Marc-André Lureau
Hi On Tue, Jun 5, 2018 at 5:30 PM, Lukáš Hrázký wrote: > Hi everyone, > > following is my attempt at solving the ID issues with monitors_config > and streaming. The concept is as follows: > Before introducing a new solution, could you describe the "issues with monitors_config and streaming"? I a

[Spice-devel] Windows 10 KVM guest very slow in SPICE console

2018-06-14 Thread Carlos González
Hello. I installed a Windows 10 KVM guest through libvirt on an openSUSE host. I use it with SPICE console through host's installed package virt-viewer. The guest uses qcow2 storage format, and has RAM ballooning range of 2 Gb - 3 Gb. I installed all due drivers in the guest through spice-guest-to

Re: [Spice-devel] [RFC/POC PATCH spice-protocol 02/16] Create a version 2 of the VDAgentMonitorsConfig message

2018-06-14 Thread Lukáš Hrázký
On Thu, 2018-06-14 at 08:37 -0500, Jonathon Jongsma wrote: > On Tue, 2018-06-05 at 17:30 +0200, Lukáš Hrázký wrote: > > To keep compatibility with old endpoints (any of client, server, > > vd_agent), we need to copy the message to add the output_id field. > > > > The output_id is the guest-side id

Re: [Spice-devel] [RFC/POC PATCH spice-gtk 07/16] Rework the handling of monitors_config

2018-06-14 Thread Lukáš Hrázký
On Tue, 2018-06-12 at 15:51 -0500, Jonathon Jongsma wrote: > This patch is potentially problematic. > > As I understand, this will prevent us from trying to configure the > monitors until we receive the monitor config from the server. > > This can conflict with our 'fullscreen' mode in virt-viewe

Re: [Spice-devel] [spice-gtk] main-channel: Fix deprecation annotation

2018-06-14 Thread Frediano Ziglio
> > Signed-off-by: Christophe Fergeau > --- > src/channel-main.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/channel-main.h b/src/channel-main.h > index 530378db..fd7a3bb3 100644 > --- a/src/channel-main.h > +++ b/src/channel-main.h > @@ -113,7 +113,7 @@ void sp

Re: [Spice-devel] [PATCH spice-streaming-agent 1/9] Separate the code for logging frames/times into a class

2018-06-14 Thread Lukáš Hrázký
On Thu, 2018-06-14 at 16:22 +0200, Christophe de Dinechin wrote: > > On 13 Jun 2018, at 14:06, Lukáš Hrázký wrote: > > > > The FrameLog class provides RAII for the FILE and encapsulates the > > logging functionality. > > > > Signed-off-by: Lukáš Hrázký > > --- > > While I retained all the behav

Re: [Spice-devel] [PATCH spice-streaming-agent 1/9] Separate the code for logging frames/times into a class

2018-06-14 Thread Lukáš Hrázký
On Thu, 2018-06-14 at 10:00 -0400, Frediano Ziglio wrote: > > > > On Thu, 2018-06-14 at 06:44 -0400, Frediano Ziglio wrote: > > > > > > > > On Thu, 2018-06-14 at 04:42 -0400, Frediano Ziglio wrote: > > > > > > > > > > > > The FrameLog class provides RAII for the FILE and encapsulates the > > > >

[Spice-devel] [spice-gtk] main-channel: Fix deprecation annotation

2018-06-14 Thread Christophe Fergeau
Signed-off-by: Christophe Fergeau --- src/channel-main.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/channel-main.h b/src/channel-main.h index 530378db..fd7a3bb3 100644 --- a/src/channel-main.h +++ b/src/channel-main.h @@ -113,7 +113,7 @@ void spice_main_clipboard_requ

Re: [Spice-devel] [PATCH] stream-device: handle_data: send whole message

2018-06-14 Thread Christophe de Dinechin
> On 14 Jun 2018, at 15:03, Uri Lublin wrote: > > On 06/14/2018 12:56 PM, Frediano Ziglio wrote: >>> >>> SPICE expect to have each frame in a single message. >>> So far the stream-device did not do that. >>> That works fine for H264 streams but not for mjpeg. >>> The client handles by itself m

Re: [Spice-devel] [PATCH] stream-device: handle_data: send whole message

2018-06-14 Thread Frediano Ziglio
> > On 06/14/2018 12:56 PM, Frediano Ziglio wrote: > >> > >> SPICE expect to have each frame in a single message. > >> So far the stream-device did not do that. > >> That works fine for H264 streams but not for mjpeg. > >> The client handles by itself mjpeg streams, and not via > >> gstreamer, and

Re: [Spice-devel] [PATCH spice-streaming-agent 1/9] Separate the code for logging frames/times into a class

2018-06-14 Thread Christophe de Dinechin
> On 13 Jun 2018, at 14:06, Lukáš Hrázký wrote: > > The FrameLog class provides RAII for the FILE and encapsulates the > logging functionality. > > Signed-off-by: Lukáš Hrázký > --- > While I retained all the behaviour of the original implementation, I > don't like it as it is. > > 1. The cl

Re: [Spice-devel] [PATCH spice-streaming-agent 1/9] Separate the code for logging frames/times into a class

2018-06-14 Thread Frediano Ziglio
> > On Thu, 2018-06-14 at 06:44 -0400, Frediano Ziglio wrote: > > > > > > On Thu, 2018-06-14 at 04:42 -0400, Frediano Ziglio wrote: > > > > > > > > > > The FrameLog class provides RAII for the FILE and encapsulates the > > > > > logging functionality. > > > > > > > > > > Signed-off-by: Lukáš Hr

Re: [Spice-devel] [RFC/POC PATCH spice-protocol 02/16] Create a version 2 of the VDAgentMonitorsConfig message

2018-06-14 Thread Jonathon Jongsma
On Tue, 2018-06-05 at 17:30 +0200, Lukáš Hrázký wrote: > To keep compatibility with old endpoints (any of client, server, > vd_agent), we need to copy the message to add the output_id field. > > The output_id is the guest-side id of the xrandr output (to be > precise, > it is the index in the list

Re: [Spice-devel] [RFC/POC PATCH spice-gtk 12/16] Use the new output_id as display ID for the mouse motion event

2018-06-14 Thread Lukáš Hrázký
On Wed, 2018-06-13 at 16:47 -0500, Jonathon Jongsma wrote: > On Tue, 2018-06-05 at 17:30 +0200, Lukáš Hrázký wrote: > > If the output_id is set, it is the true xrandr guest ID to use for > > the > > mouse motion event. If it's not present, keep relying on the wacky > > sequence of IDs of channel_id

Re: [Spice-devel] [PATCH] stream-device: handle_data: send whole message

2018-06-14 Thread Uri Lublin
On 06/14/2018 12:56 PM, Frediano Ziglio wrote: SPICE expect to have each frame in a single message. So far the stream-device did not do that. That works fine for H264 streams but not for mjpeg. The client handles by itself mjpeg streams, and not via gstreamer, and is assuming that a message cont

Re: [Spice-devel] [PATCH spice-streaming-agent 1/9] Separate the code for logging frames/times into a class

2018-06-14 Thread Lukáš Hrázký
On Thu, 2018-06-14 at 06:44 -0400, Frediano Ziglio wrote: > > > > On Thu, 2018-06-14 at 04:42 -0400, Frediano Ziglio wrote: > > > > > > > > The FrameLog class provides RAII for the FILE and encapsulates the > > > > logging functionality. > > > > > > > > Signed-off-by: Lukáš Hrázký > > > > > >

Re: [Spice-devel] Support for Win10

2018-06-14 Thread Victor Toso
Hi, On Thu, Jun 14, 2018 at 08:39:42AM -0400, Frediano Ziglio wrote: > > > > Hi Lucas, > > > > On Wed, Jun 13, 2018 at 11:20:31AM -0300, Lucas Sanches Fantacuci wrote: > > > Hi, > > > > > > I'm looking for how to install and execute a QEMU VM with SPICE > > > SERVER while the host's machine O.S

Re: [Spice-devel] Support for Win10

2018-06-14 Thread Frediano Ziglio
> > Hi Lucas, > > On Wed, Jun 13, 2018 at 11:20:31AM -0300, Lucas Sanches Fantacuci wrote: > > Hi, > > > > I'm looking for how to install and execute a QEMU VM with SPICE > > SERVER while the host's machine O.S. is a Windows 10. > > > > Does it work? > > Although I've never tested, the builds p

Re: [Spice-devel] Support for Win10

2018-06-14 Thread Victor Toso
Hi Lucas, On Wed, Jun 13, 2018 at 11:20:31AM -0300, Lucas Sanches Fantacuci wrote: > Hi, > > I'm looking for how to install and execute a QEMU VM with SPICE > SERVER while the host's machine O.S. is a Windows 10. > > Does it work? Although I've never tested, the builds provided by Stefan Weil [0

Re: [Spice-devel] [PATCH spice-streaming-agent 1/9] Separate the code for logging frames/times into a class

2018-06-14 Thread Frediano Ziglio
> > On Thu, 2018-06-14 at 04:42 -0400, Frediano Ziglio wrote: > > > > > > The FrameLog class provides RAII for the FILE and encapsulates the > > > logging functionality. > > > > > > Signed-off-by: Lukáš Hrázký > > > > Why "FrameLog" if, as you said too, is managing two types of logs? > > Beca

Re: [Spice-devel] [PATCH spice-server v3 2/2] stream-channel: Send the full frame in a single message

2018-06-14 Thread Lukáš Hrázký
On Thu, 2018-06-14 at 05:10 -0400, Frediano Ziglio wrote: > > > > On Wed, 2018-06-13 at 07:13 -0400, Frediano Ziglio wrote: > > > > > > > > On Tue, 2018-06-12 at 13:30 +0200, Christophe Fergeau wrote: > > > > > Hey, > > > > > > > > > > On Wed, May 09, 2018 at 01:20:19PM +0200, Lukáš Hrázký wrote

Re: [Spice-devel] [PATCH spice-streaming-agent 8/9] Clean up the global try-catch block

2018-06-14 Thread Lukáš Hrázký
On Thu, 2018-06-14 at 05:31 -0400, Frediano Ziglio wrote: > > > > Unify the error handling to use exceptions, narrowing down the exit > > spots for success/error to one each. > > > > Signed-off-by: Lukáš Hrázký > > --- > > src/spice-streaming-agent.cpp | 17 +++-- > > 1 file changed

Re: [Spice-devel] [PATCH spice-streaming-agent 7/9] Make the try-catch block in main() a catch-all

2018-06-14 Thread Lukáš Hrázký
On Thu, 2018-06-14 at 05:29 -0400, Frediano Ziglio wrote: > > > > Extends the try-catch block to encompass all the business code in > > main(), making it a catch-all for all errors. > > > > Signed-off-by: Lukáš Hrázký > > Idea is good, the patch does not compile. Ah, right... I've done more pa

[Spice-devel] Support for Win10

2018-06-14 Thread Lucas Sanches Fantacuci
Hi, I'm looking for how to install and execute a QEMU VM with SPICE SERVER while the host's machine O.S. is a Windows 10. Does it work? While I was looking at download page, there's just binaries for linux environment. -- Lucas Sanches Fantacuci Pesquisa e Desenvolvimento +55 (44) 3034.01

Re: [Spice-devel] [PATCH spice-streaming-agent 4/9] Improve the invalid option argument (-c) error message

2018-06-14 Thread Lukáš Hrázký
On Thu, 2018-06-14 at 05:41 -0400, Frediano Ziglio wrote: > > > > Signed-off-by: Lukáš Hrázký > > --- > > src/spice-streaming-agent.cpp | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp > > index ca10d3b.

Re: [Spice-devel] [PATCH spice-streaming-agent 2/9] FrameLog: Use std::chrono instead of gettimeofday for time

2018-06-14 Thread Lukáš Hrázký
On Thu, 2018-06-14 at 04:45 -0400, Frediano Ziglio wrote: > > > > Signed-off-by: Lukáš Hrázký > > Patch looks good but would be good to state the reasons. > Portability? > Just style? I just prefer to use std::chrono since it's provided by the standard library. It's not just style, it's about i

Re: [Spice-devel] [PATCH] stream-device: handle_data: send whole message

2018-06-14 Thread Frediano Ziglio
> > SPICE expect to have each frame in a single message. > So far the stream-device did not do that. > That works fine for H264 streams but not for mjpeg. > The client handles by itself mjpeg streams, and not via > gstreamer, and is assuming that a message contains the > whole frame. Since it curr

Re: [Spice-devel] [PATCH spice-streaming-agent 1/9] Separate the code for logging frames/times into a class

2018-06-14 Thread Lukáš Hrázký
On Thu, 2018-06-14 at 04:42 -0400, Frediano Ziglio wrote: > > > > The FrameLog class provides RAII for the FILE and encapsulates the > > logging functionality. > > > > Signed-off-by: Lukáš Hrázký > > Why "FrameLog" if, as you said too, is managing two types of logs? Because I couldn't come up

Re: [Spice-devel] [PATCH spice-streaming-agent 4/9] Improve the invalid option argument (-c) error message

2018-06-14 Thread Frediano Ziglio
> > Signed-off-by: Lukáš Hrázký > --- > src/spice-streaming-agent.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp > index ca10d3b..d5ed034 100644 > --- a/src/spice-streaming-agent.cpp > +++ b/src/spice-st

Re: [Spice-devel] [PATCH spice-streaming-agent 8/9] Clean up the global try-catch block

2018-06-14 Thread Frediano Ziglio
> > Unify the error handling to use exceptions, narrowing down the exit > spots for success/error to one each. > > Signed-off-by: Lukáš Hrázký > --- > src/spice-streaming-agent.cpp | 17 +++-- > 1 file changed, 7 insertions(+), 10 deletions(-) > > diff --git a/src/spice-streaming-a

Re: [Spice-devel] [PATCH spice-streaming-agent 7/9] Make the try-catch block in main() a catch-all

2018-06-14 Thread Frediano Ziglio
> > Extends the try-catch block to encompass all the business code in > main(), making it a catch-all for all errors. > > Signed-off-by: Lukáš Hrázký Idea is good, the patch does not compile. > --- > src/spice-streaming-agent.cpp | 46 +-- > 1 file changed, 23

Re: [Spice-devel] [PATCH spice-streaming-agent 6/9] Remove the logmask variable

2018-06-14 Thread Frediano Ziglio
> > The variable is unnecessary, we can pass the value straight to > setlogmask(). > > Signed-off-by: Lukáš Hrázký Acked-by: Frediano Ziglio > --- > src/spice-streaming-agent.cpp | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/src/spice-streaming-agent.cpp b/s

Re: [Spice-devel] [PATCH spice-server v3 2/2] stream-channel: Send the full frame in a single message

2018-06-14 Thread Frediano Ziglio
> > On Wed, 2018-06-13 at 07:13 -0400, Frediano Ziglio wrote: > > > > > > On Tue, 2018-06-12 at 13:30 +0200, Christophe Fergeau wrote: > > > > Hey, > > > > > > > > On Wed, May 09, 2018 at 01:20:19PM +0200, Lukáš Hrázký wrote: > > > > > On Wed, 2018-05-09 at 05:18 -0400, Frediano Ziglio wrote: >

Re: [Spice-devel] Spice console pixelated noise on display changes

2018-06-14 Thread Frediano Ziglio
> > Hi, > > On Wed, Jun 13, 2018 at 10:11:00AM +0200, Mitja Mihelič wrote: > > Dear all, > > > > We are running the following setup: > > ovirt-engine host: > > - CentOS release 7.5.1804 > > - ovirt-engine-4.1.9.1-1.el7.centos.noarch > > - spice-html5-0.1.7-1.el7.noarch > > > > We have noticed pro

Re: [Spice-devel] [PATCH spice-streaming-agent 3/9] Remove the arg_error macro

2018-06-14 Thread Frediano Ziglio
> > It doesn't help anything. > > Signed-off-by: Lukáš Hrázký Acked-by: Frediano Ziglio > --- > src/spice-streaming-agent.cpp | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp > index aef49c7..ca10d3b 10

Re: [Spice-devel] [PATCH spice-streaming-agent 2/9] FrameLog: Use std::chrono instead of gettimeofday for time

2018-06-14 Thread Frediano Ziglio
> > Signed-off-by: Lukáš Hrázký Patch looks good but would be good to state the reasons. Portability? Just style? Has the new implementation the same precision and efficiency? > --- > src/frame-log.cpp | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/src/frame

Re: [Spice-devel] [PATCH spice-streaming-agent 1/9] Separate the code for logging frames/times into a class

2018-06-14 Thread Frediano Ziglio
> > The FrameLog class provides RAII for the FILE and encapsulates the > logging functionality. > > Signed-off-by: Lukáš Hrázký Why "FrameLog" if, as you said too, is managing two types of logs? > --- > While I retained all the behaviour of the original implementation, I > don't like it as it