Re: [Spice-devel] [spice-streaming-agent PATCH] spec: only build rpms for x86_64 arch

2018-06-01 Thread Uri Lublin
On 06/01/2018 08:27 PM, Daniel P. Berrangé wrote: On Fri, Jun 01, 2018 at 08:19:26PM +0300, Uri Lublin wrote: We never test on other architectures. Signed-off-by: Uri Lublin --- spice-streaming-agent.spec.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/spice-streaming-agent.spec.in

Re: [Spice-devel] [PATCH spice-streaming-agent v5] Install udev rule

2018-06-01 Thread Uri Lublin
On 06/01/2018 01:31 PM, Frediano Ziglio wrote: The udev rule is used to do some action when the device is added to the system. Current rule change the permission of the special file to allow to open it by any user. Some systems use /lib/udev while others use /usr/lib/udev. Allow to specify the fu

Re: [Spice-devel] [spice-streaming-agent PATCH] spec: only build rpms for x86_64 arch

2018-06-01 Thread Daniel P . Berrangé
On Fri, Jun 01, 2018 at 08:19:26PM +0300, Uri Lublin wrote: > We never test on other architectures. > > Signed-off-by: Uri Lublin > --- > spice-streaming-agent.spec.in | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/spice-streaming-agent.spec.in b/spice-streaming-agent.spec.in > inde

[Spice-devel] [spice-streaming-agent PATCH] spec: only build rpms for x86_64 arch

2018-06-01 Thread Uri Lublin
We never test on other architectures. Signed-off-by: Uri Lublin --- spice-streaming-agent.spec.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/spice-streaming-agent.spec.in b/spice-streaming-agent.spec.in index 132a851..e94a8f2 100644 --- a/spice-streaming-agent.spec.in +++ b/spice-stre

Re: [Spice-devel] [PATCH spice-common] build: Move sources to libspice_common_client_la_SOURCES

2018-06-01 Thread Christophe Fergeau
On Fri, Jun 01, 2018 at 09:43:14AM -0400, Frediano Ziglio wrote: > > > > From: Christophe Fergeau > > > > These sources are only used by the client, so they do not belong in > > libspice_common_la_SOURCES. > > > > Signed-off-by: Eduardo Lima (Etrunko) > > Sensible, clean and works, I agree, >

Re: [Spice-devel] [PATCH spice-streaming-agent 1/3] build: Avoid a warning running autoreconf

2018-06-01 Thread Jonathon Jongsma
ACK series On Fri, 2018-06-01 at 12:59 +0100, Frediano Ziglio wrote: > During autoreconf this suggestion is emitted: > > libtoolize: Consider adding '-I m4' to ACLOCAL_AMFLAGS in > Makefile.am. > > Signed-off-by: Frediano Ziglio > --- > Makefile.am | 1 + > 1 file changed, 1 insertion(+) > >

Re: [Spice-devel] [PATCH spice-common] build: Move sources to libspice_common_client_la_SOURCES

2018-06-01 Thread Jonathon Jongsma
Maybe the subject could be: "Move *client* sources to" not a big deal. Jonathon On Thu, 2018-05-31 at 18:22 -0300, Eduardo Lima (Etrunko) wrote: > From: Christophe Fergeau > > These sources are only used by the client, so they do not belong in > libspice_common_la_SOURCES. > > Signed-of

Re: [Spice-devel] [PATCH spice-common v3] Add support for building with meson/ninja

2018-06-01 Thread Jonathon Jongsma
On Fri, 2018-06-01 at 09:38 -0400, Frediano Ziglio wrote: > > > > In a comparison with current autotools build system, meson/ninja > > provides a huge improvement in build speed, while keeping the same > > functionalities currently available and being considered more user > > friendly. > > > > Th

Re: [Spice-devel] [PATCH spice-common] build: Move sources to libspice_common_client_la_SOURCES

2018-06-01 Thread Frediano Ziglio
> > From: Christophe Fergeau > > These sources are only used by the client, so they do not belong in > libspice_common_la_SOURCES. > > Signed-off-by: Eduardo Lima (Etrunko) Sensible, clean and works, I agree, Acked. Question is: Who is the author? Frediano > --- > common/Makefile.am | 8

Re: [Spice-devel] [PATCH spice-common v3] Add support for building with meson/ninja

2018-06-01 Thread Frediano Ziglio
> > In a comparison with current autotools build system, meson/ninja > provides a huge improvement in build speed, while keeping the same > functionalities currently available and being considered more user > friendly. > > The new system coexists within the same repository with the current one, >

[Spice-devel] [PATCH spice-streaming-agent 2/3] ci: Install required autoconf-archive package

2018-06-01 Thread Frediano Ziglio
Due to recent check build is failing with: configure.ac:21: error: Missing AX_CXX_COMPILE_STDCXX_11, install autoconf-archive Signed-off-by: Frediano Ziglio --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index f1cda3b..015

[Spice-devel] [PATCH spice-streaming-agent 1/3] build: Avoid a warning running autoreconf

2018-06-01 Thread Frediano Ziglio
During autoreconf this suggestion is emitted: libtoolize: Consider adding '-I m4' to ACLOCAL_AMFLAGS in Makefile.am. Signed-off-by: Frediano Ziglio --- Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile.am b/Makefile.am index 32fdaff..99c1308 100644 --- a/Makefile.am +++ b

[Spice-devel] [PATCH spice-streaming-agent 3/3] ci: Make sure "make distcheck" works

2018-06-01 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- .gitlab-ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 0158cda..6121c8d 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -11,3 +11,4 @@ build_and_test: - ./configure - make - make check +- m

Re: [Spice-devel] [spice-protocol 1/1] NEWS: prepare for 0.12.14 release

2018-06-01 Thread Victor Toso
Hi, Release was done earlier today. Package can be found in spice-space webpage [0] or in gitlab [1]. It was signed with my key, 97D9123DE37A484F. [0] https://www.spice-space.org/download/releases/spice-protocol/ [1] https://gitlab.freedesktop.org/spice/spice-protocol/tags/v0.12.14 toso

[Spice-devel] [PATCH spice-streaming-agent v5] Install udev rule

2018-06-01 Thread Frediano Ziglio
The udev rule is used to do some action when the device is added to the system. Current rule change the permission of the special file to allow to open it by any user. Some systems use /lib/udev while others use /usr/lib/udev. Allow to specify the full path to support both type of systems. Signed-

Re: [Spice-devel] [PATCH spice-gtk] gtk-doc: fix a few warnings

2018-06-01 Thread Frediano Ziglio
> > From: Marc-André Lureau > > Fixes: > ../../src/channel-display.h:131: warning: Field description for > SpiceDisplayChannelClass::streaming_mode is not used from source code > comment block. > ./spice-gtk-unused.txt:1: warning: 1 unused declarations. They should be > added to spice-gtk-sectio

Re: [Spice-devel] [PATCH spice-streaming-agent v3 1/5] Install udev rule

2018-06-01 Thread Lukáš Hrázký
On Fri, 2018-06-01 at 04:56 -0400, Frediano Ziglio wrote: > > > > On 06/01/2018 12:12 AM, Frediano Ziglio wrote: > > > > > > > > On 05/23/2018 12:03 PM, Frediano Ziglio wrote: > > > > > The udev rule is used to do some action when the device is added to > > > > > the > > > > > system. Current ru

[Spice-devel] [PATCH spice-gtk] gtk-doc: fix a few warnings

2018-06-01 Thread marcandre . lureau
From: Marc-André Lureau Fixes: ../../src/channel-display.h:131: warning: Field description for SpiceDisplayChannelClass::streaming_mode is not used from source code comment block. ./spice-gtk-unused.txt:1: warning: 1 unused declarations. They should be added to spice-gtk-sections.txt in the ap

Re: [Spice-devel] [PATCH spice-streaming-agent v3 1/5] Install udev rule

2018-06-01 Thread Frediano Ziglio
> > On 06/01/2018 12:12 AM, Frediano Ziglio wrote: > >> > >> On 05/23/2018 12:03 PM, Frediano Ziglio wrote: > >>> The udev rule is used to do some action when the device is added to the > >>> system. Current rule change the permission of the special file to allow > >>> to > >>> open it by any user

[Spice-devel] [PATCH spice-streaming-agent v4] Install udev rule

2018-06-01 Thread Frediano Ziglio
The udev rule is used to do some action when the device is added to the system. Current rule change the permission of the special file to allow to open it by any user. Some systems use /lib/udev while others use /usr/lib/udev. Allow to specify the full path to support both type of systems. Signed-