Re: [Spice-devel] [spice-gtk] widget: avoid gdk_seat_grab/ungrab() API temporarily

2018-05-22 Thread Pavel Grunt
The intention of those commits was to be ready for new things (wayland, gtk4... wait, actually gtk3). That side effect was not desired... I'm not sure whether is better to revert it completely and go back to gtk2 api. Ack, Pavel If there is a bug/regression in gtk+, it'd be good to have reference

Re: [Spice-devel] [PATCH spice-streaming-agent v2] Detect and handle exception creating capture engine

2018-05-22 Thread Jonathon Jongsma
On Mon, 2018-05-21 at 11:41 +0100, Frediano Ziglio wrote: > Currently exception from a plugin are not handled when creating exception -> exceptions > a capture engine. > Capture the exception and try to use another plugin instead of Capture -> Catch > bailing out. > This was tested with an expe

Re: [Spice-devel] [PATCH spice-streaming-agent v2 3/5] Starts/stops the agent based on VT status

2018-05-22 Thread Christophe Fergeau
On Tue, May 22, 2018 at 07:46:48AM -0400, Frediano Ziglio wrote: > > > > On Mon, May 21, 2018 at 11:45:29AM +0100, Frediano Ziglio wrote: > > > Check if the current display server is active or not and stream only if > > > active. > > > This will allow to support multiple display servers running. >

Re: [Spice-devel] [PATCH spice-streaming-agent v2 1/5] Install udev rule

2018-05-22 Thread Christophe Fergeau
On Tue, May 22, 2018 at 07:11:15AM -0400, Frediano Ziglio wrote: > > > > On Mon, May 21, 2018 at 11:45:27AM +0100, Frediano Ziglio wrote: > > > The udev rule is used to do some action when the device is added to the > > > system. Current rule change the permission of the special file to allow to >

Re: [Spice-devel] [PATCH spice-streaming-agent v2 3/5] Starts/stops the agent based on VT status

2018-05-22 Thread Frediano Ziglio
> > On Mon, May 21, 2018 at 11:45:29AM +0100, Frediano Ziglio wrote: > > Check if the current display server is active or not and stream only if > > active. > > This will allow to support multiple display servers running. > > When multiple display servers are running only one have the GPU > > asso

Re: [Spice-devel] [PATCH spice-streaming-agent v2 1/5] Install udev rule

2018-05-22 Thread Frediano Ziglio
> > On Mon, May 21, 2018 at 11:45:27AM +0100, Frediano Ziglio wrote: > > The udev rule is used to do some action when the device is added to the > > system. Current rule change the permission of the special file to allow to > > open it by any user. > > I thought this was a temporary 'hack' until

Re: [Spice-devel] [PATCH spice-streaming-agent v2 3/5] Starts/stops the agent based on VT status

2018-05-22 Thread Christophe Fergeau
On Mon, May 21, 2018 at 11:45:29AM +0100, Frediano Ziglio wrote: > Check if the current display server is active or not and stream only if > active. > This will allow to support multiple display servers running. > When multiple display servers are running only one have the GPU > associated and is w

Re: [Spice-devel] [PATCH spice-streaming-agent v2 1/5] Install udev rule

2018-05-22 Thread Christophe Fergeau
On Mon, May 21, 2018 at 11:45:27AM +0100, Frediano Ziglio wrote: > The udev rule is used to do some action when the device is added to the > system. Current rule change the permission of the special file to allow to > open it by any user. I thought this was a temporary 'hack' until we have a bette

Re: [Spice-devel] [spice-gtk] widget: update comment on fixed gtk+ bug

2018-05-22 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Mon, May 21, 2018 at 02:20:14PM +0200, Victor Toso wrote: > From: Victor Toso > > The bug was fixed in GTK+ 3.22. I'm updating the comment plus setting > the !GTK_CHECK_VERSION() to track changes that can be removed after > bumping the gtk+ library. > > Signed-

Re: [Spice-devel] [PATCH spice-gtk 1/3] RFC channel-display-gst: Prevent accumulating output queue

2018-05-22 Thread Frediano Ziglio
> > Hi, > > > On 05/18/2018 02:50 PM, Frediano Ziglio wrote: > >> Hi, > >> > >> > >> On 04/19/2018 03:28 PM, Frediano Ziglio wrote: > >>> display_queue is queued with decoded frames ready to be displayed. > >>> However current code can insert a timeout before displaying and > >>> removing the qu

Re: [Spice-devel] [PATCH spice-gtk 1/3] RFC channel-display-gst: Prevent accumulating output queue

2018-05-22 Thread Snir Sheriber
Hi, On 05/18/2018 02:50 PM, Frediano Ziglio wrote: Hi, On 04/19/2018 03:28 PM, Frediano Ziglio wrote: display_queue is queued with decoded frames ready to be displayed. However current code can insert a timeout before displaying and removing the queued frames. As the frames are not compresse