Re: [Spice-devel] Flatpaking virt-viewer/remote-viewer

2018-05-15 Thread Adrian Lucrèce Céleste
I've hit a bit of a snag with virt-viewer. I've got it compiled, running, but whenever I try to connect to a remote instance, I always get this: [alc@xps org.virt_manager.virt-viewer]$ flatpak run org.virt_manager.virt-viewer --debug -c qemu+ssh://upsquared@192.168.10.192/system (virt-viewe

Re: [Spice-devel] [PATCH spice-streaming-agent 7/9] Change the mode to NONBLOCK for the virtio port

2018-05-15 Thread Frediano Ziglio
> > In blocking mode, the IO operations block indefinitely if the server > closes the virtio port on it's side. Change to non-blocking mode, so > that we can quit the streaming agent in case the port gets closed. > > Signed-off-by: Lukáš Hrázký > --- > src/error.cpp | 6 ++

Re: [Spice-devel] [PATCH spice-streaming-agent 6/9] Add a unit test for the stream port

2018-05-15 Thread Frediano Ziglio
A bit more comments. > > Signed-off-by: Lukáš Hrázký > --- > src/unittests/.gitignore | 1 + > src/unittests/Makefile.am | 9 - > src/unittests/test-stream-port.cpp | 69 > ++ > 3 files changed, 78 insertions(+), 1 deletion(-) > cre

Re: [Spice-devel] [PATCH spice-streaming-agent 5/9] Unify the structure of write_all() and read_all()

2018-05-15 Thread Frediano Ziglio
A bit more comment would be good. For instance why not unifying the other way around? > > Signed-off-by: Lukáš Hrázký > --- > src/stream-port.cpp | 20 +++- > src/stream-port.hpp | 4 ++-- > 2 files changed, 13 insertions(+), 11 deletions(-) > > diff --git a/src/stream-port.cp

Re: [Spice-devel] [PATCH spice-streaming-agent 4/9] Introduce a WriteError exception for write_all()

2018-05-15 Thread Frediano Ziglio
> > Update the interface to not return the size written, as it is not needed > anymore. > > Signed-off-by: Lukáš Hrázký > --- > src/error.cpp | 3 ++- > src/error.hpp | 14 + > src/spice-streaming-agent.cpp | 48 > +++

Re: [Spice-devel] [PATCH spice-streaming-agent 3/9] Implement an exception hierarchy for ReadError

2018-05-15 Thread Frediano Ziglio
> > Introduces an exception hierarchy up to a ReadError class, which is > thrown from read_all(). > > Signed-off-by: Lukáš Hrázký > --- > src/Makefile.am | 2 ++ > src/error.cpp | 29 > src/error.hpp | 44 > +++

Re: [Spice-devel] [PATCH spice-streaming-agent 2/9] Move out {read, write}_all() to a separate module

2018-05-15 Thread Frediano Ziglio
> > This starts at the bottom and prepares for gradually moving more stuff > out of the main file. > > Signed-off-by: Lukáš Hrázký > --- > src/Makefile.am | 2 ++ > src/spice-streaming-agent.cpp | 48 - > src/stream-port.cpp | 55 > +

[Spice-devel] Fix streams reference error

2018-05-15 Thread Joel Purra
Hello, See - https://bugs.freedesktop.org/show_bug.cgi?id=94776#c3 - https://github.com/SPICE/spice-html5/pull/9 Thanks! -joelpurra.com ___ Spice-devel mailing list Spice-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/spi

Re: [Spice-devel] [RFC spice-gtk v3 1/1] Gstreamer: Use GstVideoOverlay if possible

2018-05-15 Thread Christophe Fergeau
On Wed, Apr 25, 2018 at 03:43:14PM +0300, Snir Sheriber wrote: > Currently when gstreamer is used to decode a full-screen > stream sent from the server, the decoding frames are being > forced to RBGA format and pushed using appsink to be scaled > and rendered to screen. > > Today most of the gstre

Re: [Spice-devel] [PATCH spice-common 1/3] Add support for building with meson/ninja

2018-05-15 Thread Christophe Fergeau
On Thu, May 10, 2018 at 10:26:59AM -0300, Eduardo Lima (Etrunko) wrote: > >> +option('protocol-version', > >> +type : 'string', > >> +value : '0.12.12', > >> +description : 'SPICE protocol version required (default=0.12.12)') > >> + > > > > Why now there's an option for this ? > > >

Re: [Spice-devel] [PATCH] usbredirhost: host should not be marked as claimed on failure

2018-05-15 Thread Christophe Fergeau
Hey, Sorry for the delay in looking at your patch, On Sat, May 12, 2018 at 12:00:26PM +0800, Qiu Wenbo wrote: > This is a patch trying to fix a bug caused by usbredir. The problem is when > usbredir failed to claim all interface of a USB device it won't set > host->claimed to 0. The patch makes

Re: [Spice-devel] [PATCH spice-server 1/3] event-loop: Avoid possible compiler warning

2018-05-15 Thread Christophe Fergeau
I'm late to the party, but I suspect I would have gone the same way as in spice-gtk https://lists.freedesktop.org/archives/spice-devel/2018-May/043324.html and disabled the warning instead. Christophe On Sun, May 06, 2018 at 12:10:31PM +0100, Frediano Ziglio wrote: > With GCC 8.0.1 (Fedora 28), c

Re: [Spice-devel] [PATCH] Revert "usbredir: Disconnect USB device asynchronously"

2018-05-15 Thread Christophe Fergeau
If I remember correctly, this asynchronous disconnection was needed because in some case, during normal usage, the disconnection was blocking for seconds (on Windows with usbdk), and if it's not async, it would block the main loop, and thus the whole GUI (all of this should have been in the commit

Re: [Spice-devel] [spice-gtk] build-sys: Update gettext 0.18.2 -> 0.19.8

2018-05-15 Thread Victor Toso
Hi, On Tue, May 15, 2018 at 11:53:20AM +0200, Christophe Fergeau wrote: > > I got interested in adding the git history to commit log that I > > forgot to add why the change. Sorry about that. > > > > Reason is nothing new that I personally want from gettext but a > > build issue while using jhbuil

Re: [Spice-devel] [spice-jhbuild 0/2] moduleset updates

2018-05-15 Thread Christophe Fergeau
Sure, Acked-by: Christophe Fergeau On Mon, May 14, 2018 at 01:32:52PM +0200, Victor Toso wrote: > From: Victor Toso > > Hi, > > * moduleset: Use latest gnome-apps modules > > 3.18 which is currently used is a it old. Not sure if it makes > to not use the latest gnome-apps in a development mod

Re: [Spice-devel] [spice-gtk] build-sys: Update gettext 0.18.2 -> 0.19.8

2018-05-15 Thread Christophe Fergeau
On Tue, May 15, 2018 at 08:34:36AM +0200, Victor Toso wrote: > Hey, > > On Tue, May 15, 2018 at 12:49:53AM -0400, Frediano Ziglio wrote: > > > > > > From: Victor Toso > > > > > > It was bumped to 0.19.0 by: > > > > > > commit 6195151f943480eecf38029ffad8a86844406659 > > > Author: Marc-

Re: [Spice-devel] [spice-space-pages] Don't use absolute URLs for local resources

2018-05-15 Thread Snir Sheriber
Hi, On 05/14/2018 11:07 PM, Pavel Grunt wrote: Hi, does it work well with CI? IIRC there's a linter checking for the validity of links. Seems it is currently not being checked (assuming gitlab ci was meant) Pavel Dne po 14. 5. 2018 17:18 uživatel Christophe Fergeau mailto:cferg...@re