Re: [Spice-devel] [RFC spice-gtk v3 1/1] Gstreamer: Use GstVideoOverlay if possible

2018-05-09 Thread Snir Sheriber
Hi, On 05/09/2018 06:39 PM, Frediano Ziglio wrote: Currently when gstreamer is used to decode a full-screen stream sent from the server, the decoding frames are being forced to RBGA format and pushed using appsink to be scaled and rendered to screen. Today most of the gstreamer sinks supports

[Spice-devel] [PATCH] miLineArc(): initialize edge1, edge2

2018-05-09 Thread Jonathon Jongsma
When compiling spice-common with meson/ninja under "release" mode, I get the following compiler warnings: ../subprojects/spice-common/common/lines.c: In function ‘miLineArc’: ../subprojects/spice-common/common/lines.c:2167:17: error: ‘edge2.dx’ may be used uninitialized in this function [

Re: [Spice-devel] [PATCH] Support for building with meson/ninja

2018-05-09 Thread Eduardo Lima (Etrunko)
On 27/04/18 16:25, Eduardo Lima (Etrunko) wrote: > Hi all, > > Following up with my last email[1] about this subject, the work is done > for all of spice repositories. Again, if you want to try those, the > easiest way is to pull from the meson branches of my repositories in > gitlab: > > $ git

Re: [Spice-devel] [PATCH spice-gtk] ci: Install pyparsing correctly

2018-05-09 Thread Victor Toso
Hey, On Wed, May 09, 2018 at 05:12:07PM +0100, Frediano Ziglio wrote: > Now that spice-gtk is in Gitlab CI is run but using Fedora 28 is > failing during configure phase with: > > checking for PROTOCOL... yes > checking python3 module: six... yes > checking python3 module: pyparsing... no >

[Spice-devel] [PATCH spice-gtk] ci: Install pyparsing correctly

2018-05-09 Thread Frediano Ziglio
Now that spice-gtk is in Gitlab CI is run but using Fedora 28 is failing during configure phase with: checking for PROTOCOL... yes checking python3 module: six... yes checking python3 module: pyparsing... no checking python2 module: six... no checking python2 module: pyparsing... yes c

Re: [Spice-devel] [RFC spice-gtk v3 1/1] Gstreamer: Use GstVideoOverlay if possible

2018-05-09 Thread Frediano Ziglio
> Currently when gstreamer is used to decode a full-screen > stream sent from the server, the decoding frames are being > forced to RBGA format and pushed using appsink to be scaled > and rendered to screen. > > Today most of the gstreamer sinks supports the GstVideoOverlay > interface which allo

[Spice-devel] [PATCH spice-common 2/3] lz: Optimise SAME_PIXEL for RGB16

2018-05-09 Thread Frediano Ziglio
Do not extract all components and compare one by one, can be easily compared together. Signed-off-by: Frediano Ziglio --- common/lz_compress_tmpl.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/common/lz_compress_tmpl.c b/common/lz_compress_tmpl.c index 69e69a6..b778e

[Spice-devel] [PATCH spice-common 3/3] lz: Inline GET_{r, g, b} macros

2018-05-09 Thread Frediano Ziglio
With last changes are just used once and are straight forward. Signed-off-by: Frediano Ziglio --- common/lz_compress_tmpl.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/common/lz_compress_tmpl.c b/common/lz_compress_tmpl.c index b778e9d..6334020 100644 --- a/

[Spice-devel] [PATCH spice-common 1/3] lz: Move ENCODE_PIXEL for RGB24 and RGB32 to a common place

2018-05-09 Thread Frediano Ziglio
The macro for both depth is the same, reuse the definition. Signed-off-by: Frediano Ziglio --- common/lz_compress_tmpl.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/common/lz_compress_tmpl.c b/common/lz_compress_tmpl.c index 1bb5c75..69e69a6 100644 --- a/common/lz_compr

Re: [Spice-devel] [PATCH spice-server v3 2/2] stream-channel: Send the full frame in a single message

2018-05-09 Thread Lukáš Hrázký
On Wed, 2018-05-09 at 05:18 -0400, Frediano Ziglio wrote: > > > > On Tue, 2018-05-08 at 10:26 +0100, Frediano Ziglio wrote: > > > The current implementation of server and client assumes that a single > > > data message contains an encoded frame. > > > This is not a problem for most encoding but fo

Re: [Spice-devel] [PATCH spice-common v3] codegen: Add some comments

2018-05-09 Thread Lukáš Hrázký
On Wed, 2018-05-09 at 11:49 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > python_modules/ptypes.py | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py > index 209c00e..0f6d8d6 100644 > --- a/py

[Spice-devel] [PATCH spice-common v3] codegen: Add some comments

2018-05-09 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- python_modules/ptypes.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py index 209c00e..0f6d8d6 100644 --- a/python_modules/ptypes.py +++ b/python_modules/ptypes.py @@ -83,6 +83,8 @@ va

Re: [Spice-devel] [PATCH spice-common v2] codegen: Add some comments

2018-05-09 Thread Lukáš Hrázký
Sorry for being pedantic :) On Wed, 2018-05-09 at 10:05 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > python_modules/ptypes.py | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > Changes since v1: > - grammar and better comments > > diff --git a/python_mod

Re: [Spice-devel] [PATCH spice-server v3 2/2] stream-channel: Send the full frame in a single message

2018-05-09 Thread Frediano Ziglio
> > On Tue, 2018-05-08 at 10:26 +0100, Frediano Ziglio wrote: > > The current implementation of server and client assumes that a single > > data message contains an encoded frame. > > This is not a problem for most encoding but for MJPEG this causes > > the client to fail decoding. > > Collapse fr

Re: [Spice-devel] [PATCH spice-common] codegen: Removed unused get_type methods

2018-05-09 Thread Frediano Ziglio
> > On Sun, 2018-05-06 at 13:29 +0100, Frediano Ziglio wrote: > > Signed-off-by: Frediano Ziglio > > --- > > python_modules/ptypes.py | 9 - > > 1 file changed, 9 deletions(-) > > > > diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py > > index d29c97a..209c00e 100644 > >

[Spice-devel] [PATCH spice-common v2] codegen: Add some comments

2018-05-09 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- python_modules/ptypes.py | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) Changes since v1: - grammar and better comments diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py index 209c00e..cfdd17e 100644 --- a/python_modules/ptypes.py ++

Re: [Spice-devel] [PATCH spice-server v3 2/2] stream-channel: Send the full frame in a single message

2018-05-09 Thread Lukáš Hrázký
On Tue, 2018-05-08 at 10:26 +0100, Frediano Ziglio wrote: > The current implementation of server and client assumes that a single > data message contains an encoded frame. > This is not a problem for most encoding but for MJPEG this causes > the client to fail decoding. > Collapse frame data into a

Re: [Spice-devel] [PATCH spice-common] codegen: Removed unused get_type methods

2018-05-09 Thread Lukáš Hrázký
On Sun, 2018-05-06 at 13:29 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > python_modules/ptypes.py | 9 - > 1 file changed, 9 deletions(-) > > diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py > index d29c97a..209c00e 100644 > --- a/python_modules/

Re: [Spice-devel] [PATCH spice-common] codegen: Add some comments

2018-05-09 Thread Lukáš Hrázký
On Sun, 2018-05-06 at 13:33 +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > python_modules/ptypes.py | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/python_modules/ptypes.py b/python_modules/ptypes.py > index 209c00e..9007a3b 100644 > --- a/p