Re: [Spice-devel] [PATCH spice-gtk] Remove unused spice-channel-enums.h file

2018-05-04 Thread Frediano Ziglio
> > This file has been deprecated a long ago, since the following commit: > > commit d27f761325b356c91bda1ca60186d4613d6933d2 > Author: Marc-André Lureau > Date: Tue Jan 25 14:22:51 2011 +0100 > > gtk: rename s/spice-channel-enums/spice-glib-enums > > Signed-off-by: Eduardo Lima (Etrunko

[Spice-devel] [PATCH spice-gtk] Remove unused spice-channel-enums.h file

2018-05-04 Thread Eduardo Lima (Etrunko)
This file has been deprecated a long ago, since the following commit: commit d27f761325b356c91bda1ca60186d4613d6933d2 Author: Marc-André Lureau Date: Tue Jan 25 14:22:51 2011 +0100 gtk: rename s/spice-channel-enums/spice-glib-enums Signed-off-by: Eduardo Lima (Etrunko) --- src/Makefile.

Re: [Spice-devel] [PATCH spice-gtk 1/3] Add support for building with meson

2018-05-04 Thread Christophe Fergeau
On Fri, May 04, 2018 at 12:17:20PM -0300, Eduardo Lima (Etrunko) wrote: > On 03/05/18 12:24, Christophe Fergeau wrote: > > Hey, > > > > So I've experimented with this today, couple of comments/suggested > > improvements/fixes/missing things/... > > It might be worth to have some short document som

Re: [Spice-devel] [PATCH spice-gtk 1/3] Add support for building with meson

2018-05-04 Thread Eduardo Lima (Etrunko)
On 03/05/18 12:24, Christophe Fergeau wrote: > Hey, > > So I've experimented with this today, couple of comments/suggested > improvements/fixes/missing things/... > It might be worth to have some short document somewhere describing the > meson/ninja equivalent for (at least) > make CFLAGS="-Wno-er

Re: [Spice-devel] [PATCH spice-streaming-agent 1/9] Use read_all() to read headers of received messages

2018-05-04 Thread Frediano Ziglio
> > Signed-off-by: Lukáš Hrázký > --- > src/spice-streaming-agent.cpp | 9 +++-- > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp > index 8b3f833..5dd41a9 100644 > --- a/src/spice-streaming-agent.cpp > +++ b/src

Re: [Spice-devel] [spice-gtk 3/3] win32: Convert locale dir from UTF-8 to local encoding

2018-05-04 Thread Frediano Ziglio
> > As indicated in gtk+ win32 gtk_get_localedir [1], bindtextdomain() is not > UTF-8 aware on win32, so it needs a filename in locale encoding > > [1] https://gitlab.gnome.org/GNOME/gtk/blob/master/gtk/gtkwin32.c#L187 > --- > src/spice-glib-main.c | 6 +- > 1 file changed, 5 insertions(+),

Re: [Spice-devel] [spice-gtk 2/3] usb: Remove unused spice_marshaller_add_by_ref_full() user data

2018-05-04 Thread Frediano Ziglio
> > g_free() only expects a single argument, so it won't make use of the > extra 'channel' arg which will be passed as user data. > --- > src/channel-usbredir.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/channel-usbredir.c b/src/channel-usbredir.c > index f509e4

Re: [Spice-devel] [virt-viewer PATCH] maint: Drop autobuild.sh

2018-05-04 Thread Daniel P . Berrangé
On Thu, May 03, 2018 at 05:48:59PM +0200, Andrea Bolognani wrote: > The Test-AutoBuild project, that this script is supposed > to be used with, hasn't seen any activity in ~7 years; > these days, virt-viewer CI builds are happening on the > Jenkins-based CentOS CI environment under the libvirt > um

[Spice-devel] [virt-viewer PATCH] maint: Drop autobuild.sh

2018-05-04 Thread Andrea Bolognani
The Test-AutoBuild project, that this script is supposed to be used with, hasn't seen any activity in ~7 years; these days, virt-viewer CI builds are happening on the Jenkins-based CentOS CI environment under the libvirt umbrella[1], and in that context the script is not used at all. [1] https://c