Re: [Spice-devel] [PATCH spice-gtk] Remove unused spice-channel-enums.h file

2018-04-26 Thread Eduardo Lima (Etrunko)
On 26/04/18 12:43, Frediano Ziglio wrote: >> >> Signed-off-by: Eduardo Lima (Etrunko) >> --- >> src/Makefile.am | 5 - >> src/spice-channel-enums.h | 7 --- >> 2 files changed, 12 deletions(-) >> delete mode 100644 src/spice-channel-enums.h >> >> diff --git a/src/Makefile.am b/

Re: [Spice-devel] [PATCH spice-gtk] Remove unused spice-channel-enums.h file

2018-04-26 Thread Frediano Ziglio
> > Signed-off-by: Eduardo Lima (Etrunko) > --- > src/Makefile.am | 5 - > src/spice-channel-enums.h | 7 --- > 2 files changed, 12 deletions(-) > delete mode 100644 src/spice-channel-enums.h > > diff --git a/src/Makefile.am b/src/Makefile.am > index d2a749c..c6b76d4 100644 >

[Spice-devel] [PATCH spice-gtk] Remove unused spice-channel-enums.h file

2018-04-26 Thread Eduardo Lima (Etrunko)
Signed-off-by: Eduardo Lima (Etrunko) --- src/Makefile.am | 5 - src/spice-channel-enums.h | 7 --- 2 files changed, 12 deletions(-) delete mode 100644 src/spice-channel-enums.h diff --git a/src/Makefile.am b/src/Makefile.am index d2a749c..c6b76d4 100644 --- a/src/Makefile.am

Re: [Spice-devel] [PATCH spice-gtk] tests: Shut up warnings about unitialized struct fields

2018-04-26 Thread Eduardo Lima (Etrunko)
On 26/04/18 06:20, Christophe Fergeau wrote: > On Tue, Apr 24, 2018 at 04:24:32PM -0300, Eduardo Lima (Etrunko) wrote: >> Build complains about lots of unitialized fields in TestCase definition, > > This has been committed, but I don't think this was happening with git > master and the default bui

Re: [Spice-devel] bad id bug in glz decoder

2018-04-26 Thread Christophe Fergeau
On Thu, Apr 26, 2018 at 01:53:41AM -0400, Frediano Ziglio wrote: > > Hi Ziglio, > > > I was wondering if you have had a chance to look at the email below yet. > > > Best regards, > > Zhongqiang Huang > > Yes, weird, usually git CC people in the commit message, but see > > https://lists.freedes

Re: [Spice-devel] [PATCH spice-streaming-agent 4/4] Add option to disable logging full frames

2018-04-26 Thread Christophe Fergeau
On Thu, Apr 26, 2018 at 07:29:56AM -0400, Frediano Ziglio wrote: > > > > On Mon, Apr 23, 2018 at 04:07:44PM +0100, Frediano Ziglio wrote: > > > In some cases we want to avoid saving huge amount of data on the log. > > > > > > Signed-off-by: Frediano Ziglio > > > --- > > > src/spice-streaming-ag

Re: [Spice-devel] [PATCH spice-streaming-agent 4/4] Add option to disable logging full frames

2018-04-26 Thread Frediano Ziglio
> > On Mon, Apr 23, 2018 at 04:07:44PM +0100, Frediano Ziglio wrote: > > In some cases we want to avoid saving huge amount of data on the log. > > > > Signed-off-by: Frediano Ziglio > > --- > > src/spice-streaming-agent.cpp | 8 +++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > >

Re: [Spice-devel] [PATCH spice-streaming-agent 4/4] Add option to disable logging full frames

2018-04-26 Thread Christophe Fergeau
On Mon, Apr 23, 2018 at 04:07:44PM +0100, Frediano Ziglio wrote: > In some cases we want to avoid saving huge amount of data on the log. > > Signed-off-by: Frediano Ziglio > --- > src/spice-streaming-agent.cpp | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/src/s

Re: [Spice-devel] [PATCH spice-streaming-agent v2] Eliminate signed/unsigned warning

2018-04-26 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Mon, Apr 23, 2018 at 03:25:39PM +0100, Frediano Ziglio wrote: > From: Christophe de Dinechin > > Currently -Wsign-compare is disabled by default in the default settings > (m4/spice-compile-warnings.m4). > However is good and not that expensive to remove this war

Re: [Spice-devel] [PATCH spice-streaming-agent 1/4] Add some information to the log

2018-04-26 Thread Christophe Fergeau
On Mon, Apr 23, 2018 at 04:07:41PM +0100, Frediano Ziglio wrote: > Allows to track different frame timing. > > Signed-off-by: Frediano Ziglio > --- > src/spice-streaming-agent.cpp | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/src/spice-streaming-agent.cpp b/src/spice

Re: [Spice-devel] [PATCH spice-streaming-agent] build: Use same options to compile unit tests

2018-04-26 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Mon, Apr 23, 2018 at 04:11:00PM +0100, Frediano Ziglio wrote: > Unit test where not compiling with same options. > In this case warnings are different producing different results. > > Signed-off-by: Frediano Ziglio > --- > src/unittests/Makefile.am | 4 >

Re: [Spice-devel] Gitlab - 2018!

2018-04-26 Thread Christophe Fergeau
Hey, I don't think I've answered to these various threads, but personally I'm fine with the move. Christophe On Tue, Apr 24, 2018 at 05:15:33PM +0200, Victor Toso wrote: > Hey, > > JFYI, we'll be migrating to gitlab.freedesktop.org late this > week, see: > > https://gitlab.freedesktop.org/free

Re: [Spice-devel] [PATCH spice-gtk] tests: Shut up warnings about unitialized struct fields

2018-04-26 Thread Christophe Fergeau
On Tue, Apr 24, 2018 at 04:24:32PM -0300, Eduardo Lima (Etrunko) wrote: > Build complains about lots of unitialized fields in TestCase definition, This has been committed, but I don't think this was happening with git master and the default build flags? This should be mentioned in the commit log i

Re: [Spice-devel] how to debug spice-gtk on windows

2018-04-26 Thread Christophe Fergeau
On Thu, Apr 26, 2018 at 10:20:25AM +0300, Sameeh Jubran wrote: > Since the code is compiled using MingW and not VS I would suggest using the > "OutputDebugString" function along with DebugView for viewing the prints. You should also be able to use some mingw version of gdb Christophe signature.

Re: [Spice-devel] how to debug spice-gtk on windows

2018-04-26 Thread Sameeh Jubran
Since the code is compiled using MingW and not VS I would suggest using the "OutputDebugString" function along with DebugView for viewing the prints. On Thu, Apr 26, 2018 at 9:08 AM, Dingliguo wrote: > Hi , > > I compiled spice-gtk-0.33 and virt viewer with mingw32 , there is no pdb > file, so h