I think this is fine for now.
Acked-by: Jonathon Jongsma
On Thu, 2018-03-22 at 11:25 +, Frediano Ziglio wrote:
> Although not necessary for a single monitor DisplayChannel
> implementation
> this make the DisplayChannels more coherent from the client
> point of view.
>
> Signed-off-by: Fr
Looks good to me,
Acked-by: Christophe Fergeau
On Thu, Apr 19, 2018 at 05:48:35PM +0100, Frediano Ziglio wrote:
> From: Christophe de Dinechin
>
> Signed-off-by: Christophe de Dinechin
> ---
> include/spice-streaming-agent/plugin.hpp | 9 +
> 1 file changed, 9 insertions(+)
>
> diff
Acked-by: Christophe Fergeau
On Thu, Apr 19, 2018 at 05:48:33PM +0100, Frediano Ziglio wrote:
> From: Christophe de Dinechin
>
> This change addresses two issues related to plugin version checking:
>
> 1. It is possible for plugins to bypass version checking or do it wrong
>(as a matter of
On 17/04/18 04:40, Victor Toso wrote:
> From: Victor Toso
>
> The 'end' label is used only once and can be replaced by moving the
> code into the existing 'if (!devices)'.
>
> For convenience this patch also:
> * Explicit check against NULL
> * Added curly brackets to the moved 'for'
> * Moved v
On 20/04/18 06:02, Frediano Ziglio wrote:
>>
>> On 19/04/18 17:50, Frediano Ziglio wrote:
Different from autotools, with meson, the subproject is not a separate
build, so the definition of G_LOG_DOMAIN from the superproject will be
the same for spice-common.
This will
On Fri, Apr 20, 2018 at 10:10:17AM +0200, Christophe de Dinechin wrote:
> There is no easy way to test if a method is there. There is, however,
> an easy way to test if a C entry point is there in a shared library.
> This is the difference between your scenario and mine. In mine, I can
> explicitly
>
> On 19/04/18 17:50, Frediano Ziglio wrote:
> >>
> >> Different from autotools, with meson, the subproject is not a separate
> >> build, so the definition of G_LOG_DOMAIN from the superproject will be
> >> the same for spice-common.
> >>
> >> This will happen only with spice-gtk, because the val
> On 18 Apr 2018, at 16:43, Christophe Fergeau wrote:
>
> Hey,
>
> This script comes from
> https://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=blob;f=build-aux/git-version-gen;h=6d073fcaddd827a396af4c52f1bf00bdd84a9f66;hb=HEAD
> where this issue might already be fixed, the line that you chan
> On 18 Apr 2018, at 17:04, Christophe Fergeau wrote:
>
> On Tue, Apr 17, 2018 at 06:39:05PM +0200, Christophe de Dinechin wrote:
>> When does this kind of scenario happen? Imagine we added support for
>> loading/unloading plugins. Version 13 adds a new interface to unload
>> plugins, and a new
