[Spice-devel] help??????

2018-04-10 Thread molo
hi?? thx for your letter in reply. 1??some picture attached that you can not see may be forbidden?? because i am in China??within the Great Wall ?? 2??the software version is: spice-webdavd version: 2.2 spice-server version??0.12.8 libsoup version??2.60.3

[Spice-devel] [PATCH spice-common] Remove extra self parameter from member function

2018-04-10 Thread Jonathon Jongsma
When testing out some experimental protocol changes, I managed to trigger the following error: GEN generated_client_demarshallers.c Traceback (most recent call last): File "../../../spice-common/spice_codegen.py", line 267, in demarshal.write_protocol_parser(writer, proto, True) Fi

Re: [Spice-devel] [spice-gtk v1 04/11] channel-display: use GHashTable to keep stream's structure

2018-04-10 Thread Uri Lublin
On 04/10/2018 02:58 PM, Victor Toso wrote: Hi, On Mon, Apr 09, 2018 at 02:14:15PM +0300, Uri Lublin wrote: On 03/13/2018 01:25 PM, Victor Toso wrote: From: Victor Toso The major issue with the current approach is that it relies on the ID from SpiceMsgDisplayStreamCreate to create the smalles

Re: [Spice-devel] [spice-server] cursor: Delay release of QXL guest cursor resources

2018-04-10 Thread Christophe Fergeau
Hey, On Tue, Apr 10, 2018 at 08:16:32AM -0400, Frediano Ziglio wrote: > > > > > > Ping? I would like to move forward with having this fix temporarily in > > > spice-server even if in the long run, we'll be fixing QEMU too. > > > This would ease the upgrade path, as having this patch means we don'

Re: [Spice-devel] [spice-gtk v1 2/2] channel-usbredir: Fix crash on channel-up

2018-04-10 Thread Victor Toso
On Tue, Apr 10, 2018 at 05:19:05PM +0200, Christophe Fergeau wrote: > On Tue, Apr 10, 2018 at 02:17:45PM +0200, Victor Toso wrote: > > Hi, > > > > On Tue, Apr 10, 2018 at 01:37:05PM +0200, Victor Toso wrote: > > > Hi, > > > > > > On Tue, Apr 10, 2018 at 12:41:16PM +0200, Christophe Fergeau wrote:

Re: [Spice-devel] [spice-gtk v1 2/2] channel-usbredir: Fix crash on channel-up

2018-04-10 Thread Christophe Fergeau
On Tue, Apr 10, 2018 at 02:17:45PM +0200, Victor Toso wrote: > Hi, > > On Tue, Apr 10, 2018 at 01:37:05PM +0200, Victor Toso wrote: > > Hi, > > > > On Tue, Apr 10, 2018 at 12:41:16PM +0200, Christophe Fergeau wrote: > > > On Fri, Apr 06, 2018 at 09:59:44AM +0200, Victor Toso wrote: > > > > From:

Re: [Spice-devel] help!!!

2018-04-10 Thread Victor Toso
Hi, On Tue, Apr 10, 2018 at 08:40:33PM +0800, molo wrote: > hi, >thx for your letter. >1、the client is remote-viewer, it is already built against libphodav. > > > 2、and we can set the sharing folder on the remote-reviewer, > > > 3、The host and client are on the sam

Re: [Spice-devel] [PATCH spice-server] red-parse-qxl: Remove unused device_data field

2018-04-10 Thread Christophe Fergeau
On Tue, Apr 10, 2018 at 01:08:12PM +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/red-parse-qxl.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/server/red-parse-qxl.h b/server/red-parse-qxl.h > index 4a576ca0..ce7d8b05 100644 > --- a/server/red-parse-qxl.

Re: [Spice-devel] [spice-gtk v1 2/2] channel-usbredir: Fix crash on channel-up

2018-04-10 Thread Victor Toso
Hi, On Tue, Apr 10, 2018 at 01:37:05PM +0200, Victor Toso wrote: > Hi, > > On Tue, Apr 10, 2018 at 12:41:16PM +0200, Christophe Fergeau wrote: > > On Fri, Apr 06, 2018 at 09:59:44AM +0200, Victor Toso wrote: > > > From: Victor Toso > > > > > > By adding a guard to not handle channel-up on Spice

Re: [Spice-devel] [spice-server] cursor: Delay release of QXL guest cursor resources

2018-04-10 Thread Frediano Ziglio
> > > > Ping? I would like to move forward with having this fix temporarily in > > spice-server even if in the long run, we'll be fixing QEMU too. > > This would ease the upgrade path, as having this patch means we don't > > tie upgrades to spice-server 0.14 with QEMU upgrades, it does not matter

[Spice-devel] [PATCH spice-server] red-parse-qxl: Remove unused device_data field

2018-04-10 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/red-parse-qxl.h | 1 - 1 file changed, 1 deletion(-) diff --git a/server/red-parse-qxl.h b/server/red-parse-qxl.h index 4a576ca0..ce7d8b05 100644 --- a/server/red-parse-qxl.h +++ b/server/red-parse-qxl.h @@ -113,7 +113,6 @@ typedef struct RedCursorCmd {

Re: [Spice-devel] [spice-gtk v1 04/11] channel-display: use GHashTable to keep stream's structure

2018-04-10 Thread Victor Toso
Hi, On Mon, Apr 09, 2018 at 02:14:15PM +0300, Uri Lublin wrote: > On 03/13/2018 01:25 PM, Victor Toso wrote: > > From: Victor Toso > > > > The major issue with the current approach is that it relies on > > the ID from SpiceMsgDisplayStreamCreate to create the smallest 2^n > > sized array that co

Re: [Spice-devel] [spice-server] cursor: Delay release of QXL guest cursor resources

2018-04-10 Thread Frediano Ziglio
> > Ping? I would like to move forward with having this fix temporarily in > spice-server even if in the long run, we'll be fixing QEMU too. > This would ease the upgrade path, as having this patch means we don't > tie upgrades to spice-server 0.14 with QEMU upgrades, it does not matter > if you u

Re: [Spice-devel] [spice-gtk v1 2/2] channel-usbredir: Fix crash on channel-up

2018-04-10 Thread Victor Toso
Hi, On Tue, Apr 10, 2018 at 12:41:16PM +0200, Christophe Fergeau wrote: > On Fri, Apr 06, 2018 at 09:59:44AM +0200, Victor Toso wrote: > > From: Victor Toso > > > > By adding a guard to not handle channel-up on SpiceUsbredirChannel in > > case struct usbredirhost wasn't initialized yet. Same gua

Re: [Spice-devel] [spice-server] cursor: Delay release of QXL guest cursor resources

2018-04-10 Thread Christophe Fergeau
Ping? I would like to move forward with having this fix temporarily in spice-server even if in the long run, we'll be fixing QEMU too. This would ease the upgrade path, as having this patch means we don't tie upgrades to spice-server 0.14 with QEMU upgrades, it does not matter if you upgrade both a

Re: [Spice-devel] [spice-gtk v1 2/2] channel-usbredir: Fix crash on channel-up

2018-04-10 Thread Christophe Fergeau
On Fri, Apr 06, 2018 at 09:59:44AM +0200, Victor Toso wrote: > From: Victor Toso > > By adding a guard to not handle channel-up on SpiceUsbredirChannel in > case struct usbredirhost wasn't initialized yet. Same guard is in > place for the generic usbredir_handle_msg() function to avoid handling >