Re: [Spice-devel] Gitlab - 2018!

2018-04-04 Thread Eduardo Lima (Etrunko)
On 04/04/18 10:44, Victor Toso wrote: > Hey, > > Considering [2], is there anyone with issue in me filing a bug to > migrate to freedesktop's instance of gitlab? > Go Victor, GO!!! > [2] https://gitlab.freedesktop.org/freedesktop/freedesktop/wikis/home > > Cheers, > toso > > On Mon, F

[Spice-devel] [spice-gtk v1] spice-widget: remove old warning

2018-04-04 Thread Victor Toso
From: Victor Toso This log was introduced in 13f5ebbf07a3 to track the situation where the GdkCursor pointer would be invalid/NULL. That was possible if the caller passed a NULL for rgba pointer in cursor_set(). Code has changed a bit since then it isn't necessary to log a warn in the unlikely e

Re: [Spice-devel] Gitlab - 2018!

2018-04-04 Thread Victor Toso
Hey, Considering [2], is there anyone with issue in me filing a bug to migrate to freedesktop's instance of gitlab? [2] https://gitlab.freedesktop.org/freedesktop/freedesktop/wikis/home Cheers, toso On Mon, Feb 19, 2018 at 04:15:07PM +0100, Victor Toso wrote: > Hi, > > There was a thre

Re: [Spice-devel] [spice-gtk v2 1/2] spice-widget: fix leak of boxed type cursor-shape

2018-04-04 Thread Victor Toso
Hi, On Wed, Apr 04, 2018 at 09:18:18AM -0400, Frediano Ziglio wrote: > > From: Victor Toso > > > > Detected while testing valgrind on migration. > > > > > malloc (vg_replace_malloc.c:299) > > > g_malloc (in /usr/lib/libglib-2.0.so.0.5400.3) > > > spice_cursor_shape_copy (channel-cursor.c:99) >

Re: [Spice-devel] [spice-gtk v2 1/2] spice-widget: fix leak of boxed type cursor-shape

2018-04-04 Thread Frediano Ziglio
> > From: Victor Toso > > Detected while testing valgrind on migration. > > > malloc (vg_replace_malloc.c:299) > > g_malloc (in /usr/lib/libglib-2.0.so.0.5400.3) > > spice_cursor_shape_copy (channel-cursor.c:99) > > ??? (in /usr/lib/libgobject-2.0.so.0.5400.3) > > g_object_get_valist (in /usr/l

[Spice-devel] [spice-gtk v2 1/2] spice-widget: fix leak of boxed type cursor-shape

2018-04-04 Thread Victor Toso
From: Victor Toso Detected while testing valgrind on migration. > malloc (vg_replace_malloc.c:299) > g_malloc (in /usr/lib/libglib-2.0.so.0.5400.3) > spice_cursor_shape_copy (channel-cursor.c:99) > ??? (in /usr/lib/libgobject-2.0.so.0.5400.3) > g_object_get_valist (in /usr/lib/libgobject-2.0.so.

[Spice-devel] [spice-gtk v2 2/2] spice-widget: fix leak of boxed type cursor-shape

2018-04-04 Thread Victor Toso
From: Victor Toso No valgrind on this one but a leak similar to previous patch. This one was introduced in e691954be459087 Signed-off-by: Victor Toso --- src/spice-widget.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/spice-widget.c b/src/spice-widget.c index 7732f5f..8a6b5ab 100644

Re: [Spice-devel] [spice-gtk v1 2/2] spice-widget: fix leak of boxed type cursor-shape

2018-04-04 Thread Victor Toso
On Wed, Apr 04, 2018 at 05:01:16AM -0400, Frediano Ziglio wrote: > > > > From: Victor Toso > > > > No valgrind on this one but a leak similar to previous patch. > > This one was introduced in e691954be459087 > > > > Signed-off-by: Victor Toso > > --- > > src/spice-widget.c | 1 + > > 1 file c

Re: [Spice-devel] [spice-gtk v1 1/2] spice-widget: fix leak of boxed type cursor-shape

2018-04-04 Thread Victor Toso
Hi, On Wed, Apr 04, 2018 at 09:44:06AM +0300, Snir Sheriber wrote: > Hi > > On 04/03/2018 05:11 PM, Victor Toso wrote: > > From: Victor Toso > > > > Detected while testing valgrind on migration. > > > > > malloc (vg_replace_malloc.c:299) > > > g_malloc (in /usr/lib/libglib-2.0.so.0.5400.3) > >

Re: [Spice-devel] [spice-gtk v1 01/11] channel-display: remove id parameter from helper function

2018-04-04 Thread Frediano Ziglio
> > From: Victor Toso > > Instead of passing the id parameter for destroy_display_stream() which > is only used for debug, let's store the id when creating the stream at > display_stream_create(). > > With the removal of Id parameter, we are using a gpointer for > display_stream struct to compl

Re: [Spice-devel] [spice-gtk v1 03/11] channel-display: remove unneeded function

2018-04-04 Thread Frediano Ziglio
> > From: Victor Toso > > The get_stream_id_by_stream() was introduced in 141c2d82 to debug > GStreamer's pipeline. But with previous patch, we are moving the ID to > the display_stream structure and can be accessible directly. > > Signed-off-by: Victor Toso > --- > src/channel-display-gst.c

Re: [Spice-devel] [spice-gtk v1 2/2] spice-widget: fix leak of boxed type cursor-shape

2018-04-04 Thread Frediano Ziglio
> > From: Victor Toso > > No valgrind on this one but a leak similar to previous patch. > This one was introduced in e691954be459087 > > Signed-off-by: Victor Toso > --- > src/spice-widget.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/spice-widget.c b/src/spice-widget.c > in