Re: [Spice-devel] [PATCH spice-server 1/2] Add support for building with meson

2018-03-27 Thread Eduardo Lima (Etrunko)
On 27/03/18 10:16, Christophe Fergeau wrote: > On Tue, Mar 27, 2018 at 09:57:35AM -0300, Eduardo Lima (Etrunko) wrote: >> On 27/03/18 09:51, Christophe Fergeau wrote: >>> On Tue, Mar 27, 2018 at 08:53:06AM -0300, Eduardo Lima (Etrunko) wrote: No, I think it should work, but this .wrap file is

Re: [Spice-devel] [PATCH spice-server 1/2] Add support for building with meson

2018-03-27 Thread Christophe Fergeau
On Tue, Mar 27, 2018 at 09:57:35AM -0300, Eduardo Lima (Etrunko) wrote: > On 27/03/18 09:51, Christophe Fergeau wrote: > > On Tue, Mar 27, 2018 at 08:53:06AM -0300, Eduardo Lima (Etrunko) wrote: > >> No, I think it should work, but this .wrap file is useful the first time > >> user clones the repos

Re: [Spice-devel] [PATCH spice-server 1/2] Add support for building with meson

2018-03-27 Thread Eduardo Lima (Etrunko)
On 27/03/18 09:51, Christophe Fergeau wrote: > On Tue, Mar 27, 2018 at 08:53:06AM -0300, Eduardo Lima (Etrunko) wrote: >> No, I think it should work, but this .wrap file is useful the first time >> user clones the repository, it will fetch spice-common automatically. > > Hmm, but is this 'subproje

Re: [Spice-devel] [PATCH spice-server 1/2] Add support for building with meson

2018-03-27 Thread Christophe Fergeau
On Tue, Mar 27, 2018 at 08:53:06AM -0300, Eduardo Lima (Etrunko) wrote: > No, I think it should work, but this .wrap file is useful the first time > user clones the repository, it will fetch spice-common automatically. Hmm, but is this 'subproject' command going to handle git submodule updates pro

Re: [Spice-devel] [PATCH spice-server 1/2] Add support for building with meson

2018-03-27 Thread Eduardo Lima (Etrunko)
On 27/03/18 07:26, Christophe Fergeau wrote: > Couple of notes for people trying this, > > On Thu, Mar 22, 2018 at 02:18:20PM -0300, Eduardo Lima (Etrunko) wrote: >> diff --git a/meson.build b/meson.build >> new file mode 100644 >> index ..f373e662 >> --- /dev/null >> +++ b/meson.build >>

Re: [Spice-devel] [PATCH spice-server 1/2] Add support for building with meson

2018-03-27 Thread Christophe Fergeau
Couple of notes for people trying this, On Thu, Mar 22, 2018 at 02:18:20PM -0300, Eduardo Lima (Etrunko) wrote: > diff --git a/meson.build b/meson.build > new file mode 100644 > index ..f373e662 > --- /dev/null > +++ b/meson.build > @@ -0,0 +1,175 @@ > +# > +# project definition > +# > +#

Re: [Spice-devel] [PATCH 0/2] Make plugin version checking more robust

2018-03-27 Thread Lukáš Hrázký
FWIW, personal opinions below :) On Tue, 2018-03-27 at 10:56 +0200, Christophe Fergeau wrote: > On Tue, Mar 27, 2018 at 10:28:24AM +0200, Christophe de Dinechin wrote: > > > > > > > On 27 Mar 2018, at 10:12, Christophe Fergeau wrote: > > > > > > With the right patch attached this time.. ;) I'v

Re: [Spice-devel] [PATCH 0/2] Make plugin version checking more robust

2018-03-27 Thread Christophe Fergeau
On Tue, Mar 27, 2018 at 10:28:24AM +0200, Christophe de Dinechin wrote: > > > > On 27 Mar 2018, at 10:12, Christophe Fergeau wrote: > > > > With the right patch attached this time.. ;) I've only compile-tested > > this as this really is just a proof of concept at this point. > > If I understan

Re: [Spice-devel] [PATCH 0/2] Make plugin version checking more robust

2018-03-27 Thread Christophe de Dinechin
> On 27 Mar 2018, at 10:12, Christophe Fergeau wrote: > > With the right patch attached this time.. ;) I've only compile-tested > this as this really is just a proof of concept at this point. If I understand correctly, you break the ABI twice, and you rely on a “side effect” of changing the v

Re: [Spice-devel] [PATCH 0/2] Make plugin version checking more robust

2018-03-27 Thread Christophe Fergeau
With the right patch attached this time.. ;) I've only compile-tested this as this really is just a proof of concept at this point. Christophe On Mon, Mar 26, 2018 at 06:47:08PM +0200, Christophe Fergeau wrote: > On Mon, Mar 26, 2018 at 11:27:19AM +0200, Christophe de Dinechin wrote: > > > > >