This includes some rendering fixes.
Frediano Ziglio (19):
proto: Add some documentation to stream_report message
protocol: Allow to specify a surface will be streamed
canvas-base: Fix width computation for palette images
canvas: Simplify code using spice_memdup
canvas
Due to ticket expiration, it is possible that the streaming channels for
the client are created after the ticket expires. Currently, streaming
channels are created dynamically when the guest starts streaming to the
server, which can happen at any time (for instance if you decide to start
the graphi
> > On 23 Feb 2018, at 11:31, Christophe Fergeau wrote:
> >
> > On Fri, Feb 23, 2018 at 10:11:46AM +, Frediano Ziglio wrote:
> >> Depending on how structures are initialised in the code is
> >> possible that implicit padding bytes are not initialised
> >> causing possible information leaks as
On Tue, 2018-02-27 at 10:59 +, Frediano Ziglio wrote:
> Due to ticket expiration, is possible that the streaming channels for
"it is possible"
> the
> client are created after the ticket expires, this as currently
end sentence after "expires". Then:
"Currently, streaming channels are..."
>
> > On 23 Feb 2018, at 11:11, Frediano Ziglio wrote:
> >
> > Depending on how structures are initialised in the code is
> > possible that implicit padding bytes are not initialised
> > causing possible information leaks as the entire structure
> > with all padding is sent through device/networ
>
> Signed-off-by: Lukáš Hrázký
> ---
> src/spice-streaming-agent.cpp | 28 +---
> 1 file changed, 25 insertions(+), 3 deletions(-)
>
> diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp
> index ee57920..53dbca0 100644
> --- a/src/spice-streaming-
On Tue, Feb 27, 2018 at 01:04:31PM +0100, Lukáš Hrázký wrote:
> On Tue, 2018-02-27 at 06:33 -0500, Frediano Ziglio wrote:
> > >
> > > Removing noinst_PROGRAMS from src/unittests/Makefile.am will cause the
> > > unit tests not be built on a regular build (`make`), they will only be
> > > built when
Changes since v2:
- removed read_len, decrementing len and incrementing msg pointer as we
read in read_all()
- used a new struct with 1k fixed message size buffer instead of an
uint8_t array
- in case of too long a message, read a partial message, log it and
finish with an exception
- check f
Signed-off-by: Lukáš Hrázký
---
src/spice-streaming-agent.cpp | 28 +---
1 file changed, 25 insertions(+), 3 deletions(-)
diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp
index ee57920..53dbca0 100644
--- a/src/spice-streaming-agent.cpp
+++ b/src
Signed-off-by: Lukáš Hrázký
---
src/spice-streaming-agent.cpp | 31 +--
1 file changed, 21 insertions(+), 10 deletions(-)
diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp
index aeee5d3..ee57920 100644
--- a/src/spice-streaming-agent.cpp
+++ b
> On Thu, 2018-02-22 at 19:25 +0100, Christophe de Dinechin wrote:
> > > On 22 Feb 2018, at 15:11, Lukáš Hrázký wrote:
> > >
> > > Signed-off-by: Lukáš Hrázký
> > > ---
> > > src/spice-streaming-agent.cpp | 18 --
> > > 1 file changed, 16 insertions(+), 2 deletions(-)
> > >
> > >
On Tue, 2018-02-27 at 06:33 -0500, Frediano Ziglio wrote:
> >
> > Removing noinst_PROGRAMS from src/unittests/Makefile.am will cause the
> > unit tests not be built on a regular build (`make`), they will only be
> > built when running the tests (`make check`).
> >
> > C++ unit test frameworks are
>
> Removing noinst_PROGRAMS from src/unittests/Makefile.am will cause the
> unit tests not be built on a regular build (`make`), they will only be
> built when running the tests (`make check`).
>
> C++ unit test frameworks are notorious for long build times too.
>
> Signed-off-by: Lukáš Hrázký
>
> On Sun, Feb 18, 2018 at 06:58:10PM +, Frediano Ziglio wrote:
> > To communicate the error and avoiding to have to read any data the
> > guest want to write disable the device.
>
> I am having troubles parsing this. Is this missing a comma before
> "disable"?
>
> "To communicate the error
>
> On Sun, Feb 18, 2018 at 06:58:09PM +, Frediano Ziglio wrote:
> > Due to the way Qemu handle the device we must consume all pending
> > data inside the callback to read data from the device.
>
> "handles the device, we must .."
> "... the callback which reads data ..." ?
>
> I would add "
Due to ticket expiration, is possible that the streaming channels for the
client are created after the ticket expires, this as currently streaming
channels are created dynamically when the guest starts streaming to the
server which can happen at any time (for instance if you decide to start
the gra
>
> > On 23 Feb 2018, at 10:24, Frediano Ziglio wrote:
> >
> >>
> >> Title of the patch: “first not main” sounds un-english because it mixes
> >> adjective and noun-used-as-adjective. Contrast “first, not last,
> >> connexion”
> >> (with commas, I believe). Jonathon, any suggestion? Is “first n
Hi,
On Tue, Feb 27, 2018 at 10:22:49AM +0100, Jakub Janku wrote:
> Hi Victor,
>
> On Tue, Feb 27, 2018 at 9:02 AM, Victor Toso wrote:
> > Not exactly what I had in mind. The clipboad.[ch] is only
> > handling gtk code and the decision between gtk/x11 is on
> > vdagent.c by using #ifdef WITH_GTK_
Hi Victor,
On Tue, Feb 27, 2018 at 9:02 AM, Victor Toso wrote:
> Hi Jakub,
>
> On Mon, Feb 26, 2018 at 08:01:28PM +0100, Jakub Janků wrote:
>> From: Jakub Janků
>>
>> Add clipboard handling that uses GTK+ instead of Xlib.
>> Place the code into new files: clipboard.c, clipboard.h
>>
>> Use the o
Hi Jakub,
On Mon, Feb 26, 2018 at 08:01:28PM +0100, Jakub Janků wrote:
> From: Jakub Janků
>
> Add clipboard handling that uses GTK+ instead of Xlib.
> Place the code into new files: clipboard.c, clipboard.h
>
> Use the old Xlib implementation by default.
> Add configure option --with-gtk-clipb
20 matches
Mail list logo
