[Spice-devel] [PATCH vdagent v2 1/1] vdagent: add GTK+ clipboard handling

2018-02-26 Thread Jakub Janků
From: Jakub Janků Add clipboard handling that uses GTK+ instead of Xlib. Place the code into new files: clipboard.c, clipboard.h Use the old Xlib implementation by default. Add configure option --with-gtk-clipboard. Guard the code by WITH_GTK_CLIPBOARD variable - compile vdagent either with GTK+

[Spice-devel] [PATCH vdagent v2 0/1] clipboard system redesign

2018-02-26 Thread Jakub Janků
Changes since v1: - keep old Xlib implementation for now - make get_type_from_atom() more readable - refactor of weak ref functions (new_request_ref(), free_request_ref(), ...) - pack selection-dependant variables from VDAgentClipboards into struct Selection - several renames - DataRetrieval --

[Spice-devel] [PATCH spice-streaming-agent] Only build unit tests when running make check

2018-02-26 Thread Lukáš Hrázký
Removing noinst_PROGRAMS from src/unittests/Makefile.am will cause the unit tests not be built on a regular build (`make`), they will only be built when running the tests (`make check`). C++ unit test frameworks are notorious for long build times too. Signed-off-by: Lukáš Hrázký --- I am not sur

Re: [Spice-devel] [RFC PATCH spice-streaming-agent 2/2] Implement handling of error messages from the server

2018-02-26 Thread Lukáš Hrázký
On Thu, 2018-02-22 at 19:25 +0100, Christophe de Dinechin wrote: > > On 22 Feb 2018, at 15:11, Lukáš Hrázký wrote: > > > > Signed-off-by: Lukáš Hrázký > > --- > > src/spice-streaming-agent.cpp | 18 -- > > 1 file changed, 16 insertions(+), 2 deletions(-) > > > > diff --git a/src/

Re: [Spice-devel] [PATCH 12/17] Convert message writing from C style to C++ style

2018-02-26 Thread Christophe de Dinechin
Good idea. Will do it that way. > On 26 Feb 2018, at 11:05, Lukáš Hrázký wrote: > > Get rid of the 'make()' method and the 'msg' member, create the payload > on the stack in 'write()' and write the header and message in two > writes. > --- > It does split the write for FormatMessage into two, bu

Re: [Spice-devel] [PATCH v2 22/24] Throw exception in case of write failure

2018-02-26 Thread Lukáš Hrázký
On Thu, 2018-02-22 at 15:09 +0100, Christophe de Dinechin wrote: > > On 22 Feb 2018, at 14:12, Lukáš Hrázký wrote: > > > > Apart from what's below, I'm also thinking if it wouldn't be better to > > leave this addition of exception classes for later and concentrate on > > finishing what's already

Re: [Spice-devel] [PATCH 12/17] Convert message writing from C style to C++ style

2018-02-26 Thread Lukáš Hrázký
Get rid of the 'make()' method and the 'msg' member, create the payload on the stack in 'write()' and write the header and message in two writes. --- It does split the write for FormatMessage into two, but makes the code a bit simpler I think. It reduces the number of combinations the messages are

Re: [Spice-devel] [PATCH 12/17] Convert message writing from C style to C++ style

2018-02-26 Thread Lukáš Hrázký
On Fri, 2018-02-23 at 19:07 +0100, Christophe de Dinechin wrote: > > On 23 Feb 2018, at 17:37, Jonathon Jongsma wrote: > > > > On Fri, 2018-02-23 at 12:36 +0100, Christophe de Dinechin wrote: > > > > On 22 Feb 2018, at 19:05, Lukáš Hrázký wrote: > > > > > > > > On Thu, 2018-02-22 at 18:51 +0100