From: Christophe de Dinechin
Signed-off-by: Christophe de Dinechin
---
src/spice-streaming-agent.cpp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp
index a789aad..b889acc 100644
--- a/src/spice-streaming-ag
From: Christophe de Dinechin
This class will need to be moved to a separate file in a later patch.
This is done in two steps to make the evolution of the code easier to track,
as well as to facilitate later 'git bisect'
Signed-off-by: Christophe de Dinechin
---
src/spice-streaming-agent.cpp |
From: Christophe de Dinechin
Signed-off-by: Christophe de Dinechin
---
src/spice-streaming-agent.cpp | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp
index 8508f9b..b743204 100644
--- a/src/spice-streaming-agent
From: Christophe de Dinechin
This also introduces the spice::streaming_error::Error class, which we can reuse
later as a base class for all agent-specific errors. This class provides a
formatted 'message()' class that returns a string, making it easier to format
errors without allocating memory a
From: Christophe de Dinechin
Signed-off-by: Christophe de Dinechin
---
src/spice-streaming-agent.cpp | 23 +--
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp
index 85d055b..5fef102 100644
--- a/sr
From: Christophe de Dinechin
Signed-off-by: Christophe de Dinechin
---
src/spice-streaming-agent.cpp | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp
index d02b873..dbdc0e2 100644
--- a/src/spice-streaming-a
From: Christophe de Dinechin
Signed-off-by: Christophe de Dinechin
---
src/spice-streaming-agent.cpp | 27 +--
1 file changed, 17 insertions(+), 10 deletions(-)
diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp
index 61a73ce..4aae2cb 100644
---
From: Christophe de Dinechin
Signed-off-by: Christophe de Dinechin
---
src/spice-streaming-agent.cpp | 47 ++-
1 file changed, 28 insertions(+), 19 deletions(-)
diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp
index b743204..659
From: Christophe de Dinechin
Signed-off-by: Christophe de Dinechin
---
src/concrete-agent.hpp| 4
src/spice-streaming-agent.cpp | 19 +--
2 files changed, 13 insertions(+), 10 deletions(-)
diff --git a/src/concrete-agent.hpp b/src/concrete-agent.hpp
index 5bca23b.
From: Christophe de Dinechin
Signed-off-by: Christophe de Dinechin
---
src/spice-streaming-agent.cpp | 28 ++--
1 file changed, 18 insertions(+), 10 deletions(-)
diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp
index dbdc0e2..3c4fb67 100644
---
From: Christophe de Dinechin
This is not a really nice abstraction at this point, but still a step in the
right way
Signed-off-by: Christophe de Dinechin
---
src/spice-streaming-agent.cpp | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/src/spice-streaming
From: Christophe de Dinechin
- The Stream class now deals with locking and sending messages
- The Message<> template class deals with the general writing mechanisms
- Three classes, FormatMessage, FrameMessage and X11CursorMessage represent
individual messages
The various classes should be move
From: Christophe de Dinechin
Signed-off-by: Christophe de Dinechin
---
src/spice-streaming-agent.cpp | 47 +--
1 file changed, 27 insertions(+), 20 deletions(-)
diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp
index 6599028..d02
From: Christophe de Dinechin
Signed-off-by: Christophe de Dinechin
---
src/spice-streaming-agent.cpp | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp
index 26fa910..4e3a21c 100644
--- a/src/spice-stre
From: Christophe de Dinechin
Signed-off-by: Christophe de Dinechin
---
src/spice-streaming-agent.cpp | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp
index 4e3a21c..61a73ce 100644
--- a/src/spice-str
From: Christophe de Dinechin
Get rid of C-style 'goto done' in do_capture.
Get rid of global streamfd, pass it around (cleaned up in later patch)
Fixes a race condition, make sure we only use stream after opening
Signed-off-by: Christophe de Dinechin
---
src/spice-streaming-agent.cpp | 91
From: Christophe de Dinechin
Signed-off-by: Christophe de Dinechin
---
src/spice-streaming-agent.cpp | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp
index aeee5d3..894f86c 100644
--- a/src/spice-streaming-a
From: Christophe de Dinechin
Signed-off-by: Christophe de Dinechin
---
src/spice-streaming-agent.cpp | 99 ++-
1 file changed, 60 insertions(+), 39 deletions(-)
diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp
index 1c7c42d..2c3
From: Christophe de Dinechin
I also added a catch-all clause for double plus extra safety
Signed-off-by: Christophe de Dinechin
---
src/spice-streaming-agent.cpp | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.c
From: Christophe de Dinechin
Signed-off-by: Christophe de Dinechin
---
src/spice-streaming-agent.cpp | 105 +++---
1 file changed, 57 insertions(+), 48 deletions(-)
diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp
index 3c4fb67..9f4
From: Christophe de Dinechin
Signed-off-by: Christophe de Dinechin
---
src/concrete-agent.hpp| 4 +--
src/spice-streaming-agent.cpp | 64 +--
2 files changed, 34 insertions(+), 34 deletions(-)
diff --git a/src/concrete-agent.hpp b/src/concrete-a
From: Christophe de Dinechin
As per e-mail discussions (https://patchwork.freedesktop.org/patch/200629/),
using std::string for C-style string constants is against C++ good practices,
see
https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#Rstr-zstring
for reference.
S
From: Christophe de Dinechin
Signed-off-by: Christophe de Dinechin
---
src/concrete-agent.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/concrete-agent.cpp b/src/concrete-agent.cpp
index 0720782..4cf70e7 100644
--- a/src/concrete-agent.cpp
+++ b/src/concrete-agent.cpp
@@ -9,6 +9,7
From: Christophe de Dinechin
Signed-off-by: Christophe de Dinechin
---
src/mjpeg-fallback.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mjpeg-fallback.cpp b/src/mjpeg-fallback.cpp
index fd37167..5758893 100644
--- a/src/mjpeg-fallback.cpp
+++ b/src/mjpeg-fallback.c
From: Christophe de Dinechin
The streaming agent started as C code. This series converts
the style to something that is more usual for C++, notably:
- Adds encapsulation and RAII for resources such as the stream
- Splits functionality into several classes with clear roles
- Puts message formatti
On Wed, Feb 21, 2018 at 10:17 AM, Frediano Ziglio wrote:
>> From: Marc-André Lureau
>>
>> Signed-off-by: Marc-André Lureau
>> ---
>> src/spice-session.c | 31 +++
>> tests/session.c | 20 ++--
>> 2 files changed, 33 insertions(+), 18 deletions(-)
Hi
On Wed, Feb 21, 2018 at 10:24 AM, Frediano Ziglio wrote:
>> From: Marc-André Lureau
>>
>> spice:// has a weird scheme encoding, where it can accept both plain
>> and tls ports with URI query parameters. However, it's not very
>> convenient nor very common to use (who really want to mix plain
Hey,
On Mon, Jan 29, 2018 at 08:24:59AM +0100, ralfbuhrm...@bundeswehr.org wrote:
> Dear Spice-Developer,
>
> i'm a civilian Employer in the the German Navy and have a little Problem.
>
> We are using a Linux-Based Trainer Software using SUSE 9.1 and 9.3. With
> our new Hardware, we have vitual
On Wed, 2018-02-21 at 15:47 +, Frediano Ziglio wrote:
> Avoids losing sync with the device.
> Handle some missing messages.
>
> Changes since v3:
> - reverse function order to avoid function declaration.
>
> Changes since v2:
> - fix typo;
> - use the term "handle" instead of "read";
> - retu
Lukáš Hrázký writes:
> On Tue, 2018-02-20 at 20:48 +, Frediano Ziglio wrote:
>> In all paths errors from this function are treated like fatal
>> error, there's no need to handle all manually potentially
>> forgetting to handle errors.
>> Also avoid to deal directly with logging moving the res
Do not bail if the server is attempting to communicate some extensions
but just ignore as at the moment we support none.
Signed-off-by: Frediano Ziglio
---
src/spice-streaming-agent.cpp | 29 +
1 file changed, 29 insertions(+)
diff --git a/src/spice-streaming-agent.c
In all paths errors from this function are treated like fatal
error, there's no need to handle all manually potentially
forgetting to handle errors.
Also avoid to deal directly with logging moving the responsibility
to other layers.
Signed-off-by: Frediano Ziglio
---
src/spice-streaming-agent.cp
Base error message handling.
Signed-off-by: Frediano Ziglio
---
src/spice-streaming-agent.cpp | 8
1 file changed, 8 insertions(+)
diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp
index 0e419bc..aeee5d3 100644
--- a/src/spice-streaming-agent.cpp
+++ b/src/spic
Prepare to add support for other messages.
Signed-off-by: Frediano Ziglio
---
src/spice-streaming-agent.cpp | 46 +--
1 file changed, 27 insertions(+), 19 deletions(-)
diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp
index 561393
Avoids losing sync with the device.
Handle some missing messages.
Changes since v3:
- reverse function order to avoid function declaration.
Changes since v2:
- fix typo;
- use the term "handle" instead of "read";
- return void from handling functions.
Changes since v1:
- avoid the usage of ERROR
>
> On Wed, 2018-02-21 at 05:45 -0500, Frediano Ziglio wrote:
> > >
> > > On Tue, 2018-02-20 at 20:48 +, Frediano Ziglio wrote:
> > > > Prepare to add support for other messages.
> > > >
> > > > Signed-off-by: Frediano Ziglio
> > > > ---
> > > > src/spice-streaming-agent.cpp | 26 +
On Wed, 2018-02-21 at 05:51 -0500, Frediano Ziglio wrote:
> >
> > On Tue, 2018-02-20 at 20:48 +, Frediano Ziglio wrote:
> > > Base error message handling.
> > >
> > > Signed-off-by: Frediano Ziglio
> > > ---
> > > src/spice-streaming-agent.cpp | 9 +
> > > 1 file changed, 9 insertio
>
> I'm late to the party, but a one-line commit log for a patch adding 160
> lines of code is *not* acceptable.
>
> Christophe
>
Yes, was a mistake.
Frediano
> On Fri, Feb 09, 2018 at 09:10:48AM +, Frediano Ziglio wrote:
> > Signed-off-by: Frediano Ziglio
> > ---
> > server/stream-devi
On Wed, 2018-02-21 at 05:45 -0500, Frediano Ziglio wrote:
> >
> > On Tue, 2018-02-20 at 20:48 +, Frediano Ziglio wrote:
> > > Prepare to add support for other messages.
> > >
> > > Signed-off-by: Frediano Ziglio
> > > ---
> > > src/spice-streaming-agent.cpp | 26 ++
>
I'm late to the party, but a one-line commit log for a patch adding 160
lines of code is *not* acceptable.
Christophe
On Fri, Feb 09, 2018 at 09:10:48AM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/stream-device.c | 169
> ++
On Wed, 2018-02-21 at 10:19 +0100, Lukáš Hrázký wrote:
> > > > I chose short names because I was in that namespace. Otherwise,
> > > > I
> > > > agree with you.
> > > >
> > > > Do you think that the name is still too vague even within the
> > > > namespace?
> > >
> > > I think so. Everything in s
Hey,
I am cc-ing the SPICE developers mailing list in order to raise awareness
of this user issue (apologies for cross-posting).
Unfortunately, due to limitations of the SPICE protocol, input is sent as
keyboard scan codes to the remote machine rather than Unicode characters.
This is the reason y
Hi,
On Wed, Feb 21, 2018 at 12:21:41PM +0100, Christophe Fergeau wrote:
> On Mon, Feb 19, 2018 at 04:15:07PM +0100, Victor Toso wrote:
> > Hi,
> >
> > There was a thread in 2016 about moving to gitlab [0] which it
> > was not complete done. New projects have been started in gitlab
> > instead of
On Mon, 2018-02-19 at 16:15 +0100, Victor Toso wrote:
> Hi,
>
> There was a thread in 2016 about moving to gitlab [0] which it
> was not complete done. New projects have been started in gitlab
> instead of freedesktop and without notice, some users are even
> filling bugs there already [1].
>
> [
On Wed, Feb 21, 2018 at 03:17:12AM -0800, Bat Man wrote:
> Can you please remove gtk-doc as a mandatory requirment for installing
> spice-gtk. The thing is its supporting library. A cool one but support
> none the less. NO ONE reads the documentation. Your build system is
> antiquated. Please
Hey,
For what it's worth, inflamatory emails such as this one are not
welcome on this list, and usually not the best way of getting
help/feedback. gtk-doc should not be required for building from tarballs
if you pass --disable-gtk-doc to configure. It even seems to be disabled
by default on my mac
Can you please remove gtk-doc as a mandatory requirment for installing
spice-gtk. The thing is its supporting library. A cool one but support
none the less. NO ONE reads the documentation. Your build system is
antiquated. Please update it and remove gtk-doc as a requirement. It is
breaking yo
On Mon, Feb 19, 2018 at 04:15:07PM +0100, Victor Toso wrote:
> Hi,
>
> There was a thread in 2016 about moving to gitlab [0] which it
> was not complete done. New projects have been started in gitlab
> instead of freedesktop and without notice, some users are even
> filling bugs there already [1].
>
> On Tue, 2018-02-20 at 20:48 +, Frediano Ziglio wrote:
> > Base error message handling.
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > src/spice-streaming-agent.cpp | 9 +
> > 1 file changed, 9 insertions(+)
> >
> > diff --git a/src/spice-streaming-agent.cpp b/src/spice-stre
>
> On Tue, 2018-02-20 at 20:48 +, Frediano Ziglio wrote:
> > Do not bail if the server is attempting to communicate some extensions
> > but just ignore as at the moment we support none.
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > src/spice-streaming-agent.cpp | 30 +++
>
> On Tue, 2018-02-20 at 20:48 +, Frediano Ziglio wrote:
> > Prepare to add support for other messages.
> >
> > Signed-off-by: Frediano Ziglio
> > ---
> > src/spice-streaming-agent.cpp | 26 ++
> > 1 file changed, 18 insertions(+), 8 deletions(-)
> >
> > diff --git
On Tue, 2018-02-20 at 20:48 +, Frediano Ziglio wrote:
> Prepare to add support for other messages.
>
> Signed-off-by: Frediano Ziglio
> ---
> src/spice-streaming-agent.cpp | 26 ++
> 1 file changed, 18 insertions(+), 8 deletions(-)
>
> diff --git a/src/spice-streamin
On Tue, 2018-02-20 at 20:48 +, Frediano Ziglio wrote:
> Base error message handling.
>
> Signed-off-by: Frediano Ziglio
> ---
> src/spice-streaming-agent.cpp | 9 +
> 1 file changed, 9 insertions(+)
>
> diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp
> ind
On Tue, 2018-02-20 at 20:48 +, Frediano Ziglio wrote:
> Do not bail if the server is attempting to communicate some extensions
> but just ignore as at the moment we support none.
>
> Signed-off-by: Frediano Ziglio
> ---
> src/spice-streaming-agent.cpp | 30 ++
> 1
On Tue, 2018-02-20 at 20:48 +, Frediano Ziglio wrote:
> In all paths errors from this function are treated like fatal
> error, there's no need to handle all manually potentially
> forgetting to handle errors.
> Also avoid to deal directly with logging moving the responsibility
> to other layers
On Tue, 2018-02-20 at 17:20 +0100, Christophe de Dinechin wrote:
> > On 20 Feb 2018, at 16:51, Lukáš Hrázký wrote:
> >
> > On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote:
> > > From: Christophe de Dinechin
> > >
> > > This is not a really nice abstraction at this point, but sti
On Tue, 2018-02-20 at 16:41 +0100, Christophe de Dinechin wrote:
> > On 20 Feb 2018, at 15:29, Lukáš Hrázký wrote:
> >
> > On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote:
> > > From: Christophe de Dinechin
> > >
> > > - The Stream class now deals with locking and sending messag
> From: Marc-André Lureau
>
> spice:// has a weird scheme encoding, where it can accept both plain
> and tls ports with URI query parameters. However, it's not very
> convenient nor very common to use (who really want to mix plain & tls
> channels?).
>
> Instead, let's introduce the more readabl
On Tue, 2018-02-20 at 15:24 -0600, Jonathon Jongsma wrote:
> On Tue, 2018-02-20 at 14:29 +0100, Lukáš Hrázký wrote:
> > On Tue, 2018-02-20 at 10:47 +0100, Christophe de Dinechin wrote:
> > > > On 20 Feb 2018, at 10:43, Lukáš Hrázký
> > > > wrote:
> > > >
> > > > On Fri, 2018-02-16 at 17:15 +0100,
>
> From: Marc-André Lureau
>
> They couldn't not be introduced before, because the test needs both
> parsing and generation.
>
> Signed-off-by: Marc-André Lureau
> ---
> tests/session.c | 24 +++-
> 1 file changed, 23 insertions(+), 1 deletion(-)
>
> diff --git a/tests/s
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> src/spice-session.c | 31 +++
> tests/session.c | 20 ++--
> 2 files changed, 33 insertions(+), 18 deletions(-)
>
> diff --git a/src/spice-session.c b/src/spice-session.c
> in
On Tue, 2018-02-20 at 18:37 +0100, Christophe de Dinechin wrote:
> [Forgot to send, sorry for delay]
>
> > On 19 Feb 2018, at 19:03, Lukáš Hrázký wrote:
> >
> > On Fri, 2018-02-16 at 17:59 +0100, Christophe de Dinechin wrote:
> > > > On 16 Feb 2018, at 17:40, Frediano Ziglio wrote:
> > > >
> >
> On 20 Feb 2018, at 22:24, Jonathon Jongsma wrote:
>
> On Tue, 2018-02-20 at 14:29 +0100, Lukáš Hrázký wrote:
>> On Tue, 2018-02-20 at 10:47 +0100, Christophe de Dinechin wrote:
On 20 Feb 2018, at 10:43, Lukáš Hrázký
wrote:
On Fri, 2018-02-16 at 17:15 +0100, Christophe de
63 matches
Mail list logo
