Re: [Spice-devel] [PATCH 05/17] Use RAII to cleanup stream in case of exception or return

2018-02-20 Thread Christophe de Dinechin
> On 20 Feb 2018, at 22:38, Jonathon Jongsma wrote: > > On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: >> From: Christophe de Dinechin >> >> Get rid of C-style 'goto done' in do_capture. >> Get rid of global streamfd, pass it around (cleaned up in later >> patch) >> Fixes a

Re: [Spice-devel] [PATCH spice-gtk v2 2/4] uri: learn to parse spice+tls:// form

2018-02-20 Thread Marc-André Lureau
Hi On Fri, Feb 16, 2018 at 11:30 AM, Daniel P. Berrangé wrote: > On Fri, Feb 16, 2018 at 11:13:06AM +0100, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau >> >> spice:// has a weird scheme encoding, where it can accept both plain >> and tls ports with URI query parameters. However,

Re: [Spice-devel] [PATCH 05/17] Use RAII to cleanup stream in case of exception or return

2018-02-20 Thread Jonathon Jongsma
On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: > From: Christophe de Dinechin > > Get rid of C-style 'goto done' in do_capture. > Get rid of global streamfd, pass it around (cleaned up in later > patch) > Fixes a race condition, make sure we only use stream after opening > > Si

Re: [Spice-devel] [PATCH 11/17] Move read, write and locking into the 'Stream' class

2018-02-20 Thread Jonathon Jongsma
On Tue, 2018-02-20 at 14:29 +0100, Lukáš Hrázký wrote: > On Tue, 2018-02-20 at 10:47 +0100, Christophe de Dinechin wrote: > > > On 20 Feb 2018, at 10:43, Lukáš Hrázký > > > wrote: > > > > > > On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: > > > > From: Christophe de Dinechin >

[Spice-devel] [PATCH spice-streaming-agent v3 1/4] Use exception handling data from streaming device

2018-02-20 Thread Frediano Ziglio
In all paths errors from this function are treated like fatal error, there's no need to handle all manually potentially forgetting to handle errors. Also avoid to deal directly with logging moving the responsibility to other layers. Signed-off-by: Frediano Ziglio --- src/spice-streaming-agent.cp

[Spice-devel] [PATCH spice-streaming-agent v3 0/4] Handle more completely device messages

2018-02-20 Thread Frediano Ziglio
Avoids losing sync with the device. Handle some missing messages. Changes since v2: - fix typo; - use the term "handle" instead of "read"; - return void from handling functions. Changes since v1: - avoid the usage of ERROR macro. Frediano Ziglio (4): Use exception handling data from streaming

[Spice-devel] [PATCH spice-streaming-agent v3 2/4] Separate handling start/stop message from server

2018-02-20 Thread Frediano Ziglio
Prepare to add support for other messages. Signed-off-by: Frediano Ziglio --- src/spice-streaming-agent.cpp | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index 5613934..8d91f2d 100644

[Spice-devel] [PATCH spice-streaming-agent v3 3/4] Handle capabilities

2018-02-20 Thread Frediano Ziglio
Do not bail if the server is attempting to communicate some extensions but just ignore as at the moment we support none. Signed-off-by: Frediano Ziglio --- src/spice-streaming-agent.cpp | 30 ++ 1 file changed, 30 insertions(+) diff --git a/src/spice-streaming-agent.

[Spice-devel] [PATCH spice-streaming-agent v3 4/4] Stub to handle errors from server

2018-02-20 Thread Frediano Ziglio
Base error message handling. Signed-off-by: Frediano Ziglio --- src/spice-streaming-agent.cpp | 9 + 1 file changed, 9 insertions(+) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index 31c655c..343b252 100644 --- a/src/spice-streaming-agent.cpp +++ b/src/spi

Re: [Spice-devel] [PATCH spice-streaming-agent v2 4/5] Handle capabilities

2018-02-20 Thread Frediano Ziglio
> On Tue, 2018-02-20 at 18:33 +0100, Christophe de Dinechin wrote: > > > On 20 Feb 2018, at 15:30, Frediano Ziglio > > > wrote: > > > > > > Do not bail if the server is attempting to communicate some > > > extensions > > > but just ignore as at the moment we support none. > > > > > > Signed-off-

Re: [Spice-devel] [PATCH spice-streaming-agent v2 4/5] Handle capabilities

2018-02-20 Thread Jonathon Jongsma
On Tue, 2018-02-20 at 18:33 +0100, Christophe de Dinechin wrote: > > On 20 Feb 2018, at 15:30, Frediano Ziglio > > wrote: > > > > Do not bail if the server is attempting to communicate some > > extensions > > but just ignore as at the moment we support none. > > > > Signed-off-by: Frediano Zigli

Re: [Spice-devel] [PATCH 05/17] Use RAII to cleanup stream in case of exception or return

2018-02-20 Thread Christophe de Dinechin
[Forgot to send, sorry for delay] > On 19 Feb 2018, at 19:03, Lukáš Hrázký wrote: > > On Fri, 2018-02-16 at 17:59 +0100, Christophe de Dinechin wrote: >>> On 16 Feb 2018, at 17:40, Frediano Ziglio wrote: >>> From: Christophe de Dinechin Get rid of C-style 'goto done' in

Re: [Spice-devel] [PATCH spice-streaming-agent v2 4/5] Handle capabilities

2018-02-20 Thread Christophe de Dinechin
> On 20 Feb 2018, at 15:30, Frediano Ziglio wrote: > > Do not bail if the server is attempting to communicate some extensions > but just ignore as at the moment we support none. > > Signed-off-by: Frediano Ziglio > --- > src/spice-streaming-agent.cpp | 31 +++ > 1 fi

Re: [Spice-devel] [PATCH spice-streaming-agent] Detect and handle exception creating capture engine

2018-02-20 Thread Christophe de Dinechin
> On 20 Feb 2018, at 18:05, Frediano Ziglio wrote: > >>> >>> On 20 Feb 2018, at 17:49, Frediano Ziglio wrote: >>> >>> Currently exception from a plugin are not handled when creating >>> a capture engine. >>> Capture the exception and try to use another plugin instead of >>> bailing out. >>>

Re: [Spice-devel] [PATCH spice-streaming-agent] Detect and handle exception creating capture engine

2018-02-20 Thread Frediano Ziglio
> > > On 20 Feb 2018, at 17:49, Frediano Ziglio wrote: > > > > Currently exception from a plugin are not handled when creating > > a capture engine. > > Capture the exception and try to use another plugin instead of > > bailing out. > > This was tested with an experimental GStreamer plugin. > >

Re: [Spice-devel] [PATCH spice-streaming-agent] Detect and handle exception creating capture engine

2018-02-20 Thread Christophe de Dinechin
> On 20 Feb 2018, at 17:49, Frediano Ziglio wrote: > > Currently exception from a plugin are not handled when creating > a capture engine. > Capture the exception and try to use another plugin instead of > bailing out. > This was tested with an experimental GStreamer plugin. > > Signed-off-by:

[Spice-devel] [PATCH spice-streaming-agent] Detect and handle exception creating capture engine

2018-02-20 Thread Frediano Ziglio
Currently exception from a plugin are not handled when creating a capture engine. Capture the exception and try to use another plugin instead of bailing out. This was tested with an experimental GStreamer plugin. Signed-off-by: Frediano Ziglio --- src/concrete-agent.cpp | 9 - 1 file cha

Re: [Spice-devel] [PATCH 16/17] Remove client_codecs global variable, moved inside the 'Stream' class

2018-02-20 Thread Christophe de Dinechin
> On 20 Feb 2018, at 16:51, Lukáš Hrázký wrote: > > On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: >> From: Christophe de Dinechin >> >> This is not a really nice abstraction at this point, but still a step in the >> right way >> >> Signed-off-by: Christophe de Dinechin >

Re: [Spice-devel] [PATCH 12/17] Convert message writing from C style to C++ style

2018-02-20 Thread Frediano Ziglio
> From: Christophe de Dinechin > > - The Stream class now deals with locking and sending messages > - The Message<> template class deals with the general writing mechanisms > - Three classes, FormatMessage, FrameMessage and X11CursorMessage represent > individual messages > > The various classes

Re: [Spice-devel] [PATCH 17/17] Move the capture loop in the ConcreteAgent, get rid of global agent variable

2018-02-20 Thread Christophe de Dinechin
> On 20 Feb 2018, at 16:53, Lukáš Hrázký wrote: > > On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: >> From: Christophe de Dinechin >> >> Signed-off-by: Christophe de Dinechin >> --- >> src/concrete-agent.hpp| 4 >> src/spice-streaming-agent.cpp | 14 ++-

Re: [Spice-devel] [PATCH 17/17] Move the capture loop in the ConcreteAgent, get rid of global agent variable

2018-02-20 Thread Lukáš Hrázký
On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > src/concrete-agent.hpp| 4 > src/spice-streaming-agent.cpp | 14 ++ > 2 files changed, 10 insertions(+), 8 deletions(-) >

Re: [Spice-devel] [PATCH 16/17] Remove client_codecs global variable, moved inside the 'Stream' class

2018-02-20 Thread Lukáš Hrázký
On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: > From: Christophe de Dinechin > > This is not a really nice abstraction at this point, but still a step in the > right way > > Signed-off-by: Christophe de Dinechin > --- > src/spice-streaming-agent.cpp | 14 +- > 1

Re: [Spice-devel] [PATCH 14/17] Create a class encapsulating the X11 display cursor capture

2018-02-20 Thread Lukáš Hrázký
On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: > From: Christophe de Dinechin > > This class will need to be moved to a separate file in a later patch. > This is done in two steps to make the evolution of the code easier to track, > as well as to facilitate later 'git bisect' >

Re: [Spice-devel] [PATCH 12/17] Convert message writing from C style to C++ style

2018-02-20 Thread Christophe de Dinechin
> On 20 Feb 2018, at 15:29, Lukáš Hrázký wrote: > > On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: >> From: Christophe de Dinechin >> >> - The Stream class now deals with locking and sending messages >> - The Message<> template class deals with the general writing mechanisms

Re: [Spice-devel] [spice-gtk] Add --spice-disable-clipboard option

2018-02-20 Thread Christophe Fergeau
On Tue, Feb 20, 2018 at 12:48:48PM +0100, Victor Toso wrote: > On Thu, Jan 18, 2018 at 10:31:26AM +0100, Christophe Fergeau wrote: > > At least on X.org, malicious code could run the equivalent of "watch > > xsel -o --clipboard" in a VM, and would then be able to track all the > > clipboard content

Re: [Spice-devel] [PATCH spice-streaming-agent 2/6] Separate ERROR macro in a different utility header

2018-02-20 Thread Christophe de Dinechin
> On 20 Feb 2018, at 15:57, Lukáš Hrázký wrote: > > On Tue, 2018-02-20 at 15:48 +0100, Christophe de Dinechin wrote: >>> On 20 Feb 2018, at 15:45, Lukáš Hrázký wrote: >>> >>> On Tue, 2018-02-20 at 15:07 +0100, Christophe de Dinechin wrote: > On 19 Feb 2018, at 17:47, Frediano Ziglio wrot

Re: [Spice-devel] [PATCH spice-streaming-agent 2/6] Separate ERROR macro in a different utility header

2018-02-20 Thread Christophe de Dinechin
> On 20 Feb 2018, at 15:48, Christophe de Dinechin wrote: > > > >> On 20 Feb 2018, at 15:45, Lukáš Hrázký wrote: >> >> On Tue, 2018-02-20 at 15:07 +0100, Christophe de Dinechin wrote: On 19 Feb 2018, at 17:47, Frediano Ziglio wrote: > > On Mon, 2018-02-19 at 15:52 +

Re: [Spice-devel] [PATCH spice-streaming-agent 2/6] Separate ERROR macro in a different utility header

2018-02-20 Thread Lukáš Hrázký
On Tue, 2018-02-20 at 15:48 +0100, Christophe de Dinechin wrote: > > On 20 Feb 2018, at 15:45, Lukáš Hrázký wrote: > > > > On Tue, 2018-02-20 at 15:07 +0100, Christophe de Dinechin wrote: > > > > On 19 Feb 2018, at 17:47, Frediano Ziglio wrote: > > > > > > > > > > > > > > On Mon, 2018-02-19 at

Re: [Spice-devel] [PATCH spice-streaming-agent 2/6] Separate ERROR macro in a different utility header

2018-02-20 Thread Christophe de Dinechin
> On 20 Feb 2018, at 15:45, Lukáš Hrázký wrote: > > On Tue, 2018-02-20 at 15:07 +0100, Christophe de Dinechin wrote: >>> On 19 Feb 2018, at 17:47, Frediano Ziglio wrote: >>> On Mon, 2018-02-19 at 15:52 +, Frediano Ziglio wrote: > Allows to reuse it. > > Signed-off-

Re: [Spice-devel] [PATCH 00/17] WIP: Refactor the streaming agent towards a more standard C++ style

2018-02-20 Thread Christophe de Dinechin
> On 20 Feb 2018, at 15:36, Lukáš Hrázký wrote: > > On Tue, 2018-02-20 at 15:22 +0100, Christophe de Dinechin wrote: >>> On 19 Feb 2018, at 18:29, Lukáš Hrázký wrote: >>> >>> On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: From: Christophe de Dinechin The str

Re: [Spice-devel] [PATCH spice-streaming-agent 2/6] Separate ERROR macro in a different utility header

2018-02-20 Thread Lukáš Hrázký
On Tue, 2018-02-20 at 15:07 +0100, Christophe de Dinechin wrote: > > On 19 Feb 2018, at 17:47, Frediano Ziglio wrote: > > > > > > > > On Mon, 2018-02-19 at 15:52 +, Frediano Ziglio wrote: > > > > Allows to reuse it. > > > > > > > > Signed-off-by: Frediano Ziglio > > > > --- > > > > src/Mak

Re: [Spice-devel] [PATCH 00/17] WIP: Refactor the streaming agent towards a more standard C++ style

2018-02-20 Thread Lukáš Hrázký
On Tue, 2018-02-20 at 15:22 +0100, Christophe de Dinechin wrote: > > On 19 Feb 2018, at 18:29, Lukáš Hrázký wrote: > > > > On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: > > > From: Christophe de Dinechin > > > > > > The streaming agent started as C code. This series converts

[Spice-devel] [PATCH spice-streaming-agent v2 3/5] Separate handling start/stop message from server

2018-02-20 Thread Frediano Ziglio
Prepare to add support for other messages. Signed-off-by: Frediano Ziglio --- src/spice-streaming-agent.cpp | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index 80e3408..d72c30b 100644

[Spice-devel] [PATCH spice-streaming-agent v2 0/5] Handle more completely device messages

2018-02-20 Thread Frediano Ziglio
Avoids losing sync with the device. Handle some missing messages. Changes since v1: - avoid the usage of ERROR macro. Frediano Ziglio (5): Be more restrictive about error handling Use exception handling data from streaming device Separate handling start/stop message from server Handle cap

[Spice-devel] [PATCH spice-streaming-agent v2 4/5] Handle capabilities

2018-02-20 Thread Frediano Ziglio
Do not bail if the server is attempting to communicate some extensions but just ignore as at the moment we support none. Signed-off-by: Frediano Ziglio --- src/spice-streaming-agent.cpp | 31 +++ 1 file changed, 31 insertions(+) diff --git a/src/spice-streaming-agent

[Spice-devel] [PATCH spice-streaming-agent v2 2/5] Use exception handling data from streaming device

2018-02-20 Thread Frediano Ziglio
In all paths errors from this function are treated like fatal error, there's no need to handle all manually potentially forgetting to handle errors. Also avoid to deal directly with logging moving the responsibility to other layers. Signed-off-by: Frediano Ziglio --- src/spice-streaming-agent.cp

[Spice-devel] [PATCH spice-streaming-agent v2 5/5] Stub to handle errors from server

2018-02-20 Thread Frediano Ziglio
Base error message handling. Signed-off-by: Frediano Ziglio --- src/spice-streaming-agent.cpp | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index 9547e49..7ad8c42 100644 --- a/src/spice-streaming-agent.cpp +++ b/src/

[Spice-devel] [PATCH spice-streaming-agent v2 1/5] Be more restrictive about error handling

2018-02-20 Thread Frediano Ziglio
There's no much point in ignoring the error if these errors cause the communication to be out of sync. Ignoring them just change the state to indeterminate. Signed-off-by: Frediano Ziglio --- src/spice-streaming-agent.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/

Re: [Spice-devel] [PATCH 12/17] Convert message writing from C style to C++ style

2018-02-20 Thread Lukáš Hrázký
On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: > From: Christophe de Dinechin > > - The Stream class now deals with locking and sending messages > - The Message<> template class deals with the general writing mechanisms > - Three classes, FormatMessage, FrameMessage and X11Curso

Re: [Spice-devel] [PATCH 00/17] WIP: Refactor the streaming agent towards a more standard C++ style

2018-02-20 Thread Christophe de Dinechin
> On 19 Feb 2018, at 18:29, Lukáš Hrázký wrote: > > On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: >> From: Christophe de Dinechin >> >> The streaming agent started as C code. This series converts >> the style to something that is more usual for C++, notably: >> >> - Adds e

Re: [Spice-devel] [PATCH spice-streaming-agent 2/6] Separate ERROR macro in a different utility header

2018-02-20 Thread Christophe de Dinechin
> On 19 Feb 2018, at 17:47, Frediano Ziglio wrote: > >> >> On Mon, 2018-02-19 at 15:52 +, Frediano Ziglio wrote: >>> Allows to reuse it. >>> >>> Signed-off-by: Frediano Ziglio >>> --- >>> src/Makefile.am| 1 + >>> src/mjpeg-fallback.cpp | 7 +-- >>> src/utils.hpp | 1

Re: [Spice-devel] [PATCH spice-streaming-agent] Remove usage of ERROR macro

2018-02-20 Thread Frediano Ziglio
> > > On 20 Feb 2018, at 13:13, Frediano Ziglio wrote: > > > > Use more simple syntax for throwing errors. > > > > Signed-off-by: Frediano Ziglio > > --- > > src/mjpeg-fallback.cpp | 8 +--- > > 1 file changed, 1 insertion(+), 7 deletions(-) > > > > diff --git a/src/mjpeg-fallback.cpp b/sr

Re: [Spice-devel] [PATCH 11/17] Move read, write and locking into the 'Stream' class

2018-02-20 Thread Lukáš Hrázký
On Tue, 2018-02-20 at 10:47 +0100, Christophe de Dinechin wrote: > > On 20 Feb 2018, at 10:43, Lukáš Hrázký wrote: > > > > On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: > > > From: Christophe de Dinechin > > > > > > Signed-off-by: Christophe de Dinechin > > > --- > > > src/s

Re: [Spice-devel] [PATCH spice-streaming-agent] Remove usage of ERROR macro

2018-02-20 Thread Christophe de Dinechin
> On 20 Feb 2018, at 13:13, Frediano Ziglio wrote: > > Use more simple syntax for throwing errors. > > Signed-off-by: Frediano Ziglio > --- > src/mjpeg-fallback.cpp | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/src/mjpeg-fallback.cpp b/src/mjpeg-fallback.cpp

Re: [Spice-devel] [PATCH spice-streaming-agent] Remove usage of ERROR macro

2018-02-20 Thread Lukáš Hrázký
On Tue, 2018-02-20 at 12:13 +, Frediano Ziglio wrote: > Use more simple syntax for throwing errors. > > Signed-off-by: Frediano Ziglio > --- > src/mjpeg-fallback.cpp | 8 +--- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/src/mjpeg-fallback.cpp b/src/mjpeg-fallback.c

Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/3] mjpeg-fallback: unittest for the options parsing

2018-02-20 Thread Frediano Ziglio
> > Hi, > > On Tue, Feb 20, 2018 at 10:00:41AM +0100, Lukáš Hrázký wrote: > > On Mon, 2018-02-19 at 21:19 +0200, Uri Lublin wrote: > > > On 02/19/2018 06:47 PM, Lukáš Hrázký wrote: > > > > On Mon, 2018-02-19 at 18:29 +0200, Uri Lublin wrote: > > > > > On 02/14/2018 06:37 PM, Christophe Fergeau wr

[Spice-devel] [PATCH spice-streaming-agent] Remove usage of ERROR macro

2018-02-20 Thread Frediano Ziglio
Use more simple syntax for throwing errors. Signed-off-by: Frediano Ziglio --- src/mjpeg-fallback.cpp | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/mjpeg-fallback.cpp b/src/mjpeg-fallback.cpp index cf704c6..fd37167 100644 --- a/src/mjpeg-fallback.cpp +++ b/src/mj

Re: [Spice-devel] [spice-gtk] Add --spice-disable-clipboard option

2018-02-20 Thread Victor Toso
On Thu, Jan 18, 2018 at 10:31:26AM +0100, Christophe Fergeau wrote: > At least on X.org, malicious code could run the equivalent of "watch > xsel -o --clipboard" in a VM, and would then be able to track all the > clipboard content, even when the spice-gtk widget is not focused. > > At the moment,

Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/3] mjpeg-fallback: unittest for the options parsing

2018-02-20 Thread Victor Toso
On Tue, Feb 20, 2018 at 12:22:52PM +0100, Lukáš Hrázký wrote: > On Tue, 2018-02-20 at 11:59 +0100, Victor Toso wrote: > > On Tue, Feb 20, 2018 at 11:45:33AM +0100, Lukáš Hrázký wrote: > > > > That tests are not enabled by default. If we enable it by default > > > > here I would expect to do the sam

Re: [Spice-devel] [PATCH 07/17] Get rid of C-style memset initializations, use C++ style aggregates

2018-02-20 Thread Frediano Ziglio
> > On 20 Feb 2018, at 10:39, Lukáš Hrázký wrote: > > > > On Tue, 2018-02-20 at 10:18 +0100, Christophe de Dinechin wrote: > >>> On Feb 19, 2018, at 7:19 PM, Lukáš Hrázký wrote: > >>> > >>> On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: > From: Christophe de Dinechin > >

Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/3] mjpeg-fallback: unittest for the options parsing

2018-02-20 Thread Lukáš Hrázký
On Tue, 2018-02-20 at 11:59 +0100, Victor Toso wrote: > On Tue, Feb 20, 2018 at 11:45:33AM +0100, Lukáš Hrázký wrote: > > > That tests are not enabled by default. If we enable it by default > > > here I would expect to do the same for other Spice components. > > > > Ok, but I'm somewhat confused h

Re: [Spice-devel] [PATCH 01/17] Add missing header

2018-02-20 Thread Christophe de Dinechin
> On Feb 20, 2018, at 12:05 PM, Frediano Ziglio wrote: > >> On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: >>> From: Christophe de Dinechin >>> >>> Signed-off-by: Christophe de Dinechin >>> --- >>> src/concrete-agent.cpp | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff

Re: [Spice-devel] [PATCH 01/17] Add missing header

2018-02-20 Thread Frediano Ziglio
> On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: > > From: Christophe de Dinechin > > > > Signed-off-by: Christophe de Dinechin > > --- > > src/concrete-agent.cpp | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/src/concrete-agent.cpp b/src/concrete-agent.cpp >

Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/3] mjpeg-fallback: unittest for the options parsing

2018-02-20 Thread Victor Toso
On Tue, Feb 20, 2018 at 11:45:33AM +0100, Lukáš Hrázký wrote: > > That tests are not enabled by default. If we enable it by default > > here I would expect to do the same for other Spice components. > > Ok, but I'm somewhat confused here. Enabling the tests is during > packaging - you run `make ch

Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/3] mjpeg-fallback: unittest for the options parsing

2018-02-20 Thread Lukáš Hrázký
On Tue, 2018-02-20 at 11:34 +0100, Victor Toso wrote: > On Tue, Feb 20, 2018 at 11:21:47AM +0100, Lukáš Hrázký wrote: > > On Tue, 2018-02-20 at 11:02 +0100, Victor Toso wrote: > > > IMHO, tests are a must for development and should be optional > > > on tarballs from releases. That means that packag

Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/3] mjpeg-fallback: unittest for the options parsing

2018-02-20 Thread Victor Toso
On Tue, Feb 20, 2018 at 11:21:47AM +0100, Lukáš Hrázký wrote: > On Tue, 2018-02-20 at 11:02 +0100, Victor Toso wrote: > > IMHO, tests are a must for development and should be optional > > on tarballs from releases. That means that packagers can > > enable it and deal with whatever we do for testing

Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/3] mjpeg-fallback: unittest for the options parsing

2018-02-20 Thread Lukáš Hrázký
On Tue, 2018-02-20 at 11:02 +0100, Victor Toso wrote: > Hi, > > On Tue, Feb 20, 2018 at 10:00:41AM +0100, Lukáš Hrázký wrote: > > On Mon, 2018-02-19 at 21:19 +0200, Uri Lublin wrote: > > > On 02/19/2018 06:47 PM, Lukáš Hrázký wrote: > > > > On Mon, 2018-02-19 at 18:29 +0200, Uri Lublin wrote: > >

Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/3] mjpeg-fallback: unittest for the options parsing

2018-02-20 Thread Victor Toso
Hi, On Tue, Feb 20, 2018 at 10:00:41AM +0100, Lukáš Hrázký wrote: > On Mon, 2018-02-19 at 21:19 +0200, Uri Lublin wrote: > > On 02/19/2018 06:47 PM, Lukáš Hrázký wrote: > > > On Mon, 2018-02-19 at 18:29 +0200, Uri Lublin wrote: > > > > On 02/14/2018 06:37 PM, Christophe Fergeau wrote: > > > > > On

Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/3] mjpeg-fallback: unittest for the options parsing

2018-02-20 Thread Lukáš Hrázký
On Tue, 2018-02-20 at 10:31 +0100, Christophe de Dinechin wrote: > > On 20 Feb 2018, at 10:00, Lukáš Hrázký wrote: > > > > On Mon, 2018-02-19 at 21:19 +0200, Uri Lublin wrote: > > > On 02/19/2018 06:47 PM, Lukáš Hrázký wrote: > > > > On Mon, 2018-02-19 at 18:29 +0200, Uri Lublin wrote: > > > > >

Re: [Spice-devel] [PATCH 11/17] Move read, write and locking into the 'Stream' class

2018-02-20 Thread Christophe de Dinechin
> On 20 Feb 2018, at 10:43, Lukáš Hrázký wrote: > > On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: >> From: Christophe de Dinechin >> >> Signed-off-by: Christophe de Dinechin >> --- >> src/spice-streaming-agent.cpp | 86 >> +++ >> 1 f

Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/3] mjpeg-fallback: unittest for the options parsing

2018-02-20 Thread Christophe Fergeau
On Mon, Feb 19, 2018 at 09:19:18PM +0200, Uri Lublin wrote: > If users prefer to not run autogen.sh that's ok. > It provides defaults options for developers. > For example, I do not expect users to run configure with > --enable-maintainer-mode too. NB: My understanding of https://blogs.gnome.org/

Re: [Spice-devel] [PATCH 07/17] Get rid of C-style memset initializations, use C++ style aggregates

2018-02-20 Thread Christophe de Dinechin
> On 20 Feb 2018, at 10:39, Lukáš Hrázký wrote: > > On Tue, 2018-02-20 at 10:18 +0100, Christophe de Dinechin wrote: >>> On Feb 19, 2018, at 7:19 PM, Lukáš Hrázký wrote: >>> >>> On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: From: Christophe de Dinechin Sign

Re: [Spice-devel] [PATCH 11/17] Move read, write and locking into the 'Stream' class

2018-02-20 Thread Lukáš Hrázký
On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > src/spice-streaming-agent.cpp | 86 > +++ > 1 file changed, 47 insertions(+), 39 deletions(-) > > diff --gi

Re: [Spice-devel] [PATCH 07/17] Get rid of C-style memset initializations, use C++ style aggregates

2018-02-20 Thread Lukáš Hrázký
On Tue, 2018-02-20 at 10:18 +0100, Christophe de Dinechin wrote: > > On Feb 19, 2018, at 7:19 PM, Lukáš Hrázký wrote: > > > > On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: > > > From: Christophe de Dinechin > > > > > > Signed-off-by: Christophe de Dinechin > > > --- > > > sr

Re: [Spice-devel] [PATCH spice-streaming-agent] Add gitlab-ci.yml ci file

2018-02-20 Thread Victor Toso
Hi, On Tue, Feb 20, 2018 at 11:28:47AM +0200, Snir Sheriber wrote: > Hi, > > On 02/20/2018 11:20 AM, Victor Toso wrote: > > Hi, > > > > On Tue, Feb 20, 2018 at 11:10:37AM +0200, Snir Sheriber wrote: > > > Signed-off-by: Snir Sheriber > > > --- > > > .gitlab-ci.yml | 13 + > > > 1

Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/3] mjpeg-fallback: unittest for the options parsing

2018-02-20 Thread Christophe de Dinechin
> On 20 Feb 2018, at 10:00, Lukáš Hrázký wrote: > > On Mon, 2018-02-19 at 21:19 +0200, Uri Lublin wrote: >> On 02/19/2018 06:47 PM, Lukáš Hrázký wrote: >>> On Mon, 2018-02-19 at 18:29 +0200, Uri Lublin wrote: On 02/14/2018 06:37 PM, Christophe Fergeau wrote: > On Wed, Feb 14, 2018 at 1

Re: [Spice-devel] [PATCH spice-streaming-agent] Add gitlab-ci.yml ci file

2018-02-20 Thread Snir Sheriber
Hi, On 02/20/2018 11:20 AM, Victor Toso wrote: Hi, On Tue, Feb 20, 2018 at 11:10:37AM +0200, Snir Sheriber wrote: Signed-off-by: Snir Sheriber --- .gitlab-ci.yml | 13 + 1 file changed, 13 insertions(+) create mode 100644 .gitlab-ci.yml diff --git a/.gitlab-ci.yml b/.gitlab-

Re: [Spice-devel] [PATCH spice-streaming-agent] Add gitlab-ci.yml ci file

2018-02-20 Thread Victor Toso
Hi, On Tue, Feb 20, 2018 at 11:10:37AM +0200, Snir Sheriber wrote: > Signed-off-by: Snir Sheriber > --- > .gitlab-ci.yml | 13 + > 1 file changed, 13 insertions(+) > create mode 100644 .gitlab-ci.yml > > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml > new file mode 100644 > index 00

Re: [Spice-devel] [PATCH 07/17] Get rid of C-style memset initializations, use C++ style aggregates

2018-02-20 Thread Christophe de Dinechin
> On Feb 19, 2018, at 7:19 PM, Lukáš Hrázký wrote: > > On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: >> From: Christophe de Dinechin >> >> Signed-off-by: Christophe de Dinechin >> --- >> src/spice-streaming-agent.cpp | 47 >> ++- >> 1

[Spice-devel] [PATCH spice-streaming-agent] Add gitlab-ci.yml ci file

2018-02-20 Thread Snir Sheriber
Signed-off-by: Snir Sheriber --- .gitlab-ci.yml | 13 + 1 file changed, 13 insertions(+) create mode 100644 .gitlab-ci.yml diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml new file mode 100644 index 000..b74e74f --- /dev/null +++ b/.gitlab-ci.yml @@ -0,0 +1,13 @@ +image: fedora:late

Re: [Spice-devel] [PATCH 10/17] Since we use a namespace, simplify name of local classes

2018-02-20 Thread Lukáš Hrázký
On Fri, 2018-02-16 at 17:15 +0100, Christophe de Dinechin wrote: > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > src/spice-streaming-agent.cpp | 28 ++-- > 1 file changed, 18 insertions(+), 10 deletions(-) > > diff --git a/src/spice-stre

Re: [Spice-devel] [PATCH spice-streaming-agent v3 3/3] mjpeg-fallback: unittest for the options parsing

2018-02-20 Thread Lukáš Hrázký
On Mon, 2018-02-19 at 21:19 +0200, Uri Lublin wrote: > On 02/19/2018 06:47 PM, Lukáš Hrázký wrote: > > On Mon, 2018-02-19 at 18:29 +0200, Uri Lublin wrote: > > > On 02/14/2018 06:37 PM, Christophe Fergeau wrote: > > > > On Wed, Feb 14, 2018 at 10:40:58AM -0500, Frediano Ziglio wrote: > > > > > > >