> On 6 Feb 2018, at 13:23, Lukáš Hrázký wrote:
>
> On Tue, 2018-02-06 at 12:02 +0100, Christophe de Dinechin wrote:
>>> On 25 Jan 2018, at 11:29, Lukáš Hrázký wrote:
>>>
>>> It's a good practice to consistently use std::string in C++ when there
>>> are no special needs for a char *.
>>
>> OK
> On 7 Feb 2018, at 19:39, Jakub Janků wrote:
>
> Hi Christophe,
>
> On Wed, Feb 7, 2018 at 5:12 PM, Christophe de Dinechin
> wrote:
>> Hi Jakub,
>>
>>
>> I have not looked at everything, but here are a few quick notes just from
>> glancing…
>>
>>> On 21 Jan 2018, at 21:03, Jakub Janků w
Hi Christophe,
On Wed, Feb 7, 2018 at 5:12 PM, Christophe de Dinechin
wrote:
> Hi Jakub,
>
>
> I have not looked at everything, but here are a few quick notes just from
> glancing…
>
>> On 21 Jan 2018, at 21:03, Jakub Janků wrote:
>>
>> From: Jakub Janků
>>
>> Place the code that handles clipb
>
> > On 7 Feb 2018, at 14:58, Frediano Ziglio wrote:
> >
> >>
> >> From: Christophe de Dinechin
> >>
> >> Signed-off-by: Christophe de Dinechin
> >> ---
> >> docs/spice_style.txt | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>
> >> diff --git a/docs/spice_style.txt b/docs/spice_style.txt
> On 17 Jan 2018, at 11:16, Javier Celaya wrote:
>
> El vie, 12-01-2018 a las 08:05 -0500, Marc-André Lureau escribió:
>> Hi
>>
>> - Original Message -
>>> On Thu, Jan 11, 2018 at 12:35:36PM -0500, Marc-André Lureau wrote:
> I agree with you that some help from the windowing/toolki
> On 7 Feb 2018, at 17:22, Christophe de Dinechin wrote:
>
> I may be wrong, but I don’t see this series in patchwork (I search based on
> date). If that’s the case, any reason for this?
Answering my own stupidity. The “Done” filter is not preserved when you go back
in your search history…
> On 17 Jan 2018, at 12:31, Frediano Ziglio wrote:
>
> They are now just the same function with same parameters,
> just one calls the other.
>
> Signed-off-by: Frediano Ziglio
> ---
> common/canvas_utils.c | 12 +++-
> 1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/c
I may be wrong, but I don’t see this series in patchwork (I search based on
date). If that’s the case, any reason for this?
Christophe
> On 17 Jan 2018, at 12:31, Frediano Ziglio wrote:
>
> Remove obsolete stuff required for old GDI canvas.
> Actually these stuff were not used.
>
> Frediano Z
Hi Jakub,
I have not looked at everything, but here are a few quick notes just from
glancing…
> On 21 Jan 2018, at 21:03, Jakub Janků wrote:
>
> From: Jakub Janků
>
> Place the code that handles clipboard
> into a separate file - clipboard.c
> ---
> Makefile.am | 2 +
> src/vda
> On 7 Feb 2018, at 14:58, Lukáš Hrázký wrote:
>
> On Wed, 2018-02-07 at 14:44 +0100, Christophe de Dinechin wrote:
>>> On 7 Feb 2018, at 12:12, Lukáš Hrázký wrote:
>>>
>>> On Wed, 2018-02-07 at 11:35 +0100, Christophe de Dinechin wrote:
> On 7 Feb 2018, at 11:01, Frediano Ziglio wrote:
> On 7 Feb 2018, at 14:58, Frediano Ziglio wrote:
>
>>
>> From: Christophe de Dinechin
>>
>> Signed-off-by: Christophe de Dinechin
>> ---
>> docs/spice_style.txt | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/docs/spice_style.txt b/docs/spice_style.txt
>> index ccc60bb3..e352
On Wed, 2018-02-07 at 14:44 +0100, Christophe de Dinechin wrote:
> > On 7 Feb 2018, at 12:12, Lukáš Hrázký wrote:
> >
> > On Wed, 2018-02-07 at 11:35 +0100, Christophe de Dinechin wrote:
> > > > On 7 Feb 2018, at 11:01, Frediano Ziglio wrote:
> > > >
> > > > >
> > > > > From: Christophe de Din
>
> From: Christophe de Dinechin
>
> Signed-off-by: Christophe de Dinechin
> ---
> docs/spice_style.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/docs/spice_style.txt b/docs/spice_style.txt
> index ccc60bb3..e35272ec 100644
> --- a/docs/spice_style.txt
> +++ b/docs/spice_styl
> On 7 Feb 2018, at 12:12, Lukáš Hrázký wrote:
>
> On Wed, 2018-02-07 at 11:35 +0100, Christophe de Dinechin wrote:
>>> On 7 Feb 2018, at 11:01, Frediano Ziglio wrote:
>>>
From: Christophe de Dinechin
Signed-off-by: Christophe de Dinechin
---
docs/spice_style
>
> From: Christophe de Dinechin
>
> Signed-off-by: Christophe de Dinechin
> ---
> docs/spice_style.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/docs/spice_style.txt b/docs/spice_style.txt
> index 74f4e29d..a9d77afa 100644
> --- a/docs/spice_style.txt
> +++ b
>
> From: Christophe de Dinechin
>
> Signed-off-by: Christophe de Dinechin
> ---
> docs/spice_style.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/docs/spice_style.txt b/docs/spice_style.txt
> index e35272ec..780f0615 100644
> --- a/docs/spice_style.txt
> +++ b/d
On Wed, 2018-02-07 at 11:35 +0100, Christophe de Dinechin wrote:
> > On 7 Feb 2018, at 11:01, Frediano Ziglio wrote:
> >
> > >
> > > From: Christophe de Dinechin
> > >
> > > Signed-off-by: Christophe de Dinechin
> > > ---
> > > docs/spice_style.txt | 113
> > >
From: Christophe de Dinechin
As written, the headers style guide looks quite wrong. In particular,
it places headers in an order that makes it hard to detect hidden
dependencies in SPICE headers.
These rules can be enforced by the .clang-format proposed in earlier patch,
locally if you use the E
From: Christophe de Dinechin
Changes in v2:
- This splits the earlier patch about the style guide into its individual
components. This also clarifies the intent of some of the changes in the
commit messages.
- Fixed typos
Christophe de Dinechin (13):
Add .clang-format with defaults match
From: Christophe de Dinechin
Signed-off-by: Christophe de Dinechin
---
docs/spice_style.txt | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/docs/spice_style.txt b/docs/spice_style.txt
index c127f026..72ed2ef7 100644
--- a/docs/spice_style.txt
+++ b/docs/spice_sty
From: Christophe de Dinechin
Signed-off-by: Christophe de Dinechin
---
docs/spice_style.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/docs/spice_style.txt b/docs/spice_style.txt
index ccc60bb3..e35272ec 100644
--- a/docs/spice_style.txt
+++ b/docs/spice_style.txt
@@ -293,6 +293,8 @@
From: Christophe de Dinechin
The indent of the rephrasing is that:
- If you have a single constant, use const, e.g. (visible in debugger)
const unsigned max_stuff = 42;
- If you have multiple constants, prefer enums over #define, as
already suggested later in the guide:
enum {
From: Christophe de Dinechin
The objective of these guidelines is that:
- We avoid introducing new warnings
- We know how to fix old ones
- We don't have to isolate whitespace changes when submitting patches,
i.e. someone who use tools that automatically strip whitespaces and
therefore "repai
From: Christophe de Dinechin
Signed-off-by: Christophe de Dinechin
---
.clang-format | 23 +++
1 file changed, 23 insertions(+)
create mode 100644 .clang-format
diff --git a/.clang-format b/.clang-format
new file mode 100644
index ..339ce846
--- /dev/null
+++ b/.cl
From: Christophe de Dinechin
Signed-off-by: Christophe de Dinechin
---
docs/spice_style.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/spice_style.txt b/docs/spice_style.txt
index eb0e30ef..c127f026 100644
--- a/docs/spice_style.txt
+++ b/docs/spice_style.txt
@@ -1
From: Christophe de Dinechin
Signed-off-by: Christophe de Dinechin
---
docs/spice_style.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/spice_style.txt b/docs/spice_style.txt
index e35272ec..780f0615 100644
--- a/docs/spice_style.txt
+++ b/docs/spice_style.txt
@@ -3
From: Christophe de Dinechin
Signed-off-by: Christophe de Dinechin
---
docs/spice_style.txt | 15 +++
1 file changed, 15 insertions(+)
diff --git a/docs/spice_style.txt b/docs/spice_style.txt
index 780f0615..e2465aa9 100644
--- a/docs/spice_style.txt
+++ b/docs/spice_style.txt
@@ -
From: Christophe de Dinechin
Signed-off-by: Christophe de Dinechin
---
docs/spice_style.txt | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/docs/spice_style.txt b/docs/spice_style.txt
index 72ed2ef7..61cb0701 100644
--- a/docs/spice_style.txt
+++ b/docs/spice_style.txt
From: Christophe de Dinechin
Signed-off-by: Christophe de Dinechin
---
docs/spice_style.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/spice_style.txt b/docs/spice_style.txt
index 3e463d2f..74f4e29d 100644
--- a/docs/spice_style.txt
+++ b/docs/spice_style.txt
@@ -1
From: Christophe de Dinechin
The sentence explaining that example makes no real sense, and
the coding style suggestion is horrendous (not to mention flies in the
face of all automatic indentation tools)
Signed-off-by: Christophe de Dinechin
---
docs/spice_style.txt | 10 +-
1 file chan
From: Christophe de Dinechin
Signed-off-by: Christophe de Dinechin
---
docs/spice_style.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/docs/spice_style.txt b/docs/spice_style.txt
index 74f4e29d..a9d77afa 100644
--- a/docs/spice_style.txt
+++ b/docs/spice_style.txt
@@
> On 7 Feb 2018, at 11:01, Frediano Ziglio wrote:
>
>>
>> From: Christophe de Dinechin
>>
>> Signed-off-by: Christophe de Dinechin
>> ---
>> docs/spice_style.txt | 113
>> ---
>> 1 file changed, 81 insertions(+), 32 deletions(-)
>>
>> diff --g
These style are used by other SPICE projects like spice-streaming-agent.
See discussion "Coding style and naming conventions for C++" at
https://lists.freedesktop.org/archives/spice-devel/2018-January/041562.html.
Signed-off-by: Frediano Ziglio
---
docs/spice_style.txt | 54 +
>
> From: Christophe de Dinechin
>
> Signed-off-by: Christophe de Dinechin
> ---
> docs/spice_style.txt | 113
> ---
> 1 file changed, 81 insertions(+), 32 deletions(-)
>
> diff --git a/docs/spice_style.txt b/docs/spice_style.txt
> index eb0e30
From: Christophe de Dinechin
Signed-off-by: Christophe de Dinechin
---
docs/spice_style.txt | 113 ---
1 file changed, 81 insertions(+), 32 deletions(-)
diff --git a/docs/spice_style.txt b/docs/spice_style.txt
index eb0e30ef..8e2e7363 100644
---
On Wed, 2018-02-07 at 10:10 +0100, Christophe de Dinechin wrote:
> Frediano Ziglio writes:
>
> > These style are used by other SPICE projects like spice-streaming-agent.
> > See discussion "Coding style and naming conventions for C++" at
> > https://lists.freedesktop.org/archives/spice-devel/2018-
>
> Frediano Ziglio writes:
>
> > These style are used by other SPICE projects like spice-streaming-agent.
> > See discussion "Coding style and naming conventions for C++" at
> > https://lists.freedesktop.org/archives/spice-devel/2018-January/041562.html.
> >
> > Signed-off-by: Frediano Ziglio
>
On Wed, 2018-02-07 at 10:10 +0100, Christophe de Dinechin wrote:
> Frediano Ziglio writes:
>
> > These style are used by other SPICE projects like spice-streaming-agent.
> > See discussion "Coding style and naming conventions for C++" at
> > https://lists.freedesktop.org/archives/spice-devel/2018-
Frediano Ziglio writes:
> These style are used by other SPICE projects like spice-streaming-agent.
> See discussion "Coding style and naming conventions for C++" at
> https://lists.freedesktop.org/archives/spice-devel/2018-January/041562.html.
>
> Signed-off-by: Frediano Ziglio
> ---
> docs/spi
39 matches
Mail list logo
