Re: [Spice-devel] spice-vdagent screen resolution auto-adjustment fail

2018-01-31 Thread Pavel Grunt
Hello, I guess in this case the problem is in the guest's desktop environment. The auto-adjustment is implemented in Gnome and the recent KDE. Dmitriy, you can change the environment of your centos 7 guest from Mate to Gnome to check out if it works. Pavel Dne 31. 1. 2018 5:37 odp. napsal uživa

Re: [Spice-devel] Recent connection

2018-01-31 Thread Eduardo Lima (Etrunko)
On 31/01/18 06:05, arons wrote: > Hi, > I've recently installed spice viewer for windows version 6.0. > Everything works really well, I'm really happy about. > The only issue I have is that the "Recent connection" is not populated. > I need to fill the URL in connection address all the time. Can y

Re: [Spice-devel] spice-vdagent screen resolution auto-adjustment fail

2018-01-31 Thread Victor Toso
On Sun, Jan 28, 2018 at 06:50:27PM +0400, Dmitriy Kormulev wrote: > Hi, > Just wonder if there any possible changes to make in > spice-vdagent(d) source code ( I am using spice-vdagent 0.14.0 > ) to make client's screen auto-resizable. I tried but failed. > > Would be extremely grateful for any cl

Re: [Spice-devel] [spice-gtk] build-sys: update spice-common submodule

2018-01-31 Thread Victor Toso
On Wed, Jan 31, 2018 at 03:18:09PM +, Frediano Ziglio wrote: > Import some fixes. Acked-by: Victor Toso > > Frediano Ziglio (2): > canvas: Fix some semi transparent drawing > canvas: Use SPICE_UNALIGNED_CAST to avoid -Wcast-align warnings > > Signed-off-by: Frediano Ziglio > ---

[Spice-devel] [spice-gtk] build-sys: update spice-common submodule

2018-01-31 Thread Frediano Ziglio
Import some fixes. Frediano Ziglio (2): canvas: Fix some semi transparent drawing canvas: Use SPICE_UNALIGNED_CAST to avoid -Wcast-align warnings Signed-off-by: Frediano Ziglio --- Fix https://bugs.freedesktop.org/show_bug.cgi?id=104521 --- spice-common | 2 +- 1 file changed, 1 ins

Re: [Spice-devel] [PATCH spice-common] canvas: Use SPICE_UNALIGNED_CAST to avoid -Wcast-align warnings

2018-01-31 Thread Victor Toso
Hi, On Fri, Jan 19, 2018 at 02:31:35PM +, Frediano Ziglio wrote: > This solves https://bugs.freedesktop.org/show_bug.cgi?id=104521. > > Signed-off-by: Frediano Ziglio > --- > common/canvas_base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/common/canvas_base.c

Re: [Spice-devel] [PATCH spice-server 10/10] utils: Avoid possible unaligned access

2018-01-31 Thread Victor Toso
Hi, On Mon, Jan 22, 2018 at 05:55:02PM +, Frediano Ziglio wrote: > Code in rgb32_data_has_alpha possibly generate this warning using > clang: > > utils.c:35:16: error: cast from 'uint8_t *' (aka 'unsigned char *') to > 'uint32_t *' (aka 'unsigned int *') increases required alignment from 1 t

Re: [Spice-devel] [PATCH spice-streaming-agent 3/4] mjpeg-fallback-test: use BDD structure for test cases

2018-01-31 Thread Frediano Ziglio
> > Behaviour Driven Development defines self-describing, story-like > structures for testing that at the same time document them and > descriptive messages when a test fails. > > Signed-off-by: Lukáš Hrázký > --- > src/unittests/test-mjpeg-fallback.cpp | 88 > +++--

Re: [Spice-devel] [PATCH spice-server 07/10] red-common: Avoid some not used warning using clang

2018-01-31 Thread Victor Toso
Hi, On Mon, Jan 22, 2018 at 05:54:59PM +, Frediano Ziglio wrote: > clang reports lot of warnings like: > > spicevmc.c:47:1: error: unused function 'RED_CHAR_DEVICE_SPICEVMC_CLASS' > [-Werror,-Wunused-function] > SPICE_DECLARE_TYPE(RedCharDeviceSpiceVmc, red_char_device_spicevmc, > CHAR_DEVI

Re: [Spice-devel] [PATCH spice-server 03/10] char-device: Avoid to use unaligned memory

2018-01-31 Thread Victor Toso
Hi, On Mon, Jan 22, 2018 at 05:54:55PM +, Frediano Ziglio wrote: > This causes some warnings with clang: > > char-device.c:898:29: error: cast from 'uint8_t *' (aka 'unsigned char *') to > 'uint32_t *' (aka 'unsigned int *') increases required alignment from 1 to 4 > [-Werror,-Wcast-align]

Re: [Spice-devel] [PATCH spice-server 08/10] sound: Avoid cast that could cause alignment problems

2018-01-31 Thread Victor Toso
Hi, On Mon, Jan 22, 2018 at 05:55:00PM +, Frediano Ziglio wrote: > clang is reporting: > > sound.c:292:16: error: cast from 'uint8_t *' (aka 'unsigned char *') to > 'uint32_t *' (aka 'unsigned int *') increases required alignment from 1 to 4 > [-Werror,-Wcast-align] > data = (uint32

Re: [Spice-devel] [PATCH spice-server 09/10] Avoid some alignment warnings using clang

2018-01-31 Thread Victor Toso
Hi, On Mon, Jan 22, 2018 at 05:55:01PM +, Frediano Ziglio wrote: > clang reports may warnings like: > > test-display-base.c:252:11: error: cast from 'uint8_t *' (aka 'unsigned char > *') to 'uint32_t *' (aka 'unsigned int *') increases required alignment from > 1 to 4 [-Werror,-Wcast-align]

Re: [Spice-devel] [PATCH spice-server 03/10] char-device: Avoid to use unaligned memory

2018-01-31 Thread Victor Toso
Hi, On Mon, Jan 22, 2018 at 05:54:55PM +, Frediano Ziglio wrote: > This causes some warnings with clang: > > char-device.c:898:29: error: cast from 'uint8_t *' (aka 'unsigned char *') to > 'uint32_t *' (aka 'unsigned int *') increases required alignment from 1 to 4 > [-Werror,-Wcast-align]

Re: [Spice-devel] [PATCH spice-server 06/10] tests: Avoid some possible not initialized warning from Clang

2018-01-31 Thread Victor Toso
On Mon, Jan 22, 2018 at 05:54:58PM +, Frediano Ziglio wrote: > Not really possible but clang raise these warnings: Not possible because we would assert... Yes, Acked-by: Victor Toso > > test-sasl.c:555:13: error: variable 'is_ok' is uninitialized when used here > [-Werror,-Wuninitialized]

Re: [Spice-devel] [PATCH spice-server 05/10] replay: Do not use obsolete set_mm_time callback

2018-01-31 Thread Victor Toso
On Mon, Jan 22, 2018 at 05:54:57PM +, Frediano Ziglio wrote: > Marked as obsolete with clang and some options is detected as > error. > > Signed-off-by: Frediano Ziglio Acked-by: Victor Toso > --- > server/tests/replay.c | 5 - > 1 file changed, 5 deletions(-) > > diff --git a/server

Re: [Spice-devel] [PATCH spice-streaming-agent 1/4] configure.ac: remove header check for stream-device.h

2018-01-31 Thread Frediano Ziglio
> > The pkg-config version check should be enough to ensure we have the > correct version of spice-protocol which contains this header. > > Signed-off-by: Lukáš Hrázký Acked-by: Frediano Ziglio I think this was here just for 0.12.13, we forget to remove the additional check, now 0.12.14 has t

[Spice-devel] [PATCH spice-streaming-agent 4/4] mjpeg-fallback: a more C++ way of handling options

2018-01-31 Thread Lukáš Hrázký
Use C++ standard library: - std::string - std::stoi() to parse the numbers (also note atoi() behavior is undefined in case of errors) - exceptions for errors, makes testing and potential future changes to error handling easier. Signed-off-by: Lukáš Hrázký --- src/mjpeg-fallback.cpp | 42

[Spice-devel] [PATCH spice-streaming-agent 3/4] mjpeg-fallback-test: use BDD structure for test cases

2018-01-31 Thread Lukáš Hrázký
Behaviour Driven Development defines self-describing, story-like structures for testing that at the same time document them and descriptive messages when a test fails. Signed-off-by: Lukáš Hrázký --- src/unittests/test-mjpeg-fallback.cpp | 88 +++ 1 file changed,

[Spice-devel] [PATCH spice-streaming-agent 2/4] mjpeg-fallback: unittest for the options parsing

2018-01-31 Thread Lukáš Hrázký
Introduce a unit test framework (Catch) to the codebase and a simple unit test for parsing the options of the mjpeg plugin. Signed-off-by: Lukáš Hrázký --- configure.ac | 3 +++ src/mjpeg-fallback.cpp| 5 src/mjpeg-fallback.hpp| 1

[Spice-devel] [PATCH spice-streaming-agent 0/4] first unit test and options parsing improvements

2018-01-31 Thread Lukáš Hrázký
This series introduces a C++ unit test framework called Catch to the codebase, adds a simple unit test for the options parsing for the mjpeg plugin and improves on the option parsing code. It depends on the header split-off from the previous patch set ([PATCH spice-streaming-agent 1/2] mjpeg plugi

[Spice-devel] [PATCH spice-streaming-agent 1/4] configure.ac: remove header check for stream-device.h

2018-01-31 Thread Lukáš Hrázký
The pkg-config version check should be enough to ensure we have the correct version of spice-protocol which contains this header. Signed-off-by: Lukáš Hrázký --- configure.ac | 4 1 file changed, 4 deletions(-) diff --git a/configure.ac b/configure.ac index 1d86200..8795dae 100644 --- a/co

Re: [Spice-devel] [PATCH spice-streaming-agent 1/2] mjpeg plugin: split off the declaration into a header

2018-01-31 Thread Christophe de Dinechin
> On 31 Jan 2018, at 12:26, Frediano Ziglio wrote: > >>> >>> On 30 Jan 2018, at 17:54, Frediano Ziglio wrote: >>> > > On 30 Jan 2018, at 13:29, Lukáš Hrázký wrote: > > On Tue, 2018-01-30 at 06:32 -0500, Frediano Ziglio wrote: >>> >>> So that the plugin can later b

Re: [Spice-devel] [PATCH spice-streaming-agent 1/2] mjpeg plugin: split off the declaration into a header

2018-01-31 Thread Frediano Ziglio
> > > On 30 Jan 2018, at 17:54, Frediano Ziglio wrote: > > > >>> > >>> On 30 Jan 2018, at 13:29, Lukáš Hrázký wrote: > >>> > >>> On Tue, 2018-01-30 at 06:32 -0500, Frediano Ziglio wrote: > > > > So that the plugin can later be included in a unit test. > > > > Signed-off-by:

Re: [Spice-devel] [PATCH spice-server v4 0/4] Better handling reset for streaming device

2018-01-31 Thread Frediano Ziglio
> > Christophe de Dinechin writes: > > >> On 30 Jan 2018, at 12:56, Frediano Ziglio wrote: > >> > >>> > >>> Hi Frediano, > >>> > >>> > >>> > On 30 Jan 2018, at 11:50, Frediano Ziglio wrote: > > ping the series > >>> > >>> I’m currently looking at it. Is it supposed to fix the rea

Re: [Spice-devel] [PATCH spice-streaming-agent 1/2] mjpeg plugin: split off the declaration into a header

2018-01-31 Thread Christophe de Dinechin
> On 30 Jan 2018, at 17:54, Frediano Ziglio wrote: > >>> >>> On 30 Jan 2018, at 13:29, Lukáš Hrázký wrote: >>> >>> On Tue, 2018-01-30 at 06:32 -0500, Frediano Ziglio wrote: > > So that the plugin can later be included in a unit test. > > Signed-off-by: Lukáš Hrázký > -

[Spice-devel] Recent connection

2018-01-31 Thread arons
Hi, I've recently installed spice viewer for windows version 6.0. Everything works really well, I'm really happy about. The only issue I have is that the "Recent connection" is not populated. I need to fill the URL in connection address all the time. Thanks Renzo ___