Re: [Spice-devel] [PATCH spice-streaming-agent] build: Do not use top_srcdir if not necessary

2018-01-29 Thread Frediano Ziglio
> > > > On 29 Jan 2018, at 12:00, Frediano Ziglio wrote: > > > > Signed-off-by: Frediano Ziglio > > --- > > Makefile.am | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Makefile.am b/Makefile.am > > index baa9835..74ec16a 100644 > > --- a/Makefile.am > > +++ b

Re: [Spice-devel] [PATCH spice-gtk] Fix setting appsrc properties in i686 arch

2018-01-29 Thread Frediano Ziglio
> > > > > The "max-bytes" property of the appsrc GStreamer element expects a > > 64-bit value. Calling: > > g_object_set(source, "max-bytes", 0, NULL); > > in a 32-bit architecture ends up with a wrong value, it must be cast to > > a long long int: > > g_object_set(source, "max-bytes", 0LL, NULL)

Re: [Spice-devel] Spice just for a remote desktop to a virtual machine?

2018-01-29 Thread Snir Sheriber
Hi True, the process is still as toso mentioned. Currently we are running for some time now in the new instance (which is not openshift) seems stable so far. Snir. On 01/29/2018 04:07 PM, Victor Toso wrote: Hi, On Mon, Jan 29, 2018 at 02:56:19PM +0100, Christophe de Dinechin wrote: On 29 Ja

[Spice-devel] Coding style and naming conventions for C++

2018-01-29 Thread Lukáš Hrázký
Hello everybody, I'd like to discuss a few things about the coding style for C++ in Spice (looking at the streaming agent atm). Trying to keep this short and concise. 1. Method names Currently the method names are in CamelCase throughout the streaming agent. Methods are basically functions atta

Re: [Spice-devel] Spice just for a remote desktop to a virtual machine?

2018-01-29 Thread Victor Toso
Hi, On Mon, Jan 29, 2018 at 02:56:19PM +0100, Christophe de Dinechin wrote: > > On 29 Jan 2018, at 14:17, Victor Toso wrote: > > On Mon, Jan 29, 2018 at 01:48:17PM +0100, Christophe de Dinechin wrote: > >>> On 29 Jan 2018, at 12:01, Snir Sheriber wrote: > >>> > >>> On 01/29/2018 12:10 PM, Chris

Re: [Spice-devel] Spice just for a remote desktop to a virtual machine?

2018-01-29 Thread Christophe de Dinechin
> On 29 Jan 2018, at 14:17, Victor Toso wrote: > > Hi, > > On Mon, Jan 29, 2018 at 01:48:17PM +0100, Christophe de Dinechin wrote: >>> On 29 Jan 2018, at 12:01, Snir Sheriber wrote: >>> >>> On 01/29/2018 12:10 PM, Christophe de Dinechin wrote: > On 29 Jan 2018, at 11:09, Christophe

Re: [Spice-devel] [PATCH spice-server 04/10] dcc-send: Avoid to use unaligned memory

2018-01-29 Thread Victor Toso
Hi, On Mon, Jan 22, 2018 at 05:54:56PM +, Frediano Ziglio wrote: > This causes some warnings with clang: > > dcc-send.c:1799:28: error: cast from 'uint8_t *' (aka 'unsigned char *') to > 'uint32_t *' (aka 'unsigned int *') increases required alignment from 1 to 4 > [-Werror,-Wcast-align] >

Re: [Spice-devel] [PATCH spice-server 02/10] lz4-encoder: Use GUINT32_TO_BE instead of htonl

2018-01-29 Thread Victor Toso
Hi, On Mon, Jan 29, 2018 at 02:44:55PM +0100, Victor Toso wrote: > Hi, > > On Mon, Jan 22, 2018 at 05:54:54PM +, Frediano Ziglio wrote: > > Just a style change, almost of the code use similar macros for such > > tasks. > > > > Signed-off-by: Frediano Ziglio Btw, you can remove #include no

Re: [Spice-devel] [PATCH spice-server 02/10] lz4-encoder: Use GUINT32_TO_BE instead of htonl

2018-01-29 Thread Victor Toso
Hi, On Mon, Jan 22, 2018 at 05:54:54PM +, Frediano Ziglio wrote: > Just a style change, almost of the code use similar macros for such > tasks. > > Signed-off-by: Frediano Ziglio Right, nothing wrong with htonl() and just a few more in the source code: $ grepi "[hn]to[nh][ls]" * server/

Re: [Spice-devel] [PATCH spice-server 01/10] utils: Use const for rgb32_data_has_alpha data argument

2018-01-29 Thread Victor Toso
Hi, On Mon, Jan 22, 2018 at 05:54:53PM +, Frediano Ziglio wrote: > There's no reason to change data passed, the function just check > the alpha channel of the image. > > Signed-off-by: Frediano Ziglio Acked-by: Victor Toso > --- > server/utils.c | 7 --- > server/utils.h | 2 +- > 2

Re: [Spice-devel] Spice just for a remote desktop to a virtual machine?

2018-01-29 Thread Victor Toso
Hi, On Mon, Jan 29, 2018 at 01:48:17PM +0100, Christophe de Dinechin wrote: > > On 29 Jan 2018, at 12:01, Snir Sheriber wrote: > > > > On 01/29/2018 12:10 PM, Christophe de Dinechin wrote: > >> > >>> On 29 Jan 2018, at 11:09, Christophe de Dinechin > >>> wrote: > >>> > On 26 Jan 2018, a

Re: [Spice-devel] [PATCH spice-streaming-agent] build: Do not use top_srcdir if not necessary

2018-01-29 Thread Christophe de Dinechin
> On 29 Jan 2018, at 12:00, Frediano Ziglio wrote: > > Signed-off-by: Frediano Ziglio > --- > Makefile.am | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Makefile.am b/Makefile.am > index baa9835..74ec16a 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -6,11 +6,

Re: [Spice-devel] Spice just for a remote desktop to a virtual machine?

2018-01-29 Thread Christophe de Dinechin
> On 29 Jan 2018, at 12:01, Snir Sheriber wrote: > > > > On 01/29/2018 12:10 PM, Christophe de Dinechin wrote: >> >>> On 29 Jan 2018, at 11:09, Christophe de Dinechin >>> wrote: >>> >>> On 26 Jan 2018, at 23:11, Marc Dunivan wrote: Is SPICE for the use case of providing

Re: [Spice-devel] Spice just for a remote desktop to a virtual machine?

2018-01-29 Thread Snir Sheriber
On 01/29/2018 12:10 PM, Christophe de Dinechin wrote: On 29 Jan 2018, at 11:09, Christophe de Dinechin wrote: On 26 Jan 2018, at 23:11, Marc Dunivan wrote: Is SPICE for the use case of providing a remote virtual desktop only to a virtual machine’s graphical/desktop environment? Addit

[Spice-devel] [PATCH spice-streaming-agent] build: Do not use top_srcdir if not necessary

2018-01-29 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index baa9835..74ec16a 100644 --- a/Makefile.am +++ b/Makefile.am @@ -6,11 +6,11 @@ SUBDIRS = \ # this will start the program for each user session

Re: [Spice-devel] Spice just for a remote desktop to a virtual machine?

2018-01-29 Thread Christophe de Dinechin
> On 29 Jan 2018, at 11:09, Christophe de Dinechin > wrote: > > >> On 26 Jan 2018, at 23:11, Marc Dunivan wrote: >> >> Is SPICE for the use case of providing a remote virtual desktop only to a >> virtual machine’s graphical/desktop environment? Additionally, the virtual >> machine host m

Re: [Spice-devel] Spice just for a remote desktop to a virtual machine?

2018-01-29 Thread Christophe de Dinechin
> On 26 Jan 2018, at 23:11, Marc Dunivan wrote: > > Is SPICE for the use case of providing a remote virtual desktop only to a > virtual machine’s graphical/desktop environment? Additionally, the virtual > machine host must be a Linux OS, correct...SPICE server only runs on Linux? > > SPICE c

Re: [Spice-devel] [PATCH spice-streaming-agent 1/2] Wait to have some client before initialising capture

2018-01-29 Thread Christophe de Dinechin
> On 1 Dec 2017, at 17:56, Frediano Ziglio wrote: > >> >> On Tue, 2017-11-21 at 09:49 +, Frediano Ziglio wrote: >>> This saves some resources if no client are connected. >>> Also will allow to get a better capture engine taking into account >>> client supported codecs. >>> >>> Signed-off-

Re: [Spice-devel] [PATCH spice-streaming-agent 2/2] Do not use an encoding not supported by the client

2018-01-29 Thread Christophe de Dinechin
Ack > On 29 Jan 2018, at 10:56, Frediano Ziglio wrote: > > ping > >> >>> >>> On Tue, 2017-11-21 at 09:49 +, Frediano Ziglio wrote: This allows for instance old clients to work correctly. Signed-off-by: Frediano Ziglio --- src/concrete-agent.cpp| 5 -

Re: [Spice-devel] [PATCH spice-streaming-agent 2/2] Do not use an encoding not supported by the client

2018-01-29 Thread Frediano Ziglio
ping > > > > > On Tue, 2017-11-21 at 09:49 +, Frediano Ziglio wrote: > > > This allows for instance old clients to work correctly. > > > > > > Signed-off-by: Frediano Ziglio > > > --- > > > src/concrete-agent.cpp| 5 - > > > src/concrete-agent.hpp| 3 ++- > > > src/spi

Re: [Spice-devel] [PATCH spice-streaming-agent 1/2] Wait to have some client before initialising capture

2018-01-29 Thread Frediano Ziglio
ping > > > > > On Tue, 2017-11-21 at 09:49 +, Frediano Ziglio wrote: > > > This saves some resources if no client are connected. > > > Also will allow to get a better capture engine taking into account > > > client supported codecs. > > > > > > Signed-off-by: Frediano Ziglio > > > --- > >

Re: [Spice-devel] Spice just for a remote desktop to a virtual machine?

2018-01-29 Thread Uri Lublin
On 01/27/2018 12:11 AM, Marc Dunivan wrote: Is SPICE for the use case of providing a remote virtual desktop only to a virtual machine’s graphical/desktop environment? Hi, There are 2 projects that allow remoting a "non-virtual" desktop: Xspice and x11spice Additionally, the virtual machin

[Spice-devel] Spice just for a remote desktop to a virtual machine?

2018-01-29 Thread Marc Dunivan
Is SPICE for the use case of providing a remote virtual desktop only to a virtual machine’s graphical/desktop environment? Additionally, the virtual machine host must be a Linux OS, correct...SPICE server only runs on Linux? SPICE can’t be used to obtain a remote desktop from a Fedora GNOME PC

[Spice-devel] SUSE 91 / SUSE 93 supported xf86 Version

2018-01-29 Thread RalfBuhrmann
Dear Spice-Developer, i'm a civilian Employer in the the German Navy and have a little Problem. We are using a Linux-Based Trainer Software using SUSE 9.1 and 9.3. With our new Hardware, we have vitualise and try to use QEMU and: use ONE 4K Monitor to view three "Screens" in it (2 times 1200 x

[Spice-devel] spice-vdagent screen resolution auto-adjustment fail

2018-01-29 Thread Dmitriy Kormulev
Hi, Just wonder if there any possible changes to make in spice-vdagent(d) source code ( I am using spice-vdagent 0.14.0 ) to make client's screen auto-resizable. I tried but failed. Would be extremely grateful for any clue. The screen resolution is adjusted only once during - for the first ti