Re: [Spice-devel] intel vgpu framebuffer encoding & spice

2018-01-24 Thread Zhenyu Wang
On 2018.01.24 03:59:27 -0500, Frediano Ziglio wrote: > There's not currently a remote solution as far as I know. > The experimental patches sent on September 2016 were already using > correcly gst_dmabuf_* functions without texture read back, the problem > with GStreamer are stability and licensing

Re: [Spice-devel] [PATCH spice-streaming-agent 0/4] Minor improvements and cosmetics

2018-01-24 Thread Frediano Ziglio
> > Hello, > > my first patch set, feel free to nitpick :) > > Just an assortment of small improvements, there will be a followup email for > some general coding style and some more use of C++ standard library. > > Lukáš Hrázký (4): > use spaces around '=' at the end of methods declaration >

[Spice-devel] [PATCH spice-streaming-agent 4/4] better error message when opening streaming device

2018-01-24 Thread Lukáš Hrázký
Signed-off-by: Lukáš Hrázký --- src/spice-streaming-agent.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index 87e8fa3..0200e4a 100644 --- a/src/spice-streaming-agent.cpp +++ b/src/spice-streaming-agent.cpp @

[Spice-devel] [PATCH spice-streaming-agent 4/4] better error handling when opening streaming device

2018-01-24 Thread Lukáš Hrázký
Signed-off-by: Lukáš Hrázký --- src/spice-streaming-agent.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index 87e8fa3..0200e4a 100644 --- a/src/spice-streaming-agent.cpp +++ b/src/spice-streaming-agent.cpp @

[Spice-devel] [PATCH spice-streaming-agent 3/4] use std::string where it's easy to replace

2018-01-24 Thread Lukáš Hrázký
Signed-off-by: Lukáš Hrázký --- src/concrete-agent.cpp| 10 +- src/concrete-agent.hpp| 4 ++-- src/spice-streaming-agent.cpp | 6 +++--- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/concrete-agent.cpp b/src/concrete-agent.cpp index 9f1295a..b7d4bf

[Spice-devel] [PATCH spice-streaming-agent 1/4] use spaces around '=' at the end of methods declaration

2018-01-24 Thread Lukáš Hrázký
Signed-off-by: Lukáš Hrázký --- include/spice-streaming-agent/frame-capture.hpp | 14 +++--- include/spice-streaming-agent/plugin.hpp| 14 +++--- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/include/spice-streaming-agent/frame-capture.hpp b/include/spi

[Spice-devel] [PATCH spice-streaming-agent 2/4] replace tabs with 8 spaces

2018-01-24 Thread Lukáš Hrázký
Signed-off-by: Lukáš Hrázký --- src/spice-streaming-agent.cpp | 40 1 file changed, 20 insertions(+), 20 deletions(-) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index 53ffbf0..f36921d 100644 --- a/src/spice-streaming-agent.

[Spice-devel] [PATCH spice-streaming-agent 0/4] Minor improvements and cosmetics

2018-01-24 Thread Lukáš Hrázký
Hello, my first patch set, feel free to nitpick :) Just an assortment of small improvements, there will be a followup email for some general coding style and some more use of C++ standard library. Lukáš Hrázký (4): use spaces around '=' at the end of methods declaration replace tabs with 8 s

Re: [Spice-devel] [spice-gtk] GDI canvas cleanup

2018-01-24 Thread Frediano Ziglio
> > Hi, > > On 01/18/2018 04:53 PM, Frediano Ziglio wrote: > > GDI canvas support was removed from spice-common as not even > > compiling for a long time. > > This requires some changed to spice-gtk too. > > > > Frediano Ziglio (14): > >canvas: Simplify code using spice_memdup > >

Re: [Spice-devel] [PATCH spice-common] canvas: Prevent some error compiling spice-gtk

2018-01-24 Thread Frediano Ziglio
> > On 01/23/2018 01:27 PM, Frediano Ziglio wrote: > > ping > > > > Currently master is failing to compiler, see > > https://gitlab.com/spice/spice-gtk/-/jobs > > > > This is supposed to be the patch in spice-gtk that take the spice-common > > changes: > > https://lists.freedesktop.org/archives/

Re: [Spice-devel] [PATCH spice-common] canvas: Prevent some error compiling spice-gtk

2018-01-24 Thread Uri Lublin
On 01/23/2018 01:27 PM, Frediano Ziglio wrote: ping Currently master is failing to compiler, see https://gitlab.com/spice/spice-gtk/-/jobs This is supposed to be the patch in spice-gtk that take the spice-common changes: https://lists.freedesktop.org/archives/spice-devel/2018-January/041472.ht

Re: [Spice-devel] [spice-gtk] GDI canvas cleanup

2018-01-24 Thread Snir Sheriber
Hi, On 01/18/2018 04:53 PM, Frediano Ziglio wrote: GDI canvas support was removed from spice-common as not even compiling for a long time. This requires some changed to spice-gtk too. Frediano Ziglio (14): canvas: Simplify code using spice_memdup canvas: Remove possible leak on LZ

Re: [Spice-devel] [PATCH] Fix build with LibreSSL

2018-01-24 Thread Paweł Pękala
Frediano Ziglio wrote: > > > > Frediano Ziglio wrote: > > > > > > Hi Frediano, > > > > > > > > On 2018-01-22 06:04 -0500, Frediano Ziglio > > > > wrote: > > > > >> > > > > >> Hello, > > > > >> spice-gtk fails to build with LibreSSL: > > > > >> > > > > >> libtool: link: cc -o > > > > >>

Re: [Spice-devel] [PATCH spice-common] canvas: Fix some semi transparent drawing

2018-01-24 Thread Frediano Ziglio
> > This is reproducible using desktop icons on Windows XP. > > These drawing are sent for the icons on the desktop. > To get an extends.x1 >= 32 you have to move an icon out of the > screen on the right side. Set the icon size to 72 as the icon has Here is "left side", not left. > to be out of

Re: [Spice-devel] intel vgpu framebuffer encoding & spice

2018-01-24 Thread Frediano Ziglio
There's not currently a remote solution as far as I know. The experimental patches sent on September 2016 were already using correcly gst_dmabuf_* functions without texture read back, the problem with GStreamer are stability and licensing. Licensing as missing some package (due to license) for enco