[Spice-devel] intel vgpu framebuffer encoding & spice

2018-01-23 Thread Zhang, Tina
Hi, We'd like to know if there is a plan or any progress on proper remote display by encoding vgpu's framebuffers as video directly through dma-buf file descriptors. The current remote display solution is using texture readback, which has performance loss. As SPICE can use GStreamer to encode

[Spice-devel] [PATCH spice-common] canvas: Fix some semi transparent drawing

2018-01-23 Thread Frediano Ziglio
This is reproducible using desktop icons on Windows XP. These drawing are sent for the icons on the desktop. To get an extends.x1 >= 32 you have to move an icon out of the screen on the right side. Set the icon size to 72 as the icon has to be out of the screen quite a lot. Disable the grid alignm

Re: [Spice-devel] Wrong math in spice-common common/canvas_base.c ?

2018-01-23 Thread Frediano Ziglio
> > > > > Hi, > > was looking at usage of SPICE_UNALIGNED_CAST and I found this code: > > > > > > /* round down X to even 32 pixels (i.e. uint32_t) */ > > extents.x1 = extents.x1 & ~(0x1f); > > > > mask_data_src = (uint8_t *)mask_data + mask_stride * extents.y1 + > > extents.

Re: [Spice-devel] Wrong math in spice-common common/canvas_base.c ?

2018-01-23 Thread Frediano Ziglio
> > Hi, > was looking at usage of SPICE_UNALIGNED_CAST and I found this code: > > > /* round down X to even 32 pixels (i.e. uint32_t) */ > extents.x1 = extents.x1 & ~(0x1f); > > mask_data_src = (uint8_t *)mask_data + mask_stride * extents.y1 + > extents.x1 / 32; > mask_dat

Re: [Spice-devel] [PATCH spice-common] canvas: Prevent some error compiling spice-gtk

2018-01-23 Thread Frediano Ziglio
ping Currently master is failing to compiler, see https://gitlab.com/spice/spice-gtk/-/jobs This is supposed to be the patch in spice-gtk that take the spice-common changes: https://lists.freedesktop.org/archives/spice-devel/2018-January/041472.html Frediano > > Due to different warning setti

[Spice-devel] Wrong math in spice-common common/canvas_base.c ?

2018-01-23 Thread Frediano Ziglio
Hi, was looking at usage of SPICE_UNALIGNED_CAST and I found this code: /* round down X to even 32 pixels (i.e. uint32_t) */ extents.x1 = extents.x1 & ~(0x1f); mask_data_src = (uint8_t *)mask_data + mask_stride * extents.y1 + extents.x1 / 32; mask_data = SPICE_UNALIGNED_CAST(u

Re: [Spice-devel] [PATCH] Fix build with LibreSSL

2018-01-23 Thread Paweł Pękala
Frediano Ziglio wrote: > > Hi Frediano, > > > > On 2018-01-22 06:04 -0500, Frediano Ziglio > > wrote: > > >> > > >> Hello, > > >> spice-gtk fails to build with LibreSSL: > > >> > > >> libtool: link: cc -o > > >> /usr/local/ports/deskutils/spice-gtk/work/spice-gtk-0.34/src/tmp-introspectM6ai

Re: [Spice-devel] [PATCH] Fix build with LibreSSL

2018-01-23 Thread Paweł Pękala
Hi Frediano, On 2018-01-22 06:04 -0500, Frediano Ziglio wrote: >> >> Hello, >> spice-gtk fails to build with LibreSSL: >> >> libtool: link: cc -o >> /usr/local/ports/deskutils/spice-gtk/work/spice-gtk-0.34/src/tmp-introspectM6aimR/.libs/SpiceClientGLib-2.0 >> -isystem /usr/local/include -I/usr/

Re: [Spice-devel] [PATCH] Fix build with LibreSSL

2018-01-23 Thread Frediano Ziglio
> > Frediano Ziglio wrote: > > > > Hi Frediano, > > > > > > On 2018-01-22 06:04 -0500, Frediano Ziglio > > > wrote: > > > >> > > > >> Hello, > > > >> spice-gtk fails to build with LibreSSL: > > > >> > > > >> libtool: link: cc -o > > > >> /usr/local/ports/deskutils/spice-gtk/work/spice-gtk-0.

Re: [Spice-devel] [PATCH] Fix build with LibreSSL

2018-01-23 Thread Frediano Ziglio
> Hi Frediano, > > On 2018-01-22 06:04 -0500, Frediano Ziglio wrote: > >> > >> Hello, > >> spice-gtk fails to build with LibreSSL: > >> > >> libtool: link: cc -o > >> /usr/local/ports/deskutils/spice-gtk/work/spice-gtk-0.34/src/tmp-introspectM6aimR/.libs/SpiceClientGLib-2.0 > >> -isystem /usr/l

[Spice-devel] [spice-gtk] Fix build with LibreSSL

2018-01-23 Thread Frediano Ziglio
From: Paweł Pękala FreeBSD uses LibreSSL instead of OpenSSL. The two libraries are really similar but need some minimal adjustment. Signed-off-by: Paweł Pękala Acked-by: Frediano Ziglio --- src/bio-gio.c | 2 +- src/spice-channel.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-

[Spice-devel] [PATCH spice-common] Fix build with LibreSSL

2018-01-23 Thread Frediano Ziglio
From: Paweł Pękala FreeBSD uses LibreSSL instead of OpenSSL. The two libraries are really similar but need some minimal adjustment. Signed-off-by: Paweł Pękala Acked-by: Frediano Ziglio --- common/ssl_verify.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/ssl_veri