Re: [Spice-devel] [PATCH spice-server v3 07/12] test-sasl: Add tests for different mechanism names

2018-01-04 Thread Christophe Fergeau
Ok, Acked-by: Christophe Fergeau On Fri, Dec 22, 2017 at 10:07:08AM +, Frediano Ziglio wrote: > Try different connections with different tricky names. > > Signed-off-by: Frediano Ziglio > --- > server/tests/test-sasl.c | 60 > > 1 file chan

Re: [Spice-devel] [PATCH spice-server v3 06/12] test-sasl: Base test, connect using SASL

2018-01-04 Thread Christophe Fergeau
On Fri, Dec 22, 2017 at 10:07:07AM +, Frediano Ziglio wrote: > Create a thread that emulate a client and start SASL authentication ".. that emulates .." > > Signed-off-by: Frediano Ziglio > --- > server/tests/test-sasl.c | 236 > ++- > 1 file ch

Re: [Spice-devel] [PATCH spice-server v3 07/12] test-sasl: Add tests for different mechanism names

2018-01-04 Thread Christophe Fergeau
On Fri, Dec 22, 2017 at 10:07:08AM +, Frediano Ziglio wrote: > @@ -395,16 +427,32 @@ idle_next_test(void *arg) > { > // end previous test > if (test_num >= 0) { > -g_assert(encode_called); > +const TestData *data = &tests_data[test_num]; > +if (data->success)

Re: [Spice-devel] [PATCH spice-server v3 05/12] test-sasl: Add code for mocking function to test state

2018-01-04 Thread Christophe Fergeau
In the shortlog, "Add code *to* mocking functions .."? On Fri, Dec 22, 2017 at 10:07:06AM +, Frediano Ziglio wrote: > Check some functions are called in a given sequence. > > Signed-off-by: Frediano Ziglio > --- > server/tests/test-sasl.c | 19 +++ > 1 file changed, 19 inser

Re: [Spice-devel] [PATCH spice-server v3 04/12] test-sasl: Initial SASL test

2018-01-04 Thread Christophe Fergeau
On Fri, Dec 22, 2017 at 10:07:05AM +, Frediano Ziglio wrote: > +int > +main(int argc, char *argv[]) > +{ > +return 0; > +} > +#else > +int > +main(void) > +{ > +return 0; > +} > +#endif Have you considered disabling the test in Makefile.am when SASL is not available? Christophe sign

Re: [Spice-devel] [PATCH spice-server v3 02/12] red-stream: Avoid infinite loop on sasl_encode/decode failure

2018-01-04 Thread Christophe Fergeau
On Fri, Dec 22, 2017 at 10:07:03AM +, Frediano Ziglio wrote: > These functions do not set errno so is possible that errno is EAGAIN. I would be a little bit more explicit: "errno is EAGAIN" -> "errno has a stale value which happens to be EAGAIN" Acked-by: Christophe Fergeau > This would cau

[Spice-devel] Windows Guest Tools 0.141

2018-01-04 Thread Christophe Fergeau
Hi, A new release of the SPICE Guest Tools for Windows is available at https://www.spice-space.org/download/windows/spice-guest-tools/spice-guest-tools-0.141/spice-guest-tools-0.141.exe The SPICE Guest Tools for Windows is an all-in-one installer which will install the virtio drivers, the QXL dri

Re: [Spice-devel] [spice-gtk 2/2] Implement GObject::constructed rather than ::constructor

2018-01-04 Thread Marc-André Lureau
Hi - Original Message - > A few classes are implementing GObject::constructor, which is more > cumbersome to use than ::constructed. Other classes use ::constructed > rather than ::constructor. This commit removes the last uses of > ::constructor. > > Signed-off-by: Christophe Fergeau P

Re: [Spice-devel] [spice-gtk 1/2] session: Remove unused spice_gtk_session_get_read_only prototype

2018-01-04 Thread Marc-André Lureau
- Original Message - > There is no such function implemented anywhere in the codebase. > > Signed-off-by: Christophe Fergeau ack, originally introduced in 222e25a029 > --- > src/spice-gtk-session-priv.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/spice-gtk-session-pr

[Spice-devel] [spice-gtk 2/2] Implement GObject::constructed rather than ::constructor

2018-01-04 Thread Christophe Fergeau
A few classes are implementing GObject::constructor, which is more cumbersome to use than ::constructed. Other classes use ::constructed rather than ::constructor. This commit removes the last uses of ::constructor. Signed-off-by: Christophe Fergeau --- src/spice-gtk-session.c | 20 -

[Spice-devel] [spice-gtk 1/2] session: Remove unused spice_gtk_session_get_read_only prototype

2018-01-04 Thread Christophe Fergeau
There is no such function implemented anywhere in the codebase. Signed-off-by: Christophe Fergeau --- src/spice-gtk-session-priv.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/spice-gtk-session-priv.h b/src/spice-gtk-session-priv.h index d7fe3133..0dbc9e96 100644 --- a/src/spice-gtk-se

Re: [Spice-devel] [PATCH spice-gtk 1/2] gstreamer: use custom playbin sink

2018-01-04 Thread Christophe Fergeau
On Sun, Dec 31, 2017 at 05:46:24PM +0200, Snir Sheriber wrote: > Use custom playbin sink instead of just appsink. > In order to allow playbin to choose decoders that requires > more complex pipelines (e.g. pipeline that requires color > space conversion & uses gl memory). What is gstreamer take on