[Spice-devel] [PATCH spice-gtk] MainChannel: Fix incorrect deprecations

2017-12-07 Thread Jonathon Jongsma
Both spice_main_set_display() and spice_main_set_display_enabled() were deprecated in favor of the same functions with the spice_main_channel_ prefix. However, these new functions were never introduced. Since these functions merely call spice_main_channel_update_display() with a constant TRUE argum

Re: [Spice-devel] [spice-server] build: Rebuild shared library when symbol file changes

2017-12-07 Thread Christophe Fergeau
On Thu, Dec 07, 2017 at 11:19:18AM -0500, Frediano Ziglio wrote: > > > > At the moment, changing spice-server.syms to add/remove a new symbol to > > be exported does not regenerate spice-server.so. This commit added the > > needed dependency for this to work. > > > > Signed-off-by: Christophe Fer

Re: [Spice-devel] [spice-server] build: Rebuild shared library when symbol file changes

2017-12-07 Thread Frediano Ziglio
> > At the moment, changing spice-server.syms to add/remove a new symbol to > be exported does not regenerate spice-server.so. This commit added the > needed dependency for this to work. > > Signed-off-by: Christophe Fergeau > --- > server/Makefile.am | 1 + > 1 file changed, 1 insertion(+) >

[Spice-devel] [spice-server] build: Rebuild shared library when symbol file changes

2017-12-07 Thread Christophe Fergeau
At the moment, changing spice-server.syms to add/remove a new symbol to be exported does not regenerate spice-server.so. This commit added the needed dependency for this to work. Signed-off-by: Christophe Fergeau --- server/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/server/M

Re: [Spice-devel] [PATCH spice-server] Do not compute stream_id more that necessary

2017-12-07 Thread Christophe Fergeau
On Thu, Dec 07, 2017 at 10:26:57AM -0500, Frediano Ziglio wrote: > > > > Hi, > > > > On Thu, Dec 07, 2017 at 12:26:43PM +, Frediano Ziglio wrote: > > > Reuse already computed value and avoid to compute in every > > > iterations. > > > > > > Signed-off-by: Frediano Ziglio > > > --- > > > se

Re: [Spice-devel] [PATCH spice-server] Do not compute stream_id more that necessary

2017-12-07 Thread Frediano Ziglio
> > Hi, > > On Thu, Dec 07, 2017 at 12:26:43PM +, Frediano Ziglio wrote: > > Reuse already computed value and avoid to compute in every > > iterations. > > > > Signed-off-by: Frediano Ziglio > > --- > > server/dcc-send.c | 4 ++-- > > server/video-stream.c | 2 +- > > 2 files changed,

Re: [Spice-devel] [PATCH spice-server 3/9] reds: Remove RedVDIReadBuf pooling code

2017-12-07 Thread Victor Toso
Hi, On Thu, Dec 07, 2017 at 07:32:10AM -0500, Frediano Ziglio wrote: > > > > Hi, > > > > On Tue, Dec 05, 2017 at 08:41:06AM +, Frediano Ziglio wrote: > > > Originally this pool was used to avoid allocation/deallocations. > > > However the introduction of GList cause the code to do dynamic >

Re: [Spice-devel] [PATCH spice-server] Do not compute stream_id more that necessary

2017-12-07 Thread Victor Toso
Hi, On Thu, Dec 07, 2017 at 12:26:43PM +, Frediano Ziglio wrote: > Reuse already computed value and avoid to compute in every > iterations. > > Signed-off-by: Frediano Ziglio > --- > server/dcc-send.c | 4 ++-- > server/video-stream.c | 2 +- > 2 files changed, 3 insertions(+), 3 deleti

Re: [Spice-devel] [PATCH spice-server 3/9] reds: Remove RedVDIReadBuf pooling code

2017-12-07 Thread Frediano Ziglio
> > Hi, > > On Tue, Dec 05, 2017 at 08:41:06AM +, Frediano Ziglio wrote: > > Originally this pool was used to avoid allocation/deallocations. > > However the introduction of GList cause the code to do dynamic > > allocations in order to update the list making this pooling > > something useles

[Spice-devel] [PATCH spice-server] Do not compute stream_id more that necessary

2017-12-07 Thread Frediano Ziglio
Reuse already computed value and avoid to compute in every iterations. Signed-off-by: Frediano Ziglio --- server/dcc-send.c | 4 ++-- server/video-stream.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/server/dcc-send.c b/server/dcc-send.c index 975b222a..828a472f 10

Re: [Spice-devel] [NSIS] packaging: bump version to 4.3

2017-12-07 Thread Christophe Fergeau
Sure, Acked-by: Christophe Fergeau On Tue, Dec 05, 2017 at 05:31:02PM +0200, Yedidyah Bar David wrote: > Change-Id: I1bfcf05a48d3af8226061f47d76ba64e9a16c61a > Signed-off-by: Yedidyah Bar David > --- > ovirt-guest-tools-iso.spec.in | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) >

[Spice-devel] [PATCH spice-server v2 2/2] stream-device: Implements properly device reset on open/close

2017-12-07 Thread Frediano Ziglio
Due to the way Qemu handle the device we must consume all pending data inside the callback to read data from the device. We need to consume all data from previous device dialog to avoid that next device usage is still seeing old data. This as Qemu return 0 if you call SpiceCharDeviceInterface::read

[Spice-devel] [PATCH spice-server v2 1/2] test-stream-device: Better Qemu emulation for data reading

2017-12-07 Thread Frediano Ziglio
Qemu does not trigger a new data read if we don't read all data in the buffer. Signed-off-by: Frediano Ziglio --- server/stream-device.c| 9 server/tests/test-stream-device.c | 43 +-- 2 files changed, 50 insertions(+), 2 deletions(-) Ch