[Spice-devel] [PATCH spice-server 1/2] test-stream-device: Better Qemu emulation for data reading

2017-12-06 Thread Frediano Ziglio
Qemu does not trigger a new data read if we don't read all data in the buffer. Signed-off-by: Frediano Ziglio --- server/stream-device.c| 6 ++ server/tests/test-stream-device.c | 8 ++-- 2 files changed, 12 insertions(+), 2 deletions(-) Maybe would be better to use a loop i

[Spice-devel] [PATCH spice-server 2/2] stream-device: Implements properly device reset on open/close

2017-12-06 Thread Frediano Ziglio
Due to the way Qemu handle the device we must consume all pending data inside the callback to read data from the device. We need to consume all data from previous device dialog to avoid that next device usage is still seeing old data. This as Qemu returns 0 if you call SpiceCharDeviceInterface::rea

Re: [Spice-devel] [PATCH vdagent v4 3/4] refetch _NET_WM_NAME in vdagent_x11_has_icons_on_desktop()

2017-12-06 Thread Victor Toso
On Wed, Dec 06, 2017 at 04:18:25PM +0100, Victor Toso wrote: > > > --- a/src/vdagent/x11.c > > > +++ b/src/vdagent/x11.c > > > @@ -228,18 +228,18 @@ struct vdagent_x11 *vdagent_x11_create(struct > > > udscs_connection *vdagentd, > > > } > > > vdagent_x11_send_daemon_guest_xorg_res(x11, 1)

Re: [Spice-devel] [PATCH vdagent v4 4/4] x11: update wms_with_icons_on_desktop[] to support Mate

2017-12-06 Thread Victor Toso
Hi, On Tue, Dec 05, 2017 at 07:45:53PM +0100, Jakub Janků wrote: > Since version 1.9.2, Marco sets _NET_WM_NAME to "Metacity (Marco)" > instead of "Marco", see: > > http://git.mate-desktop.org/marco/commit/?id=cbf24f5d78719b930fc0cd6c0c80e00e9d62c95a Awesome, thanks! > Add this new value to wms

Re: [Spice-devel] [PATCH vdagent v4 3/4] refetch _NET_WM_NAME in vdagent_x11_has_icons_on_desktop()

2017-12-06 Thread Victor Toso
Hi, On Tue, Dec 05, 2017 at 07:57:16PM +0100, Jakub Janků wrote: > On Tue, 2017-12-05 at 19:45 +0100, Jakub Janků wrote: > > Don't cache _NET_WM_NAME, instead refetch it with each > > vdagent_x11_has_icons_on_desktop() call so that correct result is > > returned > > even if the window manager chan

Re: [Spice-devel] [PATCH vdagent v4 2/4] retrieve _NET_WM_NAME using GDK

2017-12-06 Thread Victor Toso
Hi, On Tue, Dec 05, 2017 at 07:45:51PM +0100, Jakub Janků wrote: > Get _NET_WM_NAME using gdk_x11_screen_get_window_manager_name(). > vdagent_x11_get_wm_name(): return the name instead of setting it. > Return string specifics: > - "unsupported", when not running on X11 > - "unknown", when the name

Re: [Spice-devel] [PATCH vdagent v4 1/4] vdagent: add GTK+

2017-12-06 Thread Victor Toso
On Tue, Dec 05, 2017 at 07:45:50PM +0100, Jakub Janků wrote: > This is a preparatory patch for GTK+ vdagent redesign. > > Since most of the vdagent code still uses X11 lib, > force GDK to use X11 backend by calling > gdk_set_allowed_backends("x11"). Acked-by: Victor Toso > --- > Makefile.am

Re: [Spice-devel] [PATCH spice-server 2/7] VideoStream: store channel in stream

2017-12-06 Thread Frediano Ziglio
> > On 12/04/2017 06:07 PM, Frediano Ziglio wrote: > >> > >> On 11/29/2017 10:16 PM, Jonathon Jongsma wrote: > >>> This allows us to unref the stream directly rather than needing to pass > >>> the associated DisplayChannel to stream_unref(). The same is also true > >>> for stream_agent_unref, sinc