On Tue, 2017-12-05 at 19:45 +0100, Jakub Janků wrote:
> Don't cache _NET_WM_NAME, instead refetch it with each
> vdagent_x11_has_icons_on_desktop() call so that correct result is
> returned
> even if the window manager changes during the lifetime of vdagent_x11
> struct.
> Remove char *net_wm_name
Since version 1.9.2, Marco sets _NET_WM_NAME to "Metacity (Marco)"
instead of "Marco", see:
http://git.mate-desktop.org/marco/commit/?id=cbf24f5d78719b930fc0cd6c0c80e00e9d62c95a
Add this new value to wms_with_icons_on_desktop[], so that
vdagent_x11_has_icons_on_desktop() returns TRUE.
---
src/vd
Don't cache _NET_WM_NAME, instead refetch it with each
vdagent_x11_has_icons_on_desktop() call so that correct result is returned
even if the window manager changes during the lifetime of vdagent_x11 struct.
Remove char *net_wm_name from vdagent_x11.
Remove x11 argument from vdagent_x11_has_icons_
This is a preparatory patch for GTK+ vdagent redesign.
Since most of the vdagent code still uses X11 lib,
force GDK to use X11 backend by calling
gdk_set_allowed_backends("x11").
---
Makefile.am | 2 ++
configure.ac | 1 +
src/vdagent/vdagent.c | 5 +
3 files changed, 8 ins
Get _NET_WM_NAME using gdk_x11_screen_get_window_manager_name().
vdagent_x11_get_wm_name(): return the name instead of setting it.
Return string specifics:
- "unsupported", when not running on X11
- "unknown", when the name cannot be retrieved
Since the return value is never NULL, remove obsolete c
Change-Id: I1bfcf05a48d3af8226061f47d76ba64e9a16c61a
Signed-off-by: Yedidyah Bar David
---
ovirt-guest-tools-iso.spec.in | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/ovirt-guest-tools-iso.spec.in b/ovirt-guest-tools-iso.spec.in
index 04fee49..19ed5c9 100644
--- a/ovirt-
>
> Hi,
>
> On Tue, Dec 05, 2017 at 03:58:56AM -0500, Frediano Ziglio wrote:
> > >
> > > From: Victor Toso
> > >
> > > On migration, Qemu notify spice-server with the current Guest volume
> > > and mute state values which currently is handled forwarding these
> > > values to the client.
> > >
On 12/05/2017 10:41 AM, Frediano Ziglio wrote:
RedVDIReadBuf::data is a static allocated buffer so checking for
NULL on it is useless. It would be NULL only if RedVDIReadBuf
pointer would be the opposite, in value, of the offset of
data field into it.
Signed-off-by: Frediano Ziglio
Acked-by:
Hi,
On Tue, Dec 05, 2017 at 03:58:56AM -0500, Frediano Ziglio wrote:
> >
> > From: Victor Toso
> >
> > On migration, Qemu notify spice-server with the current Guest volume
> > and mute state values which currently is handled forwarding these
> > values to the client.
> >
> > This patch is a co
Hi,
On Tue, Dec 05, 2017 at 08:41:03AM +, Frediano Ziglio wrote:
> Not strictly related.
> Some are just style ones.
>
> Frediano Ziglio (9):
> reds: Use GLib memory functions for RedVDIReadBuf
> reds: Remove leak of agent_dev
> reds: Remove RedVDIReadBuf pooling code
So, ack all patch
Hi,
On Tue, Dec 05, 2017 at 09:54:17AM +0100, Victor Toso wrote:
> From: Frediano Ziglio
>
> There's no reason to handle this message in a different
> way in MainChannel and InputsChannel, the default handling
> will return true in any case.
>
> Signed-off-by: Frediano Ziglio
> ---
>
> Rebase
On Tue, Dec 05, 2017 at 08:41:09AM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/main-channel.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Acked-by: Victor Toso
>
> diff --git a/server/main-channel.c b/server/main-channel.c
> index 34f54768..
Hi,
On Tue, Dec 05, 2017 at 08:41:06AM +, Frediano Ziglio wrote:
> Originally this pool was used to avoid allocation/deallocations.
> However the introduction of GList cause the code to do dynamic
> allocations in order to update the list making this pooling
> something useless.
> The buffers
On Tue, Dec 05, 2017 at 08:41:08AM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
Acked-by: Victor Toso
> ---
> server/main-channel.c | 6 ++
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/server/main-channel.c b/server/main-channel.c
> index f5c079f3..
On Tue, Dec 05, 2017 at 08:41:07AM +, Frediano Ziglio wrote:
> If there is a channel client there's surely a related channel.
>
> Signed-off-by: Frediano Ziglio
Acked-by: Victor Toso
> ---
> server/main-channel.c | 4
> 1 file changed, 4 deletions(-)
>
> diff --git a/server/main-cha
Hi,
On Tue, Dec 05, 2017 at 04:28:52AM -0500, Frediano Ziglio wrote:
> >
> > On Tue, Dec 05, 2017 at 04:14:10AM -0500, Frediano Ziglio wrote:
> > > >
> > > > Hi,
> > > >
> > > > On Tue, Dec 05, 2017 at 08:41:04AM +, Frediano Ziglio wrote:
> > > > > Signed-off-by: Frediano Ziglio
> > > >
>
On Fri, Dec 01, 2017 at 05:15:41AM -0500, Frediano Ziglio wrote:
> Can we have a bit more details?
> Which OS and version is running the VM? Which resolution and color depth?
> Which OS and version (Windows x64 SP1 is not a version) is running the
> client? Which resolution and color depth?
> D
On 12/04/2017 06:07 PM, Frediano Ziglio wrote:
On 11/29/2017 10:16 PM, Jonathon Jongsma wrote:
This allows us to unref the stream directly rather than needing to pass
the associated DisplayChannel to stream_unref(). The same is also true
for stream_agent_unref, since the only reason that stream
>
> On Tue, Dec 05, 2017 at 04:14:10AM -0500, Frediano Ziglio wrote:
> > >
> > > Hi,
> > >
> > > On Tue, Dec 05, 2017 at 08:41:04AM +, Frediano Ziglio wrote:
> > > > Signed-off-by: Frediano Ziglio
> > >
> > > > ---
> > > > server/reds.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 de
On Tue, Dec 05, 2017 at 04:14:10AM -0500, Frediano Ziglio wrote:
> >
> > Hi,
> >
> > On Tue, Dec 05, 2017 at 08:41:04AM +, Frediano Ziglio wrote:
> > > Signed-off-by: Frediano Ziglio
> >
> > > ---
> > > server/reds.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > >
>
> Hi,
>
> On Tue, Dec 05, 2017 at 08:41:04AM +, Frediano Ziglio wrote:
> > Signed-off-by: Frediano Ziglio
>
> > ---
> > server/reds.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/server/reds.c b/server/reds.c
> > index 64b3a967..4e652253 100644
> > ---
Hi,
On Tue, Dec 05, 2017 at 08:41:05AM +, Frediano Ziglio wrote:
> This object was not freed.
AND, you are fixing the leak in the object itself, no?
One patch should be fine but adding that in commit log should do no
harm.
Still,
Acked-by: Victor Toso
> Signed-off-by: Frediano Ziglio
> --
Hi,
On Tue, Dec 05, 2017 at 08:41:04AM +, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/reds.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/server/reds.c b/server/reds.c
> index 64b3a967..4e652253 100644
> --- a/server/reds.c
> +++ b/ser
>
> From: Victor Toso
>
> On migration, Qemu notify spice-server with the current Guest volume
> and mute state values which currently is handled forwarding these
> values to the client.
>
> This patch is a complement of f10de4bc084fcc - Here, volume was
> jumping regardless of guest's volume v
From: Frediano Ziglio
There's no reason to handle this message in a different
way in MainChannel and InputsChannel, the default handling
will return true in any case.
Signed-off-by: Frediano Ziglio
---
Rebased to apply cleanly.
server/inputs-channel.c | 2 --
server/main-channel.c | 2 --
Signed-off-by: Frediano Ziglio
---
server/main-channel.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/server/main-channel.c b/server/main-channel.c
index 34f54768..68386b61 100644
--- a/server/main-channel.c
+++ b/server/main-channel.c
@@ -207,6 +207,9 @@ static bool
There's no reason to handle this message in a different
way in MainChannel and InputsChannel, the default handling
will return true in any case.
Signed-off-by: Frediano Ziglio
---
server/inputs-channel.c | 2 --
server/main-channel.c | 2 --
2 files changed, 4 deletions(-)
diff --git a/server
Already defined by GLib headers.
Signed-off-by: Frediano Ziglio
---
server/tests/test-vdagent.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/server/tests/test-vdagent.c b/server/tests/test-vdagent.c
index 01308d0d..c734ddec 100644
--- a/server/tests/test-vdagent.c
+++ b/server/tests/t
RedVDIReadBuf::data is a static allocated buffer so checking for
NULL on it is useless. It would be NULL only if RedVDIReadBuf
pointer would be the opposite, in value, of the offset of
data field into it.
Signed-off-by: Frediano Ziglio
---
Maybe this check should just be removed?
---
server/reds
Signed-off-by: Frediano Ziglio
---
server/main-channel.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/server/main-channel.c b/server/main-channel.c
index f5c079f3..34f54768 100644
--- a/server/main-channel.c
+++ b/server/main-channel.c
@@ -177,10 +177,9 @@ static bool
Signed-off-by: Frediano Ziglio
---
server/reds.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/server/reds.c b/server/reds.c
index 64b3a967..4e652253 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -4519,7 +4519,7 @@ red_char_device_vdi_port_init(RedCharDeviceVDIPort *self
This object was not freed.
Signed-off-by: Frediano Ziglio
---
server/reds.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/server/reds.c b/server/reds.c
index 4e652253..40c82ccc 100644
--- a/server/reds.c
+++ b/server/reds.c
@@ -3754,6 +3754,7 @@ SPICE_GNUC_VISIBLE v
Not strictly related.
Some are just style ones.
Frediano Ziglio (9):
reds: Use GLib memory functions for RedVDIReadBuf
reds: Remove leak of agent_dev
reds: Remove RedVDIReadBuf pooling code
main-channel: Remove useless check
main-channel: Remove brackets if not needed
main-channel: Put
Originally this pool was used to avoid allocation/deallocations.
However the introduction of GList cause the code to do dynamic
allocations in order to update the list making this pooling
something useless.
The buffers limitation is now implemented with a simple counter.
Signed-off-by: Frediano Zi
If there is a channel client there's surely a related channel.
Signed-off-by: Frediano Ziglio
---
server/main-channel.c | 4
1 file changed, 4 deletions(-)
diff --git a/server/main-channel.c b/server/main-channel.c
index 43ab39ae..f5c079f3 100644
--- a/server/main-channel.c
+++ b/server/ma
35 matches
Mail list logo
