[Spice-devel] [PATCH spice-server 2/2] Rename StreamAgent to VideoStreamAgent

Just to avoid confusion between different uses of the word Stream (e.g. RedStream) clarify that it's related to video streams Signed-off-by: Jonathon Jongsma --- server/dcc-private.h | 2 +- server/dcc-send.c| 14 +++-- server/dcc.c | 10 - server/dcc.h

[Spice-devel] [PATCH spice-server 1/2] Rename Stream to VideoStream

To prevent confusion between Stream (a video stream) and RedStream (a generic data stream between client and server), change the name to VideoStream to be more explicit about what it is. Signed-off-by: Jonathon Jongsma --- server/Makefile.am | 4 +- server/dcc-private.h

[Spice-devel] [PATCH spice-server v2] StreamDevice: Handle incomplete reads of StreamMsgFormat

This is currently unlikely to happen since we communicate over a pipe and the pipe buffer is sufficiently large to avoid splitting the message. But for completeness, we should handle this scenario. Signed-off-by: Jonathon Jongsma --- Since v1: - updates from Frediano's review - bumps spice-prot

Re: [Spice-devel] [PATCH spice-streaming-agent v4 5/5] Move all stream-related functions within SpiceStream class

> Frediano Ziglio writes: > > >> > >> From: Christophe de Dinechin > >> > >> This incidentally fixes a race condition processing X events, > >> where we could possibly start sending cursor events to the > >> stream before it was actually open. > >> > >> Signed-off-by: Christophe de Dinechin > >>

Re: [Spice-devel] [PATCH spice-streaming-agent 3/3] Externalize plugins usage

> On 15 Nov 2017, at 12:15, Frediano Ziglio wrote: > >> >> From: Christophe de Dinechin >> >> Signed-off-by: Christophe de Dinechin >> --- >> include/spice-streaming-agent/plugin.hpp | 6 ++ >> src/concrete-agent.cpp | 11 +++ >> src/concrete-agent.hpp

Re: [Spice-devel] [PATCH spice-streaming-agent 2/3] Rework option handling

> > From: Christophe de Dinechin > > Several functional objectives: > > 1. Be able to share some common options, e.g. fps > 2. Prepare for the possibility to update options on the fly > > Also get rid of the null-terminated C++ vector > > Signed-off-by: Christophe de Dinechin > --- > includ

Re: [Spice-devel] [PATCH spice-streaming-agent 3/3] Externalize plugins usage

> > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > include/spice-streaming-agent/plugin.hpp | 6 ++ > src/concrete-agent.cpp | 11 +++ > src/concrete-agent.hpp | 1 + > src/spice-streaming-agent.cpp|

Re: [Spice-devel] [PATCH spice-streaming-agent 2/3] Rework option handling

> On 14 Nov 2017, at 16:53, Christophe de Dinechin > wrote: > > > >> On 14 Nov 2017, at 16:41, Frediano Ziglio > > wrote: >> >>> >>> From: Christophe de Dinechin >> > >>> >>> Several functional objectives: >>> >>> 1. Be able to share

Re: [Spice-devel] [PATCH spice-streaming-agent 1/3] Don't tag the plugin interface as 1.0 just yet

> > Hi, > > On Tue, Nov 14, 2017 at 04:41:46PM +0100, Christophe de Dinechin wrote: > > > > > > > On 14 Nov 2017, at 16:22, Frediano Ziglio wrote: > > > > > >> > > >> From: Christophe de Dinechin > > >> > > >> Signed-off-by: Christophe de Dinechin > > >> --- > > >> include/spice-streaming

Re: [Spice-devel] [PATCH spice-streaming-agent 1/3] Don't tag the plugin interface as 1.0 just yet

Hi, On Tue, Nov 14, 2017 at 04:41:46PM +0100, Christophe de Dinechin wrote: > > > > On 14 Nov 2017, at 16:22, Frediano Ziglio wrote: > > > >> > >> From: Christophe de Dinechin > >> > >> Signed-off-by: Christophe de Dinechin > >> --- > >> include/spice-streaming-agent/plugin.hpp | 2 +- > >>

Re: [Spice-devel] [PATCH spice-streaming-agent 1/3] Don't tag the plugin interface as 1.0 just yet

> On 15 Nov 2017, at 10:52, Frediano Ziglio wrote: > > On 14 Nov 2017, at 16:57, Frediano Ziglio wrote: > > > On 14 Nov 2017, at 16:22, Frediano Ziglio wrote: > > > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > include/spice-streaming-agent/plugin.hpp |

Re: [Spice-devel] [PATCH spice-streaming-agent 1/3] Don't tag the plugin interface as 1.0 just yet

> On 14 Nov 2017, at 16:57, Frediano Ziglio < fzig...@redhat.com > wrote: > > > > On 14 Nov 2017, at 16:22, Frediano Ziglio < fzig...@redhat.com > wrote: > > > > > > > > > > > From: Christophe de Dinechin < dinec...@redhat.com > > > > > > > > > > > > > > > > Signed-off-by: Christophe de Di

[Spice-devel] [PATCH spice-streaming-agent] Use true/false for bool value

Follow up due to read_command declaration change. Signed-off-by: Frediano Ziglio --- src/spice-streaming-agent.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index d5984bc..23b9768 100644 --- a/src/spice-s

Re: [Spice-devel] [PATCH spice-server] stream-channel: Tell client we are just streaming data

> > Frediano Ziglio writes: > > > This give an hint to client which can optimise rendering. > > > > Signed-off-by: Frediano Ziglio > > --- > > server/stream-channel.c | 6 ++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/server/stream-channel.c b/server/stream-channel.c > > index