Re: [Spice-devel] [PATCH spice-streaming-agent v4 3/5] Switch 'blocking' flag to bool

2017-11-10 Thread Frediano Ziglio
> > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > src/spice-streaming-agent.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp > index 1090517..973192b 100644 > --- a/src/s

Re: [Spice-devel] [PATCH spice-streaming-agent v4 2/5] style: Use C++ style for declaring structs

2017-11-10 Thread Frediano Ziglio
> > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > src/spice-streaming-agent.cpp | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp > index 7f93687..1090517 100644 >

[Spice-devel] [PATCH spice-streaming-agent v4 1/5] style: Remove useless whitespace

2017-11-10 Thread Christophe de Dinechin
From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- src/spice-streaming-agent.cpp | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index ed7ddb9..7f93687 100644 --- a/src/spice-streaming-ag

[Spice-devel] [PATCH spice-streaming-agent v4 4/5] Use RAII to cleanup stream in case of exception or return

2017-11-10 Thread Christophe de Dinechin
From: Christophe de Dinechin This lets us get rid of C-style 'goto done' in do_capture. Signed-off-by: Christophe de Dinechin --- src/spice-streaming-agent.cpp | 32 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/src/spice-streaming-agent.cpp b

[Spice-devel] [PATCH spice-streaming-agent v4 3/5] Switch 'blocking' flag to bool

2017-11-10 Thread Christophe de Dinechin
From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- src/spice-streaming-agent.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index 1090517..973192b 100644 --- a/src/spice-streaming-agent.cp

[Spice-devel] [PATCH spice-streaming-agent v4 5/5] Move all stream-related functions within SpiceStream class

2017-11-10 Thread Christophe de Dinechin
From: Christophe de Dinechin This incidentally fixes a race condition processing X events, where we could possibly start sending cursor events to the stream before it was actually open. Signed-off-by: Christophe de Dinechin --- src/spice-streaming-agent.cpp | 84 ---

[Spice-devel] [PATCH spice-streaming-agent v4 0/5] Add a SpiceStream class for stream access

2017-11-10 Thread Christophe de Dinechin
From: Christophe de Dinechin Add a SpiceStream that owns the actual stream. This has several benefits: 1. It makes it possible to use proper RAII to deal with the lifetime of the stream file descriptor 2. It opens the door for dealing with multiple streams 3. It removes one global with asso

[Spice-devel] [PATCH spice-streaming-agent v4 2/5] style: Use C++ style for declaring structs

2017-11-10 Thread Christophe de Dinechin
From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- src/spice-streaming-agent.cpp | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index 7f93687..1090517 100644 --- a/src/spice-streami

Re: [Spice-devel] [PATCH spice-streaming-agent v2 3/4] Use RAII to cleanup stream in case of exception or return

2017-11-10 Thread Christophe de Dinechin
Frediano Ziglio writes: >> >> From: Christophe de Dinechin >> >> This lets us get rid of C-style 'goto done' in do_capture. >> >> Signed-off-by: Christophe de Dinechin >> --- >> src/spice-streaming-agent.cpp | 32 >> 1 file changed, 20 insertions(+), 12 deletio

[Spice-devel] [PATCH spice-streaming-agent v3 2/5] style: Use C++ style for declaring structs

2017-11-10 Thread Christophe de Dinechin
From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- src/spice-streaming-agent.cpp | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index 7f93687..1090517 100644 --- a/src/spice-streami

[Spice-devel] [PATCH spice-streaming-agent v3 1/5] style: Remove useless whitespace

2017-11-10 Thread Christophe de Dinechin
From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- src/spice-streaming-agent.cpp | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index ed7ddb9..7f93687 100644 --- a/src/spice-streaming-ag

[Spice-devel] [PATCH spice-streaming-agent v3 4/5] Use RAII to cleanup stream in case of exception or return

2017-11-10 Thread Christophe de Dinechin
From: Christophe de Dinechin This lets us get rid of C-style 'goto done' in do_capture. Signed-off-by: Christophe de Dinechin --- src/spice-streaming-agent.cpp | 32 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/src/spice-streaming-agent.cpp b

[Spice-devel] [PATCH spice-streaming-agent v3 5/5] Move all stream-related functions within SpiceStream class

2017-11-10 Thread Christophe de Dinechin
From: Christophe de Dinechin This incidentally fixes a race condition processing X events, where we could possibly start sending cursor events to the stream before it was actually open. Signed-off-by: Christophe de Dinechin --- src/spice-streaming-agent.cpp | 83 ---

[Spice-devel] [PATCH spice-streaming-agent v3 0/5] Add a SpiceStream class for stream access

2017-11-10 Thread Christophe de Dinechin
From: Christophe de Dinechin Add a SpiceStream that owns the actual stream. This has several benefits: 1. It makes it possible to use proper RAII to deal with the lifetime of the stream file descriptor 2. It opens the door for dealing with multiple streams 3. It removes one global with asso

[Spice-devel] [PATCH spice-streaming-agent v3 3/5] Switch 'blocking' flag to bool

2017-11-10 Thread Christophe de Dinechin
From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- src/spice-streaming-agent.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index 1090517..973192b 100644 --- a/src/spice-streaming-agent.cp

Re: [Spice-devel] [PATCH spice-streaming-agent v2 4/4] Move all stream-related functions within SpiceStream class

2017-11-10 Thread Christophe de Dinechin
> On 10 Nov 2017, at 14:15, Frediano Ziglio wrote: > >> >> From: Christophe de Dinechin >> >> This incidentally fixes a race condition processing X events, >> where we could possibly start sending cursor events to the >> stream before it was actually open. >> >> Signed-off-by: Christophe de

Re: [Spice-devel] intel vgpu & spice & cursor

2017-11-10 Thread Gerd Hoffmann
On Fri, Nov 10, 2017 at 07:33:58AM -0500, Frediano Ziglio wrote: > > > Update, after some kvm forum discussions: seems passing the hotspot > > position is possible, using the vgpu pvinfo mmio page. So it seems > > we don't need a spice server update. > > > > cheers, > > Gerd > > > > Some mor

Re: [Spice-devel] [PATCH spice-streaming-agent v2 4/4] Move all stream-related functions within SpiceStream class

2017-11-10 Thread Frediano Ziglio
> > From: Christophe de Dinechin > > This incidentally fixes a race condition processing X events, > where we could possibly start sending cursor events to the > stream before it was actually open. > > Signed-off-by: Christophe de Dinechin > --- > src/spice-streaming-agent.cpp | 68 > +++

Re: [Spice-devel] [PATCH] usbredirserver: use more popular name instead of usbbus-usbaddr

2017-11-10 Thread Marc-André Lureau
Hi - Original Message - > From: Chen Hanxiao > > Usually we use busnum:devnum for a usb device. > Tools such as lsusb, udev did that. > Our original naming is a little confued. > > Signed-off-by: Chen Hanxiao Reviewed-by: Marc-André Lureau > --- > usbredirserver/usbredirserve

Re: [Spice-devel] [PATCH spice-streaming-agent v2 3/4] Use RAII to cleanup stream in case of exception or return

2017-11-10 Thread Frediano Ziglio
> > From: Christophe de Dinechin > > This lets us get rid of C-style 'goto done' in do_capture. > > Signed-off-by: Christophe de Dinechin > --- > src/spice-streaming-agent.cpp | 32 > 1 file changed, 20 insertions(+), 12 deletions(-) > > diff --git a/src/spic

Re: [Spice-devel] [PATCH spice-streaming-agent v2 2/4] style: Use C++ style for declaring structs

2017-11-10 Thread Frediano Ziglio
> > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > src/spice-streaming-agent.cpp | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp > index 7f93687..1090517 100644 >

Re: [Spice-devel] [PATCH spice-streaming-agent v2 1/4] style: Remove useless whitespace

2017-11-10 Thread Frediano Ziglio
> > From: Christophe de Dinechin > > Signed-off-by: Christophe de Dinechin > --- > src/spice-streaming-agent.cpp | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp > index ed7ddb9..7f93687 100644 > --- a

[Spice-devel] [PATCH spice-streaming-agent v2 4/4] Move all stream-related functions within SpiceStream class

2017-11-10 Thread Christophe de Dinechin
From: Christophe de Dinechin This incidentally fixes a race condition processing X events, where we could possibly start sending cursor events to the stream before it was actually open. Signed-off-by: Christophe de Dinechin --- src/spice-streaming-agent.cpp | 68 +++

[Spice-devel] [PATCH spice-streaming-agent v2 0/4] Add a SpiceStream class for stream access

2017-11-10 Thread Christophe de Dinechin
From: Christophe de Dinechin Add a SpiceStream that owns the actual stream. This has several benefits: 1. It makes it possible to use proper RAII to deal with the lifetime of the stream file descriptor 2. It opens the door for dealing with multiple streams 3. It removes one global with asso

[Spice-devel] [PATCH spice-streaming-agent v2 2/4] style: Use C++ style for declaring structs

2017-11-10 Thread Christophe de Dinechin
From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- src/spice-streaming-agent.cpp | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index 7f93687..1090517 100644 --- a/src/spice-streami

[Spice-devel] [PATCH spice-streaming-agent v2 3/4] Use RAII to cleanup stream in case of exception or return

2017-11-10 Thread Christophe de Dinechin
From: Christophe de Dinechin This lets us get rid of C-style 'goto done' in do_capture. Signed-off-by: Christophe de Dinechin --- src/spice-streaming-agent.cpp | 32 1 file changed, 20 insertions(+), 12 deletions(-) diff --git a/src/spice-streaming-agent.cpp b

[Spice-devel] [PATCH spice-streaming-agent v2 1/4] style: Remove useless whitespace

2017-11-10 Thread Christophe de Dinechin
From: Christophe de Dinechin Signed-off-by: Christophe de Dinechin --- src/spice-streaming-agent.cpp | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/spice-streaming-agent.cpp b/src/spice-streaming-agent.cpp index ed7ddb9..7f93687 100644 --- a/src/spice-streaming-ag

Re: [Spice-devel] intel vgpu & spice & cursor

2017-11-10 Thread Frediano Ziglio
> Hi, > > > > The latter implies client mouse mode isn't going to work, so we need > > > some other way to render the cursor. I see basically two options: > > > > > > > It's a shame not to have client mouse mode support. I wonder if we > > could modify the intel driver to pass along the cursor

Re: [Spice-devel] intel vgpu & spice & cursor

2017-11-10 Thread Gerd Hoffmann
Hi, > > The latter implies client mouse mode isn't going to work, so we need > > some other way to render the cursor. I see basically two options: > > > > It's a shame not to have client mouse mode support. I wonder if we > could modify the intel driver to pass along the cursor details, like

Re: [Spice-devel] [PATCH vdagent v2 2/2] retrieve _NET_WM_NAME using GDK

2017-11-10 Thread Frediano Ziglio
> > String returned by gdk_x11_screen_get_window_manager_name() > is never NULL. If the name cannot be retrieved, "unknown" is returned. > Change in logging behavior: > If debug flag is specified, _NET_WM_NAME is always logged > (either the actual name or "unknown"). > --- > src/vdagent/x11-priv.

Re: [Spice-devel] [PATCH spice-streaming-agent] Use RAII to cleanup stream in case of exception or return

2017-11-10 Thread Christophe Fergeau
On Thu, Nov 09, 2017 at 06:48:08PM +0100, Christophe de Dinechin wrote: > From: Christophe de Dinechin > > This lets us get rid of C-style 'goto done' in do_capture. > > Signed-off-by: Christophe de Dinechin > --- > src/spice-streaming-agent.cpp | 34 -- > 1 fil

[Spice-devel] [PATCH] usbredirserver: use more popular name instead of usbbus-usbaddr

2017-11-10 Thread Chen Hanxiao
From: Chen Hanxiao Usually we use busnum:devnum for a usb device. Tools such as lsusb, udev did that. Our original naming is a little confued. Signed-off-by: Chen Hanxiao --- usbredirserver/usbredirserver.1 | 2 +- usbredirserver/usbredirserver.c | 6 +++--- 2 files changed, 4 insertions

Re: [Spice-devel] [PATCH spice-streaming-agent] Use RAII to cleanup stream in case of exception or return

2017-11-10 Thread Frediano Ziglio
... omissis ... > > > >> @@ -441,7 +448,7 @@ int main(int argc, char* argv[]) > >> if (isatty(fileno(stderr)) && isatty(fileno(stdin))) { > >> stdin_ok = true; > >> } > >> - > >> + > >> openlog("spice-streaming-agent", stdin_ok? (LOG_PERROR|LOG_PID) : > >> LOG_PID, LOG_USE

Re: [Spice-devel] [PATCH spice-streaming-agent] Use RAII to cleanup stream in case of exception or return

2017-11-10 Thread Christophe de Dinechin
> On 10 Nov 2017, at 10:38, Frediano Ziglio wrote: > >> >> From: Christophe de Dinechin >> >> This lets us get rid of C-style 'goto done' in do_capture. >> >> Signed-off-by: Christophe de Dinechin >> --- >> src/spice-streaming-agent.cpp | 34 -- >> 1 file chan

Re: [Spice-devel] [PATCH spice-streaming-agent] Use RAII to cleanup stream in case of exception or return

2017-11-10 Thread Frediano Ziglio
> > From: Christophe de Dinechin > > This lets us get rid of C-style 'goto done' in do_capture. > > Signed-off-by: Christophe de Dinechin > --- > src/spice-streaming-agent.cpp | 34 -- > 1 file changed, 20 insertions(+), 14 deletions(-) > > diff --git a/src/sp