Re: [Spice-devel] Spice OpenGL does not work

2017-11-07 Thread 王杰东
Ok , i will use a desktop processor to try again . But do the errors : "virtio 3d acceleration is not supported" and "egl: no drm render node available , Failed to initializa EGL render node for SPICE GL" result from hardware devices only or some error configurations ? -- Or

Re: [Spice-devel] [3/6] [PATCH spice] Add horizontal mouse wheel support

2017-11-07 Thread Matthew J. Francis
On 07/11/2017 01:49, Christophe Fergeau wrote: One note here, when running a wayland spice-gtk/remote-viewer, the only scroll events I'm getting are GDK_SCROLL_SMOOTH events, I'm not getting any scroll event until I add GDK_SMOOTH_SCROLL_MASK to the events spice-gtk listens to (which results in

Re: [Spice-devel] [PATCH spice-server v2] ci: Install python3 packages to fix compile on new Fedora

2017-11-07 Thread Uri Lublin
On 11/07/2017 06:15 PM, Frediano Ziglio wrote: Fedora 26 removed dependency from python-pyparsing/python-six to python but we require the executable to run some scripts Signed-off-by: Frediano Ziglio Acked-by: Uri Lublin --- .gitlab-ci.yml | 5 - 1 file changed, 4 insertions(+), 1 d

Re: [Spice-devel] [PATCH spice-common 2/2] RFC protocol: Allows to send partial frame data

2017-11-07 Thread Frediano Ziglio
> > Frediano Ziglio writes: > > > Reduce the needs to buffer the entire frame and than send > > and on the other end to wait the entire frame before processing. > > Some encodings allow to start processing before having a full > > frame allowing to reduce latency and buffering with huge frames. >

[Spice-devel] [PATCH spice-common v2] RFC protocol: Allow to specify a surface will be streamed

2017-11-07 Thread Frediano Ziglio
This flag will allow the client to perform some optimisations on output and buffering processing. Old clients will ignore this additional flag. Signed-off-by: Frediano Ziglio --- spice.proto | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) Changes since v1: - explain how to avoid

[Spice-devel] [PATCH spice-server v2] ci: Install python3 packages to fix compile on new Fedora

2017-11-07 Thread Frediano Ziglio
Fedora 26 removed dependency from python-pyparsing/python-six to python but we require the executable to run some scripts Signed-off-by: Frediano Ziglio --- .gitlab-ci.yml | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) Changes since v1: - use python 3 packages See https://gitlab.com

Re: [Spice-devel] [PATCH spice-server] ci: Install python binary to fix compile on new Fedora

2017-11-07 Thread Christophe Fergeau
On Tue, Nov 07, 2017 at 03:17:31PM +, Frediano Ziglio wrote: > Fedora 26 removed dependency from python-pyparsing/python-six > to python but we require the executable to run some scripts I'd much prefer that this explicitly installs python3-pyparsing/python3-six (python3 being the future ;). T

[Spice-devel] [PATCH spice-server] ci: Install python binary to fix compile on new Fedora

2017-11-07 Thread Frediano Ziglio
Fedora 26 removed dependency from python-pyparsing/python-six to python but we require the executable to run some scripts Signed-off-by: Frediano Ziglio --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 6074a3d2..40c4dac5

Re: [Spice-devel] [PATCH spice-common 1/3] ring: Remove __ring_remove function

2017-11-07 Thread Christophe de Dinechin
Frediano Ziglio writes: >> >> Frediano Ziglio writes: >> >> > Is just used by ring_remove, no reason to have it. >> >> Nack. I think there is a good reason: the code and its intent is much >> clearer with a "ring_remove" name. >> > > Don't get it... are you saying __ring_remove name is more clear

Re: [Spice-devel] [PATCH spice-common v2] canvas_base: Allow to specify constant operations

2017-11-07 Thread Christophe de Dinechin
Frediano Ziglio writes: > There's no need for the canvas operations to be changed. > This allows without casts to have the operation structures > constants in the code. > This potentially allows to reduce attack surface having some > more data constant instead or read/write. > > Signed-off-by: Fr

Re: [Spice-devel] Spice OpenGL does not work

2017-11-07 Thread Frediano Ziglio
The idea of Virgl is to use the host card GPU 3D capabilities to accelerate/provide 3D rendering. Your card is mainly a 2D VGA card, really useful for remote system administration but quite useless for Virgl. Desktop processors integrate an Intel GPU which is enough for Virgl. About ATI/NVIDI

[Spice-devel] [PATCH spice-common v2] canvas_base: Allow to specify constant operations

2017-11-07 Thread Frediano Ziglio
There's no need for the canvas operations to be changed. This allows without casts to have the operation structures constants in the code. This potentially allows to reduce attack surface having some more data constant instead or read/write. Signed-off-by: Frediano Ziglio --- common/canvas_base.

Re: [Spice-devel] [PATCH spice-common 1/3] ring: Remove __ring_remove function

2017-11-07 Thread Frediano Ziglio
> > Frediano Ziglio writes: > > > Is just used by ring_remove, no reason to have it. > > Nack. I think there is a good reason: the code and its intent is much > clearer with a "ring_remove" name. > Don't get it... are you saying __ring_remove name is more clear than ring_remove ? > > > > > S

Re: [Spice-devel] [PATCH v4 1/8] Bump GLib version to 2.34

2017-11-07 Thread Jakub Janků
On Tue, Nov 7, 2017, 12:20 PM Christophe de Dinechin < christophe.de.dinec...@gmail.com> wrote: > Frediano Ziglio writes: > > > From: Jakub Janků > > > > This is required for the following GMainLoop integration, > > which utilizes some of the new functions/definitions, namely: > > > > [definition

Re: [Spice-devel] [PATCH spice-common 1/2] RFC protocol: Allow to specify a surface will be streamed

2017-11-07 Thread Frediano Ziglio
> > Frediano Ziglio writes: > > > This flag will allow the client to perform some optimisations > > on output and buffering processing. > > Old clients will ignore this additional flag. > > > > Signed-off-by: Frediano Ziglio > > --- > > spice.proto | 3 ++- > > 1 file changed, 2 insertions(+),

Re: [Spice-devel] [PATCH spice-common 2/3] ring: Remove short living temporary variable

2017-11-07 Thread Christophe de Dinechin
Frediano Ziglio writes: > Just a style change, the variable does not help readability. > > Signed-off-by: Frediano Ziglio Acked-by: Christophe de Dinechin > --- > common/ring.h | 10 ++ > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/common/ring.h b/common/ring.h >

Re: [Spice-devel] [PATCH spice-common 3/3] canvas_base: Allow to specify constant operations

2017-11-07 Thread Christophe de Dinechin
Frediano Ziglio writes: > There's no need for the canvas operations to be changed. > This allows without casts to have the operation structures > constants in the code. > This potentially allows to reduce attach surface having some Typo: "attack surface". And you are really talking about the com

Re: [Spice-devel] [PATCH spice-common 1/3] ring: Remove __ring_remove function

2017-11-07 Thread Christophe de Dinechin
Frediano Ziglio writes: > Is just used by ring_remove, no reason to have it. Nack. I think there is a good reason: the code and its intent is much clearer with a "ring_remove" name. > > Signed-off-by: Frediano Ziglio > --- > common/ring.h | 11 +++ > 1 file changed, 3 insertions(+),

Re: [Spice-devel] [PATCH v4 1/8] Bump GLib version to 2.34

2017-11-07 Thread Christophe de Dinechin
Frediano Ziglio writes: > From: Jakub Janků > > This is required for the following GMainLoop integration, > which utilizes some of the new functions/definitions, namely: > > [definition][GLib version] > g_clear_pointer() 2.34 > G_SOURCE_REMOVE 2.32 > G_SOURCE_CONTINUE 2.32 > g_unix_signal

Re: [Spice-devel] [PATCH spice-common 1/2] RFC protocol: Allow to specify a surface will be streamed

2017-11-07 Thread Christophe de Dinechin
Frediano Ziglio writes: > This flag will allow the client to perform some optimisations > on output and buffering processing. > Old clients will ignore this additional flag. > > Signed-off-by: Frediano Ziglio > --- > spice.proto | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff

Re: [Spice-devel] [PATCH spice-common 2/2] RFC protocol: Allows to send partial frame data

2017-11-07 Thread Christophe de Dinechin
Frediano Ziglio writes: > Reduce the needs to buffer the entire frame and than send > and on the other end to wait the entire frame before processing. > Some encodings allow to start processing before having a full > frame allowing to reduce latency and buffering with huge frames. > > Signed-off-

Re: [Spice-devel] [PATCH spice-protocol] RFC protocol: Allows to send partial frame data

2017-11-07 Thread Christophe de Dinechin
Frediano Ziglio writes: > Reduce the needs to buffer the entire frame and than send > and on the other end to wait the entire frame before processing. I think that you want a little more than "reduce the need", making explicit what is allowed. Something like: "When both server and client have th

[Spice-devel] [PATCH spice-common 1/3] ring: Remove __ring_remove function

2017-11-07 Thread Frediano Ziglio
Is just used by ring_remove, no reason to have it. Signed-off-by: Frediano Ziglio --- common/ring.h | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/common/ring.h b/common/ring.h index 4b0e313..036c098 100644 --- a/common/ring.h +++ b/common/ring.h @@ -70,19 +70,14

[Spice-devel] [PATCH spice-common 2/3] ring: Remove short living temporary variable

2017-11-07 Thread Frediano Ziglio
Just a style change, the variable does not help readability. Signed-off-by: Frediano Ziglio --- common/ring.h | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/common/ring.h b/common/ring.h index 036c098..1ed3576 100644 --- a/common/ring.h +++ b/common/ring.h @@ -82,

[Spice-devel] [PATCH spice-common 3/3] canvas_base: Allow to specify constant operations

2017-11-07 Thread Frediano Ziglio
There's no need for the canvas operations to be changed. This allows without casts to have the operation structures constants in the code. This potentially allows to reduce attach surface having some more data constant instead or read/write. Signed-off-by: Frediano Ziglio --- common/canvas_base.