Re: [Spice-devel] [3/6] [PATCH spice] Add horizontal mouse wheel support

2017-11-01 Thread Matthew J. Francis
On 01/11/2017 01:20, Christophe de Dinechin wrote: Matthew J. Francis writes: What requirements might there be in terms of touch pads? I would expect touch pads (and some mice) to send events that have delta_x and delta_y in the same GdkEventScroll message. Some testing on macOS with a MacBoo

Re: [Spice-devel] [PATCH v4 6/8] vdagent: Incapsulate iteration state into a VDAgent structure

2017-11-01 Thread Christophe de Dinechin
Frediano Ziglio writes: > Related to ongoing work to use GMainLoop and GTK integration > > Based on work from Victor Toso > --- > src/vdagent/vdagent.c | 121 > ++ > 1 file changed, 72 insertions(+), 49 deletions(-) > > diff --git a/src/vdagent/v

Re: [Spice-devel] [PATCH spice-server 01/15] Use standard "Red" namespace

2017-11-01 Thread Christophe de Dinechin
Jonathon Jongsma writes: > The objects RedsStream and RedsSASL are currently using the namespace > "Reds" rather than the standard "Red" namespace used throughout the rest > of the project. Change these to be consistent. This also means changing > method names and some related enumeration types.

Re: [Spice-devel] [PATCH spice-server 00/15] A bunch of stream cleanups

2017-11-01 Thread Christophe de Dinechin
Jonathon Jongsma writes: > I sent two of these patches earlier (one ACKed by Frediano), but decided > to do a little more cleanup here. There are a couple of basic issues > related to the Stream stuff: > 1. The word Stream is used in a couple of ways within the spice-server > codebase. The f

Re: [Spice-devel] [PATCH spice-protocol v2] Add definition of STREAM_MSG_CAPABILITIES_MAX

2017-11-01 Thread Christophe de Dinechin
Jonathon Jongsma writes: > This message is specified to have a size limit of 1024, so provide this > as a #define > > Signed-off-by: Jonathon Jongsma Acked-by: Christophe de Dinechin > --- > spice/stream-device.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/spi

[Spice-devel] [PATCH spice-protocol v2] Add definition of STREAM_MSG_CAPABILITIES_MAX

2017-11-01 Thread Jonathon Jongsma
This message is specified to have a size limit of 1024, so provide this as a #define Signed-off-by: Jonathon Jongsma --- spice/stream-device.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/spice/stream-device.h b/spice/stream-device.h index bf919ed..57de98b 100644 --- a/

Re: [Spice-devel] [PATCH spice-protocol] Add definition of STREAM_MSG_CAPABILITIES_MAX

2017-11-01 Thread Frediano Ziglio
> > This message is specified to have a size limit of 1024, so provide this > as a #define > --- > spice/stream-device.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/spice/stream-device.h b/spice/stream-device.h > index bf919ed..02d0e68 100644 > --- a/spice/stream-device.h > +++ b/

[Spice-devel] [PATCH spice-protocol] Add definition of STREAM_MSG_CAPABILITIES_MAX

2017-11-01 Thread Jonathon Jongsma
This message is specified to have a size limit of 1024, so provide this as a #define --- spice/stream-device.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/spice/stream-device.h b/spice/stream-device.h index bf919ed..02d0e68 100644 --- a/spice/stream-device.h +++ b/spice/stream-device.h @

Re: [Spice-devel] [PATCH spice-server] StreamDevice: Handle incomplete reads of StreamMsgFormat

2017-11-01 Thread Frediano Ziglio
> > On Wed, 2017-11-01 at 05:02 -0400, Frediano Ziglio wrote: > > > > > > This is currently unlikely to happen since we communicate over a > > > pipe > > > and the pipe buffer is sufficiently large to avoid splitting the > > > message. But for completeness, we should handle this scenario. > > >

Re: [Spice-devel] [PATCH spice-server] StreamDevice: Handle incomplete reads of StreamMsgFormat

2017-11-01 Thread Jonathon Jongsma
On Wed, 2017-11-01 at 05:02 -0400, Frediano Ziglio wrote: > > > > This is currently unlikely to happen since we communicate over a > > pipe > > and the pipe buffer is sufficiently large to avoid splitting the > > message. But for completeness, we should handle this scenario. > > > > Signed-off-by

Re: [Spice-devel] [PATCH spice-server] StreamDevice: Handle incomplete reads of StreamMsgFormat

2017-11-01 Thread Frediano Ziglio
> > This is currently unlikely to happen since we communicate over a pipe > and the pipe buffer is sufficiently large to avoid splitting the > message. But for completeness, we should handle this scenario. > > Signed-off-by: Jonathon Jongsma > --- > server/stream-device.c | 33 +