Re: [Spice-devel] [PATCH spice-server] StreamDevice: Handle incomplete reads of StreamMsgFormat

2017-10-31 Thread Christophe de Dinechin
Jonathon Jongsma writes: > This is currently unlikely to happen since we communicate over a pipe > and the pipe buffer is sufficiently large to avoid splitting the > message. But for completeness, we should handle this scenario. > > Signed-off-by: Jonathon Jongsma Reviewed-by: Christophe de Din

Re: [Spice-devel] [3/6] [PATCH spice] Add horizontal mouse wheel support

2017-10-31 Thread Christophe de Dinechin
Matthew J. Francis writes: > On 30/10/2017 17:28, Frediano Ziglio wrote: >> This patch changes ABI so would need a version bump and a Qemu patch. >> Did you send a patch to Qemu too? > > As mentioned in the patch overview, I haven't touched qemu yet - if I > can get agreement on what the API/ABI s

[Spice-devel] [PATCH spice-server] StreamDevice: Handle incomplete reads of StreamMsgFormat

2017-10-31 Thread Jonathon Jongsma
This is currently unlikely to happen since we communicate over a pipe and the pipe buffer is sufficiently large to avoid splitting the message. But for completeness, we should handle this scenario. Signed-off-by: Jonathon Jongsma --- server/stream-device.c | 33 +++--

Re: [Spice-devel] [PATCH spice-server] StreamDevice: Fix incomplete header reads

2017-10-31 Thread Frediano Ziglio
> > The code for reading a StreamDevice message from the streaming agent has > code to handle a situation where you only read a part of the header. If > we've read only a part of the header, we will try to read the remaining > n bytes of the header within a loop until the full header is read. > Ho

[Spice-devel] [PATCH spice-server] StreamDevice: Fix incomplete header reads

2017-10-31 Thread Jonathon Jongsma
The code for reading a StreamDevice message from the streaming agent has code to handle a situation where you only read a part of the header. If we've read only a part of the header, we will try to read the remaining n bytes of the header within a loop until the full header is read. However, when w