On Tue, Oct 17, 2017 at 12:30 PM, Christophe Fergeau
wrote:
> On Mon, Oct 16, 2017 at 05:01:14PM +0300, Yedidyah Bar David wrote:
>> On Mon, Oct 16, 2017 at 4:16 PM, Yedidyah Bar David wrote:
>> > On Mon, Oct 16, 2017 at 4:07 PM, Christophe Fergeau
>> > wrote:
>> >> My understanding is that the
Signed-off-by: Frediano Ziglio
---
server/reds-stream.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/server/reds-stream.c b/server/reds-stream.c
index 817564e21..c12893793 100644
--- a/server/reds-stream.c
+++ b/server/reds-stream.c
@@ -68,7 +68,6 @@ typedef struct RedsSASL {
SpiceBu
There are already other debugging code showing channel closure.
Not closed file descriptors can easily be detected with other
tools (like netstat or /proc file system).
Signed-off-by: Frediano Ziglio
---
server/reds-stream.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/server/reds-stream.c
>
> spice_server_set_channel_security() is already mostly doing that. We can
> make its code more generic, and introduce a red_channel_get_name()
> method. This method will then be used to make debug messages more
> readable by showing the actual channel name rather than its type as
> an int.
> --
>
> To be honest, to me it feels like the benefit from this change is not
> worth the added complexity of generating GEnums and modifying the
> channel clients, etc. Do you have plans to use this somewhere? Or do
> you just call it from gdb or something?
>
> Jonathon
>
I agree. One alternative
Despite my misgivings about calling _printerr() with an empty string...
Acked-by: Jonathon Jongsma
On Thu, 2017-10-12 at 12:13 +0200, Christophe Fergeau wrote:
> This commit adds red_channel_{debug,warning,printerr}() helpers which
> will prepend the log message with "channel-name:id (%p)". It
Acked-by: Jonathon Jongsma
On Thu, 2017-10-12 at 12:13 +0200, Christophe Fergeau wrote:
> spice_server_set_channel_security() is already mostly doing that. We
> can
> make its code more generic, and introduce a red_channel_get_name()
> method. This method will then be used to make debug messages
To be honest, to me it feels like the benefit from this change is not
worth the added complexity of generating GEnums and modifying the
channel clients, etc. Do you have plans to use this somewhere? Or do
you just call it from gdb or something?
Jonathon
On Thu, 2017-10-12 at 12:13 +0200, Christo
Acked-by: Jonathon Jongsma
On Tue, 2017-10-17 at 11:14 +0100, Frediano Ziglio wrote:
> In some cases mouse_mode is a bit field.
> However for this structure is used always as a boolean
> value.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/red-qxl.c | 3 ++-
> 1 file changed, 2 insertion
Acked-by: Jonathon Jongsma
On Tue, 2017-10-17 at 11:14 +0100, Frediano Ziglio wrote:
> This field was used just to store a value and retrieve again
> while we can just pass it instead.
>
> Signed-off-by: Frediano Ziglio
> ---
> server/red-qxl.c| 10 ++
> server/red-worker.c | 2 +
On Tue, Oct 17, 2017 at 10:09 AM, Frediano Ziglio wrote:
> From: Jakub Janků
>
> Replace existing main while-loop with GMainLoop.
>
> Use GIOChannel with g_io_add_watch() to manage IO
> from x11 connections in the main loop.
>
> udscs_connect() now internally creates GSources
> by calling g_io_ad
This field was used just to store a value and retrieve again
while we can just pass it instead.
Signed-off-by: Frediano Ziglio
---
server/red-qxl.c| 10 ++
server/red-worker.c | 2 +-
server/red-worker.h | 2 +-
3 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/server
In some cases mouse_mode is a bit field.
However for this structure is used always as a boolean
value.
Signed-off-by: Frediano Ziglio
---
server/red-qxl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/server/red-qxl.c b/server/red-qxl.c
index e386ba629..8cf09d9a8 100644
-
On Mon, Oct 16, 2017 at 05:01:14PM +0300, Yedidyah Bar David wrote:
> On Mon, Oct 16, 2017 at 4:16 PM, Yedidyah Bar David wrote:
> > On Mon, Oct 16, 2017 at 4:07 PM, Christophe Fergeau
> > wrote:
> >> My understanding is that the short log really should be saying "oVirt CI
> >> support" rather t
From: Jakub Janků
Replace existing main while-loop with GMainLoop.
Use GIOChannel with g_io_add_watch() to manage IO
from x11 connections in the main loop.
udscs_connect() now internally creates GSources
by calling g_io_add_watch().
This enables GMainLoop integration,
clients no longer need to
On Mon, Oct 16, 2017 at 10:53:43AM -0400, Frediano Ziglio wrote:
> > -
> > -n = select(nfds, &readfds, &writefds, NULL, NULL);
> > -if (n == -1) {
> > -if (errno == EINTR)
> > -continue;
> > -syslog(LOG_ERR, "Fatal error select: %s", strerror(
16 matches
Mail list logo
