Re: [Spice-devel] [PATCH spice-server v6 13/19] stream-device: Start supporting resetting device when close/open on guest

2017-10-13 Thread Jonathon Jongsma
On Thu, 2017-10-12 at 15:52 +0100, Frediano Ziglio wrote: > When guest close the device the host device has to be reset too. > This make easier to restart the guest device which can happen in case > of reboot, agent issues or if we want to update the agent. > > Signed-off-by: Frediano Ziglio > --

Re: [Spice-devel] [PATCH spice-server v6 10/19] stream-channel: Support client connection/disconnection

2017-10-13 Thread Jonathon Jongsma
Acked-by: Jonathon Jongsma On Thu, 2017-10-12 at 15:52 +0100, Frediano Ziglio wrote: > When a new client is connected we must restart the stream so new > clients can receive correct data without having to wait for the > next full screen (which on idle screen could take ages). > On disconnection

Re: [Spice-devel] [PATCH spice-server v6 01/19] Notify client of the creation of new channels dynamically

2017-10-13 Thread Jonathon Jongsma
On Thu, 2017-10-12 at 15:51 +0100, Frediano Ziglio wrote: > This allows the server to add channels after the client is connected. > > Signed-off-by: Frediano Ziglio > --- > Changes since v5: > - added a comment before sending a new channel list to client; > - renamed channels_list_sent to initial

Re: [Spice-devel] qxl and page flip

2017-10-13 Thread Frediano Ziglio
> > Hi, > > > Switching the qxl kms driver to use a scratchpad model too should be > > easy for userspace apps not using qxl ioctls (i.e. basically > > everything > > but xorg-x11-drv-qxl).  Just use the vga memory region (start of pci > > bar 0) as scratchpad, then we can safely use framebuffer

Re: [Spice-devel] [PATCH spice-server 1/2] tests: Check leaks registering migration interface

2017-10-13 Thread Frediano Ziglio
> > For the series, > Acked-by: Christophe Fergeau > though I would put the test after the fix, or squash both. > > Christophe > Some TDD methodologies suggest that test should first fail. But this does not work well with git blame. I reverted the order. Frediano > On Thu, Oct 12, 2017 at 03

Re: [Spice-devel] [PATCH vdagent v3 7/8] vdagent: Use GMainLoop

2017-10-13 Thread Jakub Janků
On Fri, Oct 13, 2017 at 3:49 PM Frediano Ziglio wrote: > > On Fri, Oct 13, 2017, 9:29 AM Frediano Ziglio wrote: > >> > >> > On Wed, Oct 11, 2017 at 1:43 PM, Frediano Ziglio >> wrote: >> > >> >> > >> Replace existing main while-loop with GMainLoop. >> > >> >> > >> Use GIOChannel with g_io_add_wa

Re: [Spice-devel] [PATCH spice-server 1/2] tests: Check leaks registering migration interface

2017-10-13 Thread Christophe Fergeau
For the series, Acked-by: Christophe Fergeau though I would put the test after the fix, or squash both. Christophe On Thu, Oct 12, 2017 at 03:56:16PM +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > server/tests/test-leaks.c | 36 > 1

Re: [Spice-devel] [PATCH vdagent v3 7/8] vdagent: Use GMainLoop

2017-10-13 Thread Frediano Ziglio
> > On Fri, Oct 13, 2017, 9:29 AM Frediano Ziglio < fzig...@redhat.com > wrote: > > > > > > > > > > > > On Wed, Oct 11, 2017 at 1:43 PM, Frediano Ziglio < fzig...@redhat.com > > > > > wrote: > > > > > > > >> > > > > > > > >> Replace existing main while-loop with GMainLoop. > > > > > > > >

Re: [Spice-devel] intel vgpu & spice & cursor

2017-10-13 Thread Ville Syrjälä
On Fri, Oct 13, 2017 at 11:33:23AM +0300, Joonas Lahtinen wrote: > On Fri, 2017-10-13 at 02:09 +, Zhang, Tina wrote: > > > -Original Message- > > > From: Marc-André Lureau [mailto:marcandre.lur...@redhat.com] > > > Sent: Thursday, October 12, 2017 5:42 PM > > > To: Gerd Hoffmann > > >

Re: [Spice-devel] [PATCH vdagent v3 7/8] vdagent: Use GMainLoop

2017-10-13 Thread Frediano Ziglio
> On Fri, Oct 13, 2017, 9:29 AM Frediano Ziglio < fzig...@redhat.com > wrote: > > > > > > > On Wed, Oct 11, 2017 at 1:43 PM, Frediano Ziglio < fzig...@redhat.com > > > > wrote: > > > > >> > > > > >> Replace existing main while-loop with GMainLoop. > > > > >> > > > > >> Use GIOChannel with g_i

Re: [Spice-devel] [PATCH vdagent v3 7/8] vdagent: Use GMainLoop

2017-10-13 Thread Jakub Janků
On Fri, Oct 13, 2017, 9:29 AM Frediano Ziglio wrote: > > > > On Wed, Oct 11, 2017 at 1:43 PM, Frediano Ziglio > wrote: > > >> > > >> Replace existing main while-loop with GMainLoop. > > >> > > >> Use GIOChannel with g_io_add_watch() to manage IO > > >> from x11 connections in the main loop. > >

Re: [Spice-devel] qxl and page flip

2017-10-13 Thread Gerd Hoffmann
Hi, > Switching the qxl kms driver to use a scratchpad model too should be > easy for userspace apps not using qxl ioctls (i.e. basically > everything > but xorg-x11-drv-qxl).  Just use the vga memory region (start of pci > bar 0) as scratchpad, then we can safely use framebuffer blits for > dis

Re: [Spice-devel] Spice Protocol Missing Headers

2017-10-13 Thread Frediano Ziglio
> > > I tried a few years back (spice-protocol 0.12.10) to move these code > > generation scripts to spice-protocol, but this did not work out > > nicely so this was reverted. > > I found this too, I opted to use the spice.proto file to write my own > header > with the basics that were required.

Re: [Spice-devel] intel vgpu & spice & cursor

2017-10-13 Thread Zhang, Tina
> -Original Message- > From: Marc-André Lureau [mailto:marcandre.lur...@redhat.com] > Sent: Thursday, October 12, 2017 5:42 PM > To: Gerd Hoffmann > Cc: intel-gvt-...@lists.freedesktop.org; spice-devel@lists.freedesktop.org; > Zhang, Tina > Subject: Re: [Spice-devel] intel vgpu & spice

[Spice-devel] ?????? get into trouble of the spice-connect

2017-10-13 Thread ????????
what's this??Videos is better.I can't understand it.I don't know how to do next. -- -- ??: "Christophe Fergeau"; : 2017??10??12??(??) 9:06 ??: ""<450423...@qq.com>; : "spice-devel"; : Re: [Spice-devel] get into

Re: [Spice-devel] intel vgpu & spice & cursor

2017-10-13 Thread Joonas Lahtinen
On Fri, 2017-10-13 at 02:09 +, Zhang, Tina wrote: > > -Original Message- > > From: Marc-André Lureau [mailto:marcandre.lur...@redhat.com] > > Sent: Thursday, October 12, 2017 5:42 PM > > To: Gerd Hoffmann > > Cc: intel-gvt-...@lists.freedesktop.org; spice-devel@lists.freedesktop.org; >

Re: [Spice-devel] Spice Protocol Missing Headers

2017-10-13 Thread geoff
I tried a few years back (spice-protocol 0.12.10) to move these code generation scripts to spice-protocol, but this did not work out nicely so this was reverted. I found this too, I opted to use the spice.proto file to write my own header with the basics that were required. I agree that hav

Re: [Spice-devel] [PATCH vdagent v3 7/8] vdagent: Use GMainLoop

2017-10-13 Thread Frediano Ziglio
> > On Wed, Oct 11, 2017 at 1:43 PM, Frediano Ziglio wrote: > >> > >> Replace existing main while-loop with GMainLoop. > >> > >> Use GIOChannel with g_io_add_watch() to manage IO > >> from x11 connections in the main loop. > >> > >> udscs_connect() now internally creates GSources > >> by calling