Re: [Spice-devel] [PATCH vdagent v2 7/8] vdagent: Use GMainLoop

2017-10-04 Thread Jakub Janků
On Wed, Oct 4, 2017 at 12:43 PM, Frediano Ziglio wrote: >> >> Replace existing main while-loop with GMainLoop. >> >> Use GIOChannel with g_io_add_watch() to manage IO >> from x11 connections in the main loop. >> >> udscs_connect() now internally creates GSources >> by calling g_io_add_watch(). >>

Re: [Spice-devel] [PATCH vdagent v2 4/8] vdagent: Use glib's commandline parser

2017-10-04 Thread Jakub Janků
On Wed, Oct 4, 2017 at 11:43 AM, Frediano Ziglio wrote: >> >> From: Victor Toso >> >> As we already depend on glib, let's remove code that glib can take >> care of. In this case, we don't need to handle commandline parsing >> ourselves. >> >> In regard the global variables: >> >> * static const c

[Spice-devel] [PATCH spice-server] Mention vmport in user manual

2017-10-04 Thread Jonathon Jongsma
For server mode mouse to work properly with spice, vmport must be disabled in qemu. To do this, we need to pass vmport=off to the -machine option. --- docs/manual/manual.txt | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/docs/manual/manual.txt b/docs/manual/manual.

Re: [Spice-devel] qxl and page flip

2017-10-04 Thread Gerd Hoffmann
Hi, > > So, the options I see are: > > > >  (1) Declare qxl deprecated, promote virtio-vga instead. > > > >  (2) Pimp the qxl hardware, add page-flip support.  Requires > > changes > >  in spice-server (due to lazy rendering), qemu qxl emulation > > and > >  guest kernel driver.  Shoul

Re: [Spice-devel] qxl and page flip

2017-10-04 Thread Frediano Ziglio
> > Hi, > > qxl kms driver has been converted over to atomic mode setting recently. > Caused some problems, most are fixed meanwhile. > > See https://bugzilla.kernel.org/show_bug.cgi?id=196777 > > One pretty fundamental issue sticks though: The qxl virtual hardware > doesn't support pageflip

Re: [Spice-devel] [PATCH vdagent v2 7/8] vdagent: Use GMainLoop

2017-10-04 Thread Frediano Ziglio
> > Replace existing main while-loop with GMainLoop. > > Use GIOChannel with g_io_add_watch() to manage IO > from x11 connections in the main loop. > > udscs_connect() now internally creates GSources > by calling g_io_add_watch(). > This enables GMainLoop integration, > clients no longer need to

[Spice-devel] qxl and page flip

2017-10-04 Thread Gerd Hoffmann
Hi, qxl kms driver has been converted over to atomic mode setting recently. Caused some problems, most are fixed meanwhile. See https://bugzilla.kernel.org/show_bug.cgi?id=196777 One pretty fundamental issue sticks though: The qxl virtual hardware doesn't support pageflip (see comment 11 in

Re: [Spice-devel] [PATCH vdagent v2 5/8] vdagent: small refactor on udscs setup function

2017-10-04 Thread Frediano Ziglio
> > From: Victor Toso > > This is mostly a preparatory patch to reduce the usage of globals and > the GMainLoop integration. The changes target one function by: > > * Changing its name from client_setup() to client_setup_sync(): As it > important to clarify that the function block; > > * Rem

Re: [Spice-devel] [PATCH vdagent v2 4/8] vdagent: Use glib's commandline parser

2017-10-04 Thread Frediano Ziglio
> > From: Victor Toso > > As we already depend on glib, let's remove code that glib can take > care of. In this case, we don't need to handle commandline parsing > ourselves. > > In regard the global variables: > > * static const char * -> static gchar * [only paths] > path variables: portde

Re: [Spice-devel] [PATCH vdagent v2 3/8] vdagent: move file xfer finalize to a function

2017-10-04 Thread Frediano Ziglio
> > From: Victor Toso > > This patch creates vdagent_finalize_file_xfer() to finalize and stop > file xfer. Moving this code to a function removes some duplication. > > Signed-off-by: Victor Toso Acked-by: Frediano Ziglio Frediano > --- > src/vdagent/vdagent.c | 22 --

Re: [Spice-devel] [PATCH vdagent v2 2/8] vdagent: move file xfer initialization to a function

2017-10-04 Thread Frediano Ziglio
> > From: Victor Toso > > This patch creates two functions: > - xfer_get_download_directory() > - vdagent_init_file_xfer() > > The logic should be similar as it was before this patch, taking in > consideration the global variables fx_open_dir and fx_dir which are > set from command line. > > S

Re: [Spice-devel] [PATCH vdagent v2 1/8] Bump GLib version to 2.34

2017-10-04 Thread Frediano Ziglio
> > This is required for the following GMainLoop integration, > which utilizes some of the new functions/definitions, namely: > > [definition][GLib version] > g_clear_pointer() 2.34 > G_SOURCE_REMOVE 2.32 > G_SOURCE_CONTINUE 2.32 > g_unix_signal_add() 2.30 > > GLib version accross distri

Re: [Spice-devel] [PATCH spice-server v3] gl: fix client mouse mode

2017-10-04 Thread Christophe de Dinechin
Acked-by: Christophe de Dinechin > On 4 Oct 2017, at 10:50, Frediano Ziglio wrote: > > Since 2.8, QEMU no longer creates QXL primary surfaces when using GL. > This change broke client-side mouse mode, because Spice server relies on > having a primary surface. > > When GL is enabled, use GL sca

[Spice-devel] [PATCH spice-server v3] gl: fix client mouse mode

2017-10-04 Thread Frediano Ziglio
Since 2.8, QEMU no longer creates QXL primary surfaces when using GL. This change broke client-side mouse mode, because Spice server relies on having a primary surface. When GL is enabled, use GL scanout informations. Mouse mode is always client when GL surfaces are used. This patch and most of t

Re: [Spice-devel] [PATCH spice-server v2] gl: fix client mouse mode

2017-10-04 Thread Christophe de Dinechin
> On 29 Sep 2017, at 09:52, Frediano Ziglio wrote: > >> >> On Thu, 2017-09-07 at 15:49 +0100, Frediano Ziglio wrote: >>> Since 2.8, QEMU now longer creates QXL primary surfaces when using >>> GL. >>> This change broke client-side mouse mode, because Spice server relies >>> on >>> primary surfac