Re: [Spice-devel] [PATCH spice-common v2] codegen: Make the compiler work out better way to write unaligned memory

2017-09-20 Thread Frediano Ziglio
> > On Wed, Sep 20, 2017 at 10:07:51AM -0400, Frediano Ziglio wrote: > > > > > > > > On Mon, Sep 18, 2017 at 10:27:01AM -0400, Frediano Ziglio wrote: > > > > > > > > > > > > Has this been tested on actual problematic hardware, and improved > > > > > > performance? I remember last time this was d

Re: [Spice-devel] [PATCH spice-server v2 00/23] Use GLib memory allocation

2017-09-20 Thread Christophe Fergeau
On Wed, Sep 20, 2017 at 06:15:49PM +0200, Christophe de Dinechin wrote: > > > > On 20 Sep 2017, at 17:51, Christophe Fergeau wrote: > > > > On Wed, Sep 20, 2017 at 05:31:37PM +0200, Christophe de Dinechin wrote: > >> > >> > >>> On 20 Sep 2017, at 16:51, Christophe Fergeau wrote: > >>> > >>>

[Spice-devel] spice-server 0.14 release plans

2017-09-20 Thread Christophe Fergeau
Hey, I really want to get a 0.14.0 release out of the door soon, but the amount of patches going in spice-server lately is not making me feel very comfortable with cutting a release at an arbitary time. What I would like to do: - slow down on the amount of patches going in for a while (personally

Re: [Spice-devel] [PATCH spice-server v2 00/23] Use GLib memory allocation

2017-09-20 Thread Christophe de Dinechin
> On 20 Sep 2017, at 17:51, Christophe Fergeau wrote: > > On Wed, Sep 20, 2017 at 05:31:37PM +0200, Christophe de Dinechin wrote: >> >> >>> On 20 Sep 2017, at 16:51, Christophe Fergeau wrote: >>> >>> On Wed, Sep 20, 2017 at 02:54:31PM +0200, Christophe de Dinechin wrote: > >> The b

Re: [Spice-devel] Windows 10 and current latest spice guest additions causes blank/black screen issue

2017-09-20 Thread Christophe Fergeau
Hey Iordan, On Tue, Sep 19, 2017 at 09:20:31PM -0400, i iordanov wrote: > Hi guys! > > Installing current latest spice guest additions from here on Windows 10: > > https://www.spice-space.org/download/windows/spice-guest-tools/spice-guest-tools-latest.exe I'm fairly sure the Windows agent (http

Re: [Spice-devel] [PATCH spice-common v2] codegen: Make the compiler work out better way to write unaligned memory

2017-09-20 Thread Christophe Fergeau
On Wed, Sep 20, 2017 at 10:07:51AM -0400, Frediano Ziglio wrote: > > > > > > On Mon, Sep 18, 2017 at 10:27:01AM -0400, Frediano Ziglio wrote: > > > > > > > > > > Has this been tested on actual problematic hardware, and improved > > > > > performance? I remember last time this was discussed, the o

Re: [Spice-devel] [PATCH spice-server v2 00/23] Use GLib memory allocation

2017-09-20 Thread Christophe Fergeau
On Wed, Sep 20, 2017 at 05:31:37PM +0200, Christophe de Dinechin wrote: > > > > On 20 Sep 2017, at 16:51, Christophe Fergeau wrote: > > > > On Wed, Sep 20, 2017 at 02:54:31PM +0200, Christophe de Dinechin wrote: > >>> > The benefit of doing it that way (in addition to requiring less sourc

[Spice-devel] [spice-server] tests: Automatically determine free port to use

2017-09-20 Thread Christophe Fergeau
Currently, the port used by most tests is hardcoded to 5912. However, the test suite can be run in parallel, so if 2 tests run in parallel, the 2nd one is not going to be able to bind to port 5912 and will fail. After this commit, test_new() will try to find a free port between 5912 and 5922 and w

Re: [Spice-devel] [PATCH spice-server v2 00/23] Use GLib memory allocation

2017-09-20 Thread Frediano Ziglio
> > On Wed, Sep 20, 2017 at 02:54:31PM +0200, Christophe de Dinechin wrote: > > > > > >> The benefit of doing it that way (in addition to requiring less source > > >> code > > >> changes and making following rebases or merge much easier) is that it > > >> leaves > > >> the option to instrument sp

Re: [Spice-devel] [PATCH spice-server v2 00/23] Use GLib memory allocation

2017-09-20 Thread Christophe de Dinechin
> On 20 Sep 2017, at 16:51, Christophe Fergeau wrote: > > On Wed, Sep 20, 2017 at 02:54:31PM +0200, Christophe de Dinechin wrote: >>> The benefit of doing it that way (in addition to requiring less source code changes and making following rebases or merge much easier) is that it >>>

Re: [Spice-devel] [PATCH spice-server v2 00/23] Use GLib memory allocation

2017-09-20 Thread Christophe Fergeau
On Wed, Sep 20, 2017 at 02:54:31PM +0200, Christophe de Dinechin wrote: > > > >> The benefit of doing it that way (in addition to requiring less source code > >> changes and making following rebases or merge much easier) is that it > >> leaves > >> the option to instrument spice allocations speci

Re: [Spice-devel] [PATCH spice-server v2 00/23] Use GLib memory allocation

2017-09-20 Thread Matthew Francis
On 20 September 2017 at 20:54, Christophe de Dinechin wrote: > >> On 20 Sep 2017, at 11:53, Frediano Ziglio wrote: >> There are many tools to instruments memory allocations and is not hard >> to write one on your own. For instance knowing that objects file takes >> precedence over libraries you

Re: [Spice-devel] [PATCH spice-common v2] codegen: Make the compiler work out better way to write unaligned memory

2017-09-20 Thread Frediano Ziglio
> > > > On Mon, Sep 18, 2017 at 10:27:01AM -0400, Frediano Ziglio wrote: > > > > > > > > Has this been tested on actual problematic hardware, and improved > > > > performance? I remember last time this was discussed, the outcome was > > > > not always what was expected. > > > > > > > > Christoph

Re: [Spice-devel] [PATCH spice-server v2 00/23] Use GLib memory allocation

2017-09-20 Thread Christophe de Dinechin
> On 20 Sep 2017, at 11:53, Frediano Ziglio wrote: > >>> >>> On 20 Sep 2017, at 09:50, Frediano Ziglio wrote: >>> >>> Reduce the usage of spice_new*/spice_malloc* allocations. >>> They were designed in a similar way to GLib ones. >>> Now that we use GLib make sense to remove them. >>> Howeve

Re: [Spice-devel] [PATCH spice-server v2 00/23] Use GLib memory allocation

2017-09-20 Thread Frediano Ziglio
> > > On 20 Sep 2017, at 09:50, Frediano Ziglio wrote: > > > > Reduce the usage of spice_new*/spice_malloc* allocations. > > They were designed in a similar way to GLib ones. > > Now that we use GLib make sense to remove them. > > However the versions we support for GLib can use different memory

Re: [Spice-devel] [PATCH spice-server v2 00/23] Use GLib memory allocation

2017-09-20 Thread Christophe de Dinechin
> On 20 Sep 2017, at 09:50, Frediano Ziglio wrote: > > Reduce the usage of spice_new*/spice_malloc* allocations. > They were designed in a similar way to GLib ones. > Now that we use GLib make sense to remove them. > However the versions we support for GLib can use different memory > allocators

[Spice-devel] [PATCH spice-server v2 23/23] red-pipe-item: Use GLib memory functions

2017-09-20 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/cache-item.tmpl.c | 6 +++--- server/dcc.c | 10 +- server/inputs-channel.c | 4 ++-- server/main-channel-client.c | 14 +++--- server/red-channel-client.c | 8 server/red-chan

[Spice-devel] [PATCH spice-server v2 22/23] parse-qxl: Use GLib memory functions

2017-09-20 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/display-channel.c | 2 +- server/red-parse-qxl.c | 46 +++--- 2 files changed, 24 insertions(+), 24 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index f7f778eea..e91265de5 100644

[Spice-devel] [PATCH spice-server v2 21/23] pixmap-cache: Use GLib memory functions

2017-09-20 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/dcc.c | 8 server/pixmap-cache.c | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/server/dcc.c b/server/dcc.c index 315da75d2..2c1761d28 100644 --- a/server/dcc.c +++ b/server/dcc.c @@ -959,7 +959,7 @@ bool dcc_

[Spice-devel] [PATCH spice-server v2 20/23] image-cache: Use GLib memory functions

2017-09-20 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/image-cache.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/image-cache.c b/server/image-cache.c index bd888bef2..3493ba1fc 100644 --- a/server/image-cache.c +++ b/server/image-cache.c @@ -64,7 +64,7 @@ static void image_c

[Spice-devel] [PATCH spice-server v2 19/23] inputs-channel: Use GLib memory functions

2017-09-20 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/inputs-channel.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/server/inputs-channel.c b/server/inputs-channel.c index 8e17cc724..b8944cb0f 100644 --- a/server/inputs-channel.c +++ b/server/inputs-channel.c @@ -77,7 +77,7 @@ st

[Spice-devel] [PATCH spice-server v2 17/23] worker: Use GLib memory functions

2017-09-20 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/cursor-channel.c | 2 +- server/red-worker.c | 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/server/cursor-channel.c b/server/cursor-channel.c index 7fab4c8c7..9ae76090f 100644 --- a/server/cursor-channel.c +++ b/server/cu

[Spice-devel] [PATCH spice-server v2 03/23] reds-stream: Use GLib memory functions

2017-09-20 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/reds-stream.c | 37 ++--- 1 file changed, 14 insertions(+), 23 deletions(-) diff --git a/server/reds-stream.c b/server/reds-stream.c index e5336265e..d4925712f 100644 --- a/server/reds-stream.c +++ b/server/reds-stream.c @

[Spice-devel] [PATCH spice-server v2 05/23] stream: Use GLib memory functions

2017-09-20 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/dcc.c| 2 +- server/stream.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/server/dcc.c b/server/dcc.c index 3bf75a707..aa222b09a 100644 --- a/server/dcc.c +++ b/server/dcc.c @@ -635,7 +635,7 @@ void dcc_stream_agent_clip(

[Spice-devel] [PATCH spice-server v2 18/23] tree: Use GLib memory functions

2017-09-20 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/tree.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/server/tree.c b/server/tree.c index d47f2f591..89186a858 100644 --- a/server/tree.c +++ b/server/tree.c @@ -195,7 +195,7 @@ Shadow* shadow_new(DrawItem *item, const SpicePo

[Spice-devel] [PATCH spice-server v2 14/23] dcc: Use GLib memory functions

2017-09-20 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/dcc.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/server/dcc.c b/server/dcc.c index aa222b09a..315da75d2 100644 --- a/server/dcc.c +++ b/server/dcc.c @@ -180,8 +180,8 @@ static void display_channel_client_in

[Spice-devel] [PATCH spice-server v2 04/23] smartcard: Use GLib memory functions

2017-09-20 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/smartcard.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/server/smartcard.c b/server/smartcard.c index fa3a55ddb..5410720a8 100644 --- a/server/smartcard.c +++ b/server/smartcard.c @@ -144,7 +144,7 @@ static void sma

[Spice-devel] [PATCH spice-server v2 00/23] Use GLib memory allocation

2017-09-20 Thread Frediano Ziglio
Reduce the usage of spice_new*/spice_malloc* allocations. They were designed in a similar way to GLib ones. Now that we use GLib make sense to remove them. However the versions we support for GLib can use different memory allocators so we have to match g_free with GLib allocations and spice_* ones

[Spice-devel] [PATCH spice-server v2 09/23] event-loop: Use GLib memory functions

2017-09-20 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/event-loop.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/server/event-loop.c b/server/event-loop.c index 7f2db0f68..582782e11 100644 --- a/server/event-loop.c +++ b/server/event-loop.c @@ -37,7 +37,7 @@ struct SpiceTimer {

[Spice-devel] [PATCH spice-server v2 15/23] display-channel: Use GLib memory functions

2017-09-20 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/display-channel.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/display-channel.c b/server/display-channel.c index fbdca265f..f7f778eea 100644 --- a/server/display-channel.c +++ b/server/display-channel.c @@ -170,7 +170,7

[Spice-devel] [PATCH spice-server v2 13/23] reds: Use GLib memory functions for ChannelSecurityOptions

2017-09-20 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/reds.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/reds.c b/server/reds.c index db8406a93..b92d1b73a 100644 --- a/server/reds.c +++ b/server/reds.c @@ -2951,7 +2951,7 @@ static void reds_set_one_channel_security(RedsStat

[Spice-devel] [PATCH spice-server v2 16/23] replay-qxl: Use GLib memory functions

2017-09-20 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/red-replay-qxl.c | 48 1 file changed, 24 insertions(+), 24 deletions(-) diff --git a/server/red-replay-qxl.c b/server/red-replay-qxl.c index 2f31e9cdd..d389b62ed 100644 --- a/server/red-replay-qxl.c +++ b

[Spice-devel] [PATCH spice-server v2 02/23] mjpeg: Use GLib memory functions

2017-09-20 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/mjpeg-encoder.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/server/mjpeg-encoder.c b/server/mjpeg-encoder.c index 07ca69c20..cb70ab1b5 100644 --- a/server/mjpeg-encoder.c +++ b/server/mjpeg-encoder.c

[Spice-devel] [PATCH spice-server v2 10/23] dispatcher: Use GLib memory functions

2017-09-20 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/dispatcher.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/server/dispatcher.c b/server/dispatcher.c index 7fb706f8b..7e991403c 100644 --- a/server/dispatcher.c +++ b/server/dispatcher.c @@ -112,7 +112,7 @@ dispatcher_finalize(GO

[Spice-devel] [PATCH spice-server v2 08/23] char-device: Use GLib memory functions

2017-09-20 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/char-device.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/server/char-device.c b/server/char-device.c index 658f9f364..ef361b7ac 100644 --- a/server/char-device.c +++ b/server/char-device.c @@ -150,8 +150,8 @@ static v

[Spice-devel] [PATCH spice-server v2 11/23] Use GLib memory functions for SpiceChannelEventInfo

2017-09-20 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/reds-stream.c | 2 +- server/reds.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/server/reds-stream.c b/server/reds-stream.c index d4925712f..817564e21 100644 --- a/server/reds-stream.c +++ b/server/reds-stream.c @@ -417,7

[Spice-devel] [PATCH spice-server v2 07/23] gstreamer-encoder: Use GLib memory functions

2017-09-20 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/gstreamer-encoder.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/server/gstreamer-encoder.c b/server/gstreamer-encoder.c index b2ddfea91..04f0c02fe 100644 --- a/server/gstreamer-encoder.c +++ b/server/gstreamer-enco

[Spice-devel] [PATCH spice-server v2 12/23] reds: Use GLib memory functions for link message

2017-09-20 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/reds.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/server/reds.c b/server/reds.c index 5b50bc30f..db8406a93 100644 --- a/server/reds.c +++ b/server/reds.c @@ -334,7 +334,7 @@ static void reds_link_free(RedLinkInfo *link)

[Spice-devel] [PATCH spice-server v2 06/23] spicevmc: Use GLib memory functions

2017-09-20 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/spicevmc.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/server/spicevmc.c b/server/spicevmc.c index 6b9b96fc8..7577165f5 100644 --- a/server/spicevmc.c +++ b/server/spicevmc.c @@ -364,12 +364,12 @@ static RedVmcPi

[Spice-devel] [PATCH spice-server v2 01/23] lz4-encoder: Use GLib memory functions

2017-09-20 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- server/lz4-encoder.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/server/lz4-encoder.c b/server/lz4-encoder.c index fe736d272..39aac0123 100644 --- a/server/lz4-encoder.c +++ b/server/lz4-encoder.c @@ -74,7 +74,7 @@ int lz4_encode(