Hi guys!
Installing current latest spice guest additions from here on Windows 10:
https://www.spice-space.org/download/windows/spice-guest-tools/spice-guest-tools-latest.exe
(I guess v0.132) causes a fresh Windows 10 installation in oVirt to
die with a blank, black screen the moment the client r
Can you explain briefly in the commit log about why you chose to change
the types?
Acked-by: Jonathon Jongsma
On Mon, 2017-09-11 at 16:15 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/lz4-encoder.c | 21 +++--
> 1 file changed, 11 insertions(+),
It's a bit small now. I suppose it could be squashed, or left as is.
Acked-by: Jonathon Jongsma
On Tue, 2017-09-19 at 07:35 +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/reds.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Changes since v1:
>
Signed-off-by: Matthew Francis
---
doc/reference/spice-gtk-sections.txt | 3 ++
src/channel-port.c | 67 +++-
src/channel-port.h | 15
src/map-file | 3 ++
src/spice-glib-sym-file |
Signed-off-by: Matthew Francis
---
doc/reference/spice-gtk-sections.txt | 1 +
src/channel-record.c | 19 +++
src/channel-record.h | 6 ++
src/map-file | 1 +
src/spice-glib-sym-file | 1 +
src/spice-gsta
Signed-off-by: Matthew Francis
---
doc/reference/spice-gtk-sections.txt | 5 ++
src/channel-display.c| 92 +++-
src/channel-display.h| 22 +++--
src/map-file | 5 ++
src/spice-glib-sym-file
Signed-off-by: Matthew Francis
---
doc/reference/spice-gtk-sections.txt | 11 ++
src/channel-main.c | 283 +++
src/channel-main.h | 99
src/map-file | 11 ++
src/spice-glib-sym-file
Signed-off-by: Matthew Francis
---
doc/reference/spice-gtk-sections.txt | 8 ++
src/channel-inputs.c | 146 ++-
src/channel-inputs.h | 34 ++--
src/map-file | 8 ++
src/spice-glib-sym-file
Various C functions have not been named correctly to be picked up as bound
methods under introspection. This renames them to ensure correct binding.
Outline:
- Rename incorrectly named functions
- Introduce deprecated wrappers for the original function names
- Update in-tree references to use t
On 19 September 2017 at 18:33, Marc-André Lureau
wrote:
>
> You need to modify spice-pulse.c too
Thank you for the quick review. Obviously I'd failed to compile
pulseaudio support into my local version.
Updated patches to follow for this and your points on 5/5
Regards
Matthew Francis
___
>
> On Tue, Sep 19, 2017 at 08:33:04AM -0400, Frediano Ziglio wrote:
> > >
> > > On Wed, Sep 13, 2017 at 10:15:14AM +0100, Frediano Ziglio wrote:
> > > > Now the push is done automatically when a PipeItem is added
> > > > (cfr commit 5c460de1a3972b7cf2b9b2944d0b500c3affc363
> > > > "worker: push
On Tue, Sep 19, 2017 at 08:33:04AM -0400, Frediano Ziglio wrote:
> >
> > On Wed, Sep 13, 2017 at 10:15:14AM +0100, Frediano Ziglio wrote:
> > > Now the push is done automatically when a PipeItem is added
> > > (cfr commit 5c460de1a3972b7cf2b9b2944d0b500c3affc363
> > > "worker: push data when clien
On Tue, Sep 12, 2017 at 02:03:24PM +0100, Frediano Ziglio wrote:
With some added spaces, the log is a bit easier to read imo :)
"Avoid repeating the same code twice.
red_channel_client_send sends the pending item (or a part of it). If
there are no item pending, the function does nothing (so c
>
> On Wed, Sep 13, 2017 at 10:15:14AM +0100, Frediano Ziglio wrote:
> > Now the push is done automatically when a PipeItem is added
> > (cfr commit 5c460de1a3972b7cf2b9b2944d0b500c3affc363
> > "worker: push data when clients can receive them"),
> > forcing a push cause only network fragmentation
On Wed, Aug 30, 2017 at 01:51:26PM +0100, Frediano Ziglio wrote:
> The channels list was not protected by a lock in red_client_destroy.
> This could cause for instance a RedChannelClient object to be
> created while scanning the list so potentially modifying the
> list while scanning with all race
>
> On Mon, Sep 18, 2017 at 10:27:01AM -0400, Frediano Ziglio wrote:
> > >
> > > Has this been tested on actual problematic hardware, and improved
> > > performance? I remember last time this was discussed, the outcome was
> > > not always what was expected.
> > >
> > > Christophe
> > >
> >
>
Signed-off-by: Frediano Ziglio
---
server/red-channel-client.h | 17 +---
server/red-channel.h| 19 ++---
server/red-client.h | 13 +-
server/reds.c | 12 +-
server/smartcard.c | 17 +---
server/smartcard.h | 12 +-
server/sp
- Original Message -
> Signed-off-by: Matthew Francis
Reviewed-by: Marc-André Lureau
> ---
> doc/reference/spice-gtk-sections.txt | 8 ++
> src/channel-inputs.c | 146
> ++-
> src/channel-inputs.h | 34 ++--
> sr
Hi
- Original Message -
> Signed-off-by: Matthew Francis
> ---
> doc/reference/spice-gtk-sections.txt | 1 +
> src/channel-record.c | 19 +++
> src/channel-record.h | 6 ++
> src/map-file | 1 +
> src/spice-gl
On Tue, Sep 19, 2017 at 7:52 AM Matthew Francis
wrote:
> Signed-off-by: Matthew Francis
> ---
> doc/reference/spice-gtk-sections.txt | 11 ++
> src/channel-main.c | 283
> +++
> src/channel-main.h | 99
> src/map
- Original Message -
> Signed-off-by: Matthew Francis
Reviewed-by: Marc-André Lureau
> ---
> doc/reference/spice-gtk-sections.txt | 5 ++
> src/channel-display.c| 92
> +++-
> src/channel-display.h| 22 +++--
> sr
- Original Message -
> Signed-off-by: Matthew Francis
Reviewed-by: Marc-André Lureau
> ---
> doc/reference/spice-gtk-sections.txt | 3 ++
> src/channel-port.c | 67
> +++-
> src/channel-port.h | 15
> src/
Acked-by: Christophe Fergeau
On Mon, Sep 18, 2017 at 04:04:57PM +0100, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio
> ---
> server/tests/Makefile.am| 1 +
> server/tests/test-channel.c | 347
>
> 2 files changed, 348 insertions(+)
Acked-by: Christophe Fergeau
On Mon, Sep 18, 2017 at 04:04:56PM +0100, Frediano Ziglio wrote:
> The macro will implement most of the boilerplate needed to declare an
> object.
> Its usage is similar to GLib G_DECLARE_*_TYPE macros.
>
> Signed-off-by: Frediano Ziglio
> ---
> Changes since v3:
>
Acked-by: Christophe Fergeau
On Mon, Sep 18, 2017 at 04:04:55PM +0100, Frediano Ziglio wrote:
> RedChannelClient has a "handle-acks" feature.
> If this feature is enabled, after the configured number of messages it
> waits for an ACK from the client.
> If is waiting for an ACK it stops sending m
On Mon, Sep 18, 2017 at 10:27:01AM -0400, Frediano Ziglio wrote:
> >
> > Has this been tested on actual problematic hardware, and improved
> > performance? I remember last time this was discussed, the outcome was
> > not always what was expected.
> >
> > Christophe
> >
>
> I don't remember old
On Mon, Sep 18, 2017 at 11:17:16AM -0400, Frediano Ziglio wrote:
> >
> > On Mon, Sep 18, 2017 at 06:19:03AM -0400, Frediano Ziglio wrote:
> > > >
> > > > On Mon, Sep 11, 2017 at 09:08:54AM +0100, Frediano Ziglio wrote:
> > > > > This structure was used to store the cookie for the async
> > > > >
27 matches
Mail list logo
