Re: [Spice-devel] [vdagent-win] build: Update NEWS file for 0.9.0 release

2017-08-03 Thread Frediano Ziglio
> > --- > NEWS | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/NEWS b/NEWS > index 57877ea..f142aab 100644 > --- a/NEWS > +++ b/NEWS > @@ -1,3 +1,12 @@ > +v0.9.0 > +== > +- remove cximage dependency > +- remove 'RHEV' reference from service name > +- don't disconnect agent

[Spice-devel] [vdagent-win] build: Update NEWS file for 0.9.0 release

2017-08-03 Thread Christophe Fergeau
--- NEWS | 9 + 1 file changed, 9 insertions(+) diff --git a/NEWS b/NEWS index 57877ea..f142aab 100644 --- a/NEWS +++ b/NEWS @@ -1,3 +1,12 @@ +v0.9.0 +== +- remove cximage dependency +- remove 'RHEV' reference from service name +- don't disconnect agent when client disconnects +- supp

Re: [Spice-devel] Windows agent release

2017-08-03 Thread Christophe Fergeau
Hey, On Thu, Aug 03, 2017 at 09:40:53AM -0400, Frediano Ziglio wrote: > Hi, > looks like there are quite a few patches and changes since 0.8.0 version. > Looks like that internally we are packaging lot of them already. > Should not better to have a new release? > Looks like we have a kind of int

[Spice-devel] [spice-common v3 07/12] quic: Introduce CommonState *state variable in templates

2017-08-03 Thread Christophe Fergeau
Most functions in quic_tmpl.c/quic_rgb_tmpl.c have only superficial differences. One of them is using channel->state or encoder->rgb_state. This commit adds a local CommonState *state in all template methods which will be used instead of channel->state or encoder->rgb_state. This makes it easier t

[Spice-devel] [spice-common v3 12/12] quic: Add test case for compression/decompression

2017-08-03 Thread Christophe Fergeau
This only adds a basic test relying on gdk-pixbuf. The main limitation is that gdk-pixbuf does not handle 16bpp images, nor 32bpp/no alpha images. I should have picked something else instead ;) This allows at least to exercise the QUIC_IMAGE_TYPE_RGB24 and QUIC_IMAGE_TYPE_RGBA codepaths. Signed-o

[Spice-devel] [spice-common v3 06/12] quic: Factor common code

2017-08-03 Thread Christophe Fergeau
We don't need 2 different implementations when the only difference is the CommonState which is being used. Signed-off-by: Christophe Fergeau --- common/quic.c | 194 ++ 1 file changed, 73 insertions(+), 121 deletions(-) diff --git a/common

[Spice-devel] [spice-common v3 08/12] quic: s/decorrelate_drow/correlate_row

2017-08-03 Thread Christophe Fergeau
The naming is odd as this is just an alias for channel->correlate_row. This will also help in subsequent commits to make things more consistent with quic_rgb_tmpl.c Signed-off-by: Christophe Fergeau --- common/quic_tmpl.c | 54 +++--- 1 file change

[Spice-devel] [spice-common v3 10/12] quic: Remove unused argument in uncompress_row{0, }

2017-08-03 Thread Christophe Fergeau
'correlation_row' is always set to channel->colleration_row, and we already pass 'channel' as an argument. Signed-off-by: Christophe Fergeau --- common/quic_tmpl.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/common/quic_tmpl.c b/common/quic_tmpl.c index 7a0

[Spice-devel] [spice-common v3 04/12] quic: Get rid of RLE_STAT #define

2017-08-03 Thread Christophe Fergeau
It's always set, no need to have conditional compilation based on it. Signed-off-by: Christophe Fergeau --- common/quic.c | 53 ++--- common/quic_tmpl.c | 12 2 files changed, 2 insertions(+), 63 deletions(-) diff --git a/common/

[Spice-devel] [spice-common v3 05/12] quic: Get rid of RLE #define

2017-08-03 Thread Christophe Fergeau
It's always set, no need to have conditional compilation based on it. Signed-off-by: Christophe Fergeau --- common/quic.c | 9 - common/quic_rgb_tmpl.c | 12 common/quic_tmpl.c | 12 3 files changed, 33 deletions(-) diff --git a/common/quic.c b/co

[Spice-devel] [spice-common v3 01/12] quic: Remove configurable RLE_PRED

2017-08-03 Thread Christophe Fergeau
It's hardcoded at compile-time, and I don't think it was changed in years... Signed-off-by: Christophe Fergeau --- common/quic.c | 3 --- common/quic_rgb_tmpl.c | 55 -- common/quic_tmpl.c | 55

[Spice-devel] [spice-common v3 11/12] quic: Use channel->correlate_row in macros

2017-08-03 Thread Christophe Fergeau
This avoids the need for a local variable with the right name (which was decorrelate_drow in some cases in quic_tmpl.c...) Signed-off-by: Christophe Fergeau --- common/quic_tmpl.c | 100 ++--- 1 file changed, 49 insertions(+), 51 deletions(-) diff

[Spice-devel] quic improvements

2017-08-03 Thread Christophe Fergeau
Hey, I will send the patch removing (improving) the no-inline hack separately. Changes since previous version include warning fixes Frediano reported privately, small improvements in the test code (added license, added config.h), compilation fixes for patch 10. Christophe ___

[Spice-devel] [spice-common v3 09/12] quic: Add macros to make quic_tmpl.c much closer to quic_rgb_tmpl.c

2017-08-03 Thread Christophe Fergeau
Signed-off-by: Christophe Fergeau --- common/quic_tmpl.c | 184 +++-- 1 file changed, 107 insertions(+), 77 deletions(-) diff --git a/common/quic_tmpl.c b/common/quic_tmpl.c index 631334d..7a0c898 100644 --- a/common/quic_tmpl.c +++ b/common/quic_t

[Spice-devel] [spice-common v3 02/12] quic: Remove configurable PRED

2017-08-03 Thread Christophe Fergeau
It's hardcoded at compile-time, and I don't think it was changed in years... Signed-off-by: Christophe Fergeau --- common/quic.c | 1 - common/quic_rgb_tmpl.c | 31 --- common/quic_tmpl.c | 38 -- 3 files changed, 70 d

[Spice-devel] [spice-common v3 03/12] quic: Get rid of QUIC_RGB #define

2017-08-03 Thread Christophe Fergeau
It's always set, no need to have conditional compilation based on it. Signed-off-by: Christophe Fergeau --- common/quic.c | 151 - common/quic_tmpl.c | 6 --- 2 files changed, 157 deletions(-) diff --git a/common/quic.c b/common/quic.c

Re: [Spice-devel] [PATCH spice-gtk 0/2] Disabling mmtime adjustment in the client (from audio backend)

2017-08-03 Thread Marc-André Lureau
Hi - Original Message - > > I start to be worried about all of our streaming tweaks and issues. Is > > there any effort to use RTP/SRTP instead? I think this would be a big > > opportunity to improve the situation going forward. > > There is not effort on that AFAIK. > I would put my ef

Re: [Spice-devel] [spice-common v2 13/13] quic: Add test case for compression/decompression

2017-08-03 Thread Frediano Ziglio
> > On Thu, Aug 03, 2017 at 09:24:51AM -0400, Frediano Ziglio wrote: > > > > > > On Wed, Aug 02, 2017 at 05:32:04AM -0400, Frediano Ziglio wrote: > > > > > > > > > > This only adds a basic test relying on gdk-pixbuf. > > > > > The main limitation is that gdk-pixbuf does not handle 16bpp images,

[Spice-devel] Windows agent release

2017-08-03 Thread Frediano Ziglio
Hi, looks like there are quite a few patches and changes since 0.8.0 version. Looks like that internally we are packaging lot of them already. Should not better to have a new release? Looks like we have a kind of internal fork now. Frediano ___ Spice-d

Re: [Spice-devel] [spice-common v2 13/13] quic: Add test case for compression/decompression

2017-08-03 Thread Christophe Fergeau
On Thu, Aug 03, 2017 at 09:24:51AM -0400, Frediano Ziglio wrote: > > > > On Wed, Aug 02, 2017 at 05:32:04AM -0400, Frediano Ziglio wrote: > > > > > > > > This only adds a basic test relying on gdk-pixbuf. > > > > The main limitation is that gdk-pixbuf does not handle 16bpp images, > > > > nor 32b

Re: [Spice-devel] [PATCH spice-gtk 0/2] Disabling mmtime adjustment in the client (from audio backend)

2017-08-03 Thread Victor Toso
Hi, On Thu, Aug 03, 2017 at 09:29:43AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > From: Victor Toso > > > > There should be some effort to make spice-server adjust mmtime correctly > > instead > > of relying on audio backend output directly. > > > > The latency from

Re: [Spice-devel] [spice-common v2 08/13] quic: s/decorrelate_drow/correlate_row

2017-08-03 Thread Christophe Fergeau
On Wed, Aug 02, 2017 at 05:10:56AM -0400, Frediano Ziglio wrote: > > > > The naming is odd as this is just an alias for channel->correlate_row. > > This will also help in subsequent commits to make things more > > consistent with quic_rgb_tmpl.c > > > > Signed-off-by: Christophe Fergeau > > >

Re: [Spice-devel] [PATCH spice-gtk 0/2] Disabling mmtime adjustment in the client (from audio backend)

2017-08-03 Thread Marc-André Lureau
Hi - Original Message - > From: Victor Toso > > There should be some effort to make spice-server adjust mmtime correctly > instead > of relying on audio backend output directly. > > The latency from audio backend should be forwarded to spice-server but that's > yet to be implemented. >

Re: [Spice-devel] [spice-common v2 13/13] quic: Add test case for compression/decompression

2017-08-03 Thread Frediano Ziglio
> > On Wed, Aug 02, 2017 at 05:32:04AM -0400, Frediano Ziglio wrote: > > > > > > This only adds a basic test relying on gdk-pixbuf. > > > The main limitation is that gdk-pixbuf does not handle 16bpp images, > > > nor 32bpp/no alpha images. I should have picked something else instead ;) > > > > >

Re: [Spice-devel] [PATCH spice-gtk] Remove wocky HTTP proxy

2017-08-03 Thread Marc-André Lureau
Hi - Original Message - > On Thu, Aug 03, 2017 at 01:12:10PM +0100, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau > > > > That HTTP proxy code has been added to glib 2.43.92. > > Does this mean the HTTP proxy code was already unused when running > with a recent glib? Or

Re: [Spice-devel] [spice-common v2 13/13] quic: Add test case for compression/decompression

2017-08-03 Thread Christophe Fergeau
On Wed, Aug 02, 2017 at 05:32:04AM -0400, Frediano Ziglio wrote: > > > > This only adds a basic test relying on gdk-pixbuf. > > The main limitation is that gdk-pixbuf does not handle 16bpp images, > > nor 32bpp/no alpha images. I should have picked something else instead ;) > > > > This allows at

Re: [Spice-devel] cast-align warning when building spice-gtk on Arm

2017-08-03 Thread Victor Toso
Hi, On Thu, Aug 03, 2017 at 04:01:00PM +0430, Armin Ranjbar wrote: > Hello list! > > attached is log of error i receive when trying to build on Arm, so i had to > use --disable-werror to be able to build spice-gtk, any ideas if they > should be ignored? > --- > Armin ranjbar Feel free to copy-pas

Re: [Spice-devel] [PATCH spice-gtk] Remove wocky HTTP proxy

2017-08-03 Thread Christophe Fergeau
On Thu, Aug 03, 2017 at 01:12:10PM +0100, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > That HTTP proxy code has been added to glib 2.43.92. Does this mean the HTTP proxy code was already unused when running with a recent glib? Or was wocky-http always used, and after this com

[Spice-devel] [PATCH spice-gtk 0/2] Disabling mmtime adjustment in the client (from audio backend)

2017-08-03 Thread Victor Toso
From: Victor Toso There should be some effort to make spice-server adjust mmtime correctly instead of relying on audio backend output directly. The latency from audio backend should be forwarded to spice-server but that's yet to be implemented. This two patches allow us to simply turn-off adjus

[Spice-devel] [PATCH spice-gtk 1/2] session: introduce "video-sync-on-audio-latency" property

2017-08-03 Thread Victor Toso
From: Victor Toso The multi media time (mmtime) is the relative clock used to sync video and audio decoding. The mmtime is initially set on SPICE_MSG_MAIN_INIT and readjusted on every SPICE_MSG_MAIN_MULTI_MEDIA_TIME message. Basically, spice-server as provider of video and audio stream content i

[Spice-devel] [PATCH spice-gtk 2/2] spicy: toggle SpiceSession::video-sync-on-audio-latency

2017-08-03 Thread Victor Toso
From: Victor Toso So we can work on fixing mmtime that is not set/update correctly by spice-server. Signed-off-by: Victor Toso --- tools/spicy.c | 43 ++- 1 file changed, 42 insertions(+), 1 deletion(-) diff --git a/tools/spicy.c b/tools/spicy.c index 4

Re: [Spice-devel] [PATCH spice-gtk] Remove vapi/spice-client-gtk-2.0.deps

2017-08-03 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Thu, Aug 03, 2017 at 12:47:26PM +0100, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > Left-over from v0.31-6-g0917002 > > Signed-off-by: Marc-André Lureau > --- > vapi/spice-client-gtk-2.0.deps | 2 -- > 1 file changed, 2 deletions(-) > del

[Spice-devel] [PATCH spice-gtk] Remove wocky HTTP proxy

2017-08-03 Thread marcandre . lureau
From: Marc-André Lureau That HTTP proxy code has been added to glib 2.43.92. Signed-off-by: Marc-André Lureau --- doc/reference/Makefile.am | 1 - src/Makefile.am | 2 - src/spice-session.c | 4 - src/wocky-http-proxy.c| 522 ---

Re: [Spice-devel] [PATCH spice-common 1/2] quic: fix typo corelate -> correlate

2017-08-03 Thread Christophe Fergeau
On Thu, Aug 03, 2017 at 10:56:52AM +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > common/quic.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/common/quic.c b/common/quic.c > index 8567368..5b025af 100644 > --- a/common/quic.c > +++

Re: [Spice-devel] [PATCH spice-common 2/2] quic: fix typo golomb_deoding -> golomb_decoding

2017-08-03 Thread Christophe Fergeau
Acked-by: Christophe Fergeau On Thu, Aug 03, 2017 at 10:56:53AM +0100, Frediano Ziglio wrote: > Signed-off-by: Frediano Ziglio > --- > common/quic_tmpl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/common/quic_tmpl.c b/common/quic_tmpl.c > index b9056bb..3c84791 1

[Spice-devel] [PATCH spice-gtk] Remove vapi/spice-client-gtk-2.0.deps

2017-08-03 Thread marcandre . lureau
From: Marc-André Lureau Left-over from v0.31-6-g0917002 Signed-off-by: Marc-André Lureau --- vapi/spice-client-gtk-2.0.deps | 2 -- 1 file changed, 2 deletions(-) delete mode 100644 vapi/spice-client-gtk-2.0.deps diff --git a/vapi/spice-client-gtk-2.0.deps b/vapi/spice-client-gtk-2.0.deps de

[Spice-devel] cast-align warning when building spice-gtk on Arm

2017-08-03 Thread Armin Ranjbar
Hello list! attached is log of error i receive when trying to build on Arm, so i had to use --disable-werror to be able to build spice-gtk, any ideas if they should be ignored? --- Armin ranjbar In file included from /usr/include/gstreamer-1.0/gst/gstpad.h:69:0, from /usr/include/

[Spice-devel] [PATCH spice-common 2/2] quic: fix typo golomb_deoding -> golomb_decoding

2017-08-03 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- common/quic_tmpl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/common/quic_tmpl.c b/common/quic_tmpl.c index b9056bb..3c84791 100644 --- a/common/quic_tmpl.c +++ b/common/quic_tmpl.c @@ -627,7 +627,7 @@ static void FNAME(uncompress_row)(E

[Spice-devel] [PATCH spice-common 1/2] quic: fix typo corelate -> correlate

2017-08-03 Thread Frediano Ziglio
Signed-off-by: Frediano Ziglio --- common/quic.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/common/quic.c b/common/quic.c index 8567368..5b025af 100644 --- a/common/quic.c +++ b/common/quic.c @@ -82,11 +82,11 @@ typedef struct QuicFamily { unsigned int g

Re: [Spice-devel] Multithreaded decoding/streaming

2017-08-03 Thread Victor Toso
Hi, On Thu, Aug 03, 2017 at 01:06:08PM +0430, Armin Ranjbar wrote: > well, as far as i can the whole spicy process uses one core when > streaming, any ideas how to debug this? > > --- > Armin ranjbar - Can you paste your qemu command line so we can know for sure you have streaming enabled? e.g

Re: [Spice-devel] Multithreaded decoding/streaming

2017-08-03 Thread Armin Ranjbar
well, as far as i can the whole spicy process uses one core when streaming, any ideas how to debug this? --- Armin ranjbar On Thu, Aug 3, 2017 at 12:13 PM, Victor Toso wrote: > Hi Armin, > > On Wed, Aug 02, 2017 at 08:16:55PM +0430, Armin Ranjbar wrote: > > Dear Everyone! > > > > Anyone is wor

Re: [Spice-devel] [spice-common v2 10/13] quic: Remove unused argument in uncompress_row{0, }

2017-08-03 Thread Frediano Ziglio
> On Thu, Aug 03, 2017 at 04:09:43AM -0400, Frediano Ziglio wrote: > > > > > > 'correlation_row' is always set to channel->colleration_row, and we > > > already pass 'channel' as an argument. > > > > > > Signed-off-by: Christophe Fergeau > > > > This patch does not compile > > Ah indeed, afte

Re: [Spice-devel] [spice-common v2 10/13] quic: Remove unused argument in uncompress_row{0, }

2017-08-03 Thread Christophe Fergeau
On Thu, Aug 03, 2017 at 04:09:43AM -0400, Frediano Ziglio wrote: > > > > 'correlation_row' is always set to channel->colleration_row, and we > > already pass 'channel' as an argument. > > > > Signed-off-by: Christophe Fergeau > > This patch does not compile Ah indeed, after the next patch, bui

Re: [Spice-devel] [spice-common v2 10/13] quic: Remove unused argument in uncompress_row{0, }

2017-08-03 Thread Frediano Ziglio
> > 'correlation_row' is always set to channel->colleration_row, and we > already pass 'channel' as an argument. > > Signed-off-by: Christophe Fergeau This patch does not compile Frediano > --- > common/quic_tmpl.c | 12 > 1 file changed, 4 insertions(+), 8 deletions(-) > > dif

Re: [Spice-devel] Multithreaded decoding/streaming

2017-08-03 Thread Victor Toso
Hi Armin, On Wed, Aug 02, 2017 at 08:16:55PM +0430, Armin Ranjbar wrote: > Dear Everyone! > > Anyone is working on making streaming multithreaded on client side? > i'm not sure but maybe current efforts in using gstreamer can help > with that, we are interested in this features and are willing to

Re: [Spice-devel] [spice-gtk v1] build-sys: requires gstreamer 1.9 or above

2017-08-03 Thread Christophe Fergeau
On Wed, Aug 02, 2017 at 02:19:36PM -0400, Frediano Ziglio wrote: > > > > On Wed, Aug 02, 2017 at 02:00:02PM +0200, Victor Toso wrote: > > > From: Victor Toso > > > > > > The recent work on spice-gtk with Gstreamer for video stream is > > > targeting hardware video acceleration. One of our main t