Re: [Spice-devel] [spice-common 01/14] quic: Use #define rather than static const int

2017-07-22 Thread Frediano Ziglio
> > quic.c is checking at compile-time that 'evol' is 1, 3 or 5. This is a > constant, so a static check should be good, but my compiler (gcc 7.1.1) > is unable to know 'evol' value at compile-time. Since the removal of > spice_static_assert in favour of SPICE_VERIFY, this causes a > compile-time

Re: [Spice-devel] [spice-common] Some steps toward quic_tmpl.c and quic_rgb_tmpl.c 'unification'

2017-07-22 Thread Frediano Ziglio
> > On Wed, Jul 05, 2017 at 10:27:18AM -0400, Frediano Ziglio wrote: > > > > > > Hey, > > > > > > This is a v2 of the initial 2 patches, but looking a bit closer at the > > > quic > > > code led me down a rabbit hole ;) We currently have 2 different quic > > > implementations using the preproces