Re: [Spice-devel] [vdagent-win PATCH] RFC spec: run tests during RPM build if possible

2017-07-20 Thread Christophe Fergeau
On Thu, Jul 20, 2017 at 12:30:03PM -0400, Frediano Ziglio wrote: > > Changing mingw_build_win32 will also disable the build if 32 bit packages. Even if you do this? %define mingw_build_win32 0 %check %mingw_make check %define mingw_build_win32 1 > Is there a way to tell RPM (dependencies) try t

[Spice-devel] [RFC spice-gtk] Add flatpak builder manifest file for spicy

2017-07-20 Thread Pavel Grunt
To give example for creating flatpaks depending on spice-gtk How to use to build and run the flatpak: $ flatpak-builder spicy org.spicespace.spicy.json $ flatpak build-export repo spicy $ flatpak --user remote-add --no-gpg-verify --if-not-exists spice-repo repo $ flatpak --user install spice-r

Re: [Spice-devel] [PATCH spice-gtk v2] spice-gtk: Use time comparisons that still work after wraparound

2017-07-20 Thread Jonathon Jongsma
On Tue, 2017-07-18 at 16:50 +0200, Christophe de Dinechin wrote: > > On 18 Jul 2017, at 16:48, Christophe Fergeau > > wrote: > > > > Hey, > > > > On Tue, Jul 18, 2017 at 04:37:29PM +0200, Christophe de Dinechin > > wrote: > > > OK. Since you seem to feel more strongly about this than me, I > > >

Re: [Spice-devel] [PATCH] gst: new_sample: remove redundant sample? condition

2017-07-20 Thread Pavel Grunt
Ack Thanks, Pavel On Thu, 2017-07-20 at 19:41 +0300, Uri Lublin wrote: > Move the declaration and assignment of 'buffer' into > the if (sample) block, where sample is not NULL. > > Signed-off-by: Uri Lublin > --- > src/channel-display-gst.c | 2 +- > 1 file changed, 1 insertion(+), 1 del

[Spice-devel] [PATCH] gst: new_sample: remove redundant sample? condition

2017-07-20 Thread Uri Lublin
Move the declaration and assignment of 'buffer' into the if (sample) block, where sample is not NULL. Signed-off-by: Uri Lublin --- src/channel-display-gst.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/channel-display-gst.c b/src/channel-display-gst.c index 3f51361..0

Re: [Spice-devel] [vdagent-win PATCH] RFC spec: run tests during RPM build if possible

2017-07-20 Thread Frediano Ziglio
> > On Thu, Jul 20, 2017 at 11:47:01AM -0400, Frediano Ziglio wrote: > > > > > > On Thu, Jul 20, 2017 at 11:15:04AM +0100, Frediano Ziglio wrote: > > > > Currently to run checks we need Wine for both 32 and 64 bit. > > > > Some distros (like RHEL 7) don't seem to allow installing > > > > both 32

Re: [Spice-devel] [vdagent-win PATCH] RFC spec: run tests during RPM build if possible

2017-07-20 Thread Christophe Fergeau
On Thu, Jul 20, 2017 at 11:47:01AM -0400, Frediano Ziglio wrote: > > > > On Thu, Jul 20, 2017 at 11:15:04AM +0100, Frediano Ziglio wrote: > > > Currently to run checks we need Wine for both 32 and 64 bit. > > > Some distros (like RHEL 7) don't seem to allow installing > > > both 32 and 64 bit vers

Re: [Spice-devel] [vdagent-win PATCH] RFC spec: run tests during RPM build if possible

2017-07-20 Thread Frediano Ziglio
> > > > > On Thu, Jul 20, 2017 at 11:15:04AM +0100, Frediano Ziglio wrote: > > > Currently to run checks we need Wine for both 32 and 64 bit. > > > Some distros (like RHEL 7) don't seem to allow installing > > > both 32 and 64 bit versions so turn on these checks only > > > on recent Fedora versi

Re: [Spice-devel] [vdagent-win PATCH] RFC spec: run tests during RPM build if possible

2017-07-20 Thread Frediano Ziglio
> > On Thu, Jul 20, 2017 at 11:15:04AM +0100, Frediano Ziglio wrote: > > Currently to run checks we need Wine for both 32 and 64 bit. > > Some distros (like RHEL 7) don't seem to allow installing > > both 32 and 64 bit versions so turn on these checks only > > on recent Fedora versions. > > > > S

Re: [Spice-devel] [vdagent-win PATCH] RFC spec: run tests during RPM build if possible

2017-07-20 Thread Christophe Fergeau
On Thu, Jul 20, 2017 at 11:15:04AM +0100, Frediano Ziglio wrote: > Currently to run checks we need Wine for both 32 and 64 bit. > Some distros (like RHEL 7) don't seem to allow installing > both 32 and 64 bit versions so turn on these checks only > on recent Fedora versions. > > Signed-off-by: Fre

[Spice-devel] [spice-server] Prepare for 0.13.90 release

2017-07-20 Thread Christophe Fergeau
Update NEWS and soname. --- NEWS | 19 +++ configure.ac | 2 +- 2 files changed, 20 insertions(+), 1 deletion(-) Hey, It's high time that we have an unstable release, and I'd like to start converging towards a stable 0.14 release. So we could release a 0.13.90 release ca

Re: [Spice-devel] [spice-common] canvas: Don't try to unref NULL pixman_image_t

2017-07-20 Thread Frediano Ziglio
> > pixman_image_unref() does not ignore NULL pointers, it tries to > dereference it which causes a crash. When trying to decode invalid QUIC > data, we could end up in a situation where 'surface' would still be > NULL when reaching the setjmp block. > > Signed-off-by: Christophe Fergeau > --- >

[Spice-devel] [spice-common] canvas: Don't try to unref NULL pixman_image_t

2017-07-20 Thread Christophe Fergeau
pixman_image_unref() does not ignore NULL pointers, it tries to dereference it which causes a crash. When trying to decode invalid QUIC data, we could end up in a situation where 'surface' would still be NULL when reaching the setjmp block. Signed-off-by: Christophe Fergeau --- common/canvas_bas

Re: [Spice-devel] [spice-common] Some steps toward quic_tmpl.c and quic_rgb_tmpl.c 'unification'

2017-07-20 Thread Christophe Fergeau
On Wed, Jul 05, 2017 at 10:27:18AM -0400, Frediano Ziglio wrote: > > > > Hey, > > > > This is a v2 of the initial 2 patches, but looking a bit closer at the quic > > code led me down a rabbit hole ;) We currently have 2 different quic > > implementations using the preprocessor as a template engin

Re: [Spice-devel] Windows 10: Smartcard is not redirected

2017-07-20 Thread David Jaša
On Thu, 2017-07-20 at 15:42 +0200, David Jaša wrote: > Hi Oscar, > > spice client uses on Windows also NSS library to access smart cards, > so you need to tell NSS where to look for library that provides > pkcs#11 interface (or "smart card middleware") for your smart card. > Once you know the .dll

Re: [Spice-devel] Windows 10: Smartcard is not redirected

2017-07-20 Thread David Jaša
Hi Oscar, spice client uses on Windows also NSS library to access smart cards, so you need to tell NSS where to look for library that provides pkcs#11 interface (or "smart card middleware") for your smart card. Once you know the .dll, you can create the nssdb and add the library there: mkdir %PROGR

Re: [Spice-devel] [PATCH linux vdagent] Add systemd socket activation

2017-07-20 Thread Christophe Fergeau
On Wed, Jul 19, 2017 at 01:28:28PM -0500, Jonathon Jongsma wrote: > So, Victor told me on IRC that he was having trouble getting the patch > to work and asked me to follow up on the mailing list about how to test > the patch. I tested it on a Fedora25 vm as follows: > > - Set up a Fedora 25 vm >

Re: [Spice-devel] [spice-common 01/14] quic: Use #define rather than static const int

2017-07-20 Thread Christophe Fergeau
On Tue, Jul 18, 2017 at 01:16:58PM -0400, Frediano Ziglio wrote: > > > > On Wed, Jul 05, 2017 at 06:59:46AM -0400, Frediano Ziglio wrote: > > > In my stash pile I have these: > > > > > > > > > diff --git a/common/quic.c b/common/quic.c > > > index c188ed2..aa0d8ab 100644 > > > --- a/common/quic.

[Spice-devel] [vdagent-win PATCH] RFC spec: run tests during RPM build if possible

2017-07-20 Thread Frediano Ziglio
Currently to run checks we need Wine for both 32 and 64 bit. Some distros (like RHEL 7) don't seem to allow installing both 32 and 64 bit versions so turn on these checks only on recent Fedora versions. Signed-off-by: Frediano Ziglio --- mingw-spice-vdagent.spec.in | 13 + 1 file cha

Re: [Spice-devel] [PATCH linux vdagent] Add systemd socket activation

2017-07-20 Thread Christophe Fergeau
On Thu, Jul 13, 2017 at 03:35:03PM -0500, Jonathon Jongsma wrote: > diff --git a/Makefile.am b/Makefile.am > index 7755f09..f70d514 100644 > --- a/Makefile.am > +++ b/Makefile.am > @@ -124,6 +126,7 @@ EXTRA_DIST = \ > data/spice-vdagent.desktop

Re: [Spice-devel] [PATCH spice-gtk] gst: Fix detection of h264 stream decoder

2017-07-20 Thread Victor Toso
Hi, On Thu, Jul 20, 2017 at 10:03:37AM +0200, Pavel Grunt wrote: > Victor, > > it is faster to write NACK You don't want feedback and rationale on the NACK? I wish you had discussed with me on my proposal as well as I don't agree that's wrong. > > On Thu, 2017-07-20 at 07:26 +0200, Victor Toso

Re: [Spice-devel] [spice-server PATCH 1/3] red_get_surface_cmd: avoid overflow

2017-07-20 Thread Uri Lublin
On 07/20/2017 11:45 AM, Frediano Ziglio wrote: On 07/17/2017 11:22 AM, Frediano Ziglio wrote: Although unlikely, theoretically, multiplying two 32-bit numbers may overflow. Found by coverity. Signed-off-by: Uri Lublin --- server/red-parse-qxl.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

2017-07-20 Thread Christophe Fergeau
On Thu, Jul 20, 2017 at 09:42:26AM +0200, Christophe de Dinechin wrote: > > I moved to "unsigned int" 2 versions ago. > > It was courteous of you. Yup, thanks, did not take a look at the newer iterations yet. > > > > > But still think that is a useful discussion. But honestly I think > > in th

Re: [Spice-devel] [spice-server PATCH 1/3] red_get_surface_cmd: avoid overflow

2017-07-20 Thread Frediano Ziglio
> > On 07/17/2017 11:22 AM, Frediano Ziglio wrote: > >> > >> Although unlikely, theoretically, multiplying two 32-bit > >> numbers may overflow. > >> > >> Found by coverity. > >> > >> Signed-off-by: Uri Lublin > >> --- > >> server/red-parse-qxl.c | 2 +- > >> 1 file changed, 1 insertion(+), 1

Re: [Spice-devel] [PATCH spice-gtk] gst: Fix detection of h264 stream decoder

2017-07-20 Thread Pavel Grunt
Victor, it is faster to write NACK On Thu, 2017-07-20 at 07:26 +0200, Victor Toso wrote: > A new day, a new thread > > On Wed, Jul 19, 2017 at 02:59:00PM +0200, Pavel Grunt wrote: > > GStreamer's avdec_h264 needs h264parse to be able to process H264 video > > streams. However the check for eleme

Re: [Spice-devel] [vdagent-win PATCH v6 2/5] Initial rewrite of image conversion code

2017-07-20 Thread Christophe de Dinechin
> On 19 Jul 2017, at 19:21, Frediano Ziglio wrote: > >> >> On Wed, Jul 19, 2017 at 08:03:49AM -0400, Frediano Ziglio wrote: On Wed, Jul 19, 2017 at 12:09:23PM +0200, Christophe de Dinechin wrote: > >> On 19 Jul 2017, at 11:21, Christophe Fergeau >> wrote: >> >>